[Patches] [ python-Patches-536241 ] string.zfill and unicode
noreply@sourceforge.net
noreply@sourceforge.net
Sat, 30 Mar 2002 03:25:27 -0800
Patches item #536241, was opened at 2002-03-28 13:26
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=536241&group_id=5470
Category: Library (Lib)
Group: None
>Status: Open
Resolution: Fixed
Priority: 5
Submitted By: Walter Dörwald (doerwalter)
Assigned to: A.M. Kuchling (akuchling)
Summary: string.zfill and unicode
Initial Comment:
This patch makes the function string.zfill work with
unicode instances (and instances of str and unicode
subclasses). Currently string.zfill(u"123", 10)
results in "0000u'123'". With this patch the result is
u'0000000123'.
Should zfill be made a real str und unicode method? I
noticed that a zfill implementation is available in
unicodeobject.c, but commented out.
----------------------------------------------------------------------
>Comment By: Michael Hudson (mwh)
Date: 2002-03-30 11:25
Message:
Logged In: YES
user_id=6656
Hah, I was going to say that but was distracted by IE
wiping out the machine I'm sitting at.
Re-opening.
----------------------------------------------------------------------
Comment By: Walter Dörwald (doerwalter)
Date: 2002-03-30 11:16
Message:
Logged In: YES
user_id=89016
But Python could be compiled without unicode support (by
undefining PY_USING_UNICODE), and string.zfill should work
even in this case.
What about making zfill a real str and unicode method?
----------------------------------------------------------------------
Comment By: A.M. Kuchling (akuchling)
Date: 2002-03-29 16:24
Message:
Logged In: YES
user_id=11375
Thanks for your patch! I've checked it into CVS, with two
modifications. First, I removed the code to handle the case
where Python doesn't have a unicode() built-in; there's no
expection that
you can take the standard library for Python version N and use
it with version N-1, so this code isn't needed.
Second, I changed string.zfill() to take the str() and not the repr()
when it gets a non-string object because that seems to make
more sense.
----------------------------------------------------------------------
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=536241&group_id=5470