[Patches] [ python-Patches-494863 ] file.xreadlines() should raise exception

noreply@sourceforge.net noreply@sourceforge.net
Tue, 01 Jan 2002 11:08:58 -0800


Patches item #494863, was opened at 2001-12-18 17:58
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=494863&group_id=5470

Category: Core (C code)
Group: Python 2.3
>Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Neal Norwitz (nnorwitz)
Assigned to: Neal Norwitz (nnorwitz)
Summary: file.xreadlines() should raise exception

Initial Comment:
file.xreadlines() should raise a ValueError
when the file is closed

All other file methods raise ValueError except close()

there's another patch that tests this feature
and other file methods

----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2002-01-01 11:08

Message:
Logged In: YES 
user_id=33168

Checked in as:

Misc/NEWS 1.343 
fileobject.c 2.142

Test is in #494867.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-12-28 15:42

Message:
Logged In: YES 
user_id=21627

Oops, I meant to assign it to you for check-in, not to close
it. I don't think it is a 2.2.1 candidate, since there is no
serious bug involved.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2001-12-28 15:21

Message:
Logged In: YES 
user_id=33168

Martin, did you mean to close this or assign it to me?
Should this be a 2.2.1 candidate?

I don't think it's too important, other than that
it will change behaviour, although for an obscure
condition.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-12-28 14:27

Message:
Logged In: YES 
user_id=21627

I'd say the patch is correct. Notice that this is a change
in semantics; please add an entry to Misc/NEWS as well (at
the moment, you get back an xreadlines object on which
calling .next() will raise a ValueError).

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=494863&group_id=5470