[Patches] Warnings in pythonrun.c

Fredrik Lundh fredrik@pythonware.com
Thu, 22 Jun 2000 17:19:16 +0200


On Wed, Jun 21, 2000 at 10:09:42AM +0200, Fredrik Lundh wrote:
> > more warnings:
> >
> > ..\Python\pythonrun.c(233) : warning C4013: '_PyImport_Fini' undefined;
assuming
> >  extern returning int
> >
> > the attached patch adds this function to the pythonrun.h
> > header file.
>
> The appropriate place for this is in Include/import.h.

"appropriate" ?

if you'd bothered to look in Include/pythonrun.h, you'd found
that _PyImport_Init was defined in that file, together with a
whole bunch of other internal initializations and finalizations.

if you'd bothered to look in the CVS history, you'd found that
_PyImport_Fini *was* declared in pythonrun.h, before someone
accidentally removed it a few weeks ago.

if you're gonna move declarations around, it's probably more
appropriate to move all of them to more appropriate places,
don't you think?

</F>