[Patches] Re: New module zipfile.py

[Guido van Rossum]

> I didn't hear anything about this patch.  Has it
> been accepted or rejected?

Neither yet.  I'm waiting for some discussion.  I am unfortunately in
load-shedding mode, so I don't expect I'll be able to do something
about it myself. :-(

I wrote about it earlier (but forgot to cc you):

| My own response is that the code looks a bit dense, with 2-space
| indents, very few blank lines, and some lines longer than 78 chars,
| but that it is otherwise decent; however I don't have the time to
| stress-test it.
| 
| I noticed that when I run the self-test (which should be moved into a
| module test/test_zipfile.py) I get an error:
| 
| & ../sparc/python
| Python 1.5.2+ (#1017, Feb 16 2000, 16:03:45)  [GCC 2.8.1] on sunos5
| Copyright 1991-1995 Stichting Mathematisch Centrum, Amsterdam
| >>> import zipfile
| >>> zipfile.test()
| Traceback (innermost last):
|   File "<stdin>", line 1, in ?
|   File "zipfile.py", line 335, in test
|     z.writepy("Lib")    # Directory ./Lib must exist
|   File "zipfile.py", line 279, in writepy
|     raise RuntimeError, 'Files added with writepy() must end with ".py"'
| RuntimeError: Files added with writepy() must end with ".py"
| >>> 

--Guido van Rossum (home page: http://www.python.org/~guido/)