[Patches] [Patch #101146] Replace UNPACK_TUPLE and UNPACK_LIST with UNPACK_SEQUENCE

[noreply@sourceforge.net]

Patch #101146 has been updated. 

Project: 
Category: core (C code)
Status: Open
Summary: Replace UNPACK_TUPLE and UNPACK_LIST with UNPACK_SEQUENCE

Follow-Ups:

Date: 2000-Aug-10 13:59
By: twouters

Comment:
Remove the UNPACK_TUPLE and UNPACK_LIST opcodes in favor of a single UNPACK_SEQUENCE opcode, since both the implementation and the generation of the UNPACK opcodes are identical.

-------------------------------------------------------

Date: 2000-Aug-11 02:51
By: nowonder

Comment:
Looks fine on visual inspection and works for me, too.

Someone else should review this, too.
-------------------------------------------------------

Date: 2000-Aug-11 12:13
By: tim_one

Comment:
Assigned to Guido for Final Pronouncement: looks fine to me too.  Implications:
1. You're not going to want to reintroduce a distinction between unpacking tuples and lists someday.
2. The 2.0 PVM has no chance of running .pyc/.pyo from earlier versions.

-------------------------------------------------------

Date: 2000-Aug-11 12:14
By: tim_one

Comment:
Assigned to Guido for Final Pronouncement: looks fine to me too.  Implications:
1. You're not going to want to reintroduce a distinction between unpacking tuples and lists someday.
2. The 2.0 PVM has no chance of running .pyc/.pyo from earlier versions.

-------------------------------------------------------

Date: 2000-Aug-11 13:42
By: gvanrossum

Comment:
Agree with #1 from Tim.
Disagree with #2: this would be the first place where 1.6 and 2.0 differ in the bytecode. Suggestion to fix: keep opcode 93 assigned to UNPACK_LIST and keep the case for it in the switch.
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=101146&group_id=5470