[Numpy-svn] [numpy/numpy] f3f91b: BUG: MaskedArray __eq__ wrong for masked scalar, m...

GitHub noreply at github.com
Mon Feb 27 19:00:11 EST 2017


  Branch: refs/heads/master
  Home:   https://github.com/numpy/numpy
  Commit: f3f91be7920f52cd6abace64d7e14b876e5f054f
      https://github.com/numpy/numpy/commit/f3f91be7920f52cd6abace64d7e14b876e5f054f
  Author: Marten van Kerkwijk <mhvk at astro.utoronto.ca>
  Date:   2017-02-27 (Mon, 27 Feb 2017)

  Changed paths:
    M doc/release/1.13.0-notes.rst
    M numpy/ma/core.py
    M numpy/ma/tests/test_core.py

  Log Message:
  -----------
  BUG: MaskedArray __eq__ wrong for masked scalar, multi-d recarray

In the process of trying to fix the "questionable behaviour in
`MaskedArray.__eq__`" (gh-8589), it became clear that the code was
buggy. E.g., `ma == ma[0]` failed if `ma` held a structured dtype;
multi-d structured dtypes failed generally; and, more worryingly,
a masked scalar comparison could be wrong:
`np.ma.MaskedArray(1, mask=True) == 0` yields True.

This commit solves these problems, adding tests to prevent regression.
In the process, it also ensures that the results for structured arrays
always equals what one would get by logically combining the results
over individual parts of the structure.


  Commit: 3435dd9881d84ba2b91faa478555a3c58e7921af
      https://github.com/numpy/numpy/commit/3435dd9881d84ba2b91faa478555a3c58e7921af
  Author: Marten van Kerkwijk <mhvk at astro.utoronto.ca>
  Date:   2017-02-27 (Mon, 27 Feb 2017)

  Changed paths:
    M numpy/ma/core.py
    M numpy/ma/tests/test_core.py

  Log Message:
  -----------
  BUG: ensure masked array comparison with regular void works.


  Commit: 64111c5ca2768471f80eb8190f1773aedccd5c88
      https://github.com/numpy/numpy/commit/64111c5ca2768471f80eb8190f1773aedccd5c88
  Author: Eric Wieser <wieser.eric at gmail.com>
  Date:   2017-02-28 (Tue, 28 Feb 2017)

  Changed paths:
    M doc/release/1.13.0-notes.rst
    M numpy/ma/core.py
    M numpy/ma/tests/test_core.py

  Log Message:
  -----------
  Merge pull request #8590 from mhvk/ma/eq_ne_axis_bug

BUG MaskedArray __eq__ wrong for masked scalar, multi-d recarray


Compare: https://github.com/numpy/numpy/compare/2dd9125bad6d...64111c5ca276


More information about the Numpy-svn mailing list