[Numpy-svn] [numpy/numpy] 415b52: BUG: Fix a non-constant expression used as structu...

GitHub noreply at github.com
Mon Aug 17 11:29:04 EDT 2015


  Branch: refs/heads/master
  Home:   https://github.com/numpy/numpy
  Commit: 415b5205050a737293abd97c2cb9e83c7da06e88
      https://github.com/numpy/numpy/commit/415b5205050a737293abd97c2cb9e83c7da06e88
  Author: Charles Harris <charlesr.harris at gmail.com>
  Date:   2015-08-11 (Tue, 11 Aug 2015)

  Changed paths:
    M numpy/core/src/multiarray/arrayobject.c
    M numpy/core/src/multiarray/multiarraymodule.c

  Log Message:
  -----------
  BUG: Fix a non-constant expression used as structure initializer.

PyObject_HashNotImplemented was being used to initialize the tp_hash
slot in the PyArray_Type structure. In mingw32 (gcc version 3.4) that
results in a compile error. Fix by initializing to zero, then
setting to PyObject_HashNotImplemented when the module is loaded.

The function initialization seems to work with more recent compilers, as
the determination of what is considered 'non-constant' is left to the
vendor and has changed.


  Commit: 9851d43b92e31e0c23474d84c9b38cba2c4ffbb0
      https://github.com/numpy/numpy/commit/9851d43b92e31e0c23474d84c9b38cba2c4ffbb0
  Author: Charles Harris <charlesr.harris at gmail.com>
  Date:   2015-08-11 (Tue, 11 Aug 2015)

  Changed paths:
    M numpy/core/tests/test_multiarray.py

  Log Message:
  -----------
  TST: Test that arrays are not hashable.

This adds a direct test to compliment the existing test that checks
if array is an instance of collections.Hashable.


  Commit: c29733c228ef6168b2f811f51113e9660bf6c47d
      https://github.com/numpy/numpy/commit/c29733c228ef6168b2f811f51113e9660bf6c47d
  Author: Charles Harris <charlesr.harris at gmail.com>
  Date:   2015-08-17 (Mon, 17 Aug 2015)

  Changed paths:
    M numpy/core/src/multiarray/arrayobject.c
    M numpy/core/src/multiarray/multiarraymodule.c
    M numpy/core/tests/test_multiarray.py

  Log Message:
  -----------
  Merge pull request #6195 from charris/fix-non-constant-initializer

Fix non constant initializer


Compare: https://github.com/numpy/numpy/compare/530a6fdd00ac...c29733c228ef


More information about the Numpy-svn mailing list