[Numpy-discussion] recent changes in np.maximum.accumulate ?

[Sebastian Berg]

On Tue, 2020-02-18 at 10:14 -0500, josef.pktd at gmail.com wrote:
> I'm trying to track down test failures of statsmodels against recent
> master dev versions of numpy and scipy.
> 
> The core computation is the following in one set of tests that fail
> 
>         pvals_corrected_raw = pvals * np.arange(ntests, 0, -1)
>         pvals_corrected = np.maximum.accumulate(pvals_corrected_raw)
> 

Hmmm, the two git hashes indicate few changes between the two versions
(mainly unicode related).

However, recently there was also the addition of AVX-512F loops to
maximum, so that seems like the most reasonable candidate (although I
am unsure it changed exactly between those versions, it is also more
complex maybe due to needing a machine that supports the instructions).

Some details about the input could be nice. But if this is all that is
as input, it sounds like it should be a contiguous array? I guess it
might include subnormal numbers or NaN?

Can you open an issue with some of those details if you have them?

- Sebastian



> this numpy version 
> numpy-1.19.0.dev0%2B20200214184618_1f9ab28-cp38-cp38-
> manylinux2010_x86_64.whl
> is in the test run with failures (the first time statsmodel master
> failed)
> 
> the previous version in the test runs didn't have these failures
>  numpy-1.19.0.dev0%2B20200212232857_af0dfce-cp38-cp38-
> manylinux1_x86_64.whl
> 
> 
> I'm right now just fishing for candidates for the failures. And I'm
> not running any dev versions on my computer.
> 
> Were there any recent changes that affect np.maximum.accumulate?
> 
> Josef
> 
> 
> 
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion at python.org
> https://mail.python.org/mailman/listinfo/numpy-discussion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20200218/ff7b67b6/attachment.sig>