[Numpy-discussion] Relaxed stride checking fixup

Ralf Gommers ralf.gommers at gmail.com
Thu Apr 20 06:21:26 EDT 2017


On Thu, Apr 20, 2017 at 6:28 AM, Charles R Harris <charlesr.harris at gmail.com
> wrote:

> Hi All,
>
> Currently numpy master has a bogus stride that will cause an error when
> downstream projects misuse it. That is done in order to help smoke out
> errors. Previously that bogus stride has been fixed up for releases, but
> that requires a special patch to be applied after each version branch is
> made. At this point I'd like to pick one or the other option and make the
> development and release branches the same in this regard. The question is:
> which option to choose? Keeping the fixup in master will remove some code
> and keep things simple, while not fixing up the release will possibly lead
> to more folks finding errors. At this point in time I am favoring applying
> the fixup in master.
>
> Thoughts?
>

If we have to pick then keeping the fixup sounds reasonable. Would there be
value in making the behavior configurable at compile time? If there are
more such things and they'd be behind a __NUMPY_DEBUG__ switch, then people
may want to test that in their own CI.

Ralf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20170420/4bcb7625/attachment.html>


More information about the NumPy-Discussion mailing list