From Andrew.Premdas at man.ac.uk Wed Sep 1 07:32:04 2004 From: Andrew.Premdas at man.ac.uk (Andrew Premdas) Date: Wed Sep 1 07:32:04 2004 Subject: [Moin-devel] Patch for moin/ie6 textarea problem Message-ID: Moin has a problem with its textarea under IE6. Any theme that uses sidebars, i.e. rightsidebar will show the symptom that when you edit a page, the textarea will resize itself as soon as you enter some text into it. This means that the text area will extend under the side bar and you can't see what your editing. This can be fixed by putting a fieldset tag immediately after the form tag (which contains the textarea). So in PageEdit.py replace on line 293 # send form self.request.write('
' % ( self.request.getScriptname(), wikiutil.quoteWikiname(self.page_name), )) with # send form self.request.write('' % ( self.request.getScriptname(), wikiutil.quoteWikiname(self.page_name), )) # patch to fix ie6 bug with textarea self.request.write('
') replace on line 392 self.request.write("") with # patch to fix ie6 bug with textarea self.request.write("
") self.request.write("") Further info about this issue can be found at http://fplanque.net/2003/Articles/iecsstextarea/. I've tested this with rightsidebar and my own theme on ie6 and firefox. All best Andrew Andrew Premdas Student Systems Developer Manchester University ------------------------- From noreply at sourceforge.net Thu Sep 2 14:49:02 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Sep 2 14:49:02 2004 Subject: [Moin-devel] [ moin-Bugs-1021476 ] IIS edit performance slow Message-ID: Bugs item #1021476, was opened at 2004-09-02 14:48 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=1021476&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Lorrin Nelson (lorrin) Assigned to: Nobody/Anonymous (nobody) Summary: IIS edit performance slow Initial Comment: I just upgraded from 1.2.1 to 1.2.3 and now it takes forever to edit pages (both to load the editor and to save the changes). Otherwise performance is normal. This is an idle dual-CPU Win2k server running IIS. CPU usage remains low during the delay. OK, yes, I exaggerated. It's 20+ seconds, not literally forever. ;-) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=1021476&group_id=8482 From nirs at actcom.net.il Fri Sep 3 04:37:08 2004 From: nirs at actcom.net.il (Nir Soffer) Date: Fri Sep 3 04:37:08 2004 Subject: [Moin-devel] Re: IIS edit performance slow (SourceForge.net) In-Reply-To: References: Message-ID: <67DEF768-FD9D-11D8-9F29-000A95B45AA0@actcom.net.il> On 03/09/2004, at 06:48, moin-devel-request at lists.sourceforge.net wrote: > I just upgraded from 1.2.1 to 1.2.3 and now it takes > forever to edit pages (both to load the editor and to > save the changes). Otherwise performance is normal. > > This is an idle dual-CPU Win2k server running IIS. CPU > usage remains low during the delay. > > OK, yes, I exaggerated. It's 20+ seconds, not literally > forever. ;-) This kind of problems is usually DNS problems and probably not related to the upgrade to 1.2.3. From glist at gmx.net Fri Sep 3 06:15:04 2004 From: glist at gmx.net (Georg Lutz) Date: Fri Sep 3 06:15:04 2004 Subject: [Moin-devel] Attachments: max filesize Message-ID: <20040903131521.GA3919@ercws053.erc.lan> Hi, in order to prevent a DoS situation in an environment, where space on filesystem is limited (quota), I just hacked some lines. The changes are minimal: 1. a new configuration variable "attachments_maxsize" (filesize in bytes) with default value equivalent to 2MB 2. logic in the attach-file action to - show the maximum filesize in the upload form - prevent fileuploads with larger size I think such a feature could be usefull for others too. So I ask you to include it in the next release, if it doesn't break something else. Please CC for answers, I am not subscribed. -- Georg -------------- next part -------------- --- /home/gal/progs/pc/moin-1.2.3/MoinMoin/config.py 2004-07-21 22:02:15.000000000 +0200 +++ config.py 2004-09-03 12:43:13.565993488 +0200 @@ -54,6 +54,7 @@ 'allowed_actions': [], 'allow_xslt': 0, 'attachments': None, # {'dir': path, 'url': url-prefix} + 'attachments_maxsize': 2097152, 'auth_http_enabled': 0, 'bang_meta': 0, 'backtick_meta': 1, -------------- next part -------------- --- /home/gal/progs/pc/moin-1.2.3/MoinMoin/action/AttachFile.py 2004-07-21 22:02:15.000000000 +0200 +++ AttachFile.py 2004-09-03 14:44:43.902693848 +0200 @@ -334,7 +334,7 @@ 'baseurl': request.getScriptname(), 'pagename': wikiutil.quoteWikiname(pagename), 'action_name': action_name, - 'upload_label_file': _('File to upload'), + 'upload_label_file': _('File to upload(max. %s Bytes)') % (config.attachments_maxsize), 'upload_label_mime': _('MIME Type (optional)'), 'upload_label_rename': _('Save as'), 'rename': request.form.get('rename', [''])[0], @@ -424,7 +424,11 @@ # get file content filecontent = request.form['file'][0] - + + if len(filecontent)>config.attachments_maxsize: + error_msg(pagename,request, _("Your file has not been uploaded: The max. filesize on this site is %s Bytes") % (config.attachments_maxsize)) + return + target = wikiutil.taintfilename(target) # set mimetype from extension, or from given mimetype From Andrew.Premdas at man.ac.uk Mon Sep 6 03:57:59 2004 From: Andrew.Premdas at man.ac.uk (Andrew Premdas) Date: Mon Sep 6 03:57:59 2004 Subject: [Moin-devel] Show question mark for non-existing pagelinks bug/feature Message-ID: When you select 'Show question mark for non-existing pagelinks bug/feature' in user preferences, the name of the page is no longer a link, only the question mark preceding it. Surely this is a bug, as a question mark is a very small area to spot as a link and to click on. This can be fixed by changing line 322 in page.py from return wikiutil.link_tag(request, url, '?', formatter=fmt, **kw) + text + attach_link to return wikiutil.link_tag(request, url, '?' + text, formatter=fmt, **kw) + attach_link By the way is this the place to post things like this. Posts don't seem to be getting much response. All best Andrew Andrew Premdas Student Systems Developer Manchester University ------------------------- From gia at webde-ag.de Mon Sep 6 05:03:00 2004 From: gia at webde-ag.de (Gisbert Amm) Date: Mon Sep 6 05:03:00 2004 Subject: [Moin-devel] Show question mark for non-existing pagelinks bug/feature In-Reply-To: References: Message-ID: <413C51B0.4080403@webde-ag.de> Andrew Premdas wrote: > When you select 'Show question mark for non-existing pagelinks bug/feature' > in user preferences, the name of the page is no longer a link, only the > question mark preceding it. Surely this is a bug, as a question mark is a > very small area to spot as a link and to click on. I'm not really sure if this feature should be considered a bug. When it was introduced, links to non-existing pages were displayed in a bright red color. This could make a text with many CamelCase words in it nearly unreadable. At that time, the optional question mark prevented the reader from this. Probably now, as everybody can change the color of these links as he or she likes, it should be changed. > This can be fixed by changing line 322 in page.py > > from > return wikiutil.link_tag(request, url, > '?', formatter=fmt, **kw) + text + attach_link > > to > return wikiutil.link_tag(request, url, > '?' + text, formatter=fmt, **kw) + attach_link > > By the way is this the place to post things like this. Posts don't seem to > be getting much response. It's surely way better to file a bugreport or put your patch on SourceForge. Go http://sourceforge.net/projects/moin/ Regards, Gisbert Amm From tw-public at gmx.de Mon Sep 6 07:57:10 2004 From: tw-public at gmx.de (Thomas Waldmann) Date: Mon Sep 6 07:57:10 2004 Subject: [Moin-devel] Patch for moin/ie6 textarea problem In-Reply-To: References: Message-ID: <413C7981.7030401@gmx.de> > Moin has a problem with its textarea under IE6. Any theme that uses > sidebars, i.e. rightsidebar will show the symptom that when you edit a page, > the textarea will resize itself as soon as you enter some text into it. This > means that the text area will extend under the side bar and you can't see > what your editing. > > This can be fixed by putting a fieldset tag immediately after the form tag > (which contains the textarea). I used the other method using a div around that all (looked cleaner to me). Tested on IE and Mozilla, works. Will be in 1.3 (maybe also in 1.2.x). > Further info about this issue can be found at > http://fplanque.net/2003/Articles/iecsstextarea/. I've tested this with > rightsidebar and my own theme on ie6 and firefox. Thanks for that URL! From tw-public at gmx.de Mon Sep 6 07:58:05 2004 From: tw-public at gmx.de (Thomas Waldmann) Date: Mon Sep 6 07:58:05 2004 Subject: [Moin-devel] [PATCH] Fix PageEditor puts message div inside content div In-Reply-To: <41334B46.3080103@dgreaves.com> References: <41334B46.3080103@dgreaves.com> Message-ID: <413C79C3.7070704@gmx.de> > I think there are a set of
elements that should always be top level. > This patch fixes an instance where 'message' is not at the top level. This also has been fixed (1.3 or 1.2.x). Thanks for reporting. From tfanslau at gmx.de Wed Sep 8 16:41:29 2004 From: tfanslau at gmx.de (Thomas Fanslau) Date: Wed Sep 8 16:41:29 2004 Subject: [Moin-devel] Hello everyone :) Message-ID: <413F98BE.6010702@gmx.de> In the past i had played with a old version of MoinMoin on Python 2.0.1 but had no chance to follow current development until recently my hosting company finally updated to 2.3.4 . I had modified the old version to fit my needs and although i never really made the wiki public some people still did find it and liked what i had done and requested the code and the macros from me (which i had no problem to hand out :) ). Now, for 1.2.3 i might have to do the same, and actually this time i would like to do it right and to make my changes fit into the original source. But after several years of experience in developing Software i'm scared to just change something with asking first for acceptance :) You can find hints of what i would like to do here From tfanslau at gmx.de Wed Sep 8 16:43:01 2004 From: tfanslau at gmx.de (Thomas Fanslau) Date: Wed Sep 8 16:43:01 2004 Subject: [Moin-devel] Re: Hello everyone :) In-Reply-To: <413F98BE.6010702@gmx.de> References: <413F98BE.6010702@gmx.de> Message-ID: <413F991D.8040802@gmx.de> Sorry, forgot the link at the end. It's already 2am ... :( http://moinmoin.wikiwikiweb.de/ThomasFanslau --tf Thomas Fanslau schrieb: > In the past i had played with a old version of MoinMoin on Python 2.0.1 > but had no chance to follow current development until recently my > hosting company finally updated to 2.3.4 . > > I had modified the old version to fit my needs and although i never > really made the wiki public some people still did find it and liked what > i had done and requested the code and the macros from me (which i had no > problem to hand out :) ). > > Now, for 1.2.3 i might have to do the same, and actually this time i > would like to do it right and to make my changes fit into the original > source. > > But after several years of experience in developing Software i'm scared > to just change something with asking first for acceptance :) > > You can find hints of what i would like to do here > From adrian at sixfingeredman.net Fri Sep 10 20:45:09 2004 From: adrian at sixfingeredman.net (Adrian Kubala) Date: Fri Sep 10 20:45:09 2004 Subject: [Moin-devel] bug in macro/Include.py (moin version 1.2.3) Message-ID: Line 159 reads: inc_page.set_raw_body(body[from_pos:to_pos]) It should read: inc_page.set_raw_body(body[from_pos:to_pos], 1) If you don't do this the from/to args are basically ignored and the whole page is always included. (I'm not a list subscriber so please direct replies to my personal address. Thanks!) Adrian From R.Bauer at fz-juelich.de Mon Sep 13 01:45:03 2004 From: R.Bauer at fz-juelich.de (Reimar Bauer) Date: Mon Sep 13 01:45:03 2004 Subject: [Moin-devel] calculation macro Message-ID: <41455DFE.3090407@fz-juelich.de> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dear all, I am interested to write a special calculation macro. e.g. sum over all cells in one row to the position where the macro is. Did someone else has thougth on something like this? Reimar - -- Reimar Bauer Institut fuer Stratosphaerische Chemie (ICG-I) Forschungszentrum Juelich email: R.Bauer at fz-juelich.de - ------------------------------------------------------------------- ~ a IDL library at ForschungsZentrum Juelich ~ http://www.fz-juelich.de/icg/icg-i/idl_icglib/idl_lib_intro.html =================================================================== -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) iD4DBQFBRV395aOc3Q9hk/kRAoQiAJiZDNIMtJuuWZuiFZeoPDy743TzAKCSDP5A MIg7rlBAEZofv5OgznvXLw== =Ntot -----END PGP SIGNATURE----- From R.Bauer at fz-juelich.de Sun Sep 19 06:26:01 2004 From: R.Bauer at fz-juelich.de (Reimar Bauer) Date: Sun Sep 19 06:26:01 2004 Subject: [Moin-devel] moinmoin.wikiwikiweb.de is down ? Message-ID: <200409191522.25119.R.Bauer@fz-juelich.de> Hi all while I was editing some text to the sctable prozessor the wiki goes down I don't know if the text is now there or not. If it looks corrupted I will fix this after the wikiserver is online again. Reimar -- Forschungszentrum Juelich email: R.Bauer at fz-juelich.de http://www.fz-juelich.de/icg/icg-i/ ================================================================== a IDL library at ForschungsZentrum Juelich http://www.fz-juelich.de/icg/icg-i/idl_icglib/idl_lib_intro.html -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: signature URL: From noreply at sourceforge.net Sun Sep 19 11:23:00 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Sep 19 11:23:00 2004 Subject: [Moin-devel] [ moin-Patches-1030782 ] rst parser using docutils html4css1 parser Message-ID: Patches item #1030782, was opened at 2004-09-19 18:22 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1030782&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Matthew Gilbert (mmgilbe) Assigned to: Nobody/Anonymous (nobody) Summary: rst parser using docutils html4css1 parser Initial Comment: Alternative rst parser using the docutils code rather than the moinmoin code for formatting. In my test cases handles more of the docutils structure than the existing code. Supports all of the moinmoin's linking syntax but using restructuredtext directives. Tested with docutils 0.3.5. So for now, requires docutils 0.3.5. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1030782&group_id=8482 From gilbert at voxmea.net Sun Sep 19 11:34:01 2004 From: gilbert at voxmea.net (Matthew Gilbert) Date: Sun Sep 19 11:34:01 2004 Subject: [Moin-devel] New rst parser Message-ID: <414DD0F4.5070907@voxmea.net> Hi all, I've just finished wrapping up a "beta" version of a new rst parser. It is based on using the docutils html4css1 parser rather than letting moinmoin do the html markup. It supports all of the moinmoin linking types but using a docutils syntax. In my testing I've gotten much better results with this method than with letting moinmoin do the markup. There are still some issues of course with some docutils styles not being supported, but overall it seems better. Unfortunately I forgot to update the required line so it mistakenly suggests you need a CVS version of docutils. I've been testing with docutils 0.3.5 and am not sure if it works with older versions. Anyway, I'm happy to make any fixes that anyone sees. I don't know the moinmoin code well enough to give a comparison with the patch that is already submitted from June (although, in my testing mine works quite a bit better and supports more documents). Please let me know if people are interested in continuing to see this developed (and eventually included). If the consensus is that this isn't the correct direction, please let me know and I won't waste anymore time on it. Thanks _matt From gilbert at voxmea.net Sun Sep 19 11:35:07 2004 From: gilbert at voxmea.net (Matthew Gilbert) Date: Sun Sep 19 11:35:07 2004 Subject: [Moin-devel] Oops, forgot to saw new rst parser has been submitted as a patch Message-ID: <414DD13D.8040305@voxmea.net> Forgot to mention that I've submitted the new parser as a patch on the moinmoin sourceforge page. This is my first time doing this so forgive me if I've done something incorrectly. Thanks _matt From noreply at sourceforge.net Wed Sep 22 05:00:01 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Sep 22 05:00:01 2004 Subject: [Moin-devel] [ moin-Bugs-1032567 ] bad perfomance Message-ID: Bugs item #1032567, was opened at 2004-09-22 13:59 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=1032567&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Victor Espigares (kr0n_0) Assigned to: Nobody/Anonymous (nobody) Summary: bad perfomance Initial Comment: Hi, i don't know what could be the problem, but i recently installed MoinMoin with Apache (win32) in a 256/128kbs ADSL line, and editing pages does not work properly. Sometimes it doesn't show the Save, Preview... buttons, sometimes don't load the text, and so on. Not only the edit page option, the preview option sometimes have a weird work, and when i have pages larger tan 9000bytes it doesn't allow me to full save it ...any ideas? I use Mozilla 1.6 in Linux, but the server is WinXP Prof+Apache2 with Python 2.3.4, MoinMoin 1.2.3 and 256/128 ADSL connection ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=1032567&group_id=8482 From noreply at sourceforge.net Fri Sep 24 17:35:10 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Sep 24 17:35:10 2004 Subject: [Moin-devel] [ moin-Bugs-1032567 ] bad perfomance Message-ID: Bugs item #1032567, was opened at 2004-09-22 13:59 Message generated for change (Comment added) made by thomaswaldmann You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=1032567&group_id=8482 Category: None Group: None >Status: Closed Resolution: None Priority: 5 Submitted By: Victor Espigares (kr0n_0) Assigned to: Nobody/Anonymous (nobody) Summary: bad perfomance Initial Comment: Hi, i don't know what could be the problem, but i recently installed MoinMoin with Apache (win32) in a 256/128kbs ADSL line, and editing pages does not work properly. Sometimes it doesn't show the Save, Preview... buttons, sometimes don't load the text, and so on. Not only the edit page option, the preview option sometimes have a weird work, and when i have pages larger tan 9000bytes it doesn't allow me to full save it ...any ideas? I use Mozilla 1.6 in Linux, but the server is WinXP Prof+Apache2 with Python 2.3.4, MoinMoin 1.2.3 and 256/128 ADSL connection ---------------------------------------------------------------------- >Comment By: Thomas Waldmann (thomaswaldmann) Date: 2004-09-25 02:33 Message: Logged In: YES user_id=100649 mss clamping or mtu might solve your dsl problem. this is not a moin problem. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=1032567&group_id=8482 From noreply at sourceforge.net Fri Sep 24 17:39:05 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Sep 24 17:39:05 2004 Subject: [Moin-devel] [ moin-Bugs-1021476 ] IIS edit performance slow Message-ID: Bugs item #1021476, was opened at 2004-09-02 23:48 Message generated for change (Comment added) made by thomaswaldmann You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=1021476&group_id=8482 Category: None Group: None >Status: Closed Resolution: None Priority: 5 Submitted By: Lorrin Nelson (lorrin) Assigned to: Nobody/Anonymous (nobody) Summary: IIS edit performance slow Initial Comment: I just upgraded from 1.2.1 to 1.2.3 and now it takes forever to edit pages (both to load the editor and to save the changes). Otherwise performance is normal. This is an idle dual-CPU Win2k server running IIS. CPU usage remains low during the delay. OK, yes, I exaggerated. It's 20+ seconds, not literally forever. ;-) ---------------------------------------------------------------------- >Comment By: Thomas Waldmann (thomaswaldmann) Date: 2004-09-25 02:35 Message: Logged In: YES user_id=100649 this is typically cause by a not correctly working DNS resolving. fix your DNS and moin will get much faster. the 20s is simple the timeout of the DNS lookup. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=1021476&group_id=8482 From noreply at sourceforge.net Fri Sep 24 17:54:29 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Sep 24 17:54:29 2004 Subject: [Moin-devel] [ moin-Bugs-1019102 ] rightsidebar.py displays userid escaped Message-ID: Bugs item #1019102, was opened at 2004-08-30 16:13 Message generated for change (Comment added) made by thomaswaldmann You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=1019102&group_id=8482 Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Patrick Mueller (pmuellr) Assigned to: Nobody/Anonymous (nobody) Summary: rightsidebar.py displays userid escaped Initial Comment: In the rightsidebar.py theme, when the userid has characters that moin will escape to create the actual page name for the user, that escaped version of the userid is displayed under the user section. The fix seems simple enough. In rightsidebar.py, line 75, change: html.append('%s' % wikiutil.link_tag(self.request, wikiutil.quoteWikiname(self.request.user.name))) to the following: html.append('%s' % wikiutil.link_tag(self.request, wikiutil.quoteWikiname(self.request.user.name),wikiutil.escape(self.request.user.name))) What this does is call quote Wikiname with a specific piece of text to display (the HTML escaped userid), instead of using the default which is the Moin-escaped userid. ---------------------------------------------------------------------- >Comment By: Thomas Waldmann (thomaswaldmann) Date: 2004-09-25 02:51 Message: Logged In: YES user_id=100649 thanks! fixed in moin--main--1.2 tla repository ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=1019102&group_id=8482 From noreply at sourceforge.net Fri Sep 24 17:59:55 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Sep 24 17:59:55 2004 Subject: [Moin-devel] [ moin-Bugs-988770 ] Smart quotes break RSS feed Message-ID: Bugs item #988770, was opened at 2004-07-11 06:22 Message generated for change (Comment added) made by thomaswaldmann You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=988770&group_id=8482 Category: None Group: None >Status: Closed >Resolution: Later Priority: 5 Submitted By: Simon Lieschke (slieschke) Assigned to: Nobody/Anonymous (nobody) Summary: Smart quotes break RSS feed Initial Comment: Using Python 2.3.3 and Moin 1.2.2. The attached error occurs when attempting to access the RecentChanges RSS feed with text diffs in the feed and a smart quote character appearing in one of the diffs. ---------------------------------------------------------------------- >Comment By: Thomas Waldmann (thomaswaldmann) Date: 2004-09-25 02:57 Message: Logged In: YES user_id=100649 please report again if this also happens in 1.3 beta/rc/release. "fixing" encoding problems in 1.2 often lead to other things breaking, so the real fix (or at least a better base for a real fix) is the 1.3 code base. The release schedule plans a 1.3 release for december and some betas and RCs before. Maybe help beta testing if possible. ---------------------------------------------------------------------- Comment By: Oliver Graf (lydon) Date: 2004-07-22 15:29 Message: Logged In: YES user_id=1011012 I think this is an encoding problem still present in moin 1.2.3, but fixed in moin--main--1.3 arch branch. Request.write fails to encode the unicode data into the output charset. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=988770&group_id=8482 From noreply at sourceforge.net Fri Sep 24 19:09:48 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Sep 24 19:09:48 2004 Subject: [Moin-devel] [ moin-Patches-801787 ] Added strike-through wiki markup Message-ID: Patches item #801787, was opened at 2003-09-06 23:43 Message generated for change (Comment added) made by thomaswaldmann You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=801787&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Jason Dillon (user57) Assigned to: Nobody/Anonymous (nobody) Summary: Added strike-through wiki markup Initial Comment: This patch adds strike-through wiki markup. For example: ---Strike this stuff--- Not striked --- Strike all of this --- I used '---' to avoid problems when people sign names like: --jason And also because --- is not a horizontal rule. Basically I need a way to mark bits in the wiki as crap, but not delete them right off the bat... ya know? ---------------------------------------------------------------------- >Comment By: Thomas Waldmann (thomaswaldmann) Date: 2004-09-25 03:59 Message: Logged In: YES user_id=100649 See comments there: http://moinmoin.wikiwikiweb.de/MarkupProposals?action=diff&date2=0&date1=1094038974 ---------------------------------------------------------------------- Comment By: Jason Dillon (user57) Date: 2003-09-07 12:03 Message: Logged In: YES user_id=15045 The regex used before was not valid, as it caught rules as well. The latest patch resolves this. ---------------------------------------------------------------------- Comment By: Jason Dillon (user57) Date: 2003-09-07 02:14 Message: Logged In: YES user_id=15045 Looks like there is a problem with this... some pages get everything striked... :-| ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=801787&group_id=8482 From noreply at sourceforge.net Fri Sep 24 19:17:50 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Sep 24 19:17:50 2004 Subject: [Moin-devel] [ moin-Patches-736885 ] Identify users using client certificates Message-ID: Patches item #736885, was opened at 2003-05-13 09:45 Message generated for change (Comment added) made by thomaswaldmann You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=736885&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Martin v. L?wis (loewis) >Assigned to: Thomas Waldmann (thomaswaldmann) Summary: Identify users using client certificates Initial Comment: This patch allows to identifiy Moin users using SSL client certificates. Specifically, it uses the common name and the email address from the cerificate's subject's distinguished name. Cookies and Moin user ids are still used, and finding users works like this 1. If there is a cookie, use that 2. If there is no cookie, iterate over all users, and try to find one with the same email address or where the X.509 common name is the same as the Moin user name. 3. If no user is found, but either the email address or the common name is set, create a new user. This patch works only with Apache mod_ssl, as it relies on the environment variables SSL_CLIENT_S_DN* being set. ---------------------------------------------------------------------- >Comment By: Thomas Waldmann (thomaswaldmann) Date: 2004-09-25 04:13 Message: Logged In: YES user_id=100649 Martin, I don't think any of the devels uses client certificates, so we could not test it. Would you test it if we include your patch into 1.2.x (and later, into 1.3)? I would make the necessary changes to adapt it to the current version (like using request object). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=736885&group_id=8482 From noreply at sourceforge.net Fri Sep 24 19:20:46 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Sep 24 19:20:46 2004 Subject: [Moin-devel] [ moin-Patches-1030782 ] rst parser using docutils html4css1 parser Message-ID: Patches item #1030782, was opened at 2004-09-19 20:22 Message generated for change (Comment added) made by thomaswaldmann You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1030782&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Matthew Gilbert (mmgilbe) Assigned to: Nobody/Anonymous (nobody) Summary: rst parser using docutils html4css1 parser Initial Comment: Alternative rst parser using the docutils code rather than the moinmoin code for formatting. In my test cases handles more of the docutils structure than the existing code. Supports all of the moinmoin's linking syntax but using restructuredtext directives. Tested with docutils 0.3.5. So for now, requires docutils 0.3.5. ---------------------------------------------------------------------- >Comment By: Thomas Waldmann (thomaswaldmann) Date: 2004-09-25 04:16 Message: Logged In: YES user_id=100649 as long as the efforts on rst require more than what's in debian, I can't even test it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1030782&group_id=8482 From noreply at sourceforge.net Sat Sep 25 00:10:15 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Sep 25 00:10:15 2004 Subject: [Moin-devel] [ moin-Patches-736885 ] Identify users using client certificates Message-ID: Patches item #736885, was opened at 2003-05-13 09:45 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=736885&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Martin v. L?wis (loewis) Assigned to: Thomas Waldmann (thomaswaldmann) Summary: Identify users using client certificates Initial Comment: This patch allows to identifiy Moin users using SSL client certificates. Specifically, it uses the common name and the email address from the cerificate's subject's distinguished name. Cookies and Moin user ids are still used, and finding users works like this 1. If there is a cookie, use that 2. If there is no cookie, iterate over all users, and try to find one with the same email address or where the X.509 common name is the same as the Moin user name. 3. If no user is found, but either the email address or the common name is set, create a new user. This patch works only with Apache mod_ssl, as it relies on the environment variables SSL_CLIENT_S_DN* being set. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2004-09-25 09:07 Message: Logged In: YES user_id=21627 I can certainly test it, yes. ---------------------------------------------------------------------- Comment By: Thomas Waldmann (thomaswaldmann) Date: 2004-09-25 04:13 Message: Logged In: YES user_id=100649 Martin, I don't think any of the devels uses client certificates, so we could not test it. Would you test it if we include your patch into 1.2.x (and later, into 1.3)? I would make the necessary changes to adapt it to the current version (like using request object). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=736885&group_id=8482 From R.Bauer at fz-juelich.de Sat Sep 25 13:08:47 2004 From: R.Bauer at fz-juelich.de (Reimar Bauer) Date: Sat Sep 25 13:08:47 2004 Subject: [Moin-devel] get WikiNames from text Message-ID: <200409252203.33929.R.Bauer@fz-juelich.de> Hi all I am looking for a function which returns all WikiName(s) from a given text. Where should I start? regards Reimar -- Forschungszentrum Juelich email: R.Bauer at fz-juelich.de http://www.fz-juelich.de/icg/icg-i/ ================================================================== a IDL library at ForschungsZentrum Juelich http://www.fz-juelich.de/icg/icg-i/idl_icglib/idl_lib_intro.html -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: signature URL: From R.Bauer at fz-juelich.de Sat Sep 25 14:37:38 2004 From: R.Bauer at fz-juelich.de (Reimar Bauer) Date: Sat Sep 25 14:37:38 2004 Subject: [Moin-devel] favicon Message-ID: <200409252331.57958.R.Bauer@fz-juelich.de> Dear all I don't know if this is possible now. If not take it please as a feature request for one of the next versions. I would like to have the favicon of a a page in front of the url I give favicon [http://www.linuxwiki.org/WiesoWikiFunktioniert "WiesoWikiFunktioniert"] Reimar -- Forschungszentrum Juelich email: R.Bauer at fz-juelich.de http://www.fz-juelich.de/icg/icg-i/ ================================================================== a IDL library at ForschungsZentrum Juelich http://www.fz-juelich.de/icg/icg-i/idl_icglib/idl_lib_intro.html -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: signature URL: From festifn at rupert.informatik.uni-stuttgart.de Sun Sep 26 04:14:08 2004 From: festifn at rupert.informatik.uni-stuttgart.de (Florian Festi) Date: Sun Sep 26 04:14:08 2004 Subject: [Moin-devel] get WikiNames from text In-Reply-To: <200409252203.33929.R.Bauer@fz-juelich.de> References: <200409252203.33929.R.Bauer@fz-juelich.de> Message-ID: > I am looking for a function which returns all WikiName(s) from a given text. > > Where should I start? use Page.getPageLinks(request) have fun FlorianFesti From festifn at rupert.informatik.uni-stuttgart.de Sun Sep 26 04:24:16 2004 From: festifn at rupert.informatik.uni-stuttgart.de (Florian Festi) Date: Sun Sep 26 04:24:16 2004 Subject: [Moin-devel] favicon In-Reply-To: <200409252331.57958.R.Bauer@fz-juelich.de> References: <200409252331.57958.R.Bauer@fz-juelich.de> Message-ID: > I don't know if this is possible now. If not take it please as a feature > request for one of the next versions. > > I would like to have the favicon of a a page in front of the url I give > > favicon [http://www.linuxwiki.org/WiesoWikiFunktioniert > "WiesoWikiFunktioniert"] I don't know a easy way to achive this right now, but I like the idea. But there are some different possible ways to implement favicon support. I would suggest to collect some ideas on a wiki page on MoinMoin. I would see this as a ExtensionProposals. cu FlorianFesti From R.Bauer at fz-juelich.de Sun Sep 26 10:58:52 2004 From: R.Bauer at fz-juelich.de (Reimar Bauer) Date: Sun Sep 26 10:58:52 2004 Subject: [Moin-devel] get WikiNames from text In-Reply-To: References: <200409252203.33929.R.Bauer@fz-juelich.de> Message-ID: <200409261950.51923.R.Bauer@fz-juelich.de> Am Sonntag, 26. September 2004 13:07 schrieb Florian Festi: > > I am looking for a function which returns all WikiName(s) from a given > > text. > > > > Where should I start? > > use Page.getPageLinks(request) > > have fun > > FlorianFesti Dear Florian I believe I could use this routine only if the text is saved in a page. I recognized saving a page creates a file with the pagename in the dir my_wiki/data/cache/pagelinks with all wikinames. Later on a lot of routines references this file. In my case I need the mechanism which do this and probably I like to use it with words or a text line or the whole text array. This must be a quite simple function but I haven't seen it. Because I got stuck here and probably someone else is interested to help the first version of EmbedWikiPage is on ProcessorMarket. cheers Reimar -- Forschungszentrum Juelich email: R.Bauer at fz-juelich.de http://www.fz-juelich.de/icg/icg-i/ ================================================================== a IDL library at ForschungsZentrum Juelich http://www.fz-juelich.de/icg/icg-i/idl_icglib/idl_lib_intro.html -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: signature URL: From noreply at sourceforge.net Sun Sep 26 15:05:20 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Sep 26 15:05:20 2004 Subject: [Moin-devel] [ moin-Patches-1030782 ] rst parser using docutils html4css1 writer Message-ID: Patches item #1030782, was opened at 2004-09-19 18:22 Message generated for change (Comment added) made by mmgilbe You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1030782&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Matthew Gilbert (mmgilbe) Assigned to: Nobody/Anonymous (nobody) >Summary: rst parser using docutils html4css1 writer Initial Comment: Alternative rst parser using the docutils code rather than the moinmoin code for formatting. In my test cases handles more of the docutils structure than the existing code. Supports all of the moinmoin's linking syntax but using restructuredtext directives. Tested with docutils 0.3.5. So for now, requires docutils 0.3.5. ---------------------------------------------------------------------- >Comment By: Matthew Gilbert (mmgilbe) Date: 2004-09-26 22:01 Message: Logged In: YES user_id=1002483 Tested with docutils 0.3.3 which I see there is a package for in debian unstable? Thomas, will you install something from unstable? The url is: http://packages.debian.org/unstable/python/python-docutils It seems to work fine with 0.3.3. Will you try the patch the now? Thanks ---------------------------------------------------------------------- Comment By: Thomas Waldmann (thomaswaldmann) Date: 2004-09-25 02:16 Message: Logged In: YES user_id=100649 as long as the efforts on rst require more than what's in debian, I can't even test it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1030782&group_id=8482 From noreply at sourceforge.net Mon Sep 27 12:40:01 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Sep 27 12:40:01 2004 Subject: [Moin-devel] [ moin-Patches-1035685 ] Fixes id sections for preview Message-ID: Patches item #1035685, was opened at 2004-09-27 20:34 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1035685&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Nigel Metheringham (nigel) Assigned to: Nobody/Anonymous (nobody) Summary: Fixes id sections for preview Initial Comment: Using default moin 1.2.3, when a preview of an edit is done an additional
is emitted within the preview div. This means there are 2 content sections embedded within one another, and tends to lead to real problems with the CSS and layout particularly for themes which use a left hand navigation bar. This patch changes the div within the preview to have id="previewcontent". There is a chance it could interact badly with people who have worked round the previous bug in their CSS, but they should know enough to fix that. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1035685&group_id=8482 From noreply at sourceforge.net Mon Sep 27 23:01:29 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Sep 27 23:01:29 2004 Subject: [Moin-devel] [ moin-Patches-1035685 ] Fixes id sections for preview Message-ID: Patches item #1035685, was opened at 2004-09-27 21:34 Message generated for change (Comment added) made by lydon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1035685&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Nigel Metheringham (nigel) Assigned to: Nobody/Anonymous (nobody) Summary: Fixes id sections for preview Initial Comment: Using default moin 1.2.3, when a preview of an edit is done an additional
is emitted within the preview div. This means there are 2 content sections embedded within one another, and tends to lead to real problems with the CSS and layout particularly for themes which use a left hand navigation bar. This patch changes the div within the preview to have id="previewcontent". There is a chance it could interact badly with people who have worked round the previous bug in their CSS, but they should know enough to fix that. ---------------------------------------------------------------------- Comment By: Oliver Graf (lydon) Date: 2004-09-28 07:55 Message: Logged In: YES user_id=1011012 This is an old thing. Already fixed in 1.3. See http://moinmoin.wikiwikiweb.de/MoinMoinBugs_2fContentDivProblems ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1035685&group_id=8482 From R.Bauer at fz-juelich.de Wed Sep 29 00:42:15 2004 From: R.Bauer at fz-juelich.de (Reimar Bauer) Date: Wed Sep 29 00:42:15 2004 Subject: [Moin-devel] TRaceback warnings Message-ID: <415A65B3.60102@fz-juelich.de> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 While changing the EmbedWikiPage from a macro to a processor the following warnings are removed. Did someone have something like this seen before and could give a hint what probably could be wrong? Traceback (most recent call last): ~ File "/lib/python/MoinMoin/request.py", line 405, in run ~ Page(query).send_page(self, count_hit=1) ~ File "/lib/python/MoinMoin/Page.py", line 611, in send_page ~ self.send_page_content(request, Parser, body) ~ File "/lib/python/MoinMoin/Page.py", line 662, in send_page_content ~ Parser(body, request).format(self.formatter) ~ File "/lib/python/MoinMoin/parser/wiki.py", line 1033, in format ~ formatted_line = self.scan(scan_re, line) # this also sets self.inhibit_p as side effect! ~ File "/lib/python/MoinMoin/parser/wiki.py", line 876, in scan ~ return ''.join(result) TypeError: sequence item 1: expected string, NoneType found Reimar - -- Reimar Bauer Institut fuer Stratosphaerische Chemie (ICG-I) Forschungszentrum Juelich email: R.Bauer at fz-juelich.de - ------------------------------------------------------------------- ~ a IDL library at ForschungsZentrum Juelich ~ http://www.fz-juelich.de/icg/icg-i/idl_icglib/idl_lib_intro.html =================================================================== -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) iD8DBQFBWmWf5aOc3Q9hk/kRAs36AKCuWPv1somjpqFcTK6C9FphKxky8wCfc6ZF uTz2HkDetD7u6lSiPYqZlhE= =eXYi -----END PGP SIGNATURE----- From festifn at rupert.informatik.uni-stuttgart.de Wed Sep 29 01:22:23 2004 From: festifn at rupert.informatik.uni-stuttgart.de (Florian Festi) Date: Wed Sep 29 01:22:23 2004 Subject: [Moin-devel] TRaceback warnings In-Reply-To: <415A65B3.60102@fz-juelich.de> References: <415A65B3.60102@fz-juelich.de> Message-ID: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > While changing the EmbedWikiPage from a macro to a processor the > following warnings are removed. > > Did someone have something like this seen before and could give a hint > what probably could be wrong? > > Traceback (most recent call last): > ~ File "/lib/python/MoinMoin/request.py", line 405, in run > ~ Page(query).send_page(self, count_hit=1) > ~ File "/lib/python/MoinMoin/Page.py", line 611, in send_page > ~ self.send_page_content(request, Parser, body) > ~ File "/lib/python/MoinMoin/Page.py", line 662, in send_page_content > ~ Parser(body, request).format(self.formatter) > ~ File "/lib/python/MoinMoin/parser/wiki.py", line 1033, in format > ~ formatted_line = self.scan(scan_re, line) # this also sets > self.inhibit_p as side effect! > ~ File "/lib/python/MoinMoin/parser/wiki.py", line 876, in scan > ~ return ''.join(result) > TypeError: sequence item 1: expected string, NoneType found Sounds familiar. I fixed something like this in the 1.3 branch some weeks ago. What version do you use exactly? Consider to update to 1.3 current. If you are already on 1.3 current please complain again. cu FlorianFesti From noreply at sourceforge.net Wed Sep 29 05:39:13 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Sep 29 05:39:13 2004 Subject: [Moin-devel] [ moin-Patches-1035685 ] Fixes id sections for preview Message-ID: Patches item #1035685, was opened at 2004-09-27 20:34 Message generated for change (Comment added) made by nigel You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1035685&group_id=8482 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Nigel Metheringham (nigel) Assigned to: Nobody/Anonymous (nobody) Summary: Fixes id sections for preview Initial Comment: Using default moin 1.2.3, when a preview of an edit is done an additional
is emitted within the preview div. This means there are 2 content sections embedded within one another, and tends to lead to real problems with the CSS and layout particularly for themes which use a left hand navigation bar. This patch changes the div within the preview to have id="previewcontent". There is a chance it could interact badly with people who have worked round the previous bug in their CSS, but they should know enough to fix that. ---------------------------------------------------------------------- >Comment By: Nigel Metheringham (nigel) Date: 2004-09-29 13:29 Message: Logged In: YES user_id=31288 Although this is fixed in the 1.3 tree, the current 1.2 development tree does not have a fix. I suggest that OliverGraf's fix from http://moinmoin.wikiwikiweb.de/MoinMoinBugs_2fContentDivProblems is applied to the 1.2 branch, or (probably better), the attachment on that page:- http://moinmoin.wikiwikiweb.de/MoinMoinBugs_2fContentDivProblems?action=AttachFile&do=get&target=preview-div.diff ---------------------------------------------------------------------- Comment By: Oliver Graf (lydon) Date: 2004-09-28 06:55 Message: Logged In: YES user_id=1011012 This is an old thing. Already fixed in 1.3. See http://moinmoin.wikiwikiweb.de/MoinMoinBugs_2fContentDivProblems ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308482&aid=1035685&group_id=8482 From noreply at sourceforge.net Thu Sep 30 09:31:05 2004 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Sep 30 09:31:05 2004 Subject: [Moin-devel] [ moin-Bugs-927192 ] "Internal Server Error" using moinmoin 1.2.1 and apache Message-ID: Bugs item #927192, was opened at 2004-03-31 18:57 Message generated for change (Comment added) made by jamesjwagner You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108482&aid=927192&group_id=8482 Category: None Group: None Status: Closed Resolution: Invalid Priority: 5 Submitted By: Jerry Dobner (jdobner) Assigned to: Nobody/Anonymous (nobody) Summary: "Internal Server Error" using moinmoin 1.2.1 and apache Initial Comment: Updates to certain pages always result in: Internal Server Error The server encountered an internal error or misconfiguration and was unable to complete your request. Here's what the apache's error log reports: [Wed Mar 31 20:53:44 2004] [error] [client 10.1.15.250] malformed header from script. Bad header=
  

Hi!

I've recently set up MoinMoin on our company server to serve as a 
collaborative internal documentation environment.

The problem is, we need centralized user management because it's getting 
too much with all the different workstations, servers, websites, 
mail/FTP accounts and so on.

Is anything known about an LDAP interface being developed by someone? 
Seeing that HTTP Auth is already in there, maybe mod_auth_ldap is an 
option (as somebody already mentioned here in 2003-04 but never got back 
  to it)?

Just tell me if anything's on the horizon; If not, I'll probably do the 
work.

Bye,
	Sebastian.

P.S.: I love your ACLs ;)
-- 
Reclaim Your Inbox!
http://www.mozilla.org/products/thunderbird/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
URL: 

From david at dgreaves.com  Thu Sep 30 14:49:03 2004
From: david at dgreaves.com (David Greaves)
Date: Thu Sep 30 14:49:03 2004
Subject: [Moin-devel] Hit / page counters...
Message-ID: <415C7F1D.3090307@dgreaves.com>

What do people use?

I couldn't easily see anything in MoinMoin - did I miss it?

David




From david at dgreaves.com  Thu Sep 30 14:51:01 2004
From: david at dgreaves.com (David Greaves)
Date: Thu Sep 30 14:51:01 2004
Subject: [Moin-devel] [PATCH] Allow subscribers to see 'trivial' changes
In-Reply-To: <41334D6C.7010702@dgreaves.com>
References: <20040823154435.50751.qmail@web14306.mail.yahoo.com> <41334D6C.7010702@dgreaves.com>
Message-ID: <415C7F97.9090407@dgreaves.com>

As an FYI, this has been live for a month now and works like a charm :)

Did you try it Roger?

David

David Greaves wrote:

> As discussed (briefly!) recently.
>
> This patch adds a 'want_trivial' to the User object (and preferences)
> that indicates that the users would like to see all changes, no matter 
> how trivial.
> It also sends the entire body of a page if there is no history (ie a 
> new page).
>
> The current 'behaviour' is mimicked.
> In other words, if a user unticks 'Send mail notification' then it 
> appears as if no
> notifications have been sent.
> This
> a) lets 'nice' users think they're not bothering people with emails 
> about trivial
> changes (so they don't feel shy about correcting typos)
> b) may fool the abusers into thinking the admins are 'on the ball' :)
> c) most importantly - doesn't let abusers add p0rn links etc and stop 
> notification emails.
>
> This applies to 1.2.3
>
> David
> PS please let me know if there are any issues.
>
> Roger Haase wrote:
>
>> --- David Greaves  wrote:
>>  
>>
>> I agree with your thinking David. Tools which assist administrators in
>> watching a site are very beneficial. I would certainly apply your patch
>> if it were available.
>>
>> Roger Haase
>>  
>