[Matplotlib-devel] Why keep codecov?

[Thomas Caswell]

I think the current problem with codecov is that on the master branch azure
uploads coverage reports but it does not an the PR runs which leads to the
drop in coverage due to the edge cases that are hit slightly differently on
azure than on travis / appveyor.

Tom

On Tue, May 5, 2020 at 11:21 PM Jody Klymak <jklymak at uvic.ca> wrote:

> Hi Eric,
>
> I agree for the codecov/project check.  I don’t see how it helps, and I
> routinely ignore it during reviews because it is pretty obscure how you are
> supposed to fix it.
>
> In my opinion, codecov/patch is pretty helpful to know if someone’s new
> code actually ever gets exercised.
>
> Cheers,   Jody
>
> > On May 5, 2020, at  18:55 PM, Eric Firing <efiring at hawaii.edu> wrote:
> >
> >
> https://codecov.io/gh/matplotlib/matplotlib/compare/5455bab77e75cee46d260c0f27110d6b4fa78270...3eb471dadd2fd397c840bc98db90a06845697131/changes
> >
> > The link above is what I find for the "failing" codecov test for
> https://github.com/matplotlib/matplotlib/pull/17266, which is passing all
> the other tests.
> >
> > The codecov.io output looks like complete garbage, listing a huge
> number of untouched files.
> >
> > I added 2 tests for the code I modified.  As far as I can see, from a
> practical standpoint, codecov is incorrectly flagging the PR as failing,
> leading to a misleading red X in the PR list.
> >
> > I can see how a mechanized code coverage test could be useful for a
> project at an early stage, when it is building up its test infrastructure,
> and at a later stage, to be run occasionally, especially when major code
> additions are made.
> >
> > As it is being run now, however, I think it is impeding, not aiding, the
> development process.
> >
> > I recommend that we remove it from the suite of tests run for every PR,
> or at least keep it out of the accounting for the overall "pass/fail"
> rating of the PR.
> >
> > Eric
> > _______________________________________________
> > Matplotlib-devel mailing list
> > Matplotlib-devel at python.org
> > https://mail.python.org/mailman/listinfo/matplotlib-devel
>
> _______________________________________________
> Matplotlib-devel mailing list
> Matplotlib-devel at python.org
> https://mail.python.org/mailman/listinfo/matplotlib-devel
>


-- 
Thomas Caswell
tcaswell at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/matplotlib-devel/attachments/20200505/9d2c19b2/attachment.html>