[Matplotlib-devel] new github features

[Matthias Bussonnier]

Hi all,

One data point, it seem that some users/dev (at least on Jupyter side)
are complaining that they don't get the "grouped-review-comments" by
emails. So are waiting for feedback they never get until they check
the PR.

Still haven't figured out when this happens.

I'm curious if the "Approved" review get reset after a new commit is
pushed, and If so and the N reviewer is enforced, it can be annoying
if someone approved with a small condition, like typo fixed or
something similar.
-- 
M

On Mon, Sep 19, 2016 at 7:24 PM, Thomas Caswell <tcaswell at gmail.com> wrote:
> Folks,
>
> Have people had a chance to look at the new review tools on github?  Do we
> want to work these into our workflow?  It looks like we can set it so that
> PRs can only be merged via the web UI with at least one approve review and
> no 'needs work' reviews if we want.   My initial reaction is we should try
> to use the review tools, but hold on on the engineering control on merges
> until we have a better sense of what that would look like.
>
> Has anyone looked at the 'projects' feature yet?
>
> A suggestion from Nelle Varoquaux is to follow skimage/sklearn and on review
> add a [mrg+N] to the title to help other devs find PRs that are almost ready
> to merge, but need another set of eyes.
>
> Tom
>
> _______________________________________________
> Matplotlib-devel mailing list
> Matplotlib-devel at python.org
> https://mail.python.org/mailman/listinfo/matplotlib-devel
>