[Mailman-Users] Additional questions about ban_list

[Chris Nulk]

On 10/15/2015 4:01 PM, Mark Sapiro wrote:
> On 10/15/2015 03:25 PM, Chris Nulk wrote:
>>
>> On 10/15/2015 3:07 PM, Mark Sapiro wrote:
>>
>>> This was done for subscribe_auto_approval, and
>>> while it's kind of kludgy, the error log messages that you have above
>>> for 'Ban_list listfor %s references own list' and 'Ban_list for list %s
>>> references non-existent list %s' refer to subscribe_auto_approval rather
>>> than ban_list or something variable.
>>>
>>> Thus if you had 2.1.19 or later, the code change is much simpler if you
>>> don't mind the error log messages saying subscribe_auto_approval when
>>> they might mean ban_list.
>> Okay.  That makes sense.
>
> I have decided to refactor this code to allow the attribute name to be
> passed as the argument to GetPattern that says to allow @listname
> syntax. This will make the error messages log the correct attribute name
> and will simplify extending @listname recognition to other attributes in
> the future. Along with this, I'm replacing the matches_p() function in
> Moderate.py with calls to the GetPattern() method so all this is in one
> place.
>
> I haven't committed this change yet as it still needs testing, but I
> expect it to be in 2.1.21.
>
Excellent.  Thank you for the hard work.

Chris