[Mailman-Users] wrong path to Debian logo

[Mark Sapiro]

On 03/31/2015 02:33 PM, Roland Miyamoto wrote:
> Hi Mark.
>
> Mark Sapiro wrote:
>> This is a Debian packaging issue. If it were an issue with Mailman
>> per
>
> I do not understand.
> I set
>
>   IMAGE_LOGOS         = '/mailman/images/'
>
> in mm_cfg.py
> Then the html returned by http://mydom.ain/mailman/listinfo
> reads
>
> <table WIDTH="100%" BORDER="0">
>   <tr>
>     <td><a href="http://www.gnu.org/software/mailman/index.html"><img
> src="/mailman/images/mailman.jpg" alt="Delivered by Mailman"
> border="0" /><br>version 2.1.15</a></td>
>     <td><a href="http://www.python.org/"><img
> src="/mailman/images/PythonPowered.png" alt="Python Powered"
> border="0" /></a></td>
>     <td><a href="http://www.gnu.org/"><img
> src="/mailman/images/gnu-head-tiny.jpg" alt="GNU's Not Unix"
> border="0" /></a></td>
>     <td><a href="http://www.debian.org/"><img
> src="/images/mailman/debianpowered.png" alt="Debian Powered"
> border="0" /></a></td>
>   </tr>
> </table>
>
> at the bottom. Note how the path is different for the last image
>
>   /images/mailman/debianpowered.png
>
> instead of /mailman/images/debianpowered.png as is for the other three
> images.
> I do not see how packaging can influence the html produced by
> Mailman's python code.

You don't think packagers ever change the upstream code? If only that
were true <sigh...>.

If you download
<http://ftp.de.debian.org/debian/pool/main/m/mailman/mailman_2.1.15-1.debian.tar.gz>
and extract the files, you will see the patches that Debian applies to
their Mailman package.

In particular, look at 01_defaults.debian.patch which patches
Defaults.py.in to change the default for IMAGE_LOGOS from '/icons/' to
'/doc/mailman/images/'

Then look at 25_site_logo_patch which patches Defaults.py.in to add

# The site logo/text presence, site text, site url and site logo
SITE_LINK = Yes
SITE_TEXT = 'Debian Powered'
SITE_URL = 'http://www.debian.org/'
SITE_LOGO = '/images/mailman/debianpowered.png'

All of which don't exist in non-Debian Mailman. This patch further
modifies code in htmlformat.py to generate the logos in the footer. This
code gets the 3 standard logos from the IMAGE_LOGOS directory and gets
the Debian Powered logo from the SITE_LOGO directory.

Thus, the 3 standard logos all come from the directory defined in
Defaults.py or overridden in mm_cfg.py by the IMAGE_LOGOS setting.

The 4th (Debian Powered) logo comes from the file defined in Defaults.py
or overridden in mm_cfg.py by the SITE_LOGO setting.

In fact, you can turn this off in a Debian installation by setting

SITE_LINK = No

in mm_cfg.py or adjust the text, image and URL with the other 3 settings.

This is a feature of the Debian package. All this *should* be covered in
Debian's documentation, but outside of reading Defaults.py, I don't see
anything off hand.

If you have an issue with how this is done or documented, you need to
take it up with Debian because this is a Debian feature added by Debian
and doesn't come from the GNU Mailman project.

-- 
Mark Sapiro <mark at msapiro.net>        The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://mail.python.org/pipermail/mailman-users/attachments/20150331/1a26e64c/attachment.sig>