[Mailman-Users] Strange rejection

Mark Sapiro mark at msapiro.net
Sat Oct 25 19:50:05 CEST 2014


On 10/25/2014 09:20 AM, Lindsay Haisley wrote:
> 
> Does this look correct?
> 
> --- IncomingRunner.py.orig	2014-10-25 10:53:02.000000000 -0500
> +++ IncomingRunner.py	2014-10-25 11:03:40.000000000 -0500
> @@ -157,8 +157,11 @@
>                      os._exit(1)
>              except Errors.DiscardMessage:
>                  # Throw the message away; we need do nothing else with it.
> -                syslog('vette', 'Message discarded, msgid: %s',
> -                       msg.get('message-id', 'n/a'))
> +                syslog('vette', """Message discarded, msgid: %s
> +         list: %s,
> +         handler: %s""",
> +                      msg.get('message-id', 'n/a'),
> +                      mlist.real_name, handler)
>                  return 0
>              except Errors.HoldMessage:
>                  # Let the approval process take it from here.  The message no


Yes, it looks right.


> A test list posts correctly, so no stupid syntax or indentation errors
> (which shouldn't be a problem anyway since the added code is all inside
> a function call argument list)
> 
> I'm a great fan of intelligent logging!  This would be a good mod for a
> future version of MM 2.


I plan to do it. I don't know why I didn't do it at the same time as the
reject logging enhancement, but I'll do it now.

-- 
Mark Sapiro <mark at msapiro.net>        The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan


More information about the Mailman-Users mailing list