[Mailman-Users] subscribing by email

[Alan Rubin]

Mark,

Nope, I didn't realise that a restart was required.  I just restarted it
and it seems to work fine now. Thanks for the help, once again.

Regards,

Alan Rubin   
Technician Unix
DCS Midrange Services
Phone: +61 (08) 8999 5111
Fax:      +61 (08) 8999 7493
e-Mail: alan.rubin at nt.gov.au

-----Original Message-----
From: Mark Sapiro [mailto:mark at msapiro.net] 
Sent: Wednesday, 18 February 2009 1:28 AM
To: Alan Rubin; Mailman User List
Subject: RE: [Mailman-Users] subscribing by email

Alan Rubin wrote:
>
>I applied the patch, used the request address, and my message still
gets
>shunted.


Did you restart Mailman after applying the patch?


>
>Feb 17 14:59:32 2009 (1046) Uncaught runner exception: 'NoneType'
object
>has no attribute 'lower'
>Feb 17 14:59:32 2009 (1046) Traceback (most recent call last):
>  File "/export/home/mailman/Mailman/Queue/Runner.py", line 114, in
>_oneloop
>    self._onefile(msg, msgdata)
>  File "/export/home/mailman/Mailman/Queue/Runner.py", line 185, in
>_onefile
>    keepqueued =3D self._dispose(mlist, msg, msgdata)
>  File "/export/home/mailman/Mailman/Queue/CommandRunner.py", line 239,
>in _dispose
>    res.process()
>  File "/export/home/mailman/Mailman/Queue/CommandRunner.py", line 112,
>in process
>    stop =3D self.do_command(cmd, args)
>  File "/export/home/mailman/Mailman/Queue/CommandRunner.py", line 139,
>in do_command
>    return handler.process(self, args)
>  File "/export/home/mailman/Mailman/Commands/cmd_subscribe.py", line
>74, in process
>    if (digest is None
>AttributeError: 'NoneType' object has no attribute 'lower'
>
>Feb 17 14:59:32 2009 (1046) SHUNTING:
>1234848571.543715+462ea839ccdd63f659aab843129562980c886d3c
>
>
>Diff on the cmd_subscribe.py new and old:
>
># diff Mailman/Commands/cmd_subscribe.py Mailman/Commands/cmd_sub>
>74,75c74
><     if (digest is None
><             and password and password.lower() in ('digest',
>'nodigest')):
>---
>>     if digest is None and password.lower() in ('digest', 'nodigest'):


I think the only possible explanation for the above is you didn't
restart Mailman.

Also, even without the patch, if you sent a

  subscribe nodigest address=xxx at example.com

command to the list-request address, it shouldn't trigger that error
unless you also had, e.g., a bare 'subscribe' in the subject. In mails
to -request, both Subject: and body are scanned for commands so if you
mail to -request with "Subject: subscribe" and body

subscribe nodigest address=xxx at example.com

that's two subscribe commands and the plain "subscribe" will trigger
the bug.


>The web form that you pointed me at should work regardless of this
error
>with the cmd_subscribe.py utility?


That's correct.

-- 
Mark Sapiro <mark at msapiro.net>        The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan