[Mailman-Users] PGP keys causing problems

[Mark Sapiro]

Mark Sapiro wrote:
>
>Regarding the original problem of the message body and attached patch 
>not being in the archive, I have done some testing with the latest 
>Scrubber, and it works properly with all the test messages Todd sent me.
>
>I note that the annotation "Skipped content of type multipart/mixed" 
>will not appear in these cases in Mailman 2.1.6 and up, but the change 
>that skips issuing that message is not what fixed the problem. I need to 
>test with older versions of Scrubber to actually identify what the 
>problem was and what fixed it.


I have identified the problem with 2.1.5 and earlier. Basically, it has
nothing to do with PGP signed messages. The problem was if a message
contained a multipart MIME sub-part which in turn contained one or
more text/plain parts, these text plain parts would be lost. This
would happen with PGP signed messages with text/plain attachments
because the unsigned message is multipart/mixed with text/plain
sub-parts and when it is signed the entire message is wrapped in a
multipart/signed outer part and an application/pgp-signature part
added.

This problem was fixed in Mailman 2.1.6 by the following change (note
the line numbers are from the latest trunk, not 2.1.5 or 2.1.6)

--- Scrubberx.py        2006-05-19 11:08:25.562500000 -0700
+++ Scrubber.py 2006-05-19 10:59:25.609375000 -0700
@@ -309,7 +309,10 @@
         # BAW: Martin's original patch suggested we might want to try
         # generalizing to utf-8, and that's probably a good idea
(eventually).
         text = []
-        for part in msg.get_payload():
+        for part in msg.walk():
+            # TK: bug-id 1099138 and multipart
+            if not part or part.is_multipart():
+                continue
             # All parts should be scrubbed to text/plain by now.
             partctype = part.get_content_type()
             if partctype <> 'text/plain':


-- 
Mark Sapiro <msapiro at value.net>       The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan