From nicolas at karageuzian.com Mon Dec 2 14:47:50 2013 From: nicolas at karageuzian.com (nicolas) Date: Mon, 02 Dec 2013 14:47:50 +0100 Subject: [Mailman-Developers] conf in runner differs from shell Message-ID: Hello, I'm wondering why the wonderful hyperkitty archiver is not archiving some standard messages.. I tested message injection and it work, problem may not come from archiver itself... in a mailman shell, i'm trying : (py27)mailman at mail:~$ mailman shell Welcome to the GNU Mailman shell >>> from mailman.config import config >>> for archiver in config.archivers: ... print archiver.name ... mail-archive prototype hyperkitty mhonarc >>> And that's nice, that reflects my conf, well.. But, adding a constructor to archive runner in order to verify in daemon mode (mailman start) class ArchiveRunner(Runner): """The archive runner.""" def __init__(self, slice=None, numslices=1): super(ArchiveRunner, self).__init__(slice, numslices) debug_log.info('start archive trace') for archiver in config.archivers: debug_log.info("loaded archiver : %s" % archiver.name) debug output gives : Dec 02 14:21:02 2013 (23189) start archive trace Dec 02 14:21:02 2013 (23189) loaded archiver : prototype Dec 02 14:21:02 2013 (23189) loaded archiver : mail-archive Dec 02 14:21:02 2013 (23189) loaded archiver : mhonarc and that explains why messages are archived with scripting but not while using smtp. I'm using latest lp:mailman (slightly patched lp:~nkarageuzian/mailman/hyperkitty_compliance ) How could we explain this behavior ? Regards From nicolas at karageuzian.com Mon Dec 2 15:42:44 2013 From: nicolas at karageuzian.com (nicolas) Date: Mon, 02 Dec 2013 15:42:44 +0100 Subject: [Mailman-Developers] Conf instance in runner different from instance in shell In-Reply-To: <69b0d6f81f5b8f189c7e562dda273ba3@mail.menestrel.net> References: <69b0d6f81f5b8f189c7e562dda273ba3@mail.menestrel.net> Message-ID: <4b75ef59972d916c8037e6b09778c891@mail.menestrel.net> Solved, setting up environment MAILMAN_CONFIG_FILE fixed that point Le 2013-12-02 15:15, nicolas a ?crit?: > Hello, > > I'm wondering why the wonderful hyperkitty archiver is not archiving > some standard messages.. > > I tested message injection and it work, problem may not come from > archiver itself... > > in a mailman shell, i'm trying : > > (py27)mailman at mail:~$ mailman shell > Welcome to the GNU Mailman shell > >>>> from mailman.config import config >>>> for archiver in config.archivers: > ... print archiver.name > ... > mail-archive > prototype > hyperkitty > mhonarc >>>> > > > And that's nice, that reflects my conf, well.. > > But, adding a constructor to archive runner in order to verify in > daemon mode (mailman start) > > class ArchiveRunner(Runner): > """The archive runner.""" > def __init__(self, slice=None, numslices=1): > super(ArchiveRunner, self).__init__(slice, numslices) > debug_log.info('start archive trace') > for archiver in config.archivers: > debug_log.info("loaded archiver : %s" % archiver.name) > > debug output gives : > > Dec 02 14:21:02 2013 (23189) start archive trace > Dec 02 14:21:02 2013 (23189) loaded archiver : prototype > Dec 02 14:21:02 2013 (23189) loaded archiver : mail-archive > Dec 02 14:21:02 2013 (23189) loaded archiver : mhonarc > > and that explains why messages are archived with scripting but not > while using smtp. > > I'm using latest lp:mailman (slightly patched > lp:~nkarageuzian/mailman/hyperkitty_compliance ) > > How could we explain this behavior ? > > Regards From barry at list.org Mon Dec 2 17:04:44 2013 From: barry at list.org (Barry Warsaw) Date: Mon, 2 Dec 2013 11:04:44 -0500 Subject: [Mailman-Developers] Conf instance in runner different from instance in shell In-Reply-To: <4b75ef59972d916c8037e6b09778c891@mail.menestrel.net> References: <69b0d6f81f5b8f189c7e562dda273ba3@mail.menestrel.net> <4b75ef59972d916c8037e6b09778c891@mail.menestrel.net> Message-ID: <20131202110444.711fc175@anarchist> On Dec 02, 2013, at 03:42 PM, nicolas wrote: >Solved, setting up environment MAILMAN_CONFIG_FILE fixed that point That will work, although it should *also* work to pass `-C ` to `mailman start`. A custom configuration file should get passed down to all the subprocess runners. -Barry From nicolas at karageuzian.com Tue Dec 3 12:09:42 2013 From: nicolas at karageuzian.com (nicolas) Date: Tue, 03 Dec 2013 12:09:42 +0100 Subject: [Mailman-Developers] Problem with runner logger with unicode Message-ID: Hi, I encountered a subtil problem when a component logs unicode strings (present case was the hyperkitty archiver) : (py27)mailman at mail:~$ Traceback (most recent call last): File "/home/mailman/mailman/src/mailman/core/logging.py", line 76, in emit msg = self.format(record) File "/usr/lib/python2.7/logging/__init__.py", line 723, in format return fmt.format(record) File "/usr/lib/python2.7/logging/__init__.py", line 464, in format record.message = record.getMessage() File "/usr/lib/python2.7/logging/__init__.py", line 328, in getMessage msg = msg % self.args UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 21: ordinal not in range(128) Logged from file runner.py, line 261 Traceback (most recent call last): File "/home/mailman/mailman/src/mailman/core/logging.py", line 76, in emit msg = self.format(record) File "/usr/lib/python2.7/logging/__init__.py", line 723, in format return fmt.format(record) File "/usr/lib/python2.7/logging/__init__.py", line 464, in format record.message = record.getMessage() File "/usr/lib/python2.7/logging/__init__.py", line 328, in getMessage msg = msg % self.args UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 2982: ordinal not in range(128) Logged from file runner.py, line 264 then found how to fix it : === modified file 'src/mailman/core/runner.py' --- src/mailman/core/runner.py 2013-12-01 13:28:49 +0000 +++ src/mailman/core/runner.py 2013-12-03 10:47:56 +0000 @@ -258,10 +258,10 @@ self.switchboard.enqueue(msg, msgdata) def _log(self, exc): - elog.error('Uncaught runner exception: %s', exc) + elog.error(b'Uncaught runner exception: %s', exc) s = StringIO() traceback.print_exc(file=s) - elog.error('%s', s.getvalue()) + elog.error(b'%s', s.getvalue()) def _clean_up(self): """See `IRunner`.""" unless it can be considered as a problem in the component itself... But (personal thought) mailman's stability may not depend of third party components... I can propose a merge for it if it's revelant (just have to go deeper into lp/bzr) Cheers Nico From nicolas at karageuzian.com Tue Dec 3 12:43:46 2013 From: nicolas at karageuzian.com (nicolas) Date: Tue, 03 Dec 2013 12:43:46 +0100 Subject: [Mailman-Developers] Problem with runner logger with unicode In-Reply-To: References: Message-ID: Basicaly it was not hyperkitty archiver, but mailman itself (or in fact Storm localized error message strings), cause here is the output : Dec 03 12:37:49 2013 (23760) ACCEPT: Dec 03 12:37:50 2013 (23762) conf loaded Dec 03 12:37:50 2013 (23762) Uncaught runner exception: ERREUR: la relation \xc2\xab listarchiver \xc2\xbb n\'existe pas\nLINE 1: ...tarchiver.mailing_list_id, listarchiver.name FROM listarchiv...\n ^\nDec 03 12:37:50 2013 (23762) Traceback (most recent call last):\n File "/home/mailman/mailman/src/mailman/core/runner.py", line 169, in _one_iteration\n self._process_one_file(msg, msgdata)\n File "/home/mailman/mailman/src/mailman/core/runner.py", line 252, in _process_one_file\n keepqueued = self._dispose(mlist, msg, msgdata)\n File "/home/mailman/mailman/src/mailman/runners/pipeline.py", line 36, in _dispose\n process(mlist, msg, msgdata, pipeline)\n File "/home/mailman/mailman/src/mailman/core/pipelines.py", line 66, in process\n handler.process(mlist, msg, msgdata)\n File "/home/mailman/mailman/src/mailman/handlers/rfc_2369.py", line 120, in process\n process(mlist, msg, msgdata)\n File "/home/mailman/mailman/src/mailman/handlers/rfc_2369.py", line 87, in process\n archiver_set = IListArchiverSet(mlist)\n File "/home/mailman/py27/local/lib/python2.7/site-packages/zope.component-4.1.0-py2.7.egg/zope/component/hookable.py", line 33, in __call__\n return self.__implementation(*args, **kw)\n File "/home/mailman/py27/local/lib/python2.7/site-packages/zope.component-4.1.0-py2.7.egg/zope/component/_api.py", line 156, in adapter_hook\n return sitemanager.queryAdapter(object, interface, name, default)\n File "/home/mailman/py27/local/lib/python2.7/site-packages/zope.interface-4.0.5-py2.7-linux-x86_64.egg/zope/interface/registry.py", line 229, in queryAdapter\n return self.adapters.queryAdapter(object, interface, name, default)\n File "/home/mailman/mailman/src/mailman/model/mailinglist.py", line 590, in __init__\n ListArchiver.name == archiver_name)).one()\n File "/home/mailman/py27/local/lib/python2.7/site-packages/storm-0.20-py2.7-linux-x86_64.egg/storm/store.py", line 1158, in one\n result = self._store._connection.execute(select)\n File "/home/mailman/py27/local/lib/python2.7/site-packages/storm-0.20-py2.7-linux-x86_64.egg/storm/databases/postgres.py", line 266, in execute\n return Connection.execute(self, statement, params, noresult)\n File "/home/mailman/py27/local/lib/python2.7/site-packages/storm-0.20-py2.7-linux-x86_64.egg/storm/database.py", line 241, in execute\n raw_cursor = self.raw_execute(statement, params)\n File "/home/mailman/py27/local/lib/python2.7/site-packages/storm-0.20-py2.7-linux-x86_64.egg/storm/databases/postgres.py", line 276, in raw_execute\n return Connection.raw_execute(self, statement, params)\n File "/home/mailman/py27/local/lib/python2.7/site-packages/storm-0.20-py2.7-linux-x86_64.egg/storm/database.py", line 374, in raw_execute\n self._run_execution(raw_cursor, args, params, statement)\n File "/home/mailman/py27/local/lib/python2.7/site-packages/storm-0.20-py2.7-linux-x86_64.egg/storm/database.py", line 388, in _run_execution\n self._check_disconnect(raw_cursor.execute, *args)\n File "/home/mailman/py27/local/lib/python2.7/site-packages/storm-0.20-py2.7-linux-x86_64.egg/storm/database.py", line 454, in _check_disconnect\n return function(*args, **kwargs)\nProgrammingError: ERREUR: la relation \xc2\xab listarchiver \xc2\xbb n\'existe pas\nLINE 1: ...tarchiver.mailing_list_id, listarchiver.name FROM listarchiv...\n ^\n\nDec 03 12:37:50 2013 (23762) SHUNTING: 1386070670.221361+6120e5d3eaedee1815abe8fc6bf7dd306961f1dd and the real problem origin is missing schema upgrades for postgres Cheers Le 2013-12-03 12:09, nicolas a ?crit?: > Hi, > > I encountered a subtil problem when a component logs unicode strings > (present case was the hyperkitty archiver) : > > (py27)mailman at mail:~$ Traceback (most recent call last): > File "/home/mailman/mailman/src/mailman/core/logging.py", line 76, > in emit > msg = self.format(record) > File "/usr/lib/python2.7/logging/__init__.py", line 723, in format > return fmt.format(record) > File "/usr/lib/python2.7/logging/__init__.py", line 464, in format > record.message = record.getMessage() > File "/usr/lib/python2.7/logging/__init__.py", line 328, in > getMessage > msg = msg % self.args > UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position > 21: ordinal not in range(128) > Logged from file runner.py, line 261 > Traceback (most recent call last): > File "/home/mailman/mailman/src/mailman/core/logging.py", line 76, > in emit > msg = self.format(record) > File "/usr/lib/python2.7/logging/__init__.py", line 723, in format > return fmt.format(record) > File "/usr/lib/python2.7/logging/__init__.py", line 464, in format > record.message = record.getMessage() > File "/usr/lib/python2.7/logging/__init__.py", line 328, in > getMessage > msg = msg % self.args > UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position > 2982: ordinal not in range(128) > Logged from file runner.py, line 264 > > then found how to fix it : > > === modified file 'src/mailman/core/runner.py' > --- src/mailman/core/runner.py 2013-12-01 13:28:49 +0000 > +++ src/mailman/core/runner.py 2013-12-03 10:47:56 +0000 > @@ -258,10 +258,10 @@ > self.switchboard.enqueue(msg, msgdata) > > def _log(self, exc): > - elog.error('Uncaught runner exception: %s', exc) > + elog.error(b'Uncaught runner exception: %s', exc) > s = StringIO() > traceback.print_exc(file=s) > - elog.error('%s', s.getvalue()) > + elog.error(b'%s', s.getvalue()) > > def _clean_up(self): > """See `IRunner`.""" > > unless it can be considered as a problem in the component itself... > But (personal thought) mailman's stability may not depend of third > party components... > > I can propose a merge for it if it's revelant (just have to go deeper > into lp/bzr) > > Cheers > > Nico > > _______________________________________________ > Mailman-Developers mailing list > Mailman-Developers at python.org > https://mail.python.org/mailman/listinfo/mailman-developers > Mailman FAQ: http://wiki.list.org/x/AgA3 > Searchable Archives: > http://www.mail-archive.com/mailman-developers%40python.org/ > Unsubscribe: > > https://mail.python.org/mailman/options/mailman-developers/nicolas%40karageuzian.com > > Security Policy: http://wiki.list.org/x/QIA9 From aurelien at bompard.org Tue Dec 3 13:56:18 2013 From: aurelien at bompard.org (Aurelien Bompard) Date: Tue, 3 Dec 2013 13:56:18 +0100 Subject: [Mailman-Developers] Problem with runner logger with unicode In-Reply-To: References: Message-ID: So, if I understand correctly, Storm add to its exception the error message it gets from PostgreSQL, which is a bytestream (encoded in UTF-8 on your system). But Mailman sends its logs to the logger as unicode, thus the exception must be converted to unicode, and that's where the UnicodeDecodeError is raised. What can we do? Should we try to decode the Storm exception using the default system encoding before sending it to the logger? Aur?lien From barry at list.org Thu Dec 5 17:47:50 2013 From: barry at list.org (Barry Warsaw) Date: Thu, 5 Dec 2013 11:47:50 -0500 Subject: [Mailman-Developers] Pecan Message-ID: <20131205114750.7022107d@anarchist> Does anybody here have experience with Pecan? http://pecanpy.org/index.html -Barry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From smati.beghoura at gmail.com Sat Dec 7 15:02:29 2013 From: smati.beghoura at gmail.com (Smati Beghoura) Date: Sat, 7 Dec 2013 10:02:29 -0400 Subject: [Mailman-Developers] probleme install Message-ID: <52a32a74.2aceb40a.0266.ffffdd92@mx.google.com> Hello, I'm French. The following text was translated with Google Translate. Allow me to contact you because I have a problem in the configuration mailman / postfix. I have a new server. Config: I am under release3 CentOS 6.4 + webmin. I asked a technician to deal with the migration of my sites from the old server to it, but unfortunately, even if the sites work now, he somewhat "broken" the distrib. So that I had no mailman. So I decided to remove and reinstall mailman. Mailman now works with a list (mailman default) + newsletter. Postfix on, if I send myself an email through Outlook postmaster at hellovoyance.com reserved area on postfix) I get well email. However, if I send an email to the list (newsletter at hellovoyance.com) Outlook me a mail with return "user unknown". The detail of this is as follows: Reporting-MTA: dns; ns2275743.ovh.net X-Postfix-Queue-ID: 5521962ED9 X-Postfix-Sender: rfc822; postmaster at hellovoyance.com Arrival-Date: Fri, 29 Nov 2013 11:58:54 +0100 (CET) Final-Recipient: rfc822; newsletter at hellovoyance.com Original-Recipient: rfc822;newsletter at hellovoyance.com Action: failed Status: 5.1.1 Diagnostic-Code: x-unix; user unknow I would like your opinion, because I admit that I am lost. I am novice but trying to do it myself with the means that are given to me. Thanking you in advance for your reply Regards SmatiBeghoura PS: if I must re-install, how to remove mailman properly and with precise installation documentation with my current setup? PPS: for information, there is also a database whose name is "mail". On this basis, there is the following tables: "admin", "alias", "alias_domain", "config", "domain, "domain_admins", "fetchmail", "log", "mailbox", "mailing", "quota", "quota2", "vacation" " vacation_notification" From mark at msapiro.net Sat Dec 7 17:10:33 2013 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 07 Dec 2013 08:10:33 -0800 Subject: [Mailman-Developers] probleme install In-Reply-To: <52a32a74.2aceb40a.0266.ffffdd92@mx.google.com> References: <52a32a74.2aceb40a.0266.ffffdd92@mx.google.com> Message-ID: <52A34879.6070208@msapiro.net> On 12/07/2013 06:02 AM, Smati Beghoura wrote: > Mailman now works with a list (mailman default) + > newsletter. Postfix on, if I send myself an email through Outlook > postmaster at hellovoyance.com reserved area on postfix) I get well email. > However, if I send an email to the list (newsletter at hellovoyance.com) > Outlook me a mail with return "user unknown". See Note that mailman-users at python.org is probably a more appropriate place for this and similar discussions. -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan From nicolas at karageuzian.com Wed Dec 11 18:43:03 2013 From: nicolas at karageuzian.com (nicolas) Date: Wed, 11 Dec 2013 18:43:03 +0100 Subject: [Mailman-Developers] mailman3 API and workflow Message-ID: <5a2a9b48bfe53185161d79c14809242a@mail.menestrel.net> Hello, I have the following use case : an unregistered user sends a mail to list, accepted by moderators, then i see it's adress inserted in the address table but no entry is created in the user table. when using mailman client to 'get' the user's profile using email as key, it answers 404 user not found, and when i'm trying create_user routine, I have : HTTPError: HTTP Error 400: Address already exists: It's either a bug at recieve/accept which should not insert or some bug in api for creating user or maybe i'm wrong using the API, or missing some doc, somewhere... would appreciate help (or fix directives) Regards From fclists at pr-z.info Fri Dec 13 14:06:26 2013 From: fclists at pr-z.info (fc lists) Date: Fri, 13 Dec 2013 13:06:26 +0000 Subject: [Mailman-Developers] Possible bug in marilman arch when doing incremental archiving Message-ID: Hi, I think i encountered a bug for mailman *arch* process when doing incremental archiving out of band from mbox file. I am running mailman-2.1.9 (working on upgrading to 2.1.17 ... but if i got this right it is still present in that version) For various reasons i need to run my Archiving out of band from the normal mailman pipeline. So i set mailman to only archive to MBOX file and then i regularly run the *arch* command using "-s" and "-e" option to define my incremental The issue i have been having is that at every single time the *arch *command is called after the first "wipe" then i get a duplicate of every single attachment file that was previously created from messages already archived. I followed up into the code and i think i found the issue, but i wanted to confirm here that i did not miss anything else or just got on the wrong road. (i am not a developer whatsoever) in lib/mailman/Mailman/Mailbox.py (line 79 and following on my code) an *archfactory* is defined for the MBOX file that will be opened. *def _archfactory(mailbox): * which return the scrubber which extract the attachment from the email. the factory is called on the message extracted every time the *next()*method is called on the mbox object in lib/mailman/Mailman/pipermail.py where the actual logic of arch -s X -e X is defined the code look like (line 555 on my code): def processUnixMailbox(self, input, start=None, end=None): mbox = ArchiverMailbox(input, self.maillist) if start is None: start = 0 counter = 0 while counter < start: try: * m = mbox.next()* except Errors.DiscardMessage: continue if m is None: return counter += 1 When the start is higher then counter, to iterate over the mailbox and get to the starting point requested, the *next()* method on the mbox object is called which trigger the archfactory which extract the attachment from messages that were already archived causing the duplicate attachment to happen. My "test fix" is basically to set the factory for the mbox object to the default rfc822.Message while iterating over the mbox object until the start is reached , then i set the factory back to the _archfactory ... and everything seems to work as expected. Again, i am no developer and i wanted to double check this here before i go on and put this live on my systems. Thanks Francesco Ciocchetti From mark at msapiro.net Fri Dec 13 23:57:19 2013 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 13 Dec 2013 14:57:19 -0800 Subject: [Mailman-Developers] Possible bug in marilman arch when doing incremental archiving In-Reply-To: References: Message-ID: <52AB90CF.3050006@msapiro.net> On 12/13/2013 05:06 AM, fc lists wrote: > > When the start is higher then counter, to iterate over the mailbox and get > to the starting point requested, the *next()* method on the mbox object is > called which trigger the archfactory which extract the attachment from > messages that were already archived causing the duplicate attachment to > happen. > > My "test fix" is basically to set the factory for the mbox object to the > default rfc822.Message while iterating over the mbox object until the start > is reached , then i set the factory back to the _archfactory ... and > everything seems to work as expected. Thank you for the report. I have created for this issue. I think your fix is OK, but I am inclined to set the factory while skipping to the start to Mailman.Mailbox._safeparser rather than the default just in case one of the skipped messages throws MessageParseError. -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan From mark at msapiro.net Sat Dec 14 02:09:22 2013 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 13 Dec 2013 17:09:22 -0800 Subject: [Mailman-Developers] Possible bug in marilman arch when doing incremental archiving In-Reply-To: <52AB90CF.3050006@msapiro.net> References: <52AB90CF.3050006@msapiro.net> Message-ID: <52ABAFC2.8080104@msapiro.net> On 12/13/2013 02:57 PM, Mark Sapiro wrote: > > Thank you for the report. I have created > for this issue. > > I think your fix is OK, but I am inclined to set the factory while > skipping to the start to Mailman.Mailbox._safeparser rather than the > default just in case one of the skipped messages throws MessageParseError. I have committed a fix. I fixed this in a way that is probably different from what you did because I didn't want to import private Mailman.Mailbox functions into Mailman/Archiver/pipermail.py. See for my fix. -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan From fclists at pr-z.info Wed Dec 18 10:34:58 2013 From: fclists at pr-z.info (fc lists) Date: Wed, 18 Dec 2013 09:34:58 +0000 Subject: [Mailman-Developers] Possible bug in marilman arch when doing incremental archiving In-Reply-To: <52ABAFC2.8080104@msapiro.net> References: <52AB90CF.3050006@msapiro.net> <52ABAFC2.8080104@msapiro.net> Message-ID: Thanks a lot for this :) I will take a look at your fix and most likely import that in my mailman package ... other then anything, i would prefer to have something mantained upstream so i don't have to patch my package every time i upgrade. On Sat, Dec 14, 2013 at 1:09 AM, Mark Sapiro wrote: > On 12/13/2013 02:57 PM, Mark Sapiro wrote: > > > > Thank you for the report. I have created > > for this issue. > > > > I think your fix is OK, but I am inclined to set the factory while > > skipping to the start to Mailman.Mailbox._safeparser rather than the > > default just in case one of the skipped messages throws > MessageParseError. > > > I have committed a fix. I fixed this in a way that is probably different > from what you did because I didn't want to import private > Mailman.Mailbox functions into Mailman/Archiver/pipermail.py. > > See > > for my fix. > > -- > Mark Sapiro The highway is for gamblers, > San Francisco Bay Area, California better use your sense - B. Dylan > _______________________________________________ > Mailman-Developers mailing list > Mailman-Developers at python.org > https://mail.python.org/mailman/listinfo/mailman-developers > Mailman FAQ: http://wiki.list.org/x/AgA3 > Searchable Archives: > http://www.mail-archive.com/mailman-developers%40python.org/ > Unsubscribe: > https://mail.python.org/mailman/options/mailman-developers/fclists%40pr-z.info > > Security Policy: http://wiki.list.org/x/QIA9 > From willey at washington.edu Thu Dec 19 21:07:56 2013 From: willey at washington.edu (Stephen Willey Mats Mats) Date: Thu, 19 Dec 2013 12:07:56 -0800 Subject: [Mailman-Developers] bug in tests/test_handlers.py Message-ID: <23D15F97-F505-4F38-84C0-5F99DB34C0E9@washington.edu> with http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1376 ? Setting digest_size_threshhold to zero now means no digests will be sent based on size instead of a digest being sent with every post. ? tests/test_handlers.py sets digest_size_threshhold to 0. I assume this is an attempt to force the digest send. But now 0 means ?no digest?. Below is my proposed patch to trick ToDigest into sending. steve --- /usr/local/mailman/tests/test_handlers.py.old 2013-12-19 11:57:09.745503688 -0800 +++ /usr/local/mailman/tests/test_handlers.py 2013-12-19 11:26:18.325853268 -0800 @@ -1880,7 +1880,7 @@ Here is message %(i)d msg = self._makemsg(99) print msg size = os.path.getsize(self._path) + len(str(msg)) - mlist.digest_size_threshhold = 0 + mlist.digest_size_threshhold = .001 ToDigest.process(mlist, msg, {}) files = self._sb.files() # There should be two files in the queue, one for the MIME digest and From mark at msapiro.net Fri Dec 20 03:44:24 2013 From: mark at msapiro.net (Mark Sapiro) Date: Thu, 19 Dec 2013 18:44:24 -0800 Subject: [Mailman-Developers] bug in tests/test_handlers.py In-Reply-To: <23D15F97-F505-4F38-84C0-5F99DB34C0E9@washington.edu> References: <23D15F97-F505-4F38-84C0-5F99DB34C0E9@washington.edu> Message-ID: <52B3AF08.9070803@msapiro.net> On 12/19/2013 12:07 PM, Stephen Willey Mats Mats wrote: > > tests/test_handlers.py sets digest_size_threshhold to 0. I assume this is an attempt to force the digest send. But now 0 means ?no digest?. Below is my proposed patch to trick ToDigest into sending. Thanks for the report and patch. This and two other failures have been fixed. See and . -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan