[Mailman-Developers] bounce info not updating in MM 2.1.11rc1 + patch

[Barry Warsaw]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Jun 16, 2008, at 4:01 AM, Fil wrote:

> (always with MysqlMemberships.py)
> I noticed that my bounce info stays in the database at level 1, even
> when the logs say "current bounce score: 2.0"
>
> In Mailman/Bouncer.py I think that two self.setBounceInfo(member,
> info) are missing:
>
> --- Mailman/Bouncer.save.py     2008-06-16 10:00:17.000000000 +0200
> +++ Mailman/Bouncer.py  2008-06-16 10:00:43.000000000 +0200
> @@ -137,6 +137,7 @@ class Bouncer:
>             if lastbounce + self.bounce_info_stale_after < now:
>                 # Information is stale, so simply reset it
>                 info.reset(weight, day,  
> self.bounce_you_are_disabled_warnings)
> +                self.setBounceInfo(member, info)
>                 syslog('bounce', '%s: %s has stale bounce info,  
> resetting',
>                        self.internal_name(), member)
>             else:
> @@ -144,6 +145,7 @@ class Bouncer:
>                 # score and take any necessary action.
>                 info.score += weight
>                 info.date = day
> +                self.setBounceInfo(member, info)
>                 syslog('bounce', '%s: %s current bounce score: %s',
>                        self.internal_name(), member, info.score)
>             # Continue to the check phase below

This makes some sense.  I don't know anything about the  
MysqlMembership.py adapter, but unlike the pickle-based standard  
adapter, it probably needs this call to mark the object as modified so  
that it will be stored in the db on the next save.  The standard  
adapter doesn't need this, because it's just going to pickle whatever  
the current state is.

The patch is a bit icky, but probably useful and I don't think it can  
hurt the standard adapter.

- -Barry

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)

iEYEARECAAYFAkhXsmwACgkQ2YZpQepbvXE9RQCgnOJ4F5NEfXDA9oPoxhXMK+U5
7uUAnREdrThi0xFV3uFCx27PoiBv6Bvt
=w2D7
-----END PGP SIGNATURE-----