[Mailman-Developers] [Mailman-checkins] [Branch ~mailman-coders/mailman/3.0]

[Mark Sapiro]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Barry Warsaw wrote:
> On Nov 6, 2007, at 9:07 PM, noreply at launchpad.net wrote:
> 
>> ------------------------------------------------------------
>> revno: 6573
>> committer: Mark Sapiro <msapiro at value.net>
<snip>
>>          # If the message isn't a multipart, then we'll strip it  
>> out as an
>>          # attachment that would have to be separately downloaded.   
>> Pipermail
>>          # will transform the url into a hyperlink.
>> -        elif part and not part.is_multipart():
>> +        elif part._payload and not part.is_multipart():
> 
> I'm not sure it's a good idea to use this non-public attribute.   
> 'part.get_payload()' would probably be a better test.


I think Barry is right, but I did it as I did because of a concern
expressed by Tokio at
<http://mail.python.org/pipermail/mailman-users/2006-December/054961.html>.

I'll gladly change it to get_payload()

- --
Mark Sapiro <msapiro at value.net>       The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)

iD8DBQFHQIStVVuXXpU7hpMRAlVhAJ9M5OX2iT3Blt5QzQ2UPBuRY+1XUACg4rHg
MZywGERykk1M7brgkGDtUcA=
=bXYJ
-----END PGP SIGNATURE-----