From msapiro at value.net Fri Jun 1 00:44:40 2007 From: msapiro at value.net (Mark Sapiro) Date: Thu, 31 May 2007 15:44:40 -0700 Subject: [Mailman-Developers] Interacting with mailman remotely throughAPIs / wrappers In-Reply-To: <112606.50855.qm@web35615.mail.mud.yahoo.com> Message-ID: Ben Sims wrote: > >I had been hoping to avoid command line calls. However, I'm probably just putting unnecessary obstacles up, so unless anybody advises against it I'm going to use subprocess to call the scripts I have to and leave it at that. I'm not sure what John was actually trying to say, but what I would have said at the time had I not been away is that it is certainly possible to create a list using the Mailman/* modules, and see the code in bin/newlist to see how it's done. -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan From jdennis at redhat.com Fri Jun 1 06:17:48 2007 From: jdennis at redhat.com (John Dennis) Date: Fri, 01 Jun 2007 00:17:48 -0400 Subject: [Mailman-Developers] Interacting with mailman remotely throughAPIs / wrappers In-Reply-To: References: Message-ID: <1180671469.19847.3.camel@junko.usersys.redhat.com> On Thu, 2007-05-31 at 15:44 -0700, Mark Sapiro wrote: > Ben Sims wrote: > > > >I had been hoping to avoid command line calls. However, I'm probably just putting unnecessary obstacles up, so unless anybody advises against it I'm going to use subprocess to call the scripts I have to and leave it at that. > > > I'm not sure what John was actually trying to say, but what I would > have said at the time had I not been away is that it is certainly > possible to create a list using the Mailman/* modules, and see the > code in bin/newlist to see how it's done. Yes, that's what I meant, it's a good example of how to use the mailman API directly. -- John Dennis From fermat at rigel.deusto.es Mon Jun 4 04:27:07 2007 From: fermat at rigel.deusto.es (Alvaro =?utf-8?B?VXLDrWE=?=) Date: Mon, 4 Jun 2007 04:27:07 +0200 Subject: [Mailman-Developers] More help on the WebUI templating issue Message-ID: <20070604022707.GF10602@mogli> Hi all! This is my first mail to the list so, let me greet all of you and just say that I've been reading over here for quite a while now. BTW, with pretty interesting threads. I've been administering GNU Mailman since 2003 and a few months ago started to dig into its design, in the aim of helping you, first with the WebUI templating, and with the idea of continuing in a future with other parts of Mailman. As a way of helping me to understand Mailman, I've created a few UML class diagrams based on MM2.1 (which I hope to improve), http://csl-mmwebui.forja.rediris.es/uml/uml.html ...and I've generated the API with epydoc, http://csl-mmwebui.forja.rediris.es/mailman-api/ In reference to the templating engine, I know you're thinking to use Kid or Genshi... but I've started another approach with Cheetah (http://www.cheetahtemplate.org/), which uses text-based templates. Here you have a very simple test of how Cgi scripts could be rewritten for the creation of web content, http://csl-mmwebui.forja.rediris.es/auria-test.tgz In this .tgz you have: 2 scripts: * Test.py (the one to be run) * TemplateController.py (the one that deals with Cheetah and the templating files, and called by the Cgi scripts) 2 templates: * if 'example.tpl' does not exist, 'error.tpl' is read (if not, a string is returned). BTW, I just wanted to clarify that I understand that only a templating engine will be used for the whole project, but I wanted to give a try to Cheetah and see if it matches in a better way all Mailman needs (including email templates and archives, and making easier to integrate the pages on "corporated sites", allowing to change pageheaders and pagefoots). I didn't say anything before on the list because I haven't been working constantly on this, and because I don't like very much to talk with no other purpose than talking (you know, "talk is cheap...", etc. :-)). Comming back to the WebUI, maybe the most important thing is that most of the i18n that is currently working should also work on any new design. In that sense, I've thought to migrate all to Unicode format (UTF-8) and to join all HTML templates per language in a common one, and instead of having contents like: """ Username: Password: """ ...we could have, """ $label_foo $label_bar """ So, the thing would be to include all this i18n (labels, etc.) to the .po files. For ".txt" files, nothing would change. In summary, only would change "templates//*.html", joining them in a common dir like "templates/common//*.html". (Between those "themes", or styles, there could be ones using "" tags and others with "
" and using only CSS for the draw...) So, as you can see, all CSS issues would be similar (if not the same) with what you're working right now, what it reduces (or joins) efforts :-) And last (sorry to bother you O:-)), I've started to use bazaar a week ago and I hope to push my work on this on launchpad. What I don't know is if I should create a branch and create subdirectories for different parts in there, or create those subdirectories as branches... :? Thank you very much for reading till here, and hope to help you :-)) Best regards, -- ,____________, .' '. /~~~~^~~~^~^~~~\ / _ /|| \ Alvaro Ur?a (0x3AD91E72) ; ( } \||D ; | | /\__,=[_] | ; ( |_\_ |---| ; It might look like I'm doing nothing, but \ )| |/ | | / at the cellular level I'm really quite busy. '. | /_ | |.' '------------' -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://mail.python.org/pipermail/mailman-developers/attachments/20070604/1c6b462a/attachment.pgp From tufail_fifa at hotmail.com Wed Jun 6 15:20:03 2007 From: tufail_fifa at hotmail.com (tufail muhammad) Date: Wed, 06 Jun 2007 13:20:03 +0000 Subject: [Mailman-Developers] missing the file ACEXML In-Reply-To: Message-ID: dear while isntallation of opendiameter 1.0.7-i the one error come i.e /usr/bin/ld: cannot find -lACEXML this error is not /usr/bin/ld: cannot find -lACE_SSL different error what i should do for installation. thanks _________________________________________________________________ Don?t miss your chance to WIN $10,000 and other great prizes from Microsoft Office Live http://clk.atdmt.com/MRT/go/aub0540003042mrt/direct/01/ From Andreas_Kahl at gmx.net Wed Jun 6 15:31:48 2007 From: Andreas_Kahl at gmx.net (Andreas Kahl) Date: Wed, 06 Jun 2007 15:31:48 +0200 Subject: [Mailman-Developers] Where to insert additional Attachment-filters in the code? Message-ID: <4666B744.6090401@gmx.net> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello everybody, I have installed Mailman on a Debian for my club for organisational discussions. Some Members don't like attachments, some do. One solution could be a filter copying attachments to a location on my Webserver and sending a link + password over the list. Another could be a filter for several members where they can adjust personally to receive attachments or not. I am not familiar with your code, could you tell me in which .py-File the size of attachments is checked. Do you have any further recommendations to me when trying to implement such a module? Are there already similar modules? Thanks for your help. Andreas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFGZrdEq60kmgwCDSARAm6TAKDp3BjuAHnF4Z6yraeR7D9rsVCzlwCg9ln+ 9/sYoOlQNsLwwAtxPLJg4B4= =d4db -----END PGP SIGNATURE----- From msapiro at value.net Thu Jun 7 04:03:46 2007 From: msapiro at value.net (Mark Sapiro) Date: Wed, 6 Jun 2007 19:03:46 -0700 Subject: [Mailman-Developers] Where to insert additional Attachment-filtersin the code? In-Reply-To: <4666B744.6090401@gmx.net> Message-ID: Andreas Kahl wrote: > >I have installed Mailman on a Debian for my club for organisational >discussions. Some Members don't like attachments, some do. > >One solution could be a filter copying attachments to a location on my >Webserver and sending a link + password over the list. >Another could be a filter for several members where they can adjust >personally to receive attachments or not. > >I am not familiar with your code, could you tell me in which .py-File >the size of attachments is checked. The size of attachments is not checked. The size of the entire message is checked in Mailman/Handlers/Hold.py. >Do you have any further >recommendations to me when trying to implement such a module? Are >there already similar modules? Mailman/Handlers/MimeDel.py is the handler that processes the Content filtering options. You could expand the user's options to include a flag for whether or not to apply content filtering for this user, but implementing this would be tricky in the current Mailman architecture as it would require the list to effectively be personalized and then the content filtering to be applied for each recipient at delivery time instead of generally in the pipeline of incoming handlers. You could just set Non-digest options->scrub_nondigest to Yes which will cause all non-plain text attachments to be removed and replaced by links. I the list's archive is private, the user's will need their list password to access these attachments. It seems this might do what you want with no code changes at all. -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan From barry at python.org Thu Jun 7 16:42:40 2007 From: barry at python.org (Barry Warsaw) Date: Thu, 7 Jun 2007 10:42:40 -0400 Subject: [Mailman-Developers] [Mailman-i18n] Mistake in Brazilian Portuguese Translation In-Reply-To: References: <1174412637.19775.6.camel@mare> Message-ID: <09F5BBA9-4782-4F75-95E2-7D24AABF3A85@python.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Jun 7, 2007, at 9:59 AM, Clytie Siddall wrote: > (Barry, is the Jira tracker ready for use yet?) Sadly, I haven't had time to do the migration, and I haven't been able to rustle up any volunteers to help. Maybe I should just give up and start fresh in Jira. We'll have to live with two trackers for a while, but maybe it will be easier to ask folks to migrate individual relevant bugs rather than do the entire tracker in one shot. I'm open to thoughts on how we can move to Jira sooner. This may make even more sense when I announce my roadmap plans (hopefully this week). Cheers, - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQCVAwUBRmgZYXEjvBPtnXfVAQLzzAQAhgt/dV22QQ+DTkC6RvjrawN3XDBG7Pk9 z+9nB5rNWD4u8h+FhrDQRhZsQ82W5aw5Oneguqig/N0HC4PzQRYs5MAAoBwZSrCS RZhR5rDXEgBpVlPN2wVAisIjG40yQNhCXC+1+YmWgnWhqigmY+S9Ui6Qqnf2w8cZ Evpp6xsnhc8= =xyrD -----END PGP SIGNATURE----- From barry at python.org Fri Jun 15 22:27:10 2007 From: barry at python.org (Barry Warsaw) Date: Fri, 15 Jun 2007 16:27:10 -0400 Subject: [Mailman-Developers] Bazaar branches Message-ID: <76DAC373-93DC-48CE-BC71-C0A095A995D1@python.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi folks, I've started a page that we should use to collect 'interesting' bazaar branches of the Mailman source code. There will be two sections, one for the official branches and one for unofficial branches: http://wiki.list.org/display/DEV/MailmanBranches Right now it lists the branches being sync'd automatically to upstream svn, and a branch I've been working on to improve the Elixir data model. This latter will get merged to the 3.0 branch on Flag Day, when the official branches will move to being owned by the mailman-coders team. Still, what's described should be enough for you to start getting a feel for what it will be like to work with the Bazaar branches. I'm pretty sure that any branches you make now will be easily merged with the official branches after Flag Day. Enjoy, and feel free to ask questions! - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQCVAwUBRnL2HnEjvBPtnXfVAQL0jQP/Ux7pa0vzm2BzfftOK23k7aOdp1qpoSDe 77SiLyS9QI07cZQwwKd7H7VQR9xmS/GdBAZIoo5Vq6sOD7dvsdBJQCjb1RXwkZrG rZ738R4M0wLRxgw0gL/+KpC9C1tCU1+HWwItGF7hV8gV/ufJ8v0Mdyu3g+wF2trB IXuzUaxTrWQ= =NoiY -----END PGP SIGNATURE----- From msapiro at value.net Sat Jun 16 19:03:58 2007 From: msapiro at value.net (Mark Sapiro) Date: Sat, 16 Jun 2007 10:03:58 -0700 Subject: [Mailman-Developers] Scrubber changes for Trunk Message-ID: I have found a couple of Scrubber issues in 2.1.9 which I have patched on the Release_2_1-maint branch. These issues involved a message with a message/delivery-status part which parses into text/plain sub-parts with None payloads, and a message with an improperly RFC 2047 encoded filename which had a trailing null byte. In looking at how the Release_2_1-maint patches port to the Trunk, I've seen some other problems. I have developed the attached Scrubber.patch.txt patch for the Trunk which I think fixes the problems I saw in 2.1.9 and fixes the other problems I see. I would appreciate others, particularly Tokio, looking at this to see if it seems correct. -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: Scrubber.patch.txt Url: http://mail.python.org/pipermail/mailman-developers/attachments/20070616/dda98470/attachment.txt From barry at python.org Thu Jun 21 17:29:31 2007 From: barry at python.org (Barry Warsaw) Date: Thu, 21 Jun 2007 11:29:31 -0400 Subject: [Mailman-Developers] Reminder about bzr flag day Message-ID: <08ABC965-75AB-427E-9884-F473AB229128@python.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Just a reminder that I plan to switch the official Mailman branches to Bazaar hosted on Launchpad sometime tomorrow. I may start doing this as early as midnight my time (UTC-4). I'll send out a message when the deed is done. If you have commit privileges on the Subversion repository, you will need to apply for membership in the Mailman Coders team on Launchpad: https://launchpad.net/~mailman-coders These Mailman wiki pages contain more information: http://wiki.list.org/display/DEV/MailmanOnLaunchpad http://wiki.list.org/display/DEV/MailmanBranches The branch names will change once the conversion is complete. Notifications of diffs pushed to the official branches will continue to be sent to mailman-checkins. Expect to see a big merge on the trunk branch after the conversion is complete. :) Cheers, - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQCVAwUBRnqZW3EjvBPtnXfVAQJs9gQAn/aRSJ9lVWo4f9H/NtJ4+YJL4ubCNz63 5Pgr5FZpzRYZarTwLRtOm2hwUZgu8JAp0plq6Xc+jzLBWn8csc1l2B/pPbREocs7 a04YG/nhDe7E7XJvE7a01KoXfiUFRxpi6nkdYs3sGSz56kXE7F/SK0fhifSAu9u8 wRBH2IwXw1A= =LtQ8 -----END PGP SIGNATURE----- From barry at python.org Fri Jun 22 17:00:16 2007 From: barry at python.org (Barry Warsaw) Date: Fri, 22 Jun 2007 11:00:16 -0400 Subject: [Mailman-Developers] Reminder about bzr flag day In-Reply-To: <08ABC965-75AB-427E-9884-F473AB229128@python.org> References: <08ABC965-75AB-427E-9884-F473AB229128@python.org> Message-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Jun 21, 2007, at 11:29 AM, Barry Warsaw wrote: > Just a reminder that I plan to switch the official Mailman branches > to Bazaar hosted on Launchpad sometime tomorrow. I may start doing > this as early as midnight my time (UTC-4). I'll send out a message > when the deed is done. If you have commit privileges on the > Subversion repository, you will need to apply for membership in the > Mailman Coders team on Launchpad: > > https://launchpad.net/~mailman-coders > > These Mailman wiki pages contain more information: > > http://wiki.list.org/display/DEV/MailmanOnLaunchpad > http://wiki.list.org/display/DEV/MailmanBranches The deed is done; we are now on Bazaar. I've updated the branches page to point to the correct locations. Please give it a try (even if you can only do read-only branching) and let me know if anything is confusing or doesn't work. I haven't merged my Elixir branch yet, but that's coming soon. Enjoy, - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQCVAwUBRnvkAHEjvBPtnXfVAQLATQP/VrPS/0uqkIJ5SrvyGItH9JOh9nGM+XkE dwiIvU75wjE08WqUGY7WPIBTriI0STHda/ul7rk+U+DHMdukiqe+C+fU5v5vvC9F nxwxuUEbdzLEOebMhUAtGy5EiQLxdgU5dCXSxcbIxgOXOTCS28QPBhzCCZoKyXTq SbEGOhRDxus= =5xWF -----END PGP SIGNATURE----- From msapiro at value.net Fri Jun 22 17:07:51 2007 From: msapiro at value.net (Mark Sapiro) Date: Fri, 22 Jun 2007 08:07:51 -0700 Subject: [Mailman-Developers] [Mailman-checkins] [Branch ~mailman-coders/mailman/2.1] (no title) In-Reply-To: <20070622123706.23799.74289.launchpad@canonical@gandwana.ubuntu.com> Message-ID: noreply at launchpad.net wrote: >-- >(no title) >https://code.launchpad.net/~mailman-coders/mailman/2.1 > >You are receiving this branch notification because you are subscribed to it. >To unsubscribe from this branch go to https://code.launchpad.net/~mailman-coders/mailman/2.1/+subscription/mailman-checkins. Hmmm... If I go to and log in, I am told Sorry, you don't have permission to access this page. You are logged in as Mark Sapiro. It occurs to me that this message/URL is for mailman-checkins at python.org to unsubscribe from branch notifications, so the lack of permission for msapiro makes sense, but the original message leads to this confusion. Can these notices be sent out without this message? -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan From barry at python.org Fri Jun 22 17:20:41 2007 From: barry at python.org (Barry Warsaw) Date: Fri, 22 Jun 2007 11:20:41 -0400 Subject: [Mailman-Developers] [Mailman-checkins] [Branch ~mailman-coders/mailman/2.1] (no title) In-Reply-To: References: Message-ID: <45F8A3DB-30AA-44CE-943F-0C7E10B53740@python.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Jun 22, 2007, at 11:07 AM, Mark Sapiro wrote: > Hmmm... > > If I go to > +subscription/mailman-checkins> > and log in, I am told > > Sorry, you don't have permission to access this page. > > You are logged in as Mark Sapiro. > > It occurs to me that this message/URL is for > mailman-checkins at python.org to unsubscribe from branch notifications, > so the lack of permission for msapiro makes sense, but the original > message leads to this confusion. Can these notices be sent out without > this message? I think the answer currently is "no", but I will submit a bug report on this. (Maybe I'll even fix it :). - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQCVAwUBRnvoyXEjvBPtnXfVAQIuDgP/ROj5/rlgGm/c6CSA9uNOSUPB3jPEuc7S GguUc8VrXBtugBc657HGDLqmEdKJhMDMK0wZdhdm6OizjYH9UTp9JSaKBzY0aMDg nKDol/nBxdmdssr1tneWnHHiZQbNTctnnozJYo2WnYEVcJTqvt/FUEX/r705HvPn qcRMK7mMcuw= =YwnS -----END PGP SIGNATURE----- From frederik_vanderstraeten at yahoo.co.uk Fri Jun 22 18:58:59 2007 From: frederik_vanderstraeten at yahoo.co.uk (Frederik Vanderstraeten) Date: Fri, 22 Jun 2007 18:58:59 +0200 Subject: [Mailman-Developers] News -> mail should remove the mailing list tag Message-ID: <467BFFD3.1030409@yahoo.co.uk> Hi When synchronizing a mailing list and a newsgroup, if a tag is enabled for the mailing list, but disabled for the newsgroup, the tag gets added properly when copying the message to the mailing list. But it doesn't get removed when copying responses back to the newsgroup. For an example of the problem, see this screenshot: http://img.photobucket.com/albums/v35/Benoit/projectowners_snap.png I'd be willing to fix this myself, but I never looked at Mailman's code before, so could someone help me with the whole development process. I don't even know what branch I should make my patch on. Thanks Frederik Vanderstraeten From barry at python.org Sat Jun 23 16:12:52 2007 From: barry at python.org (Barry Warsaw) Date: Sat, 23 Jun 2007 10:12:52 -0400 Subject: [Mailman-Developers] News -> mail should remove the mailing list tag In-Reply-To: <467BFFD3.1030409@yahoo.co.uk> References: <467BFFD3.1030409@yahoo.co.uk> Message-ID: <2739A52F-124E-4F66-96EC-DBD925844A68@python.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Jun 22, 2007, at 12:58 PM, Frederik Vanderstraeten wrote: > When synchronizing a mailing list and a newsgroup, if a tag is enabled > for the mailing list, but disabled for the newsgroup, the tag gets > added > properly when copying the message to the mailing list. But it doesn't > get removed when copying responses back to the newsgroup. > For an example of the problem, see this screenshot: > http://img.photobucket.com/albums/v35/Benoit/projectowners_snap.png > I'd be willing to fix this myself, but I never looked at Mailman's > code > before, so could someone help me with the whole development process. I > don't even know what branch I should make my patch on. Frederik, By 'tag' do you mean the Subject prefix? It should probably be an option in the gateway to remove this tag on the way into the news server. - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQCVAwUBRn0qZHEjvBPtnXfVAQKFJAQAkHi0XomkiKci8KiON7VoUROsC4S1nlLi k8H/jFIp6ey9oBapP+G0phTdvXJ46HXKJm0teO2CROfzUUwor3Gl6onw/1fPv+LX 0ngTJubuO3Lx9eUqUoWwIpjVdtlQwWf7fqBlFMPSbT3Ik7YcbL/mOoqJzyPVimBV 3G0L3KqIhwI= =+UAI -----END PGP SIGNATURE----- From frederik_vanderstraeten at yahoo.co.uk Sat Jun 23 16:28:10 2007 From: frederik_vanderstraeten at yahoo.co.uk (Frederik Vanderstraeten) Date: Sat, 23 Jun 2007 16:28:10 +0200 Subject: [Mailman-Developers] News -> mail should remove the mailing list tag In-Reply-To: <2739A52F-124E-4F66-96EC-DBD925844A68@python.org> References: <467BFFD3.1030409@yahoo.co.uk> <2739A52F-124E-4F66-96EC-DBD925844A68@python.org> Message-ID: <467D2DFA.1090402@yahoo.co.uk> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Barry Warsaw schreef: > On Jun 22, 2007, at 12:58 PM, Frederik Vanderstraeten wrote: > >> When synchronizing a mailing list and a newsgroup, if a tag is enabled >> for the mailing list, but disabled for the newsgroup, the tag gets added >> properly when copying the message to the mailing list. But it doesn't >> get removed when copying responses back to the newsgroup. >> For an example of the problem, see this screenshot: >> http://img.photobucket.com/albums/v35/Benoit/projectowners_snap.png >> I'd be willing to fix this myself, but I never looked at Mailman's code >> before, so could someone help me with the whole development process. I >> don't even know what branch I should make my patch on. > > Frederik, > > By 'tag' do you mean the Subject prefix? > > It should probably be an option in the gateway to remove this tag on the > way into the news server. Hi, Yes, I mean the Subject prefix. There already is an option (if I'm correct) if you want to add it to newsgroup messages or not. I think if you don't want to add it, you probably want to remove it if it's there. Otherwise, the results are really inconsistent, with the tag not being there for the opening post (if it's posted via the newsgroup), not being there for any newsgroup replies, but it's there for mailing list replies, and all replies to those. - - Frederik Vanderstraeten -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (MingW32) Comment: GnuPT 2.6.2.1 by EQUIPMENTE.DE Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGfS35Kkfl8uMbsEERApjuAJ97ur18lvyBtRtM1mwsXjzKzYOvqgCffmGz sCQyUnd+evCV0yFqKZcfB9M= =zxbv -----END PGP SIGNATURE----- From msapiro at value.net Sat Jun 23 20:45:46 2007 From: msapiro at value.net (Mark Sapiro) Date: Sat, 23 Jun 2007 11:45:46 -0700 Subject: [Mailman-Developers] News -> mail should remove the mailinglist tag In-Reply-To: <2739A52F-124E-4F66-96EC-DBD925844A68@python.org> Message-ID: Barry Warsaw wrote: > >On Jun 22, 2007, at 12:58 PM, Frederik Vanderstraeten wrote: > >> When synchronizing a mailing list and a newsgroup, if a tag is enabled >> for the mailing list, but disabled for the newsgroup, the tag gets >> added >> properly when copying the message to the mailing list. But it doesn't >> get removed when copying responses back to the newsgroup. >> For an example of the problem, see this screenshot: >> http://img.photobucket.com/albums/v35/Benoit/projectowners_snap.png >> I'd be willing to fix this myself, but I never looked at Mailman's >> code >> before, so could someone help me with the whole development process. I >> don't even know what branch I should make my patch on. > >Frederik, > >By 'tag' do you mean the Subject prefix? > >It should probably be an option in the gateway to remove this tag on >the way into the news server. I think this option already exists. Frederik, Do you have the list's Mail<->News gateways news_prefix_subject_too option set to No? -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan From barry at python.org Thu Jun 28 20:14:48 2007 From: barry at python.org (Barry Warsaw) Date: Thu, 28 Jun 2007 14:14:48 -0400 Subject: [Mailman-Developers] [Mailman-checkins] [Branch ~mailman-coders/mailman/3.0] (no title) In-Reply-To: <20070628172707.24622.38018.launchpad@canonical@gandwana.ubuntu.com> References: <20070628172707.24622.38018.launchpad@canonical@gandwana.ubuntu.com> Message-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Mark, thanks for fixing this. Just a couple of quick comments... On Jun 28, 2007, at 1:27 PM, noreply at launchpad.net wrote: > @@ -100,20 +101,25 @@ > os.chown(path, -1, MAILMAN_GID) > else: > print > - # All directories must be at least rwxrwsr-x. Don't check > the private > - # archive directory or database directory themselves since > these are > - # checked in checkarchives() and checkarchivedbs() below. > + # Most directories must be at least rwxrwsr-x. > + # The private archive directory and database directory > must be at > + # least rwxrws---. Their 'other' permissions are checked in > + # checkarchives() and checkarchivedbs() below. Their > 'user' and > + # 'group' permissions are checked here. > + # The directories under qfiles should be rwxrws---. Their > 'user' and > + # 'group' permissions are checked here. Their 'other' > permissions > + # aren't checked. > private = config.PRIVATE_ARCHIVE_FILE_DIR > - if path == private or (os.path.commonprefix((path, > private)) == private > - and os.path.split(path)[1] == > 'database'): > - continue > - # The directories under qfiles should have a more limited > permission > - if os.path.commonprefix((path, config.QUEUE_DIR)) == > config.QUEUE_DIR: > + if path == private or \ > + (os.path.commonprefix((path, private)) == private > + and os.path.split(path)[1] == 'database'): This is probably better style: if path == private or ( os.path.commonprefix((path, private)) == private and os.path.split(path)[1] == 'database'): # then... targetperms = PRIVATEPERMS It eliminates a backslash (always ugly ;) though it kind of begs for the 'then...' comment because of the way the columns line up. > + targetperms = PRIVATEPERMS > + elif os.path.commonprefix((path, config.QUEUE_DIR)) \ > + == config.QUEUE_DIR: > targetperms = QFILEPERMS Similarly, this removes the need for a backslash: elif (os.path.commonprefix((path, config.QUEUE_DIR)) == config.QUEUE_DIR): targetperms = QFILEPERMS You probably can't do much better without storing config.QUEUE_DIR in a local variable. Cheers, - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQCVAwUBRoP6mHEjvBPtnXfVAQL8qQP9GZzd1T5xdGGmcWvGR+lpZPUpZPGWJhCq 7yH54o8E45pBisH6LVVJR3KoS7/xfJGevj3t/tQ6gLgiOsdeiLaTWQJ05UBBiHAr r8+7FWWgUrc84o7EvkhgXXsqCVT/iFTW1yVWmlsVGLm0ezdl6oOPTcrpJ2biA63S 3Hn//tQKi2o= =rA0r -----END PGP SIGNATURE----- From msapiro at value.net Thu Jun 28 20:30:37 2007 From: msapiro at value.net (Mark Sapiro) Date: Thu, 28 Jun 2007 11:30:37 -0700 Subject: [Mailman-Developers] [Mailman-checkins] [Branch ~mailman-coders/mailman/3.0] (no title) In-Reply-To: References: <20070628172707.24622.38018.launchpad@canonical@gandwana.ubuntu.com> Message-ID: <4683FE4D.9010506@value.net> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Barry Warsaw wrote: > Hi Mark, thanks for fixing this. Just a couple of quick comments... >> private = config.PRIVATE_ARCHIVE_FILE_DIR >> - if path == private or (os.path.commonprefix((path, >> private)) == private >> - and os.path.split(path)[1] == >> 'database'): >> - continue >> - # The directories under qfiles should have a more limited >> permission >> - if os.path.commonprefix((path, config.QUEUE_DIR)) == >> config.QUEUE_DIR: >> + if path == private or \ >> + (os.path.commonprefix((path, private)) == private >> + and os.path.split(path)[1] == 'database'): > > This is probably better style: > > if path == private or ( > os.path.commonprefix((path, private)) == private > and os.path.split(path)[1] == 'database'): > # then... > targetperms = PRIVATEPERMS > > It eliminates a backslash (always ugly ;) though it kind of begs for > the 'then...' comment because of the way the columns line up. > >> + targetperms = PRIVATEPERMS >> + elif os.path.commonprefix((path, config.QUEUE_DIR)) \ >> + == config.QUEUE_DIR: >> targetperms = QFILEPERMS > > Similarly, this removes the need for a backslash: > > elif (os.path.commonprefix((path, config.QUEUE_DIR)) > == config.QUEUE_DIR): > targetperms = QFILEPERMS > > You probably can't do much better without storing config.QUEUE_DIR in > a local variable. Thanks Barry, I thought about this a bit, but clearly didn't think it through. I'll clean it up. /Mark - -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) iD8DBQFGg/5NVVuXXpU7hpMRAguhAJ9X9PpO8yhZqQ40vi5cfjCKCnmodQCg7/Ph GQxqjG/MfwJWFZYflqvaTnI= =EWWb -----END PGP SIGNATURE----- From barry at python.org Thu Jun 28 20:40:17 2007 From: barry at python.org (Barry Warsaw) Date: Thu, 28 Jun 2007 14:40:17 -0400 Subject: [Mailman-Developers] [Mailman-checkins] [Branch ~mailman-coders/mailman/3.0] (no title) In-Reply-To: <4683FE4D.9010506@value.net> References: <20070628172707.24622.38018.launchpad@canonical@gandwana.ubuntu.com> <4683FE4D.9010506@value.net> Message-ID: <966C4972-B369-4254-8A53-9E01649C6A82@python.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Jun 28, 2007, at 2:30 PM, Mark Sapiro wrote: > Thanks Barry, > > I thought about this a bit, but clearly didn't think it through. I'll > clean it up. > > /Mark Thanks Mark! - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQCVAwUBRoQAkXEjvBPtnXfVAQLbSwP+IKkeaLWQ08+tR61ZRAJ3HBghGcIclQiB xUjVlrS4KZ+eljtxRD55VCFGgvZ0SzOUlC9MZQBR3k7Dy901dGj24Pm1ZJE0fCYN FmEvhf/Oaw0JMebYY8itI9AxBuIFGOcWcd1qfdiZ29Gg1yxB2ri7Ah6S4zKwCO0N asw3oOfLWwo= =t8Tv -----END PGP SIGNATURE-----