[Mailman-Developers] logger umask

[Tokio Kikuchi]

Hi,

I think our new logger should set group writable to the new logs.  I
tried a fresh install and get cgi error after mailmanctl start /
mailmanctl errot after cgi execution, vice versa.

The patch should look like this:

Index: Mailman/loginit.py
===================================================================
--- Mailman/loginit.py  (revision 7892)
+++ Mailman/loginit.py  (working copy)
@@ -103,6 +103,8 @@
     # There was also a 'debug' logger, but that was mostly unused, so
instead
     # we'll use debug level on existing loggers.
     #
+    # First set umask because both mailman/www write logs
+    oumask = os.umask(002)
     # Start by creating a common formatter and the root logger.
     formatter = logging.Formatter(fmt=FMT, datefmt=DATEFMT)
     log = logging.getLogger('mailman')
@@ -120,6 +122,8 @@
         _handlers.append(handler)
         handler.setFormatter(formatter)
         log.addHandler(handler)
+    # restore original umask
+    os.umask(oumask)

-- 
Tokio Kikuchi, tkikuchi@ is.kochi-u.ac.jp
http://weather.is.kochi-u.ac.jp/