[Mailman-Developers] Errors.MMHostileAddress

[SHIGENO Kazutaka]

Hi,

When creating a list by Mailman-2.1.4,
if a user use owner addresses with comma, 
Errors.MMHostileAddress will occur.

================================================================
admin(21445): [----- Mailman Version: 2.1.4 -----]
admin(21445): [----- Traceback ------]
admin(21445): Traceback (most recent call last):
admin(21445):   File "/export/mm/scripts/driver", line 87, in run_main
admin(21445):     main()
admin(21445):   File "/export/mm/Mailman/Cgi/create.py", line 55, in main
admin(21445):     process_request(doc, cgidata)
admin(21445):   File "/export/mm/Mailman/Cgi/create.py", line 201, in process_request
admin(21445):     mlist.Create(listname, owner, pw, number, langs, emailhost)
admin(21445):   File "/export/mm/Mailman/MailList.py", line 462, in Create
admin(21445):     Utils.ValidateEmail(admin)
admin(21445):   File "/export/mm/Mailman/Utils.py", line 210, in ValidateEmail
admin(21445):     raise Errors.MMHostileAddress, s
admin(21445): MMHostileAddress: usera at domain,userb at domain
================================================================

How about changing into 'except Errors.EmailAddressError:'?

--- bin/newlist	2004/01/23 07:53:00
+++ bin/newlist	2004/02/25 12:44:02
@@ -175,7 +175,7 @@ def main():
                 os.umask(oldmask)
         except Errors.BadListNameError, s:
             usage(1, _('Illegal list name: %(s)s'))
-        except Errors.MMBadEmailError, s:
+        except Errors.EmailAddressError, s:
             usage(1, _('Bad owner email address: %(s)s'))
         except Errors.MMListAlreadyExistsError:
             usage(1, _('List already exists: %(listname)s'))

--- Mailman/Cgi/create.py	2004/01/09 02:49:02
+++ Mailman/Cgi/create.py	2004/02/25 12:44:02
@@ -201,7 +201,7 @@ def process_request(doc, cgidata):
                 mlist.Create(listname, owner, pw, number, langs, emailhost)
             finally:
                 os.umask(oldmask)
-        except Errors.MMBadEmailError, s:
+        except Errors.EmailAddressError, s:
             request_creation(doc, cgidata,
                              _('Bad owner email address: %(s)s'))
             return

--- Mailman/MailList.py	2004/02/25 12:35:20
+++ Mailman/MailList.py	2004/02/25 12:44:01
@@ -451,7 +451,7 @@ class MailList(HTMLFormatter, Deliverer,
         postingaddr = '%s@%s' % (name, emailhost)
         try:
             Utils.ValidateEmail(postingaddr)
-        except Errors.MMBadEmailError:
+        except Errors.EmailAddressError:
             raise Errors.BadListNameError, postingaddr
         # Validate the admin's email address
         Utils.ValidateEmail(admin)

-- shigeno