[Mailman-Developers] Suppress version advertisement

[John A. Martin]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
NotDashEscaped: You need GnuPG to verify this message

Please consider an option suppressing the advertisement of Mailman
version.  In spite of the possibility that the advertisement may ease
troubleshooting there are those who believe that the running version
of software should not be advertised to outsiders.  Some sites require
that such advertisements not be visible to non-local users.

IMHO version advertisement suppression should be an option in
Mailman/Defaults.py so that sites using distribution packages (.deb,
.rpm, etc) can choose for themselves, in Mailman/mm_config.py, whether
or not to advertise.

The following patch illustrates what needed to be suppressed through
Mailman-2.0.13.  The patch however does not make an option in
Mailman/Defaults.py.

-------------- cut here ---->8 ---< head
diff -urN mailman-2.0.12/Mailman/Handlers/CookHeaders.py mailman-2.0.12-jam/Mailman/Handlers/CookHeaders.py
--- mailman-2.0.12/Mailman/Handlers/CookHeaders.py	Wed Nov 15 23:35:09 2000
+++ mailman-2.0.12-jam/Mailman/Handlers/CookHeaders.py	Thu Jul 18 08:21:47 2002
@@ -68,8 +68,8 @@
     # http://www.dsv.su.se/~jpalme/ietf/jp-ietf-home.html
     #
     # None of these headers are added if they already exist
-    if not msg.get('x-mailman-version'):
-        msg['X-Mailman-Version'] = mm_cfg.VERSION
+    #if not msg.get('x-mailman-version'):
+    #    msg['X-Mailman-Version'] = mm_cfg.VERSION
     # Semi-controversial: some don't want this included at all, others
     # want the value to be `list'.
     if not msg.get('precedence'):
diff -urN mailman-2.0.12/Mailman/Handlers/ToDigest.py mailman-2.0.12-jam/Mailman/Handlers/ToDigest.py
--- mailman-2.0.12/Mailman/Handlers/ToDigest.py	Fri Oct  6 16:33:36 2000
+++ mailman-2.0.12-jam/Mailman/Handlers/ToDigest.py	Thu Jul 18 08:21:47 2002
@@ -211,7 +211,7 @@
 	msg['Subject'] = ('%s digest, %s - %s' % 
                           (mlist.real_name, self.__volume, self.__numinfo))
 	msg['Reply-to'] = mlist.GetListEmail()
-        msg['X-Mailer'] = "Mailman v%s" % mm_cfg.VERSION
+        msg['X-Mailer'] = "Mailman"
         msg['MIME-version'] = '1.0'
 
     def TemplateRefs(self):
diff -urN mailman-2.0.12/Mailman/MailCommandHandler.py mailman-2.0.12-jam/Mailman/MailCommandHandler.py
--- mailman-2.0.12/Mailman/MailCommandHandler.py	Tue Jul  2 12:33:23 2002
+++ mailman-2.0.12-jam/Mailman/MailCommandHandler.py	Thu Jul 18 08:21:47 2002
@@ -675,7 +675,6 @@
         text = Utils.maketext(
             'help.txt',
             {'listname'    : self.real_name,
-             'version'     : mm_cfg.VERSION,
              'listinfo_url': self.GetScriptURL('listinfo', absolute=1),
              'requestaddr' : self.GetRequestEmail(),
              'adminaddr'   : self.GetAdminEmail(),
diff -urN mailman-2.0.12/Mailman/htmlformat.py mailman-2.0.12-jam/Mailman/htmlformat.py
--- mailman-2.0.12/Mailman/htmlformat.py	Tue Apr  2 17:28:59 2002
+++ mailman-2.0.12-jam/Mailman/htmlformat.py	Thu Jul 18 08:21:48 2002
@@ -520,7 +520,7 @@
         def logo(file):
             return mm_cfg.IMAGE_LOGOS + file
         mmlink = '<img src="%s" alt="Delivered by Mailman" border=0>' \
-                 '<br>version %s' % (logo(DELIVERED_BY), mm_cfg.VERSION)
+                 % logo(DELIVERED_BY)
         pylink = '<img src="%s" alt="Python Powered" border=0>' % \
                  logo(PYTHON_POWERED)
         gnulink = '<img src="%s" alt="GNU\'s Not Unix" border=0>' % \
@@ -529,7 +529,7 @@
     else:
         # use only textual links
         mmlink = Link(MAILMAN_URL,
-                      'Delivered by Mailman<br>version %s' % mm_cfg.VERSION)
+                      'Delivered by Mailman')
         pylink = Link(PYTHON_URL, 'Python Powered')
         gnulink = Link(GNU_URL, "Gnu's Not Unix")
         t.AddRow([mmlink, pylink, gnulink])
diff -urN mailman-2.0.12/bin/add_members mailman-2.0.12-jam/bin/add_members
--- mailman-2.0.12/bin/add_members	Sun Sep 10 23:58:57 2000
+++ mailman-2.0.12-jam/bin/add_members	Thu Jul 18 08:21:48 2002
@@ -106,7 +106,6 @@
          'listinfo_url': mlist.GetScriptURL('listinfo', absolute=1),
          'requestaddr' : mlist.GetRequestEmail(),
          'adminaddr'   : adminaddr,
-         'version'     : mm_cfg.VERSION,
          }
     text = Utils.maketext('convert.txt', d)
     subject = 'Big change in %(listname)s@%(listhost)s mailing list' % d
---- 8<------- cut here ----------> tail

        jam

-----BEGIN PGP SIGNATURE-----

iD8DBQE+NT9LUEvv1b/iXy8RAmWsAJ0QgTum+cfLtM4DNbF/fMLieC9oHACfcqYP
kSV/9oVc6dUlpR9RlOSoMhM=
=gErb
-----END PGP SIGNATURE-----