[Mailman-Developers] [ mailman-Patches-594771 ] i18n support for
Archiver
noreply@sourceforge.net
noreply@sourceforge.net
Tue, 08 Oct 2002 10:14:39 -0700
Patches item #594771, was opened at 2002-08-13 17:09
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=594771&group_id=103
Category: Pipermail
Group: Mailman 2.1
>Status: Closed
>Resolution: Accepted
Priority: 7
Submitted By: Simone Piunno (pioppo)
Assigned to: Barry A. Warsaw (bwarsaw)
Summary: i18n support for Archiver
Initial Comment:
I'm trying to provide changes in small chunks.
This 1st patch does the following:
- 7 new template files:
archidxentry.html
archidxhead.html
archidxfoot.html
archliststart.html
archlistend.html
archtoc.html
archtocentry.html
- _() marking for translatable strings
- a few small bugfixes (e.g. unwanted spaces,
bin/arch not calling i18n.set_language, etc.)
TODO:
- show translated tags for archive volumes (e.g.
"2002-August", "2002q3", "Week-of-Mon-XXXX")
I have 2 alternatives: renaming files and dirs where
the archives are built (cleaner, but screws up
everything in pre-existing archives) or build a
tag-to-description translator (better, I think)
- find a way to produce translated datetime strings
without using locale.setlocale and time.strftime()
(this is discouraged in Python manual)
Here I really need some advice.
----------------------------------------------------------------------
>Comment By: Barry A. Warsaw (bwarsaw)
Date: 2002-10-08 13:14
Message:
Logged In: YES
user_id=12800
After removing the processUnixMailbox() in HyperArch.py,
this patch seems pretty good. I'm going to go ahead and
commit it and we can fix any bugs that crop up later.
(However, the simple things appear to work fine).
----------------------------------------------------------------------
Comment By: Barry A. Warsaw (bwarsaw)
Date: 2002-10-08 11:53
Message:
Logged In: YES
user_id=12800
I'm looking at this patch now and am cleaning up the code.
Is there a reason why one of the patches copied the
processUnixMailbox() method from pipermail.py to
HyperArch.py? That doesn't appear necessary.
----------------------------------------------------------------------
Comment By: Tokio Kikuchi (tkikuchi)
Date: 2002-08-26 19:53
Message:
Logged In: YES
user_id=67709
Thank you for updating.
Another comment:
I'v got error when I post a message to a list after applying
this patch. It is because a new variable Article._lang was
introduced and the older archive doesn't have this. I had
to re-generate the whole archive.
Another solution may be like.....
if not self._lang:
self._lang = self._mlist.preferred_language
i18n.set_language(self._lang)
----------------------------------------------------------------------
Comment By: Simone Piunno (pioppo)
Date: 2002-08-26 15:12
Message:
Logged In: YES
user_id=227443
I'm attaching the 3rd chunk modified as suggested by Tokio Kikuchi.
Maybe i18n_ctime is worth moving in Mailman/i18n.py ?
----------------------------------------------------------------------
Comment By: Tokio Kikuchi (tkikuchi)
Date: 2002-08-26 01:02
Message:
Logged In: YES
user_id=67709
I have submitted a slight change to this patch. It is
uploaded in a separate patch ID.
Thank you Simone for exellent work!
----------------------------------------------------------------------
Comment By: Simone Piunno (pioppo)
Date: 2002-08-14 14:49
Message:
Logged In: YES
user_id=227443
And finally, this is the 3rd piece of the puzzle: dates translation.
I had to reinvent the wheel, and it's an relatively expensive
hack (from a computational efficiency point of view) but it
works without touching pipermail.py
This patch is incremental and must be applied after #2
----------------------------------------------------------------------
Comment By: Simone Piunno (pioppo)
Date: 2002-08-13 19:38
Message:
Logged In: YES
user_id=227443
Here is the 2nd patch, providing the tag-to-description translator
for volume tags. This patch is incremental and must be applied
after patch #¹
Now the last thing is dates.
I wouln'd want to reinvent the wheel....
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=594771&group_id=103