[Mailman-Developers] Slightly lame logging: web subscription request

[Jost Krieger]

On Mon, Oct 28, 2002 at 11:16:16AM -0500, Barry A. Warsaw wrote:
> 
> >>>>> "GW" == Greg Ward <gward@mems-exchange.org> writes:
> 
>     GW> It appears that MM 2.1b4's logging of web subscription
>     GW> requests is a bit lame -- it doesn't actually log the email
>     GW> address involved, just the real name.  Is this deliberate?
> 
> No.  I'll have to double check this when I get a chance.

As this ist still in 2.1b5, I had a look.

The following patch fixed it for me, but I don't understand the case I didn't
fix (umbrella lists?).

Jost

--- /usr/local/mailman/Mailman/MailList.py.ORIG Wed Nov 27 12:01:18 2002
+++ /usr/local/mailman/Mailman/MailList.py      Wed Nov 27 12:01:44 2002
@@ -821,7 +821,7 @@
             if recipient <> email:
                 who = "%s (%s)" % (email, recipient.split('@')[0])
             else:
-                who = name
+                who = "%s (%s)" % (email, name)
             syslog('subscribe', '%s: pending %s %s',
                    self.internal_name(), who, by)
             raise Errors.MMSubscribeNeedsConfirmation

-- 
| Jost.Krieger+sig@ruhr-uni-bochum.de  Please help stamp out spam! |
| Postmaster, JAPH, resident answer machine          am RZ der RUB |
| Pluralitas non est ponenda sine necessitate                      |
|                                 William of Ockham (1285-1347/49) |