[Mailman-Developers] (2.0.11 patch) explicit references to mailman-owner instead of MAILMAN_OWNER

jpmg@eng.cam.ac.uk jpmg@eng.cam.ac.uk
Thu, 30 May 2002 12:29:12 +0100 (BST)


There are a few places where mailman-2.0.11 makes explicit reference to
'mailman-owner' + mlist.host_name where I believe it should use the
MAILMAN_OWNER variable (else why bother pretending that the latter is
usefully administrator-configurable?).

[ I've ignored the one in scripts/answer_majordomo_mail as I don't 
  believe that script can run anyway (does the Utils.SendTextToUser
  function exist?) ]

*** bin/newlist.orig	Sat Mar  3 05:58:19 2001
--- bin/newlist	Thu May 30 11:23:42 2002
***************
*** 204,214 ****
                   'admin_url'   : mlist.GetScriptURL('admin', absolute=1), 
                   'listinfo_url': mlist.GetScriptURL('listinfo', absolute=1),
                   'requestaddr' : "%s-request@%s" % (listname, mlist.host_name),
!                  'hostname'    : mlist.host_name,
                   })
              msg = Message.UserNotification(
                  owner_mail,
!                 'mailman-owner@' + mlist.host_name,
                  'Your new mailing list: ' + listname,
                  text)
              HandlerAPI.DeliverToUser(mlist, msg)
--- 204,214 ----
                   'admin_url'   : mlist.GetScriptURL('admin', absolute=1), 
                   'listinfo_url': mlist.GetScriptURL('listinfo', absolute=1),
                   'requestaddr' : "%s-request@%s" % (listname, mlist.host_name),
!                  'mailman-owner'    : mm_cfg.MAILMAN_OWNER,
                   })
              msg = Message.UserNotification(
                  owner_mail,
!                 mm_cfg.MAILMAN_OWNER,
                  'Your new mailing list: ' + listname,
                  text)
              HandlerAPI.DeliverToUser(mlist, msg)
*** templates/newlist.txt.orig	Fri Jun 19 20:37:07 1998
--- templates/newlist.txt	Thu May 30 11:23:50 2002
***************
*** 32,35 ****
  your admin password.  You can also use your password to change
  member's options, including digestification, delivery disabling, etc.
  
! Please address all questions to mailman-owner@%(hostname)s.
--- 32,35 ----
  your admin password.  You can also use your password to change
  member's options, including digestification, delivery disabling, etc.
  
! Please address all questions to %(mailman-owner)s.



------------------------

On a separate note, I _think_ that the email address "mailman@site"
is only ever used in one place, namely
Mailman/MailCommandHandler.py , where it's purpose doesn't seem
noticeably distinct from the MAILMAN_OWNER account.

Is there any good reason not to do the following patch, and simplify
the installation of mailman such that the only non-list-related alias
that it requires is the one specified by MAILMAN_OWNER in the mm_cfg.py
file?

*** Mailman/MailCommandHandler.py.orig	Tue Aug  1 23:03:23 2000
--- Mailman/MailCommandHandler.py	Thu May 30 11:27:52 2002
***************
*** 406,413 ****
  	    return
  	lists = Utils.list_names()
  	lists.sort()
! 	self.AddToResponse("\nPublic mailing lists run by mailman@%s"
! 			   % self.host_name, trunc=0)
  	for listname in lists:
  	    if listname == self._internal_name:
  		listob = self
--- 406,413 ----
  	    return
  	lists = Utils.list_names()
  	lists.sort()
! 	self.AddToResponse("\nPublic mailing lists run by %s"
! 			   % mm_cfg.MAILMAN_OWNER, trunc=0)
  	for listname in lists:
  	    if listname == self._internal_name:
  		listob = self


-------------------------


-patrick.