[Mailman-Developers] Bug in latest CVS: confirm.py

[Dan Mick]

Bug in latest confirm.py: passwords not completely stamped out.
Breaks Web subscription confirmations.

Index: confirm.py
===================================================================
RCS file: /cvsroot/mailman/mailman/Mailman/Cgi/confirm.py,v
retrieving revision 2.14
diff -u -r2.14 confirm.py
--- confirm.py  4 Mar 2002 20:17:50 -0000       2.14
+++ confirm.py  8 Mar 2002 02:27:15 -0000
@@ -302,7 +302,7 @@
             else:
                 digest = None
             userdesc = UserDesc(fullname=cgidata.getvalue('realname', None),
-                                password=pw, digest=digest, lang=lang)
+                                digest=digest, lang=lang)
             op, addr, pw, digest, lang = mlist.ProcessConfirmation(
                 cookie, userdesc)
         except Errors.MMNeedApproval:
@@ -329,14 +329,14 @@
             optionsurl = mlist.GetOptionsURL(addr, absolute=1)
             doc.SetTitle(title)
             doc.AddItem(Header(3, Bold(FontAttr(title, size='+2'))))
-            if not setformpasswd:
-                doc.AddItem(_("""\
-                The passwords you entered in the confirmation screen did not
-                match, so your original subscription password will be used
-                instead.  Your password will have been generated by Mailman if
-                you left the password fields blank.  In any event, your
-                membership password will be sent to you in a separate
-                acknowledgement email.<p>"""))
+##          if not setformpasswd:
+##              doc.AddItem(_("""\
+##              The passwords you entered in the confirmation screen did not
+##              match, so your original subscription password will be used
+##              instead.  Your password will have been generated by Mailman if
+##              you left the password fields blank.  In any event, your
+##              membership password will be sent to you in a separate
+##              acknowledgement email.<p>"""))
             doc.AddItem(_('''\
             You have successfully confirmed your subscription request for
             "%(addr)s" to the %(listname)s mailing list.  A separate