[Mailman-Developers] list_members doesn't return the whole membership list

Dan Mick Dan Mick <dmick@utopia.West.Sun.COM>
Tue, 5 Mar 2002 13:58:08 -0800 (PST)


Just sent this to Barry early Monday morning:

Date: Mon, 4 Mar 2002 09:58:20 -0800 (PST)
From: Dan Mick <dmick@utopia74>
Subject: bug: list_members has a backwards test
To: barry@wooz.org

The ambiguously-named 'statusp' returns 'true' if the address
should be filtered, so the tests are backwards:

Index: list_members
===================================================================
RCS file: /cvsroot/mailman/mailman/bin/list_members,v
retrieving revision 2.4
diff -u -r2.4 list_members
--- list_members        23 Feb 2002 06:40:44 -0000      2.4
+++ list_members        4 Mar 2002 17:58:09 -0000
@@ -179,14 +179,14 @@
         rmembers.sort()
         for addr in rmembers:
             # Filter out nomails
-            if not statusp(mlist, addr, why):
+            if statusp(mlist, addr, why):
                 continue
             print >> fp, addr
     if digest:
         dmembers.sort()
         for addr in dmembers:
             # Filter out nomails
-            if not statusp(mlist, addr, why):
+            if statusp(mlist, addr, why):
                 continue
             # Filter out digest kinds
             if mlist.getMemberOption(addr, mm_cfg.DisableMime):

> root@gandalf:/var/local/mailman/bin# ./dumpdb ../lists/test3/config.pck | grep 
user_options
>     'user_options': {'marc@merlins.org': 266},
> root@gandalf:/var/local/mailman/bin# ./list_members test3
> root@gandalf:/var/local/mailman/bin#
> 
> On bigger lists, list_members returns some of the list membership. It's not 
just
> the digest or non digest members, it looks kinda random.
> 
> I need to get  some sleep, so I'll leave this for someone  else to debug and
> fix