[Mailman-Developers] [ mailman-Patches-655214 ] Fix archiving

noreply at sourceforge.net noreply at sourceforge.net
Thu Dec 19 16:45:30 EST 2002


Patches item #655214, was opened at 2002-12-17 14:49
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=655214&group_id=103

Category: Pipermail
Group: Mailman 2.1
Status: Open
Resolution: None
Priority: 5
Submitted By: Martin v. Löwis (loewis)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix archiving

Initial Comment:
This patch restores MIME charset capabilities for
article archiving in CVS mailman.

It:
- removes the .charset attribute from articles; all
articles are encoded in the list's charset,

- decodes subject and author to Unicode; if this fails,
no decoding (not even MIME) is done to subject and author,

- MIME-decodes the body in the constructor using
get_payload, removes the hand-crafted qp decoding from
_get_body,

- Unicode-decodes the body in the constructor if the
body's charset differs from the list's charset,

- fixes processbody_URLquote to always return byte
strings (by escaping the URL also); comparing the old
and the new string is no longer possible since the old
string is Unicode and the new string is a list-encoded
byte string.

- changes text archiving to have the archives in the
list's encoding, with unsupported characters 'replace'd

- Fixes a bug in the scrubber, where a
content-transfer-encoding might have survived
flattening of the message.

With these changes, I can process the playground
archives correctly, to get mojibake-free pages.

----------------------------------------------------------------------

Comment By: Tokio Kikuchi (tkikuchi)
Date: 2002-12-20 00:45

Message:
Logged In: YES 
user_id=67709

Thanks.
 It looks like working for me (Japanese), except there was a
typo:

       if isinstance(body, unicode):
should be
       if isinstance(body, types.UnicodeType):



----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-12-19 06:55

Message:
Logged In: YES 
user_id=21627

Oops, attached.

----------------------------------------------------------------------

Comment By: Tokio Kikuchi (tkikuchi)
Date: 2002-12-19 03:13

Message:
Logged In: YES 
user_id=67709

Hi, Martin,
Haven't you forget to attach file? I am interested in
reviewing your patch.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=655214&group_id=103



More information about the Mailman-Developers mailing list