[Mailman-Developers] [PATCH] A small bug fixed in --with-python patch

Barry A. Warsaw barry@zope.com
Thu, 6 Sep 2001 01:29:38 -0400


>>>>> "BG" == Ben Gertzfield <che@debian.org> writes:

    BG> There were a few scripts nestled among all the ones I
    BG> converted to use #! /usr/bin/env @PYTHON@ that were not being
    BG> installed, because they did not have a #! line at all.

A couple of nits...

First, since your patch changes things so that the scripts no longer
search for `python' on your $PATH, we don't need the /usr/bin/env
trick anymore.  So I think those lines can safely be changed to

    #! @PYTHON@

No need to generate another patch Ben, I've made this change myself.

Second, we can forget about the filter directory; it's old, obsolete,
and soon to be removed <wink>.  Third, we don't need #! lines in the
scripts/* files, since these will always be executed by the wrappers,
which already have @PYTHON@ hard-coded into them.  I've changed these
lines to

    #! -*- python -*-

to keep the Emacs major mode dance working.

Other than that, I think your patch looks fine.  It certainly
meets my requirements, seems to work, and solves your problem.

Unless I hear any objections, I'll go ahead and accept these changes.

Thanks Ben!
-Barry