[Mailman-Developers] A bug?

[Mikhail Sobolev]

--EeQfGwPcQSOJBaQU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Oops.  Now they are really attached.

--
Misha

On Tue, Sep 04, 2001 at 10:48:01AM +0100, Mikhail Sobolev wrote:
> While trying to subscribe to a newly created list running under CVS
> version of Mailman, I found that the subject line for a confirmation
> request looks strange:
> 
>     confirm %(cookie)s
> 
> I attach two (since I do not know what way is kocher :) patches that
> seem to fix this problem.
> 
> Regards,
> 
> --
> Misha
> 
> _______________________________________________
> Mailman-Developers mailing list
> Mailman-Developers@python.org
> http://mail.python.org/mailman/listinfo/mailman-developers

--EeQfGwPcQSOJBaQU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ml.1.patch"

Index: MailList.py
===================================================================
RCS file: /cvsroot/mailman/mailman/Mailman/MailList.py,v
retrieving revision 2.37
diff -u -b -r2.37 MailList.py
--- MailList.py	2001/08/30 04:15:30	2.37
+++ MailList.py	2001/09/04 09:41:43
@@ -627,7 +627,7 @@
                  }, lang=lang, mlist=self)
             msg = Message.UserNotification(
                 recipient, self.GetRequestEmail(),
-                'confirm %(cookie)s',
+                'confirm %(cookie)s' % { 'cookie' : cookie },
                 text)
             msg['Reply-To'] = self.GetRequestEmail()
             msg.send(self)
@@ -804,7 +804,7 @@
              }, lang=self.getMemberLanguage(oldaddr), mlist=self)
         msg = Message.UserNotification(
             newaddr, self.GetRequestEmail(),
-            'confirm %(cookie)s',
+            'confirm %(cookie)s' % { 'cookie' : cookie },
             text)
         msg['Reply-To'] = self.GetRequestEmail()
         msg.send(self)
@@ -897,7 +897,7 @@
              }, lang=lang, mlist=self)
         msg = Message.UserNotification(
             addr, self.GetRequestEmail(),
-            'confirm %(cookie)s',
+            'confirm %(cookie)s' % { 'cookie' : cookie },
             text)
         msg['Reply-To'] = self.GetRequestEmail()
         msg.send(self)

--EeQfGwPcQSOJBaQU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ml.2.patch"

Index: MailList.py
===================================================================
RCS file: /cvsroot/mailman/mailman/Mailman/MailList.py,v
retrieving revision 2.37
diff -u -b -r2.37 MailList.py
--- MailList.py	2001/08/30 04:15:30	2.37
+++ MailList.py	2001/09/04 09:42:27
@@ -627,7 +627,7 @@
                  }, lang=lang, mlist=self)
             msg = Message.UserNotification(
                 recipient, self.GetRequestEmail(),
-                'confirm %(cookie)s',
+                'confirm %s' % cookie,
                 text)
             msg['Reply-To'] = self.GetRequestEmail()
             msg.send(self)
@@ -804,7 +804,7 @@
              }, lang=self.getMemberLanguage(oldaddr), mlist=self)
         msg = Message.UserNotification(
             newaddr, self.GetRequestEmail(),
-            'confirm %(cookie)s',
+            'confirm %s' % cookie,
             text)
         msg['Reply-To'] = self.GetRequestEmail()
         msg.send(self)
@@ -897,7 +897,7 @@
              }, lang=lang, mlist=self)
         msg = Message.UserNotification(
             addr, self.GetRequestEmail(),
-            'confirm %(cookie)s',
+            'confirm %s' % cookie,
             text)
         msg['Reply-To'] = self.GetRequestEmail()
         msg.send(self)

--EeQfGwPcQSOJBaQU--