[Mailman-Developers] minor qrunner bug.

[Chuq Von Rospach]

Just noticed a minor bug in qrunner. when qrunner starts up, it opens 
the log files, and leaves them open.

this is fine -- except when the logs get rolled and restarted. When you 
move the logs off and gzip them for storage, qrunner continues writing 
to the (now unlinked) old files, not the new, zeroed ones. So all of the 
qrunner stat and errror and whatever data from the time you roll the 
logs until that instance of qrunner exits  is gone (which, if you've 
modified qrunner lifetime values, can become significant on a busy 
system)

Since mailman isn't oding much log processing, not a big deal. but for 
sites that are (for instance) charging for list usage, or sites that 
have implemented reporting, there are  potential holes in the data, and 
if they're busy so they have extended qrunner times, significant holes.

while open/write/close is expensive, given all of the other stuff 
qrunner's doing and the relative lack of logging, I don't think it's 
significant. Alternatively, it can notice the files have been 
moved/zeroed, or perhaps accept a HUP like syslog...


--
Chuq Von Rospach, Internet Gnome <http://www.chuqui.com>
[<chuqui@plaidworks.com> = <me@chuqui.com> = <chuq@apple.com>]
Yes, yes, I've finally finished my home page. Lucky you.

I'm out of my mind, but feel free to leave a
message...