[Mailman-Developers] [PATCH] CVS typo fix: Let users actually set options

Ben Gertzfield che@debian.org
Tue, 28 Aug 2001 20:43:17 +0900


Big oops in the CVS, Barry!  

I was struggling to understand why, with my new code to let users
avoid duplicate messages, I couldn't get the options for any user to
change.. turns out there was a silly typo in
Mailman/OldStyleMemberships.py which had been preventing all users
from EVER setting any options in CVS Mailman.

Patch follows, and is pretty self-evident when you look at it.

--- mailman.cvs.orig/Mailman/OldStyleMemberships.py	Thu Aug 16 15:32:11 2001
+++ mailman/Mailman/OldStyleMemberships.py	Tue Aug 28 20:38:47 2001
@@ -273,9 +273,9 @@
         # the entry below just to make things (questionably) cleaner.
         flags = self.__mlist.user_options.setdefault(memberkey, 0)
         if value:
-            self.__mlist.user_options[memberkey] |= flags
+            self.__mlist.user_options[memberkey] |= flag
         else:
-            self.__mlist.user_options[memberkey] &= ~flags
+            self.__mlist.user_options[memberkey] &= ~flag
         if not self.__mlist.user_options[memberkey]:
             del self.__mlist.user_options[memberkey]
 

Ben

-- 
Brought to you by the letters D and M and the number 12.
"If you turn both processors off, you will have to reboot."
Debian GNU/Linux maintainer of Gimp and GTK+ -- http://www.debian.org/