[Mailman-Developers] Patch for non-ASCII characters in Subject line

Johan Holmberg holmberg@iar.se
Wed, 11 Apr 2001 16:03:39 +0200 (MEST)


  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

---559023410-2110444415-986997469=:13982
Content-Type: TEXT/PLAIN; CHARSET=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <Pine.GSO.4.33.0104111601141.13982@pjakkur.iar.se>


Hello mailman-developers !

I have for a long time been annoyed by the fact that Mailman adds
more than one copy of the mailing-list-prefix to the Subject line in
replies sent to a list. This can occur if the Subject line contains
non-ASCII characters (this has been reported in the bug-database
as bug #230400: "German Umlaute mess up subject-line and body").
It looks something like (if you can view this in your mailers :-)):

       Subject: Re: [Test] Re: [Test] r=E4kms=F6rg=E5s

The reason seems to be that Mailman has the following "algorithm" to
decide what to do:

    - add list-name-prefix (if it isn't already there)

instead of the more correct:

    - MIME-decode the subject
    - add list-name-prefix (if it isn't already there)
    - MIME-reencode the subject

If no MIME-decoding is done, Mailman can fail to detect the precense
of a mailing-list-prefix, since the prefix can be "buried" in the
MIME-encoded stuff.

I have made a patch to "CookHeaders.py" that fixes this problem, and
implements the second alternative above (see the attached patch).

Could something like this be added to future versions of Mailman ??
(I don't know if I have made the change the right way (I'm not a
Python programmer)).

/Johan Holmberg


---559023410-2110444415-986997469=:13982
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="mailman-subject-patch.txt"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.GSO.4.33.0104111557490.13982@pjakkur.iar.se>
Content-Description: 
Content-Disposition: ATTACHMENT; FILENAME="mailman-subject-patch.txt"

KioqIENvb2tIZWFkZXJzLnB5Lm9yaWcJRnJpIEZlYiAxNiAxMzo0MDoxOSAy
MDAxDQotLS0gQ29va0hlYWRlcnMucHkJV2VkIEFwciAxMSAxNDowMDoxNyAy
MDAxDQoqKioqKioqKioqKioqKioNCioqKiAyMCwyOCAqKioqDQotLS0gMjAs
NTIgLS0tLQ0KICBpbXBvcnQgc3RyaW5nDQogIGltcG9ydCByZQ0KICBpbXBv
cnQgdXJscGFyc2UNCisgaW1wb3J0IG1pbWlmeQ0KKyANCiAgZnJvbSBNYWls
bWFuIGltcG9ydCBtbV9jZmcNCiAgDQogIA0KKyAjLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLQ0KKyAjIFRoaXMgZnVuY3Rpb24gTUlNRS1kZWNvZGVzIHRo
ZSBzdWJqZWN0IGJlZm9yZSBkZWNpZGluZyBpZiBhDQorICMgcHJlZml4IHNo
b3VsZCBiZSBhZGRlZC4gSUYgd2UgY2hhbmdlIHRoZSBzdWJqZWN0IHdlIGhh
dmUgdG8NCisgIyAicmVlbmNvZGUiIGl0IGJlZm9yZSBzZW5kaW5nIGl0Lg0K
KyAjDQorICMgVGhpcyBpcyBhICJoYWNrIiBtYWRlIGJ5IEpvaGFuIEhvbG1i
ZXJnIDxob2xtYmVyZ0BpYXIuc2U+Lg0KKyAjIFNlZW1zIHRvIHdvcmssIGJ1
dCBJJ20gbm8gUHl0aG9uIHByb2dyYW1tZXIgKHByZWZlcnMgUGVybC9SdWJ5
IDotKSkNCisgIyBVc2UgaXQgYXQgeW91ciBvd24gcmlzay4NCisgIw0KKyAN
CisgZGVmIGFkZF9wcmVmaXgocHJlZml4LHN1YmplY3QpOg0KKyAgICAgaWYg
bm90IHByZWZpeDogcmV0dXJuIHN1YmplY3QNCisgICAgIHRleHQgPSBtaW1p
ZnkubWltZV9kZWNvZGVfaGVhZGVyKHN1YmplY3QpDQorICAgICBpZiByZS5z
ZWFyY2gocmUuZXNjYXBlKHByZWZpeCksIHRleHQsIHJlLkkpOg0KKyAgICAg
ICAgIHJldHVybiBzdWJqZWN0DQorICAgICBlbHNlOg0KKyAgICAgICAgIHRl
eHQgPSBwcmVmaXggKyBzdWJqZWN0DQorICAgICAgICAgdGV4dCA9IG1pbWlm
eS5taW1lX2VuY29kZV9oZWFkZXIodGV4dCkNCisgICAgICAgICByZXR1cm4g
dGV4dA0KKyANCisgIy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCisgDQog
IAwNCiAgZGVmIHByb2Nlc3MobWxpc3QsIG1zZywgbXNnZGF0YSk6DQogICAg
ICAjIE1hcmsgdGhlIG1lc3NhZ2UgYXMgZGlydHkgc28gdGhhdCBpdHMgdGV4
dCB3aWxsIGJlIGZvcmNlZCB0byBkaXNrIG5leHQNCioqKioqKioqKioqKioq
Kg0KKioqIDQ4LDU1ICoqKioNCiAgICAgICAgICAjIHdlIHB1cnBvc2VmdWxs
eSBsZWF2ZSBubyBzcGFjZSBiL3cgcHJlZml4IGFuZCBzdWJqZWN0IQ0KICAg
ICAgICAgIGlmIG5vdCBzdWJqZWN0Og0KICAgICAgICAgICAgICBtc2dbJ1N1
YmplY3QnXSA9IHByZWZpeCArICcobm8gc3ViamVjdCknDQohICAgICAgICAg
ZWxpZiBwcmVmaXggYW5kIG5vdCByZS5zZWFyY2gocmUuZXNjYXBlKHByZWZp
eCksIHN1YmplY3QsIHJlLkkpOg0KISAgICAgICAgICAgICBtc2dbJ1N1Ympl
Y3QnXSA9IHByZWZpeCArIHN1YmplY3QNCiAgICAgICMNCiAgICAgICMgZ2V0
IHJpZCBvZiBkdXBsaWNhdGUgaGVhZGVycw0KICAgICAgZGVsIG1zZ1snc2Vu
ZGVyJ10NCi0tLSA3Miw3OSAtLS0tDQogICAgICAgICAgIyB3ZSBwdXJwb3Nl
ZnVsbHkgbGVhdmUgbm8gc3BhY2UgYi93IHByZWZpeCBhbmQgc3ViamVjdCEN
CiAgICAgICAgICBpZiBub3Qgc3ViamVjdDoNCiAgICAgICAgICAgICAgbXNn
WydTdWJqZWN0J10gPSBwcmVmaXggKyAnKG5vIHN1YmplY3QpJw0KISAgICAg
ICAgIGVsaWYgcHJlZml4Og0KISAgICAgICAgICAgICBtc2dbJ1N1YmplY3Qn
XSA9IGFkZF9wcmVmaXgocHJlZml4LHN1YmplY3QpDQogICAgICAjDQogICAg
ICAjIGdldCByaWQgb2YgZHVwbGljYXRlIGhlYWRlcnMNCiAgICAgIGRlbCBt
c2dbJ3NlbmRlciddDQo=
---559023410-2110444415-986997469=:13982--