[Mailman-Developers] htmlformat.py missing </body>, quotes on attributes

[Jim Tittsler]

--OgqxwSJOaUobr8KG
Content-Type: text/plain; charset=us-ascii

CVS of 2000-03-21 19:00 EST

My /mailman/listinfo page was missing a </BODY> tag.  It looks like it is
missing from all pages generated by mailman/htmlformat.py

As long as I was looking at the HTML source, I noticed that it quoted the
attribute values for some of the tags (like for the BODY tag), but not those
for table, table rows, and cells.  That led to things like 100% and #99CCFF
not being quoted literals.

add </body> tag
quote all attribute values


-- 
Jim Tittsler, Tokyo
Python Starship     http://starship.python.net/crew/jwt/


--OgqxwSJOaUobr8KG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="htmlformat.diff"

--- Mailman/htmlformat.py.orig	Tue Mar 21 15:58:15 2000
+++ Mailman/htmlformat.py	Wed Mar 22 09:19:00 2000
@@ -121,7 +121,7 @@
 		output = output + ' NOWRAP'
 		continue
 	    else:
-		output = output + ' %s=%s' %(string.upper(key), val) 
+		output = output + ' %s="%s"' %(string.upper(key), val) 
 
 	return output
 
@@ -132,7 +132,7 @@
 	for (key, val) in info.items():
 	    if not key in valid_mods:
 		continue
-	    output = output + ' %s=%s' %(string.upper(key), val) 
+	    output = output + ' %s="%s"' %(string.upper(key), val) 
 
 	return output
 
@@ -149,7 +149,7 @@
 		output = output + ' BORDER'
 		continue
 	    else:	
-		output = output + ' %s=%s' %(string.upper(key), val) 	
+		output = output + ' %s="%s"' %(string.upper(key), val) 	
 
 	return output
 
@@ -284,7 +284,7 @@
 	else:
 	    output = output + '>\n'
 	output = output + Container.Format(self, indent)
-	output = output + '%s</html>\n' % spaces
+	output = output + '%s</body>\n%s</html>\n' % (spaces, spaces)
 	return output
 
 class HeadlessDocument(Document):

--OgqxwSJOaUobr8KG--