[Mailman-Developers] fix for approval forwards

[Barry A. Warsaw]

>>>>> "RK" == Ricardo Kustner <ricardo@rixhq.nu> writes:

    RK> I mentioned earlier that the forward option on the approval
    RK> page is not working properly... since i've spent some more
    RK> time in the mailman code this weekend, i decided to see if i
    RK> could fix this...

    RK> It turns out the i could fix this by changing line # 233 in
    RK> ListAdmin.py from

    RK> msg.recips = addr

    RK> to

    RK> msg.recips = [addr]

    RK> someday i might actually understand python... :)

I think you've identified the problem correctly, and your patch would
work fine.  However this one is probably a bit better (since I'm
moving away from setting attributes on the msg object).  I'll check
this in and probably spin beta4 sometime in the next hour or so.

-Barry

-------------------- snip snip --------------------
Index: ListAdmin.py
===================================================================
RCS file: /cvsroot/mailman/mailman/Mailman/ListAdmin.py,v
retrieving revision 1.43
diff -u -r1.43 ListAdmin.py
--- ListAdmin.py	2000/07/05 20:37:35	1.43
+++ ListAdmin.py	2000/07/06 18:03:19
@@ -235,8 +235,8 @@
             # This should also uniquify the message enough for the hash-based
             # file naming (not foolproof though).
             msg['Resent-To'] = addr
-            msg.recips = addr
-            HandlerAPI.DeliverToUser(self, msg, {'_enqueue_immediate': 1})
+            HandlerAPI.DeliverToUser(self, msg, {'_enqueue_immediate': 1,
+                                                 'recips': [addr]})
         # for safety
         def strquote(s):
             return string.replace(s, '%', '%%')