[Mailman-Developers] oops - hit a bug - 1.0b11

Barry A. Warsaw bwarsaw@cnri.reston.va.us (Barry A. Warsaw)
Sat, 3 Apr 1999 21:07:49 -0500 (EST)


>>>>> "JH" == Jeff Hahn <jeffh@streek.com> writes:

    JH> just noticed this in my logs from this afternoon - don't know
    JH> if it's b11 specific...

    JH> I am able to reproduce the problem by:

    | 1.	go to listinfo page
    | 2.	hit link for archive (archive restricted to members)
    | 3.	enter aaa@bbb.com for user ( any non member )
    | 4.	enter 12345 (or anything else for password)
 
    JH> then I get the "oops" page...  I don't recall trying to access
    JH> a restricted archive as a non-member before this, so it may
    JH> not be b11 specific.  I assume private.py should also be
    JH> trapping the MMNotAMemberError error...

Correct.  Here's a patch, thanks for the report!
-Barry

-------------------- snip snip --------------------
Index: private.py
===================================================================
RCS file: /projects/cvsroot/mailman/Mailman/Cgi/private.py,v
retrieving revision 1.11
retrieving revision 1.12
diff -c -r1.11 -r1.12
*** private.py	1999/03/29 23:53:57	1.11
--- private.py	1999/04/04 02:06:58	1.12
***************
*** 118,124 ****
          raise SystemExit
      try:
  	listobj.ConfirmUserPassword( username, password)
!     except (Errors.MMBadUserError, Errors.MMBadPasswordError): 
  	return 0
  
      token = `hash(list_name)`
--- 118,125 ----
          raise SystemExit
      try:
  	listobj.ConfirmUserPassword( username, password)
!     except (Errors.MMBadUserError, Errors.MMBadPasswordError,
!             Errors.MMNotAMemberError): 
  	return 0
  
      token = `hash(list_name)`