From futatuki at poem.co.jp Fri Jun 1 12:43:23 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Fri, 01 Jun 2018 16:43:23 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-forbid-subscription into lp:mailman/2.1 Message-ID: <152787140042.9056.1608519153337152198.launchpad@ackee.canonical.com> Yasuhito FUTATSUKI at POEM has proposed merging lp:~futatuki/mailman/2.1-forbid-subscription into lp:mailman/2.1. Commit message: Add new value for MailList.subscribe_policy 4 as forbid Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-forbid-subscription/+merge/347305 This extends MailList.subscribe_policy with new value '4', forbid subscribe request via E-mail and via Web UI (except list owners operation). With MailList.subscribe_policy == 4, * For Web UI - reject all subscribe request (Mailman/Cgi/subscribe.py, Mailman/HTMLFormatter.py) - hide subscription form from listinfo page (Mailman/Cgi/listinfo.py, new template templates/en/listinfo_nosubscribe.html) * For request via E-mail, reject all subscribe command (Mailman/Command/cmd_subscribe.py) * foolproof: MailList.AddMember() raise new exception Errors.MembershipIsRejectedByPolicy() (Mailman/Errors.py, Mailman/MailList.py) To set new value to MailList.subscribe_policy, * For Web UI, add new radio button and description (Mailman/Gui/Privacy.py) For new template * Add menu new item for new template file (Mailman/Cgi/edithtml.py) For description * Add description for new value (Mailman/Defauilts.py.in, misc/sitelist.cfg) Please revise not only code logic but also identifiers, words, messages to be suitable. -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-forbid-subscription into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 17785 bytes Desc: not available URL: From 1774826 at bugs.launchpad.net Sat Jun 2 19:21:32 2018 From: 1774826 at bugs.launchpad.net (Oscar Racle) Date: Sat, 02 Jun 2018 23:21:32 -0000 Subject: [Bug 1774826] [NEW] Feature request: simple captcha Message-ID: <152798169305.24903.16625051013418669536.malonedeb@gac.canonical.com> Public bug reported: Suggest to include a simple captcha that (unlike reCAPTCHA) does not involve feeding data to the internet advertising and surveillance industry. This could be a simple arithmetic captcha entirely implemented in python without any contact to 3rd party servers. Such a mechanism should be sufficient to keep out ordinary spambots. ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774826 Title: Feature request: simple captcha To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774826/+subscriptions From mark at msapiro.net Sat Jun 2 20:02:28 2018 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 03 Jun 2018 00:02:28 -0000 Subject: [Bug 1774826] Re: Feature request: simple captcha References: <152798169305.24903.16625051013418669536.malonedeb@gac.canonical.com> Message-ID: <152798414876.25068.7134694316957106652.launchpad@gac.canonical.com> ** Changed in: mailman Importance: Undecided => Wishlist ** Changed in: mailman Status: New => Triaged -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774826 Title: Feature request: simple captcha To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774826/+subscriptions From post+launchpad at ralfj.de Sun Jun 3 16:43:24 2018 From: post+launchpad at ralfj.de (Ralf Jung) Date: Sun, 03 Jun 2018 20:43:24 -0000 Subject: [Merge] lp:~ralfjung-e/mailman/csrf-injective into lp:mailman/2.1 Message-ID: <152805860189.27913.11757656387002609437.launchpad@ackee.canonical.com> Ralf Jung has proposed merging lp:~ralfjung-e/mailman/csrf-injective into lp:mailman/2.1. Commit message: Separate data in CSRF token by colon to avoid collisions. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~ralfjung-e/mailman/csrf-injective/+merge/347340 This makes the data-to-token function injective. Previously, for example, the list called "list1" and the IP "10.0.0.0" would have the same hash as the list called "list" and the IP "110.0.0.0", as the strings were just concatenated. -- Your team Mailman Coders is requested to review the proposed merge of lp:~ralfjung-e/mailman/csrf-injective into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1553 bytes Desc: not available URL: From jimpop at domainmail.org Sun Jun 3 17:54:06 2018 From: jimpop at domainmail.org (Jim Popovitch) Date: Sun, 03 Jun 2018 21:54:06 -0000 Subject: [Merge] lp:~ralfjung-e/mailman/csrf-injective into lp:mailman/2.1 In-Reply-To: <152805860189.27913.11757656387002609437.launchpad@ackee.canonical.com> Message-ID: <152806284595.24590.9155597616372475786.codereview@gac.canonical.com> A couple thoughts: 1) The original code in listinfo.py uses 'now' twice in the token. I wonder if that's necessary. 2) Should use something besides a colon as colons are part of IPv6 addresses? -- https://code.launchpad.net/~ralfjung-e/mailman/csrf-injective/+merge/347340 Your team Mailman Coders is requested to review the proposed merge of lp:~ralfjung-e/mailman/csrf-injective into lp:mailman/2.1. From 1774987 at bugs.launchpad.net Mon Jun 4 08:51:21 2018 From: 1774987 at bugs.launchpad.net (Robert Arends) Date: Mon, 04 Jun 2018 12:51:21 -0000 Subject: [Bug 1774987] [NEW] mailman-config incorrect quoting in print statement Message-ID: <152811668136.3829.12283918953317829930.malonedeb@chaenomeles.canonical.com> Public bug reported: As found in this newly included file bin/mailman-config Mailman version: 2.1.26 The following 2 lines have extra quotes. print "mail_group: %s" % ""mail", "postfix", "mailman", "nobody", "daemon"" print "cgi_group: %s" % ""apache"" Editing to remove the extra quotes works. print "mail_group: %s" % "mail", "postfix", "mailman", "nobody", "daemon" print "cgi_group: %s" % "apache" Thanks. Rob. ** Affects: mailman Importance: Undecided Status: New ** Description changed: As found in this newly included file bin/mailman-config + Mailman version: 2.1.26 The following 2 lines have extra quotes. - print "mail_group: %s" % ""mail", "postfix", "mailman", "nobody", "daemon"" + print "mail_group: %s" % ""mail", "postfix", "mailman", "nobody", "daemon"" print "cgi_group: %s" % ""apache"" - + Editing to remove the extra quotes works. - print "mail_group: %s" % "mail", "postfix", "mailman", "nobody", "daemon" - print "cgi_group: %s" % "apache" + print "mail_group: %s" % "mail", "postfix", "mailman", "nobody", "daemon" + print "cgi_group: %s" % "apache" Thanks. Rob. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774987 Title: mailman-config incorrect quoting in print statement To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774987/+subscriptions From 1774986 at bugs.launchpad.net Mon Jun 4 08:51:17 2018 From: 1774986 at bugs.launchpad.net (Robert Arends) Date: Mon, 04 Jun 2018 12:51:17 -0000 Subject: [Bug 1774986] [NEW] mailman-config incorrect quoting in print statement Message-ID: <152811667792.32030.17776533431233849580.malonedeb@soybean.canonical.com> Public bug reported: As found in this newly included file bin/mailman-config The following 2 lines have extra quotes. print "mail_group: %s" % ""mail", "postfix", "mailman", "nobody", "daemon"" print "cgi_group: %s" % ""apache"" Editing to remove the extra quotes works. print "mail_group: %s" % "mail", "postfix", "mailman", "nobody", "daemon" print "cgi_group: %s" % "apache" Thanks. Rob. ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774986 Title: mailman-config incorrect quoting in print statement To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774986/+subscriptions From 1774986 at bugs.launchpad.net Mon Jun 4 11:57:17 2018 From: 1774986 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Mon, 04 Jun 2018 15:57:17 -0000 Subject: [Bug 1774986] Re: mailman-config incorrect quoting in print statement References: <152811667792.32030.17776533431233849580.malonedeb@soybean.canonical.com> Message-ID: <152812784098.20183.10331354081940243216.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774986 Title: mailman-config incorrect quoting in print statement To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774986/+subscriptions From mark at msapiro.net Mon Jun 4 12:03:19 2018 From: mark at msapiro.net (Mark Sapiro) Date: Mon, 04 Jun 2018 16:03:19 -0000 Subject: [Bug 1774986] Re: mailman-config incorrect quoting in print statement References: <152811667792.32030.17776533431233849580.malonedeb@soybean.canonical.com> Message-ID: <152812819980.25493.2089238968154089013.malone@wampee.canonical.com> This occurs because the values in the --with-mail-gid= and --with-cgi- gid= options passed to configure were quoted. Normally, they will not be. Whoever created your package should adjust their configure command options to remove unnecessary quoting. Doesn't this also affect the print "configure_opts: ... line? This occurs because the values in the --with-mail-gid= and --with-cgi-gid= options passed to configure were quoted That said, I have changed the parameter quoting in bin/mailman-config from double to single quotes which should help. ** Changed in: mailman Importance: Undecided => Low ** Changed in: mailman Status: New => Fix Committed ** Changed in: mailman Milestone: None => 2.1.27 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774986 Title: mailman-config incorrect quoting in print statement To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774986/+subscriptions From 1774986 at bugs.launchpad.net Tue Jun 5 05:24:05 2018 From: 1774986 at bugs.launchpad.net (Robert Arends) Date: Tue, 05 Jun 2018 09:24:05 -0000 Subject: [Bug 1774986] Re: mailman-config incorrect quoting in print statement References: <152811667792.32030.17776533431233849580.malonedeb@soybean.canonical.com> Message-ID: <152819064592.26276.12916801313942761473.malone@wampee.canonical.com> My configure_opts line is as follows (I have not edited this line). print "configure_opts: \"%s\"" % "--libdir=/usr/lib --prefix=/usr/lib/mailman --with-var-prefix=/var/lib/mailman --with- config-dir=/etc/mailman --with-lock-dir=/var/lock/mailman --with-log- dir=/var/log/mailman --with-pid-dir=/var/run/mailman --with-queue- dir=/var/spool/mailman --with-template-dir=/etc/mailman/templates --with-python=/usr/bin/python --with-mail-gid=mail postfix mailman nobody daemon --with-cgi-id=apache --with-cgi-gid=apache --with- mailhost=localhost.localdomain --with-urlhost=localhost.localdomain --without-permcheck" The package was obtained from: -> rpmfind.net mailman-2.1.26-1.fc29.x86_64 Other than that I don't know the packager. I will admit that I'm running it on CentOS7.5.1804 OT (FYI) I'm not using Archives at all, but everything else including virtual domains are working after a migration from RHEL5/mailman-2.1.9-8.el5_11 Including the reCaptcha on the subscription page - main reason for migrating. Thanks - great work. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774986 Title: mailman-config incorrect quoting in print statement To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774986/+subscriptions From 1774986 at bugs.launchpad.net Tue Jun 5 05:28:21 2018 From: 1774986 at bugs.launchpad.net (Robert Arends) Date: Tue, 05 Jun 2018 09:28:21 -0000 Subject: [Bug 1774986] Re: mailman-config incorrect quoting in print statement References: <152811667792.32030.17776533431233849580.malonedeb@soybean.canonical.com> Message-ID: <152819090172.3642.9583871803098930277.malone@chaenomeles.canonical.com> Mark, it was likely quoted by the packager because there are multiple values provided, and an assumption would be that quoting would be necessary. I certainly would have assumed the next line needed quoting. But then I'm not familiar with compiling my own. --with-mail-gid=mail postfix mailman nobody daemon Thanks, Rob. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774986 Title: mailman-config incorrect quoting in print statement To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774986/+subscriptions From mark at msapiro.net Tue Jun 5 12:12:07 2018 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 05 Jun 2018 16:12:07 -0000 Subject: [Bug 1774986] Re: mailman-config incorrect quoting in print statement References: <152811667792.32030.17776533431233849580.malonedeb@soybean.canonical.com> Message-ID: <152821512772.26276.4784668961136691347.malone@wampee.canonical.com> I'm not sure what's going on. Your 'configure_opts:' says '--with-cgi- gid=apache' and '--with-mail-gid=mail postfix mailman nobody daemon' which doesn't quote the values, yet the individual values set by configure are quoted. Yet, in my development environment before changing the quotes, I see: print "mail_group: %s" % "mark" print "cgi_group: %s" % "www-data" and print "configure_opts: \"%s\"" % "--prefix=/var/MM/21 --with- username=mark --with-groupname=mark --with-cgi-gid=www-data --with-mail- gid=mark --with-mailhost=msapiro.net --with-urlhost=msapiro.net" I.e. '--with-cgi-gid=www-data' does not produce print "cgi_group: %s" % ""www-data"" whereas in your case, '--with-cgi-gid=apache' does produce print "cgi_group: %s" % ""apache"" The difference is something in configure on the system on which the package was built, but even then, why does it affect mail_group and cgi_group and not, e.g., var_prefix, mailman_user and mailman_group? Anyway, I did replace the double quotes with single quotes and that should fix it. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774986 Title: mailman-config incorrect quoting in print statement To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774986/+subscriptions From futatuki at poem.co.jp Tue Jun 5 13:42:57 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Tue, 05 Jun 2018 17:42:57 -0000 Subject: [Bug 1775233] [NEW] Python 2.7 dependency in Utils.banned_ip() Message-ID: <152822057791.32332.17469853457378730895.malonedeb@soybean.canonical.com> Public bug reported: Utils.banned_ip() introduced at rev 1762 has Python 2.7 dependency. The feature allows to ommit positional argument specifiers of str.format() appeared in Python 2.7. ** Affects: mailman Importance: Undecided Status: New ** Patch added: "banned_ip_py26_patch.txt" https://bugs.launchpad.net/bugs/1775233/+attachment/5149058/+files/banned_ip_py26_patch.txt ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1775233 Title: Python 2.7 dependency in Utils.banned_ip() To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1775233/+subscriptions From mark at msapiro.net Tue Jun 5 14:23:06 2018 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 05 Jun 2018 18:23:06 -0000 Subject: [Bug 1775233] Re: Python 2.7 dependency in Utils.banned_ip() References: <152822057791.32332.17469853457378730895.malonedeb@soybean.canonical.com> Message-ID: <152822298647.24397.17455286209944541819.malone@gac.canonical.com> I would really like to answer this by saying Python 2.7 is required, but since I have another change to this code in progress, I'll fix it. ** Changed in: mailman Importance: Undecided => Low ** Changed in: mailman Status: New => In Progress ** Changed in: mailman Milestone: None => 2.1.27 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1775233 Title: Python 2.7 dependency in Utils.banned_ip() To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1775233/+subscriptions From mark at msapiro.net Tue Jun 5 15:15:03 2018 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 05 Jun 2018 19:15:03 -0000 Subject: [Bug 1775233] Re: Python 2.7 dependency in Utils.banned_ip() References: <152822057791.32332.17469853457378730895.malonedeb@soybean.canonical.com> Message-ID: <152822610438.31906.6358299460239438037.launchpad@soybean.canonical.com> ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1775233 Title: Python 2.7 dependency in Utils.banned_ip() To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1775233/+subscriptions From futatuki at poem.co.jp Thu Jun 7 02:59:24 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Thu, 07 Jun 2018 06:59:24 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 Message-ID: <152835476182.26178.12300837974584887617.launchpad@ackee.canonical.com> Yasuhito FUTATSUKI at POEM has proposed merging lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. Commit message: Update ja translation up to lp:mailman/2.1 rev 1766 Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-ja-translation/+merge/347572 * add translation word for 'Esperanto' * fix some inconsistent translation word for 'subscribe' * Update translation for Default.py.in up to rev 1762, with expected change of description for IPv6 support feature added in rev 1766 -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 3157 bytes Desc: not available URL: From 1774826 at bugs.launchpad.net Sun Jun 10 13:33:08 2018 From: 1774826 at bugs.launchpad.net (Ralf Jung) Date: Sun, 10 Jun 2018 17:33:08 -0000 Subject: [Bug 1774826] Re: Feature request: simple captcha References: <152798169305.24903.16625051013418669536.malonedeb@gac.canonical.com> Message-ID: <152865198819.22210.3711360903706688957.malone@chaenomeles.canonical.com> I have implemented such a simple CAPTCHA for Mailman 2 and described the patch at . If there is interest from the maintainers, I'd be happy to prepare a merge request for this. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774826 Title: Feature request: simple captcha To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774826/+subscriptions From mark at msapiro.net Sun Jun 10 15:00:18 2018 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 10 Jun 2018 19:00:18 -0000 Subject: [Bug 1774826] Re: Feature request: simple captcha References: <152798169305.24903.16625051013418669536.malonedeb@gac.canonical.com> Message-ID: <152865721819.21387.10022399364704310299.malone@gac.canonical.com> I have looked at your blog post describing the patch. It is interesting and to me it is quite reminiscent of the MoinMoin TextCHA feature. See https://moinmo.in/HelpOnSpam for a bit on that. I'd be interested in a merge request against the current HEAD, but it would need work. I think the display and verify functions should be in Mailman/Utils.py rather than a separate module. Also, I would like to see support for multiple languages as in the MoinMoin implementation, and I would like to see it done in such a way that one could set neither, one or both of CAPTCHAS and RECAPTCHA_SITE_KEY/RECAPTCHA_SECRET_KEY in mm_cfg.py and the right thing would be done in each case. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774826 Title: Feature request: simple captcha To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774826/+subscriptions From noreply at launchpad.net Sun Jun 10 15:08:22 2018 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sun, 10 Jun 2018 19:08:22 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 In-Reply-To: <152835476182.26178.12300837974584887617.launchpad@ackee.canonical.com> Message-ID: <152865770069.30742.7540884667337290585.launchpad@ackee.canonical.com> The proposal to merge lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-ja-translation/+merge/347572 -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. From 1774826 at bugs.launchpad.net Thu Jun 14 03:27:13 2018 From: 1774826 at bugs.launchpad.net (Ralf Jung) Date: Thu, 14 Jun 2018 07:27:13 -0000 Subject: [Bug 1774826] Re: Feature request: simple captcha References: <152798169305.24903.16625051013418669536.malonedeb@gac.canonical.com> Message-ID: <152896123387.26875.16144748144531020502.malone@gac.canonical.com> > I think the display and verify functions should be in Mailman/Utils.py rather than a separate module. Absolutely, I just did that to keep the diff small and reduce the chance of conflicts. > I would like to see support for multiple languages as in the MoinMoin implementation So, having an additional outer-level dictionary mapping languages to something like what I am using currently? Yes, I can do that. Technical question: Can I rely on the language being the same on the listinfo and the subscribe page, or do I have to put the language into the FORM_SECRET to be able to know which language was used? > and I would like to see it done in such a way that one could set neither, one or both of CAPTCHAS and RECAPTCHA_SITE_KEY/RECAPTCHA_SECRET_KEY in mm_cfg.py and the right thing would be done in each case I definitely planned to implement it that way. Do you have any suggestions for the best way to test such a patch locally before submission? Is there a good way to run mailman from source? I guess I could copy-paste the changed files to one of my servers but that seems suboptimal. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774826 Title: Feature request: simple captcha To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774826/+subscriptions From futatuki at poem.co.jp Thu Jun 14 12:17:24 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Thu, 14 Jun 2018 16:17:24 -0000 Subject: [Merge] lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1 Message-ID: <152899304149.5392.13038835066372813746.launchpad@ackee.canonical.com> Yasuhito FUTATSUKI at POEM has proposed merging lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1. Commit message: Add '%(whence)s' to adminsubscribeack.txt and adminunsubscribeack.txt, for each language. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~futatuki/mailman/i18n-add-whence-to-adminack-templates/+merge/347992 As far as I saw adminsubscribeack.txt and adminunsubscribeack.txt templates other than 'en', '%(whence)s' line can be added safely. So, I did it by using sed and shell script below(in ./templates directory, FreeBSD envirionment): --- begin --- #!/bin/sh LC_CTYPE=C sed='/usr/bin/sed' for l in * ; do if [ -d "${l}" -a ! "$l" = en ] ; then if [ -f ${l}/adminsubscribeack.txt ]; then ${sed} -I '' -e 's/\(.\)$/\1\ %(whence)s/' ${l}/adminsubscribeack.txt fi if [ -f ${l}/adminunsubscribeack.txt ]; then ${sed} -I '' -e 's/\(.\)$/\1\ %(whence)s/' ${l}/adminunsubscribeack.txt fi fi done --- end --- -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 21202 bytes Desc: not available URL: From noreply at launchpad.net Thu Jun 14 13:15:38 2018 From: noreply at launchpad.net (noreply at launchpad.net) Date: Thu, 14 Jun 2018 17:15:38 -0000 Subject: [Merge] lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1 In-Reply-To: <152899304149.5392.13038835066372813746.launchpad@ackee.canonical.com> Message-ID: <152899653658.8437.9116740378892238487.launchpad@ackee.canonical.com> The proposal to merge lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~futatuki/mailman/i18n-add-whence-to-adminack-templates/+merge/347992 -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1. From mark at msapiro.net Thu Jun 14 18:08:25 2018 From: mark at msapiro.net (Mark Sapiro) Date: Thu, 14 Jun 2018 22:08:25 -0000 Subject: [Bug 1774826] Re: Feature request: simple captcha References: <152798169305.24903.16625051013418669536.malonedeb@gac.canonical.com> <152896123387.26875.16144748144531020502.malone@gac.canonical.com> Message-ID: <09b013ec-3070-65c2-1aa2-4b95e93bdf9d@msapiro.net> On 06/14/2018 12:27 AM, Ralf Jung wrote: > > So, having an additional outer-level dictionary mapping languages to > something like what I am using currently? Yes, I can do that. My thought on languages is that the definition of CAPTCHAS to enable the feature would be something like: CAPTCHAS = {'en': [('english question one', 'regexp matching answers'), ('english question two', 'regexp matching answers'), ... ] 'l2': [('language2 question one', 'regexp matching answers'), ('language2 question two', 'regexp matching answers'), ... ] ... } Then the trigger would be something like: if isinstance(CAPTCHAS, dict) and 'en' in CAPTCHAS: And the idea being to look up the questions and answer regexps for the language in question and if not found, use the 'en' questions and answer regexps. > Technical question: Can I rely on the language being the same on the > listinfo and the subscribe page, or do I have to put the language into > the FORM_SECRET to be able to know which language was used? No. you can't. The language that you will see when generating the question is the language selected with the "View this page in" button at the upper right of the listinfo page. The language passed to the subscribe CGI as the value of 'language' is the language selected at "Which language do you prefer to display your messages?" These are not necessarily the same as each other or as the list's or sites preferred language. So, yes, you have to pass bothe the language and the question index in the token. > Do you have any suggestions for the best way to test such a patch > locally before submission? Is there a good way to run mailman from > source? I guess I could copy-paste the changed files to one of my > servers but that seems suboptimal. It's easy enough. I actually have development environments on my local work stations, so I don't think much about how to set it up, but you basically need to have a development box that has a web server. For this, you don't need an MTA and you don't need to run Mailman as you're only testing CGIs and you can see from Mailman's logs and qfiles what happened beyond the web responses. You need to start with the source plus your changes, run configure with some local directory as --prefix. I use: > #! /bin/sh > ./configure --prefix=/var/MM/21 --with-username=mark --with-groupname=mark --with-cgi-gid=www-data --with-mail-gid=mark --with-mailhost=msapiro.net --with-urlhost=msapiro.net and then 'make install'. In my apache config I have > ScriptAlias /mailman/ /var/MM/21/cgi-bin/ > Alias /pipermail/ /var/MM/21/archives/public/ > > > AllowOverride None > Options ExecCGI > Require all granted > > > > Options +FollowSymLinks > Require all granted > You also have to create a list, and I think that's about it. -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774826 Title: Feature request: simple captcha To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774826/+subscriptions From 1696066 at bugs.launchpad.net Fri Jun 15 05:10:52 2018 From: 1696066 at bugs.launchpad.net (=?utf-8?b?7oO/IENocmlzdGlhbiBFaHJoYXJkdCDug78=?=) Date: Fri, 15 Jun 2018 09:10:52 -0000 Subject: [Bug 1696066] Re: Postfix module - Mailman wrapper - Couldn't write data/aliases.db and data/virtual-mailman.db files References: <149673486419.28883.14597965095773088289.malonedeb@wampee.canonical.com> Message-ID: <152905385288.26269.2923852444049031995.malone@soybean.canonical.com> Bionic and Cosmic have 1:2.1.26-1 so #1 and #2 are done. Given that Mark identified this as: a) uncommon issue b) not affecting the usual way the packaging encourages this isn't a high prio issue, so I'm not sure if it is worth the effort and regression risk to backport it to former releases. ** Changed in: mailman (Ubuntu) Status: Triaged => Fix Released ** Changed in: mailman (Debian) Status: New => Fix Released ** Changed in: mailman (Ubuntu Xenial) Status: New => Won't Fix ** Changed in: mailman (Ubuntu Artful) Status: New => Won't Fix ** Changed in: mailman (Ubuntu Zesty) Status: New => Won't Fix -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1696066 Title: Postfix module - Mailman wrapper - Couldn't write data/aliases.db and data/virtual-mailman.db files To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1696066/+subscriptions From 1696066 at bugs.launchpad.net Fri Jun 15 05:13:01 2018 From: 1696066 at bugs.launchpad.net (=?utf-8?b?7oO/IENocmlzdGlhbiBFaHJoYXJkdCDug78=?=) Date: Fri, 15 Jun 2018 09:13:01 -0000 Subject: [Bug 1696066] Re: Postfix module - Mailman wrapper - Couldn't write data/aliases.db and data/virtual-mailman.db files References: <149673486419.28883.14597965095773088289.malonedeb@wampee.canonical.com> Message-ID: <152905398191.1873.14018938152179949255.malone@chaenomeles.canonical.com> I'll be bold and set to Won't Fix to trigger a discussion if people largely disagree. If this really is an important enough issue for the SRU [1] policy, then I'd ask to help and phrase the SRU template accordingly in a way you are convinced that the SRU Team will accept the regression risk for the benefit this change provides. [1]: https://wiki.ubuntu.com/StableReleaseUpdates ** Tags removed: server-next -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1696066 Title: Postfix module - Mailman wrapper - Couldn't write data/aliases.db and data/virtual-mailman.db files To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1696066/+subscriptions From futatuki at poem.co.jp Sat Jun 16 05:52:28 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Sat, 16 Jun 2018 09:52:28 -0000 Subject: [Bug 1777222] [NEW] admindb uses wrong language in subscription approval result page body Message-ID: <152914274823.27266.10863310945877078065.malonedeb@gac.canonical.com> Public bug reported: If * a list allows to use different language from list.preferred_language * its policy requires admin approval for subscribes * it set to send welcome message to new member and admin approves subscription request of user who select his language different from list's on Web UI, the result page body of admindb uses charset of user's language while the header declare to use charset of the lists, thus causes 'Mojibake'. I'm very sorry, but I have not read the code arround it yet, so I report symptom only right now. ** Affects: mailman Importance: Undecided Status: New ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1777222 Title: admindb uses wrong language in subscription approval result page body To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1777222/+subscriptions From futatuki at poem.co.jp Sat Jun 16 07:55:32 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Sat, 16 Jun 2018 11:55:32 -0000 Subject: [Bug 1777222] Re: admindb uses wrong language in subscription approval result page body References: <152914274823.27266.10863310945877078065.malonedeb@gac.canonical.com> Message-ID: <152915013248.25530.7206269053437021454.malone@soybean.canonical.com> This is caused by MailList.ApprovedAddMember(), which is not preserve translation object on sending welcome message by using Deliverer.SendSubscribeAck(). ** Attachment added: "fix_admindb_result_patch.txt" https://bugs.launchpad.net/mailman/+bug/1777222/+attachment/5153279/+files/fix_admindb_result_patch.txt -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1777222 Title: admindb uses wrong language in subscription approval result page body To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1777222/+subscriptions From mark at msapiro.net Sat Jun 16 12:57:32 2018 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 16 Jun 2018 16:57:32 -0000 Subject: [Bug 1777222] Re: admindb uses wrong language in subscription approval result page body References: <152914274823.27266.10863310945877078065.malonedeb@gac.canonical.com> Message-ID: <152916825244.26875.4414558781457601428.malone@gac.canonical.com> Thank you very much for the report and patch. ** Changed in: mailman Importance: Undecided => Medium ** Changed in: mailman Status: New => Fix Committed ** Changed in: mailman Milestone: None => 2.1.27 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1777222 Title: admindb uses wrong language in subscription approval result page body To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1777222/+subscriptions From futatuki at poem.co.jp Sun Jun 17 09:05:34 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Sun, 17 Jun 2018 13:05:34 -0000 Subject: [Merge] lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1 Message-ID: <152924073110.17665.2531914696637916776.launchpad@ackee.canonical.com> Yasuhito FUTATSUKI at POEM has proposed merging lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1. Commit message: i18nize whence candidate message strings Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~futatuki/mailman/i18n-add-whence-to-adminack-templates/+merge/348127 This is a solution of problem left in mp+347992. To mark whence messages for pygettext, I introduced dummy function i18n.D_(s) returns s it self, and then added "-k D_" option to pygettext commandline in messages/Makefile.in. This costs extra function call on execute, for its maintenancebility. I've picked up whence candidate message strings except from bin/add_member, bin/delete_member, and cron/disabled, and tested with ja translation (temporary for test, not included in this proposal). Note: * whence messages for user conformation of subscribe and unsubscribe are inconsistent. For subscribe they are 'via email confirmation' and 'via web confirmation', but for unsubscribe they are 'email confirmation' and 'web confirmation'. * admin approval for unsubscription dosen't report whence because ListAdmin.__handleunsubscription() calls ApproveDeleteMember() without whence option. -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 7477 bytes Desc: not available URL: From futatuki at poem.co.jp Sun Jun 17 09:07:38 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Sun, 17 Jun 2018 13:07:38 -0000 Subject: [Merge] lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1 In-Reply-To: <152924073110.17665.2531914696637916776.launchpad@ackee.canonical.com> Message-ID: <152924085604.8472.5611520580330021710.launchpad@ackee.canonical.com> The proposal to merge lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1 has been updated. Description changed to: This is a solution of problem left in mp+347992. To mark whence messages for pygettext, I introduced dummy function i18n.D_(s) returns s it self, and then added "-k D_" option to pygettext commandline in messages/Makefile.in. This costs extra function call on execute, for its maintenancebility. I've picked up whence candidate message strings except from bin/add_member, bin/delete_member, and cron/disabled, and tested with ja translation (temporary for test, not included in this proposal). Note: * whence messages for user conformation of subscribe and unsubscribe are inconsistent. For subscribe they are 'via email confirmation' and 'via web confirmation', but for unsubscribe they are 'email confirmation' and 'web confirmation'. * admin approval for unsubscription dosen't report whence because ListAdmin.__handleunsubscription() calls ApproveDeleteMember() without whence option. For more details, see: https://code.launchpad.net/~futatuki/mailman/i18n-add-whence-to-adminack-templates/+merge/348127 -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1. From 1777342 at bugs.launchpad.net Sun Jun 17 14:08:08 2018 From: 1777342 at bugs.launchpad.net (WGH) Date: Sun, 17 Jun 2018 18:08:08 -0000 Subject: [Bug 1777342] [NEW] config_list: generated python encoding declaration is erroneously translated Message-ID: <152925888870.26761.15788870868098814177.malonedeb@gac.canonical.com> Public bug reported: config_list script generates Python configuration file. The script has header specified as string constant enclosed into gettext call. In Russian message files, someone translated "coding: %(charset)s" thing into Russian, which is wrong, because Python can only recognize encoding declaration in English. Maybe others translations have similar problem, but I haven't checked. #: bin/config_list:118 msgid "" "# -*- python -*-\n" "# -*- coding: %(charset)s -*-\n" "## \"%(listname)s\" mailing list configuration settings\n" "## captured on %(when)s\n" msgstr "" "# -*- python -*-\n" "# -*- ?????????: %(charset)s -*-\n" "## ????????? ?????? ???????? \"%(listname)s\"\n" "## ?????? ??????? %(when)s\n" ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1777342 Title: config_list: generated python encoding declaration is erroneously translated To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1777342/+subscriptions From 1777342 at bugs.launchpad.net Sun Jun 17 15:32:59 2018 From: 1777342 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Sun, 17 Jun 2018 19:32:59 -0000 Subject: [Bug 1777342] Re: config_list: generated python encoding declaration is erroneously translated References: <152925888870.26761.15788870868098814177.malonedeb@gac.canonical.com> Message-ID: <152926398373.8742.1929357058597926784.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1777342 Title: config_list: generated python encoding declaration is erroneously translated To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1777342/+subscriptions From mark at msapiro.net Sun Jun 17 15:34:42 2018 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 17 Jun 2018 19:34:42 -0000 Subject: [Bug 1777342] Re: config_list: generated python encoding declaration is erroneously translated References: <152925888870.26761.15788870868098814177.malonedeb@gac.canonical.com> Message-ID: <152926408321.7333.18038577846675983637.malone@wampee.canonical.com> I'v fixed this. I looked quickly and I think Russian was the only language that had this issue. ** Changed in: mailman Importance: Undecided => Medium ** Changed in: mailman Status: New => Fix Committed ** Changed in: mailman Milestone: None => 2.1.27 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1777342 Title: config_list: generated python encoding declaration is erroneously translated To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1777342/+subscriptions From futatuki at poem.co.jp Sun Jun 17 18:13:24 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Sun, 17 Jun 2018 22:13:24 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 Message-ID: <152927360190.10769.16649764005544682145.launchpad@ackee.canonical.com> Yasuhito FUTATSUKI at POEM has proposed merging lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. Commit message: Update ja translation up to lp:mailman/2.1 rev.1776 Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-ja-translation/+merge/348130 in messages/ja/LC_MESSAGES/mailman.po * Add translation of whence reasons into ja po file * refine translation of --unknown option description in docstring of cron/disabled in messages/ja/doc/Defaults.py.in * Add translation of comment for BLOCK_SPAMHAUS_LISTED_DBL_SUBSCRIBE in Defaults.py.in * fix corrupted comment -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 5088 bytes Desc: not available URL: From noreply at launchpad.net Sun Jun 17 18:39:58 2018 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sun, 17 Jun 2018 22:39:58 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 In-Reply-To: <152927360190.10769.16649764005544682145.launchpad@ackee.canonical.com> Message-ID: <152927519618.8437.13990990950744224545.launchpad@ackee.canonical.com> The proposal to merge lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-ja-translation/+merge/348130 -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. From futatuki at poem.co.jp Thu Jun 21 18:07:25 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Thu, 21 Jun 2018 22:07:25 -0000 Subject: [Merge] lp:~futatuki/mailman/enhance-i18n-list-overview into lp:mailman/2.1 Message-ID: <152961884300.28936.3881729004412061318.launchpad@ackee.canonical.com> Yasuhito FUTATSUKI at POEM has proposed merging lp:~futatuki/mailman/enhance-i18n-list-overview into lp:mailman/2.1. Commit message: enhance i18n of listinfo/admin overview page Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~futatuki/mailman/enhance-i18n-list-overview/+merge/348365 On listinfo/admin overview page, lists' description may be stored in different charset/encoding from what the page uses. However current implementation of listinfo/admin overview page uses those regardlessly of the difference, so those cannot be displayed correctly. To avoid this, (1) I've implemented a new function to get description as string of specified charset (with XML character reference) in MailList class, MailList.GetDescription(), and use it instead of accessing .description attribute directly in overview functions. This function uses a precondition that .description attribute is stored in charset of list's preferred_language. This is fundamentally true, but in case list's preferred_language has been changed and of the description hasn't, it is not true(Suppose changing preferred_language temporary to edit template files via Web UI, for example). To help to ensure the precondition, (2) I've added hook to change charset of list's description when preferred_language is changed via Web UI. (This is not always preserve identity of description string when preferred_languages is changed one of other charset/encoding and then changed back, because of multiple mapping of character between charset, and intentional use of XML character reference) -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/enhance-i18n-list-overview into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 3318 bytes Desc: not available URL: From mark at msapiro.net Fri Jun 22 12:43:23 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:43:23 -0000 Subject: [Bug 1777342] Re: config_list: generated python encoding declaration is erroneously translated References: <152925888870.26761.15788870868098814177.malonedeb@gac.canonical.com> Message-ID: <152968580410.26643.8427421340842816935.launchpad@gac.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1777342 Title: config_list: generated python encoding declaration is erroneously translated To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1777342/+subscriptions From mark at msapiro.net Fri Jun 22 12:43:13 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:43:13 -0000 Subject: [Bug 1777222] Re: admindb uses wrong language in subscription approval result page body References: <152914274823.27266.10863310945877078065.malonedeb@gac.canonical.com> Message-ID: <152968579451.7333.7514189678291696005.launchpad@wampee.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1777222 Title: admindb uses wrong language in subscription approval result page body To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1777222/+subscriptions From mark at msapiro.net Fri Jun 22 12:44:22 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:44:22 -0000 Subject: [Bug 1775233] Re: Python 2.7 dependency in Utils.banned_ip() References: <152822057791.32332.17469853457378730895.malonedeb@soybean.canonical.com> Message-ID: <152968586321.26226.9512496000335552917.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1775233 Title: Python 2.7 dependency in Utils.banned_ip() To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1775233/+subscriptions From mark at msapiro.net Fri Jun 22 12:44:11 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:44:11 -0000 Subject: [Bug 1774986] Re: mailman-config incorrect quoting in print statement References: <152811667792.32030.17776533431233849580.malonedeb@soybean.canonical.com> Message-ID: <152968585246.26601.11720709577005754015.launchpad@gac.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1774986 Title: mailman-config incorrect quoting in print statement To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1774986/+subscriptions From mark at msapiro.net Fri Jun 22 12:43:03 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:43:03 -0000 Subject: [Bug 1773064] Re: bin/add_members needs an "invite" option. References: <152712952862.28191.6511583714805053719.malonedeb@soybean.canonical.com> Message-ID: <152968578392.26563.14317835238882259048.launchpad@gac.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1773064 Title: bin/add_members needs an "invite" option. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1773064/+subscriptions From mark at msapiro.net Fri Jun 22 12:42:54 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:42:54 -0000 Subject: [Bug 1769374] Re: The reCAPTCHA feature requires JavaScript References: <152553713404.22103.9606281574181604067.malonedeb@soybean.canonical.com> Message-ID: <152968577565.26226.10543396677465843491.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1769374 Title: The reCAPTCHA feature requires JavaScript To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1769374/+subscriptions From mark at msapiro.net Fri Jun 22 12:43:54 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:43:54 -0000 Subject: [Bug 1768892] Re: bin/arch still reports messages in list language/charset References: <152536316404.21887.2225996709470324000.malonedeb@soybean.canonical.com> Message-ID: <152968583576.26681.12956683589674262351.launchpad@gac.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1768892 Title: bin/arch still reports messages in list language/charset To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1768892/+subscriptions From mark at msapiro.net Fri Jun 22 12:42:29 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:42:29 -0000 Subject: [Bug 1762871] Re: Retries of temporary delivery failures can cause excessive activity in OutgoingRunner. References: <152340453446.31818.8466853466889302705.malonedeb@chaenomeles.canonical.com> Message-ID: <152968575047.25456.6970979266034003418.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1762871 Title: Retries of temporary delivery failures can cause excessive activity in OutgoingRunner. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1762871/+subscriptions From mark at msapiro.net Fri Jun 22 12:43:41 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:43:41 -0000 Subject: [Bug 1760506] Re: mm_cfg.py syntax error is handled ungracefully References: <152262509016.29765.1531474203035053036.malonedeb@gac.canonical.com> Message-ID: <152968582233.1873.3766268130531176313.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1760506 Title: mm_cfg.py syntax error is handled ungracefully To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1760506/+subscriptions From mark at msapiro.net Fri Jun 22 12:42:07 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:42:07 -0000 Subject: [Bug 1754516] Re: config_list can set invalid values and break lists. References: <152055224179.7678.6901479882831335797.malonedeb@wampee.canonical.com> Message-ID: <152968572829.27033.12989158718527521571.launchpad@gac.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1754516 Title: config_list can set invalid values and break lists. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1754516/+subscriptions From mark at msapiro.net Fri Jun 22 12:42:17 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:42:17 -0000 Subject: [Bug 1755317] Re: Python 2.7 dependency in Handlers/ToDigests.py References: <152089771354.14987.10288688334563369556.malonedeb@chaenomeles.canonical.com> Message-ID: <152968573952.2108.6508786618213970671.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1755317 Title: Python 2.7 dependency in Handlers/ToDigests.py To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1755317/+subscriptions From mark at msapiro.net Fri Jun 22 12:41:54 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:41:54 -0000 Subject: [Bug 1752658] Re: The reCAPTCHA implementation in Mailman 2.1.26 requires Python 2.7 References: <151992449153.12064.4884074331952287371.malonedeb@gac.canonical.com> Message-ID: <152968571509.26643.17129420409132787840.launchpad@gac.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1752658 Title: The reCAPTCHA implementation in Mailman 2.1.26 requires Python 2.7 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1752658/+subscriptions From mark at msapiro.net Fri Jun 22 12:41:22 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 22 Jun 2018 16:41:22 -0000 Subject: [Bug 1731604] Re: VERP fails if the recipient address local part is quoted. References: <151038163229.934.12641910175503585284.malonedeb@chaenomeles.canonical.com> Message-ID: <152968568302.27152.14166347770919034666.launchpad@gac.canonical.com> ** Changed in: mailman Milestone: 2.1.27 => 2.1.28 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1731604 Title: VERP fails if the recipient address local part is quoted. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1731604/+subscriptions From 1778363 at bugs.launchpad.net Sat Jun 23 17:46:25 2018 From: 1778363 at bugs.launchpad.net (Olivier GERARD) Date: Sat, 23 Jun 2018 21:46:25 -0000 Subject: [Bug 1778363] [NEW] exception (utf8 codec) in pipermail Message-ID: <152979038533.27033.5958097208292576716.malonedeb@gac.canonical.com> Public bug reported: After upgrading Mailman from 2.1.23 to 2.1.26-1 on Debian, things went smoothly, the list's mbox is updated but the archives are not updated. In the error log, one sees, for every message Jun 23 19:59:03 2018 (20419) SHUNTING: 1529776742.660616+f4a3eea82ed27ce3f481064f194162863c62b280 Jun 23 21:35:24 2018 (20419) Uncaught runner exception: 'utf8' codec can't decode byte 0xaa in position 26: invalid start byte Jun 23 21:35:24 2018 (20419) Traceback (most recent call last): File "/var/lib/mailman/Mailman/Queue/Runner.py", line 119, in _oneloop self._onefile(msg, msgdata) File "/var/lib/mailman/Mailman/Queue/Runner.py", line 190, in _onefile keepqueued = self._dispose(mlist, msg, msgdata) File "/var/lib/mailman/Mailman/Queue/ArchRunner.py", line 77, in _dispose mlist.ArchiveMail(msg) File "/var/lib/mailman/Mailman/Archiver/Archiver.py", line 214, in ArchiveMail h.processUnixMailbox(f) File "/var/lib/mailman/Mailman/Archiver/pipermail.py", line 596, in processUnixMailbox self.add_article(a) File "/var/lib/mailman/Mailman/Archiver/pipermail.py", line 640, in add_article author = fixAuthor(article.decoded['author']) File "/var/lib/mailman/Mailman/Archiver/pipermail.py", line 63, in fixAuthor while i>0 and (L[i-1][0] in lowercase or UnicodeDecodeError: 'utf8' codec can't decode byte 0xaa in position 26: invalid start byte This is always the same complaint. I have checked shunted messages and the mbox itself and I have not found any 0xaa value in them. ** Affects: mailman Importance: Undecided Status: New ** Tags: pipermail unicode -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1778363 Title: exception (utf8 codec) in pipermail To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1778363/+subscriptions From mark at msapiro.net Sat Jun 23 18:42:29 2018 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 23 Jun 2018 22:42:29 -0000 Subject: [Bug 1778363] Re: exception (utf8 codec) in pipermail References: <152979038533.27033.5958097208292576716.malonedeb@gac.canonical.com> Message-ID: <152979375010.1951.6078510024984389406.malone@chaenomeles.canonical.com> This may have something to do with the archive database. You can try the script at https://www.msapiro.net/scripts/hddump to dump the database for the affected period with --verbose and look for values of 'author' and 'decoded'['author']. Is there anything unusual in those or anything with a number like 'Doe, John 3rd'. If you can post one of the shunted message files or email it to mark at msapiro.net if you don't want to post it, I'll see if I can duplicate this, but also, please see https://wiki.list.org/x/12812344 . ** Changed in: mailman Status: New => Incomplete ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1778363 Title: exception (utf8 codec) in pipermail To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1778363/+subscriptions From bruce at perens.com Sun Jun 24 02:10:49 2018 From: bruce at perens.com (Bruce Perens) Date: Sun, 24 Jun 2018 06:10:49 -0000 Subject: [Bug 1760506] Re: mm_cfg.py syntax error is handled ungracefully References: <152262509016.29765.1531474203035053036.malonedeb@gac.canonical.com> <152968582233.1873.3766268130531176313.launchpad@chaenomeles.canonical.com> Message-ID: Mark, thanks very much for working on this. Thanks Bruce On Fri, Jun 22, 2018 at 9:43 AM, Mark Sapiro wrote: > ** Changed in: mailman > Status: Fix Committed => Fix Released > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1760506 > > Title: > mm_cfg.py syntax error is handled ungracefully > > Status in GNU Mailman: > Fix Released > > Bug description: > The user left a trailing quote out in mm_cfg.py . Mailman's response > was to fail with the message "Mailman experienced a very low level > failure". Perhaps "low-level failure" was Mailman's opinion of the > user :-) One would hope that we could catch an exception from Python > and give the user a bit more help. Thanks! - Bruce > > To manage notifications about this bug go to: > https://bugs.launchpad.net/mailman/+bug/1760506/+subscriptions > -- Bruce Perens K6BP - CEO, Legal Engineering Standards committee chair, license review committee member, co-founder, Open Source Initiative President, Open Research Institute; Board Member, Fashion Freedom Initiative. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1760506 Title: mm_cfg.py syntax error is handled ungracefully To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1760506/+subscriptions From 1462755 at bugs.launchpad.net Wed Jun 27 05:21:52 2018 From: 1462755 at bugs.launchpad.net (=?utf-8?b?7oO/IENocmlzdGlhbiBFaHJoYXJkdCDug78=?=) Date: Wed, 27 Jun 2018 09:21:52 -0000 Subject: [Bug 1462755] Re: qrunner crashes on invalid unicode sequence References: <20150607142830.12558.37544.malonedeb@soybean.canonical.com> Message-ID: <153009131231.6638.15112704646577253271.malone@soybean.canonical.com> Setting the task for a whishlist item, since it is essentially a config change that breaks it (as Mark said 'shot oneself in the foot'. I'm personally not so keen about on-upgrade detection+warning since that (in general) has a history of too many false-positives leading people to config-break their system without a reason. But then as I read Mark this is due to Debian intentionally changing some encodings, so maybe it should be done ... ** Changed in: mailman (Ubuntu) Status: New => Confirmed ** Changed in: mailman (Ubuntu) Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1462755 Title: qrunner crashes on invalid unicode sequence To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1462755/+subscriptions From futatuki at poem.co.jp Sat Jun 30 05:55:37 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Sat, 30 Jun 2018 09:55:37 -0000 Subject: [Bug 1779445] [NEW] edithtml.py saves en templates using html entity reference with raw iso-8859-1 character Message-ID: <153035253794.18526.5905648585348856237.malonedeb@chaenomeles.canonical.com> Public bug reported: In Mailman's web administrative interface, edithtml page saves en language templates by using iso-8859-1 raw character if the template uses html entity reference like " ". For example, If "General list information page" (templates/en/listinfo.html), which contains  ", has been saved without modification from web UI, the lists template en/listinfo.html will contain raw '\xa0' character. If Adding " in text area and submit changes twice, it will turn into "". I'm not sure the patch attached is a good way to fix it because I don't know these entity reference characters are always ISO-8859-1 character, but for reference. ** Affects: mailman Importance: Undecided Status: New ** Patch added: "edithtml-save-as-ascii-patch.txt" https://bugs.launchpad.net/bugs/1779445/+attachment/5158043/+files/edithtml-save-as-ascii-patch.txt ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1779445 Title: edithtml.py saves en templates using html entity reference with raw iso-8859-1 character To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1779445/+subscriptions