[Bug 1251495] Re: Lists with topics enabled can throw unexpected keyword argument 'Delete' exception.

[ChristianEhrhardt]

** Description changed:

  [Impact]
  
-  * Using Mailman Lists with topics enabled can fail due to a typo
+  * Using Mailman Lists with topics enabled can fail due to a typo
  
-  * Fix is trivial and a backport active in everything >Trusty for quite a 
-    while now
+  * Fix is trivial and a backport active in everything >Trusty for quite a
+    while now
  
  [Test Case]
  
-  * I beg your pardon for not knowing a "live" case to set up, but I think 
-    it is obvious. With packages installed check the argument "Delete" vs 
-    "delete":
- 
+  * Code approach as it is rather obvious. With packages installed check 
+    the argument "Delete" vs
+    "delete":
  # grep -A 2 'change_header('  /usr/lib/mailman/Mailman/Handlers/Tagger.py
-         change_header('X-Topics', NLTAB.join(hits.keys()),
-                       mlist, msg, msgdata, Delete=False)
- 
+         change_header('X-Topics', NLTAB.join(hits.keys()),
+                       mlist, msg, msgdata, Delete=False)
  #  grep -A 2 def /usr/lib/mailman/Mailman/Handlers/CookHeaders.py | grep 'change_header('
  def change_header(name, value, mlist, msg, msgdata, delete=True, repl=True):
  
+   * Use-Case approach:
+     0. do a basic mailman setup
+     1. enable by putting these two lines
+       topics_enabled = 1
+       topics = [('Match_all', '.', 'Topic matches anything for testing', False)]
+       in a file and running Mailman's bin/config_list like:
+       $ bin/config_list -i path/to/file/with/lines list_name
+     2. Then, a post to that list should be delivered normally and contain 
+        a header 'X-Topics: Match_all', but the bug will cause the post to 
+        be shunted.
+     X. With the fixed package that no more happens
+ 
  [Regression Potential]
  
-  * It fixes an obvious broken variable access, but nothing else - so I'd 
-    consider it safe. I don't think any code reaching this line ever worked
-    but if one had a setup awkwardly working while accepting this breakage 
-    he might now get a different behavior.
+  * It fixes an obvious broken variable access, but nothing else - so I'd
+    consider it safe. I don't think any code reaching this line ever worked
+    but if one had a setup awkwardly working while accepting this breakage
+    he might now get a different behavior.
  
  [Other Info]
-  
-  * embarrassingly old
+ 
+  * embarrassingly old
  
  ---
  
- 
- Code added to Tagger.py in 2.1.16 to support the from_is_list Wrap Message option contained a misspelling.
+ Code added to Tagger.py in 2.1.16 to support the from_is_list Wrap
+ Message option contained a misspelling.

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/1251495

Title:
  Lists with topics enabled can throw unexpected keyword argument
  'Delete' exception.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mailman/+bug/1251495/+subscriptions