From mark at msapiro.net Sun Mar 1 07:56:05 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 01 Mar 2015 06:56:05 -0000 Subject: [Bug 1426825] [NEW] CommandRunner throws KeyError References: <20150301065605.20840.58517.malonedeb@soybean.canonical.com> Message-ID: <20150301065605.20840.58517.malonedeb@soybean.canonical.com> Public bug reported: If a message to the list-request contains a line that would be a command but has the command word terminated with a dot, e.g. a line like Help. Please unsubscribe me CommandRunner can throw KeyError. I.e., in this example, it sets modname to 'Mailman.Commands.cmd_help.' and __import__(modname) succeeds, but handler = sys.modules[modname] then throws KeyError because of the trailing dot. ** Affects: mailman Importance: Low Assignee: Mark Sapiro (msapiro) Status: In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1426825 Title: CommandRunner throws KeyError To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1426825/+subscriptions From 1426825 at bugs.launchpad.net Sun Mar 1 08:06:17 2015 From: 1426825 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Sun, 01 Mar 2015 07:06:17 -0000 Subject: [Bug 1426825] Re: CommandRunner throws KeyError References: <20150301065605.20840.58517.malonedeb@soybean.canonical.com> Message-ID: <20150301070617.7525.28048.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1426825 Title: CommandRunner throws KeyError To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1426825/+subscriptions From mark at msapiro.net Sun Mar 1 08:06:47 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 01 Mar 2015 07:06:47 -0000 Subject: [Bug 1426825] Re: CommandRunner throws KeyError References: <20150301065605.20840.58517.malonedeb@soybean.canonical.com> Message-ID: <20150301070648.12907.32840.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: In Progress => Fix Committed ** Changed in: mailman Milestone: None => 2.1.20 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1426825 Title: CommandRunner throws KeyError To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1426825/+subscriptions From mark at msapiro.net Sun Mar 1 09:16:22 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 01 Mar 2015 08:16:22 -0000 Subject: [Bug 1426829] [NEW] CommandRunner can look too far for command words. References: <20150301081622.20216.35182.malonedeb@wampee.canonical.com> Message-ID: <20150301081622.20216.35182.malonedeb@wampee.canonical.com> Public bug reported: If a message to the list-request address contains a valid command without an Re: or similar prefix in the subject, CommandRunner can pop the first word off the first body line in searching for additional commands in the body. ** Affects: mailman Importance: Low Assignee: Mark Sapiro (msapiro) Status: In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1426829 Title: CommandRunner can look too far for command words. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1426829/+subscriptions From ankprashar at gmail.com Sun Mar 1 09:57:24 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Sun, 01 Mar 2015 08:57:24 -0000 Subject: [Bug 1425359] Re: 500 error code shown by postorius instead of 409 error code References: <20150225025413.24385.93661.malonedeb@wampee.canonical.com> Message-ID: <20150301085725.19734.9072.launchpad@wampee.canonical.com> ** Description changed: When a new mailman subscriber is created with the email of an already existing mailman subscriber or user a `409` code with a message `user already exists` is returned by the postorius but when the same email but now case sensitive is used a `500` code with message `server error code` is returned. The latter should also return a `409` instead of `500` as it is misleading. - - Although the mailman core is giving `AssertionError: User should have - had linked address` in both the cases`. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1425359 Title: 500 error code shown by postorius instead of 409 error code To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1425359/+subscriptions From 1426829 at bugs.launchpad.net Sun Mar 1 17:35:51 2015 From: 1426829 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Sun, 01 Mar 2015 16:35:51 -0000 Subject: [Bug 1426829] Re: CommandRunner can look too far for command words. References: <20150301081622.20216.35182.malonedeb@wampee.canonical.com> Message-ID: <20150301163551.7525.10141.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1426829 Title: CommandRunner can look too far for command words and 'Subject: Re: Command is case sensitive. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1426829/+subscriptions From mark at msapiro.net Sun Mar 1 17:40:16 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 01 Mar 2015 16:40:16 -0000 Subject: [Bug 1426829] Re: CommandRunner can look too far for command words. References: <20150301081622.20216.35182.malonedeb@wampee.canonical.com> Message-ID: <20150301164017.17292.27381.launchpad@gac.canonical.com> ** Description changed: If a message to the list-request address contains a valid command - without an Re: or similar prefix in the subject, CommandRunner can pop - the first word off the first body line in searching for additional - commands in the body. + without an Re: or similar prefix in the subject or a subject with fewer + than two words, CommandRunner can pop the first word off the first body + line in searching for additional commands in the body. + + Also, commands in the Subject: with an Re: prefix are case sensitive. ** Summary changed: - CommandRunner can look too far for command words. + CommandRunner can look too far for command words and 'Subject: Re: Command is case sensitive. ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1426829 Title: CommandRunner can look too far for command words and 'Subject: Re: Command is case sensitive. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1426829/+subscriptions From mark at msapiro.net Mon Mar 2 22:22:46 2015 From: mark at msapiro.net (Mark Sapiro) Date: Mon, 02 Mar 2015 21:22:46 -0000 Subject: [Bug 1427389] [NEW] SpamDetect throws LookupError if a message has an RFC 2047 encoded header with an unknown encoding. References: <20150302212246.19837.33553.malonedeb@wampee.canonical.com> Message-ID: <20150302212246.19837.33553.malonedeb@wampee.canonical.com> Public bug reported: The SpamDetect.py module in the handler pipeline attempts to get the text of all the message headers encoded in the character set of the list's preferred_language in order to test header_filter_rules. If a header is RFC 2047 encoded in an unknown character set, the LookupError is thrown. ** Affects: mailman Importance: Medium Assignee: Mark Sapiro (msapiro) Status: In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1427389 Title: SpamDetect throws LookupError if a message has an RFC 2047 encoded header with an unknown encoding. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1427389/+subscriptions From 1427389 at bugs.launchpad.net Mon Mar 2 22:51:18 2015 From: 1427389 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Mon, 02 Mar 2015 21:51:18 -0000 Subject: [Bug 1427389] Re: SpamDetect throws LookupError if a message has an RFC 2047 encoded header with an unknown encoding. References: <20150302212246.19837.33553.malonedeb@wampee.canonical.com> Message-ID: <20150302215119.21632.25698.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1427389 Title: SpamDetect throws LookupError if a message has an RFC 2047 encoded header with an unknown encoding. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1427389/+subscriptions From mark at msapiro.net Mon Mar 2 22:51:32 2015 From: mark at msapiro.net (Mark Sapiro) Date: Mon, 02 Mar 2015 21:51:32 -0000 Subject: [Bug 1427389] Re: SpamDetect throws LookupError if a message has an RFC 2047 encoded header with an unknown encoding. References: <20150302212246.19837.33553.malonedeb@wampee.canonical.com> Message-ID: <20150302215133.21027.8229.launchpad@soybean.canonical.com> ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1427389 Title: SpamDetect throws LookupError if a message has an RFC 2047 encoded header with an unknown encoding. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1427389/+subscriptions From akash.agrawall094 at gmail.com Mon Mar 2 23:05:31 2015 From: akash.agrawall094 at gmail.com (Akash Agrawall) Date: Mon, 02 Mar 2015 22:05:31 -0000 Subject: [Bug 881316] Re: RuntimeError: maximum recursion depth exceeded while pickling an object References: <20111025090301.27890.71203.malonedeb@soybean.canonical.com> Message-ID: <20150302220531.13196.21439.launchpad@chaenomeles.canonical.com> ** Description changed: With mailman 3.0.0a8. - I got the following traceback from a html mail with html signature+image from Outlook, - Oct 14 09:21:31 2011 (17579) Traceback (most recent call last): - File "/home/zope/mailman/src/mailman/core/runner.py", line 138, in _one_iteration - self._process_one_file(msg, msgdata) - File "/home/zope/mailman/src/mailman/core/runner.py", line 220, in _process_one_file - keepqueued = self._dispose(mlist, msg, msgdata) - File "/home/zope/mailman/src/mailman/runners/incoming.py", line 64, in _dispose - process(mlist, msg, msgdata, mlist.start_chain) - File "/home/zope/mailman/src/mailman/core/chains.py", line 90, in process - link.function(mlist, msg, msgdata) - File "/home/zope/mailman/src/mailman/chains/hold.py", line 245, in _process - nmsg.send(mlist, **dict(tomoderators=True)) - File "/home/zope/mailman/src/mailman/email/message.py", line 198, in send - self._enqueue(mlist, **_kws) - File "/home/zope/mailman/src/mailman/email/message.py", line 216, in _enqueue - virginq.enqueue(self, **str_keywords) - File "/home/zope/mailman/src/mailman/core/switchboard.py", line 133, in enqueue - msgsave = cPickle.dumps(_msg, protocol) + I got the following traceback from a html mail with html signature+image from Outlook, + Oct 14 09:21:31 2011 (17579) Traceback (most recent call last): + ??File "/home/zope/mailman/src/mailman/core/runner.py", line 138, in _one_iteration + ????self._process_one_file(msg, msgdata) + ??File "/home/zope/mailman/src/mailman/core/runner.py", line 220, in _process_one_file + ????keepqueued = self._dispose(mlist, msg, msgdata) + ??File "/home/zope/mailman/src/mailman/runners/incoming.py", line 64, in _dispose + ????process(mlist, msg, msgdata, mlist.start_chain) + ??File "/home/zope/mailman/src/mailman/core/chains.py", line 90, in process + ????link.function(mlist, msg, msgdata) + ??File "/home/zope/mailman/src/mailman/chains/hold.py", line 245, in _process + ????nmsg.send(mlist, **dict(tomoderators=True)) + ??File "/home/zope/mailman/src/mailman/email/message.py", line 198, in send + ????self._enqueue(mlist, **_kws) + ??File "/home/zope/mailman/src/mailman/email/message.py", line 216, in _enqueue + ????virginq.enqueue(self, **str_keywords) + ??File "/home/zope/mailman/src/mailman/core/switchboard.py", line 133, in enqueue + ????msgsave = cPickle.dumps(_msg, protocol) RuntimeError: maximum recursion depth exceeded while pickling an object It's really an obscure issue for me. I resolved it by adding - sys.setrecursionlimit(10000) - in src/mailman/core/switchboard.py - before - msgsave = cPickle.dumps(_msg, protocol) + sys.setrecursionlimit(10000) + in src/mailman/core/switchboard.py + before + msgsave = cPickle.dumps(_msg, protocol) line 134 and doing bin/mailman unshunt fixed the issue. By default sys.getrecursionlimit() returns 1000. If you want to have a test email to reproduce, I can ask my customer to send an email to a test mailing-list. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/881316 Title: RuntimeError: maximum recursion depth exceeded while pickling an object To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/881316/+subscriptions From akash.agrawall094 at gmail.com Mon Mar 2 23:13:29 2015 From: akash.agrawall094 at gmail.com (Akash Agrawall) Date: Mon, 02 Mar 2015 22:13:29 -0000 Subject: [Bug 265920] Re: "/" is a valid e-mail address character References: <20080905192707.27052.9083.launchpad@forster.canonical.com> Message-ID: <20150302221330.20898.44194.launchpad@soybean.canonical.com> ** Changed in: mailman Assignee: (unassigned) => Akash Agrawall (akash-agrawall094) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/265920 Title: "/" is a valid e-mail address character To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/265920/+subscriptions From mark at msapiro.net Tue Mar 3 02:35:35 2015 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 03 Mar 2015 01:35:35 -0000 Subject: [Bug 265920] Re: "/" is a valid e-mail address character References: <20080905192707.27052.9083.launchpad@forster.canonical.com> Message-ID: <20150303013535.20249.59342.malone@wampee.canonical.com> This was fixed in Mailman 2.1.6. Note that strictly speaking any printable ascii character is allowed in e-mail address local-parts if quoted, and we don't actually parse the local part to determine if it or characters within it are quoted, so there may be email addresses which are technically valid which we don't accept, but we have no plans to for further changes in this area. ** Changed in: mailman Status: New => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/265920 Title: "/" is a valid e-mail address character To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/265920/+subscriptions From noreply at launchpad.net Tue Mar 3 03:34:40 2015 From: noreply at launchpad.net (noreply at launchpad.net) Date: Tue, 03 Mar 2015 02:34:40 -0000 Subject: [Merge] lp:~raj-abhilash1/mailman/docs-fix into lp:mailman In-Reply-To: <20150218050920.20327.35608.launchpad@ackee.canonical.com> Message-ID: <20150303023439.9415.27120.launchpad@ackee.canonical.com> The proposal to merge lp:~raj-abhilash1/mailman/docs-fix into lp:mailman has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raj-abhilash1/mailman/docs-fix/+merge/250092 -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/mailman/docs-fix into lp:mailman. From sambuddhabasu1 at gmail.com Tue Mar 3 23:27:34 2015 From: sambuddhabasu1 at gmail.com (Sambuddha Basu) Date: Tue, 03 Mar 2015 22:27:34 -0000 Subject: [Merge] lp:~sambuddhabasu1/mailman/fix_mailman_run_error into lp:mailman Message-ID: <20150303222733.5655.43303.launchpad@ackee.canonical.com> Sambuddha Basu has proposed merging lp:~sambuddhabasu1/mailman/fix_mailman_run_error into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~sambuddhabasu1/mailman/fix_mailman_run_error/+merge/251667 The error message that showed up on running 'mailman start' was: /usr/bin/python3: can't open file '/usr/bin/master': [Errno 2] No such file or directory This was caused as the file was searching for '/usr/bin/master' which is not present. Rather it should search for '/usr/local/bin/master'. -- Your team Mailman Coders is requested to review the proposed merge of lp:~sambuddhabasu1/mailman/fix_mailman_run_error into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 596 bytes Desc: not available URL: From andrew.stuart at supercoders.com.au Tue Mar 3 23:43:26 2015 From: andrew.stuart at supercoders.com.au (Andrew Stuart) Date: Tue, 03 Mar 2015 22:43:26 -0000 Subject: [Bug 1427890] [NEW] attempting to delete mailing list or domain gives sqlalchemy error References: <20150303224327.13335.13801.malonedeb@chaenomeles.canonical.com> Message-ID: <20150303224327.13335.13801.malonedeb@chaenomeles.canonical.com> Public bug reported: The Mailman database seems to get into a state in which it is not possible to delete my test mailing list and test domain. I figure it is something to do with the database state but I can?t see what at this stage. ###########################################################################################################################Attempting to delete a domain gives sqlalchemy error ######################################################################################## curl -X DELETE --verbose --header "authorization: Basic cmVzdGFkbWluOnJlc3RwYXNz" http://localhost:8001/3.0/domains/mail.example.org Traceback (most recent call last): File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 951, in _execute_context context) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/default.py", line 436, in do_execute cursor.execute(statement, parameters) sqlite3.IntegrityError: NOT NULL constraint failed: acceptablealias.mailing_list_id The above exception was the direct cause of the following exception: Traceback (most recent call last): File "/usr/lib/python3.4/wsgiref/handlers.py", line 137, in run self.result = application(self.environ, self.start_response) File "/home/ubuntu/mailman/src/mailman/database/transaction.py", line 57, in wrapper config.db.commit() File "/home/ubuntu/mailman/src/mailman/database/base.py", line 56, in commit self.store.commit() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 776, in commit self.transaction.commit() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 377, in commit self._prepare_impl() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 357, in _prepare_impl self.session.flush() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 1919, in flush self._flush(objects) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 2037, in _flush transaction.rollback(_capture_exception=True) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/langhelpers.py", line 60, in __exit__ compat.reraise(exc_type, exc_value, exc_tb) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 182, in reraise raise value File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 2001, in _flush flush_context.execute() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/unitofwork.py", line 372, in execute rec.execute(self) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/unitofwork.py", line 526, in execute uow File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/persistence.py", line 60, in save_obj mapper, table, update) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/persistence.py", line 518, in _emit_update_statements execute(statement, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 729, in execute return meth(self, multiparams, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/sql/elements.py", line 322, in _execute_on_connection return connection._execute_clauseelement(self, multiparams, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 826, in _execute_clauseelement compiled_sql, distilled_params File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 958, in _execute_context context) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 1159, in _handle_dbapi_exception exc_info File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 188, in raise_from_cause reraise(type(exception), exception, tb=exc_tb, cause=exc_value) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 181, in reraise raise value.with_traceback(tb) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 951, in _execute_context context) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/default.py", line 436, in do_execute cursor.execute(statement, parameters) sqlalchemy.exc.IntegrityError: (IntegrityError) NOT NULL constraint failed: acceptablealias.mailing_list_id 'UPDATE acceptablealias SET mailing_list_id=? WHERE acceptablealias.id = ?' (None, 1) ###########################################################################################################################Attempting to delete a mailing list gives sqlalchemy error ######################################################################################## curl -X DELETE --verbose --header "authorization: Basic cmVzdGFkbWluOnJlc3RwYXNz" http://localhost:8001/3.0/lists/testlist1.mail.example.org Traceback (most recent call last): File "/usr/lib/python3.4/wsgiref/handlers.py", line 137, in run self.result = application(self.environ, self.start_response) File "/home/ubuntu/mailman/src/mailman/database/transaction.py", line 56, in wrapper rtn = function(*args, **kws) File "/home/ubuntu/mailman/src/mailman/rest/wsgiapp.py", line 62, in __call__ environ, start_response) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/falcon/api.py", line 175, in __call__ responder(req, resp, **params) File "/home/ubuntu/mailman/src/mailman/rest/lists.py", line 145, in on_delete remove_list(self._mlist) File "/home/ubuntu/mailman/src/mailman/app/lifecycle.py", line 101, in remove_list call_name(config.mta.incoming).delete(mlist) File "/home/ubuntu/mailman/src/mailman/mta/postfix.py", line 69, in create self.regenerate() File "/home/ubuntu/mailman/src/mailman/mta/postfix.py", line 83, in regenerate self._generate_lmtp_file(fp) File "/home/ubuntu/mailman/src/mailman/mta/postfix.py", line 116, in _generate_lmtp_file for list_name, mail_host in list_manager.name_components: File "/home/ubuntu/mailman/src/mailman/model/listmanager.py", line 119, in name_components MailingList.list_name): File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/query.py", line 1011, in values return iter(q) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/query.py", line 2437, in __iter__ self.session._autoflush() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 1208, in _autoflush util.raise_from_cause(e) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 188, in raise_from_cause reraise(type(exception), exception, tb=exc_tb, cause=exc_value) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 182, in reraise raise value File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 1198, in _autoflush self.flush() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 1919, in flush self._flush(objects) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 2037, in _flush transaction.rollback(_capture_exception=True) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/langhelpers.py", line 60, in __exit__ compat.reraise(exc_type, exc_value, exc_tb) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 182, in reraise raise value File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 2001, in _flush flush_context.execute() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/unitofwork.py", line 372, in execute rec.execute(self) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/unitofwork.py", line 526, in execute uow File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/persistence.py", line 60, in save_obj mapper, table, update) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/persistence.py", line 518, in _emit_update_statements execute(statement, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 729, in execute return meth(self, multiparams, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/sql/elements.py", line 322, in _execute_on_connection return connection._execute_clauseelement(self, multiparams, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 826, in _execute_clauseelement compiled_sql, distilled_params File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 958, in _execute_context context) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 1159, in _handle_dbapi_exception exc_info File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 188, in raise_from_cause reraise(type(exception), exception, tb=exc_tb, cause=exc_value) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 181, in reraise raise value.with_traceback(tb) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 951, in _execute_context context) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/default.py", line 436, in do_execute cursor.execute(statement, parameters) sqlalchemy.exc.IntegrityError: (raised as a result of Query-invoked autoflush; consider using a session.no_autoflush block if this flush is occurring prematurely) (IntegrityError) NOT NULL constraint failed: acceptablealias.mailing_list_id 'UPDATE acceptablealias SET mailing_list_id=? WHERE acceptablealias.id = ?' (None, 1) ########################################################################################This is the database at the time of the errors - note I have had to remove an accumulation of UID and preferences INSERTS. ######################################################################################## PRAGMA foreign_keys=OFF; BEGIN TRANSACTION; CREATE TABLE pended ( id INTEGER NOT NULL, token VARCHAR, expiration_date DATETIME, PRIMARY KEY (id) ); CREATE TABLE preferences ( id INTEGER NOT NULL, acknowledge_posts BOOLEAN, hide_address BOOLEAN, preferred_language VARCHAR, receive_list_copy BOOLEAN, receive_own_postings BOOLEAN, delivery_mode INTEGER, delivery_status INTEGER, PRIMARY KEY (id), CHECK (acknowledge_posts IN (0, 1)), CHECK (hide_address IN (0, 1)), CHECK (receive_list_copy IN (0, 1)), CHECK (receive_own_postings IN (0, 1)) ); CREATE TABLE domain ( id INTEGER NOT NULL, mail_host VARCHAR, base_url VARCHAR, description VARCHAR, contact_address VARCHAR, PRIMARY KEY (id) ); INSERT INTO "domain" VALUES(1,'mail.example.org','http://mail.example.org',NULL,'postmaster at mail.example.org'); CREATE TABLE message ( id INTEGER NOT NULL, message_id VARCHAR, message_id_hash VARCHAR, path VARCHAR, PRIMARY KEY (id) ); CREATE TABLE mailinglist ( id INTEGER NOT NULL, list_name VARCHAR, mail_host VARCHAR, list_id VARCHAR, allow_list_posts BOOLEAN, include_rfc2369_headers BOOLEAN, advertised BOOLEAN, anonymous_list BOOLEAN, created_at DATETIME, next_request_id INTEGER, next_digest_number INTEGER, digest_last_sent_at DATETIME, volume INTEGER, last_post_at DATETIME, accept_these_nonmembers BLOB, admin_immed_notify BOOLEAN, admin_notify_mchanges BOOLEAN, administrivia BOOLEAN, archive_policy INTEGER, autoresponse_grace_period DATETIME, autorespond_owner INTEGER, autoresponse_owner_text VARCHAR, autorespond_postings INTEGER, autoresponse_postings_text VARCHAR, autorespond_requests INTEGER, autoresponse_request_text VARCHAR, filter_action INTEGER, filter_content BOOLEAN, collapse_alternatives BOOLEAN, convert_html_to_plaintext BOOLEAN, bounce_info_stale_after DATETIME, bounce_matching_headers VARCHAR, bounce_notify_owner_on_disable BOOLEAN, bounce_notify_owner_on_removal BOOLEAN, bounce_score_threshold INTEGER, bounce_you_are_disabled_warnings INTEGER, bounce_you_are_disabled_warnings_interval DATETIME, forward_unrecognized_bounces_to INTEGER, process_bounces BOOLEAN, default_member_action INTEGER, default_nonmember_action INTEGER, description VARCHAR, digest_footer_uri VARCHAR, digest_header_uri VARCHAR, digest_is_default BOOLEAN, digest_send_periodic BOOLEAN, digest_size_threshold FLOAT, digest_volume_frequency INTEGER, digestable BOOLEAN, discard_these_nonmembers BLOB, emergency BOOLEAN, encode_ascii_prefixes BOOLEAN, first_strip_reply_to BOOLEAN, footer_uri VARCHAR, forward_auto_discards BOOLEAN, gateway_to_mail BOOLEAN, gateway_to_news BOOLEAN, goodbye_message_uri VARCHAR, header_matches BLOB, header_uri VARCHAR, hold_these_nonmembers BLOB, info VARCHAR, linked_newsgroup VARCHAR, max_days_to_hold INTEGER, max_message_size INTEGER, max_num_recipients INTEGER, member_moderation_notice VARCHAR, mime_is_default_digest BOOLEAN, moderator_password BLOB, newsgroup_moderation INTEGER, nntp_prefix_subject_too BOOLEAN, nondigestable BOOLEAN, nonmember_rejection_notice VARCHAR, obscure_addresses BOOLEAN, owner_chain VARCHAR, owner_pipeline VARCHAR, personalize INTEGER, post_id INTEGER, posting_chain VARCHAR, posting_pipeline VARCHAR, preferred_language VARCHAR, display_name VARCHAR, reject_these_nonmembers BLOB, reply_goes_to_list INTEGER, reply_to_address VARCHAR, require_explicit_destination BOOLEAN, respond_to_post_requests BOOLEAN, scrub_nondigest BOOLEAN, send_goodbye_message BOOLEAN, send_welcome_message BOOLEAN, subject_prefix VARCHAR, topics BLOB, topics_bodylines_limit INTEGER, topics_enabled BOOLEAN, welcome_message_uri VARCHAR, PRIMARY KEY (id), CHECK (allow_list_posts IN (0, 1)), CHECK (include_rfc2369_headers IN (0, 1)), CHECK (advertised IN (0, 1)), CHECK (anonymous_list IN (0, 1)), CHECK (admin_immed_notify IN (0, 1)), CHECK (admin_notify_mchanges IN (0, 1)), CHECK (administrivia IN (0, 1)), CHECK (filter_content IN (0, 1)), CHECK (collapse_alternatives IN (0, 1)), CHECK (convert_html_to_plaintext IN (0, 1)), CHECK (bounce_notify_owner_on_disable IN (0, 1)), CHECK (bounce_notify_owner_on_removal IN (0, 1)), CHECK (process_bounces IN (0, 1)), CHECK (digest_is_default IN (0, 1)), CHECK (digest_send_periodic IN (0, 1)), CHECK (digestable IN (0, 1)), CHECK (emergency IN (0, 1)), CHECK (encode_ascii_prefixes IN (0, 1)), CHECK (first_strip_reply_to IN (0, 1)), CHECK (forward_auto_discards IN (0, 1)), CHECK (gateway_to_mail IN (0, 1)), CHECK (gateway_to_news IN (0, 1)), CHECK (mime_is_default_digest IN (0, 1)), CHECK (nntp_prefix_subject_too IN (0, 1)), CHECK (nondigestable IN (0, 1)), CHECK (obscure_addresses IN (0, 1)), CHECK (require_explicit_destination IN (0, 1)), CHECK (respond_to_post_requests IN (0, 1)), CHECK (scrub_nondigest IN (0, 1)), CHECK (send_goodbye_message IN (0, 1)), CHECK (send_welcome_message IN (0, 1)), CHECK (topics_enabled IN (0, 1)) ); INSERT INTO "mailinglist" VALUES(1,'testlist1','mail.example.org','testlist1.mail.example.org',0,0,0,1,'2015-03-01 20:04:21.186669',1,1,NULL,1,NULL,X'80049503000000000000005D942E',0,1,0,0,'1970-02-15 00:00:00.000000',1,'the owner',2,'the mailing list',1,'the robot',2,1,0,1,'1970-01-08 00:00:00.000000',' # Lines that *start* with a ''#'' are comments. to: friend at public.com message-id: relay.comanche.denmark.eu from: list at listme.com from: .*@uplinkpro.com ',1,1,5,3,'1970-01-08 00:00:00.000000',1,1,0,2,'This is my mailing list','mailman:///$listname/$language/footer-generic.txt',NULL,0,1,10.5,1,1,X'80049503000000000000005D942E',0,0,1,'mailman:///$listname/$language/footer-generic.txt',1,0,0,'',X'80049503000000000000005D942E',NULL,X'80049503000000000000005D942E','','',0,40,10,'',0,NULL,0,1,1,'',1,'default-owner-chain','default-owner-pipeline',0,1,'default-posting-chain','virgin','en','Fnords',X'80049503000000000000005D942E',1,'bee at example.com',1,1,0,1,0,'[ant]',X'80049503000000000000005D942E',5,0,'mailman:///welcome.txt'); CREATE TABLE bounceevent ( id INTEGER NOT NULL, list_id VARCHAR, email VARCHAR, timestamp DATETIME, message_id VARCHAR, context INTEGER, processed BOOLEAN, PRIMARY KEY (id), CHECK (processed IN (0, 1)) ); INSERT INTO "bounceevent" VALUES(1,'testlist1.mail.example.org','testuser1 at mail.example.org','2015-03-01 20:01:54.950333','<20150301200153.A950280974 at ip-10-223-10-27.us-west-1.compute.internal>',1,0); INSERT INTO "bounceevent" VALUES(2,'testlist1.mail.example.org','testuser1 at mail.example.org','2015-03-01 20:01:56.083932','<20150301200155.C229880974 at ip-10-223-10-27.us-west-1.compute.internal>',1,0); INSERT INTO "bounceevent" VALUES(3,'testlist1.mail.example.org','testuser1 at mail.example.org','2015-03-01 20:02:20.319257','<20150301200219.244BE80974 at ip-10-223-10-27.us-west-1.compute.internal>',1,0); INSERT INTO "bounceevent" VALUES(4,'testlist1.mail.example.org','testuser1 at mail.example.org','2015-03-01 20:03:14.618731','<20150301200313.BD8E180974 at ip-10-223-10-27.us-west-1.compute.internal>',1,0); CREATE TABLE uid ( id INTEGER NOT NULL, uid CHAR(32), PRIMARY KEY (id) ); CREATE TABLE ban ( id INTEGER NOT NULL, email VARCHAR, list_id VARCHAR, PRIMARY KEY (id) ); CREATE TABLE user ( id INTEGER NOT NULL, display_name VARCHAR, password VARCHAR, _user_id CHAR(32), _created_on DATETIME, _preferred_address_id INTEGER, preferences_id INTEGER, PRIMARY KEY (id), FOREIGN KEY(preferences_id) REFERENCES preferences (id) ); INSERT INTO "user" VALUES(1,'Server Owner','$6$rounds=101751$cOyechNgTQqeyfTJ$2lHEhtTCYTUuQ37CkZ/ncyptVRW3I9T61WxW8BV6sbzMa2KDJBoU6uRpiWyowbtVej.QTZnL9Ww0YXXM3lPdb/','4e0a784aeaa84b37b0e731aef00683aa','2015-03-01 20:00:41.531120',NULL,2); INSERT INTO "user" VALUES(2,'test user 1','$6$rounds=90188$eLE.L0U2hfbpa9QG$SKzS7PNvGiEvPjKSTDjG5PgDtIvsjARyt6HOtia24zT3eT3w99TCuXlL2ZrL.t7B3xLxX4PuWTolrjd1lZ6Qg.','23856abb3f414114b9cfde92d9557ecb','2015-03-01 20:00:58.143566',NULL,34); INSERT INTO "user" VALUES(4,'','$6$rounds=94146$ydwCyzFScrDi8mJt$Ia4w6zMnEdePdWvm3vuBrn8d0MpWstdmN0mLtImqJ3k/aLaEkZShgw.0aZU4Q7eh1sTuxUAtY7SLkSOWYj0RN.','c5e5dfd8a11e439a868cba6bdedc966e','2015-03-01 20:01:20.944564',NULL,92); CREATE TABLE listarchiver ( id INTEGER NOT NULL, mailing_list_id INTEGER NOT NULL, name VARCHAR NOT NULL, _is_enabled BOOLEAN, PRIMARY KEY (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id), CHECK (_is_enabled IN (0, 1)) ); INSERT INTO "listarchiver" VALUES(1,1,'prototype',1); INSERT INTO "listarchiver" VALUES(2,1,'mail-archive',1); INSERT INTO "listarchiver" VALUES(3,1,'mhonarc',1); CREATE TABLE acceptablealias ( id INTEGER NOT NULL, mailing_list_id INTEGER NOT NULL, alias VARCHAR NOT NULL, PRIMARY KEY (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id) ); INSERT INTO "acceptablealias" VALUES(1,1,'one at example.com'); INSERT INTO "acceptablealias" VALUES(2,1,'two at example.com'); CREATE TABLE pendedkeyvalue ( id INTEGER NOT NULL, "key" VARCHAR, value VARCHAR, pended_id INTEGER, PRIMARY KEY (id), FOREIGN KEY(pended_id) REFERENCES pended (id) ); CREATE TABLE contentfilter ( id INTEGER NOT NULL, mailing_list_id INTEGER, filter_type INTEGER, filter_pattern VARCHAR, PRIMARY KEY (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id) ); CREATE TABLE _request ( id INTEGER NOT NULL, "key" VARCHAR, request_type INTEGER, data_hash VARCHAR, mailing_list_id INTEGER, PRIMARY KEY (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id) ); CREATE TABLE address ( id INTEGER NOT NULL, email VARCHAR, _original VARCHAR, display_name VARCHAR, verified_on DATETIME, registered_on DATETIME, user_id INTEGER, preferences_id INTEGER, PRIMARY KEY (id), FOREIGN KEY(user_id) REFERENCES user (id), FOREIGN KEY(preferences_id) REFERENCES preferences (id) ); INSERT INTO "address" VALUES(1,'theboss at mail.example.org',NULL,'Server Owner',NULL,'2015-03-01 20:00:41.530793',1,1); CREATE TABLE autoresponserecord ( id INTEGER NOT NULL, address_id INTEGER, mailing_list_id INTEGER, response_type INTEGER, date_sent DATE, PRIMARY KEY (id), FOREIGN KEY(address_id) REFERENCES address (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id) ); CREATE TABLE onelastdigest ( id INTEGER NOT NULL, mailing_list_id INTEGER, address_id INTEGER, delivery_mode INTEGER, PRIMARY KEY (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id), FOREIGN KEY(address_id) REFERENCES address (id) ); CREATE TABLE member ( id INTEGER NOT NULL, _member_id CHAR(32), role INTEGER, list_id VARCHAR, moderation_action INTEGER, address_id INTEGER, preferences_id INTEGER, user_id INTEGER, PRIMARY KEY (id), FOREIGN KEY(address_id) REFERENCES address (id), FOREIGN KEY(preferences_id) REFERENCES preferences (id), FOREIGN KEY(user_id) REFERENCES user (id) ); CREATE TABLE alembic_version ( version_num VARCHAR(32) NOT NULL ); INSERT INTO "alembic_version" VALUES('33e1f5f6fa8'); CREATE INDEX ix_uid_uid ON uid (uid); CREATE INDEX ix_user_preferences_id ON user (preferences_id); CREATE INDEX ix_user__user_id ON user (_user_id); CREATE INDEX ix_listarchiver_mailing_list_id ON listarchiver (mailing_list_id); CREATE INDEX ix_acceptablealias_mailing_list_id ON acceptablealias (mailing_list_id); CREATE INDEX ix_acceptablealias_alias ON acceptablealias (alias); CREATE INDEX ix_pendedkeyvalue_pended_id ON pendedkeyvalue (pended_id); CREATE INDEX ix_contentfilter_mailing_list_id ON contentfilter (mailing_list_id); CREATE INDEX ix__request_mailing_list_id ON _request (mailing_list_id); CREATE INDEX ix_address_user_id ON address (user_id); CREATE INDEX ix_address_preferences_id ON address (preferences_id); CREATE INDEX ix_autoresponserecord_address_id ON autoresponserecord (address_id); CREATE INDEX ix_autoresponserecord_mailing_list_id ON autoresponserecord (mailing_list_id); COMMIT; ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1427890 Title: attempting to delete mailing list or domain gives sqlalchemy error To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1427890/+subscriptions From 2013165 at iiitdmj.ac.in Wed Mar 4 05:21:01 2015 From: 2013165 at iiitdmj.ac.in (Rashi Karanpuria) Date: Wed, 04 Mar 2015 04:21:01 -0000 Subject: [Bug 1427979] [NEW] Documentation mistake References: <20150304042101.17031.44512.malonedeb@gac.canonical.com> Message-ID: <20150304042101.17031.44512.malonedeb@gac.canonical.com> Public bug reported: In DOCS https://pythonhosted.org/mailman/src/mailman/model/docs/mlist-addresses.html below Mailing list addresses, It should be *The leave (a.k.a. unsubscribe) address is where someone can email to get removed from the mailing list.* instead of *The leave (a.k.a. unsubscribe) address is where someone can email to get added to the mailing list. * ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1427979 Title: Documentation mistake To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1427979/+subscriptions From 2013165 at iiitdmj.ac.in Wed Mar 4 05:33:35 2015 From: 2013165 at iiitdmj.ac.in (Rashi Karanpuria) Date: Wed, 04 Mar 2015 04:33:35 -0000 Subject: [Bug 1427979] Re: Documentation mistake References: <20150304042101.17031.44512.malonedeb@gac.canonical.com> Message-ID: <20150304043335.21337.45783.malone@soybean.canonical.com> Hi, uploading the diff file for the fix. ** Patch added: "mlist-addresses.diff" https://bugs.launchpad.net/mailman/+bug/1427979/+attachment/4334047/+files/mlist-addresses.diff -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1427979 Title: Documentation mistake To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1427979/+subscriptions From 1427979 at bugs.launchpad.net Wed Mar 4 05:35:53 2015 From: 1427979 at bugs.launchpad.net (Barry Warsaw) Date: Wed, 04 Mar 2015 04:35:53 -0000 Subject: [Bug 1427979] Re: Documentation mistake References: <20150304042101.17031.44512.malonedeb@gac.canonical.com> Message-ID: <20150304043553.20216.2183.launchpad@wampee.canonical.com> ** Tags added: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1427979 Title: Documentation mistake To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1427979/+subscriptions From ankprashar at gmail.com Wed Mar 4 05:50:52 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Wed, 04 Mar 2015 04:50:52 -0000 Subject: [Bug 1425359] Re: 500 error code shown by postorius instead of 409 error code References: <20150225025413.24385.93661.malonedeb@wampee.canonical.com> Message-ID: <20150304045053.12978.40727.launchpad@chaenomeles.canonical.com> ** Description changed: When a new mailman subscriber is created with the email of an already existing mailman subscriber or user a `409` code with a message `user already exists` is returned by the postorius but when the same email but now case sensitive is used a `500` code with message `server error code` is returned. The latter should also return a `409` instead of `500` as it is misleading. + + Bug discussed in detail at : https://mail.python.org/pipermail/mailman- + developers/2015-March/024474.html ** Description changed: + Bug discussed in detail at : https://mail.python.org/pipermail/mailman- + developers/2015-March/024474.html + When a new mailman subscriber is created with the email of an already existing mailman subscriber or user a `409` code with a message `user - already exists` is returned by the postorius but when the same email but - now case sensitive is used a `500` code with message `server error code` - is returned. + already exists` is returned by the Mailman REST API but when the same + email but now case sensitive is used a `500` code with message `server + error code` is returned. The latter should also return a `409` instead of `500` as it is misleading. - - Bug discussed in detail at : https://mail.python.org/pipermail/mailman- - developers/2015-March/024474.html -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1425359 Title: 500 error code shown by postorius instead of 409 error code To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1425359/+subscriptions From ankprashar at gmail.com Wed Mar 4 10:38:37 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Wed, 04 Mar 2015 09:38:37 -0000 Subject: [Bug 1425359] Re: 500 error code shown by postorius instead of 409 error code References: <20150225025413.24385.93661.malonedeb@wampee.canonical.com> Message-ID: <20150304093838.13165.20317.launchpad@chaenomeles.canonical.com> ** Branch linked: lp:~black-perl/mailman/fix-mailman -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1425359 Title: 500 error code shown by postorius instead of 409 error code To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1425359/+subscriptions From ankprashar at gmail.com Wed Mar 4 10:47:24 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Wed, 04 Mar 2015 09:47:24 -0000 Subject: [Merge] lp:~black-perl/mailman/fix-mailman into lp:mailman Message-ID: <20150304094721.16320.2265.launchpad@ackee.canonical.com> Ankush Sharma has proposed merging lp:~black-perl/mailman/fix-mailman into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1425359 in GNU Mailman: "500 error code shown by postorius instead of 409 error code" https://bugs.launchpad.net/mailman/+bug/1425359 For more details, see: https://code.launchpad.net/~black-perl/mailman/fix-mailman/+merge/251709 Discussed here https://mail.python.org/pipermail/mailman-developers/2015-March/024474.html about the bug and its fix. Added test to call mailman REST api using case sensitive email address in 'test_try_to_join_a_list_twice' method. -- Your team Mailman Coders is requested to review the proposed merge of lp:~black-perl/mailman/fix-mailman into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1394 bytes Desc: not available URL: From rohanjaswal2507 at gmail.com Wed Mar 4 11:57:31 2015 From: rohanjaswal2507 at gmail.com (Rohan Jaswal) Date: Wed, 04 Mar 2015 10:57:31 -0000 Subject: [Bug 1104497] Re: User profile pages References: <20130124220831.20714.28903.malonedeb@wampee.canonical.com> Message-ID: <20150304105731.17393.1912.malone@gac.canonical.com> What I learn from description is: we need following things. which are- 1. user profile page for web UI 2. page should contain personal information[1] 3. list all the posts by that user [1] what kind of personal information is expected there, apart form Name and e-mail? One more question, Is there any pre-decided style scheme for the interface? -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1104497 Title: User profile pages To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1104497/+subscriptions From nilmadhab1994 at gmail.com Wed Mar 4 13:58:28 2015 From: nilmadhab1994 at gmail.com (nilmadhab mondal) Date: Wed, 04 Mar 2015 12:58:28 -0000 Subject: [Bug 1414352] Re: Improve code coverage by adding tests References: <20150124193353.29200.98953.malonedeb@gac.canonical.com> Message-ID: <20150304125829.17186.60398.launchpad@gac.canonical.com> ** Changed in: postorius Assignee: (unassigned) => nilmadhab mondal (nilmadhab1994) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1414352 Title: Improve code coverage by adding tests To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1414352/+subscriptions From godricglow at gmail.com Wed Mar 4 14:08:13 2015 From: godricglow at gmail.com (Pranjal Yadav) Date: Wed, 04 Mar 2015 13:08:13 -0000 Subject: [Bug 1414352] Re: Improve code coverage by adding tests References: <20150124193353.29200.98953.malonedeb@gac.canonical.com> Message-ID: <20150304130814.13196.11479.malone@chaenomeles.canonical.com> Hi florain I modified tests for forms and currently at 52% coverage. I'm testing on views and I'll try to move it up to 55% soon. Will be sending a pull req soon -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1414352 Title: Improve code coverage by adding tests To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1414352/+subscriptions From godricglow at gmail.com Wed Mar 4 14:57:22 2015 From: godricglow at gmail.com (Pranjal Yadav) Date: Wed, 04 Mar 2015 13:57:22 -0000 Subject: [Merge] lp:~godricglow/postorius/tests_forms into lp:postorius Message-ID: <20150304135722.17489.78748.launchpad@ackee.canonical.com> Pranjal Yadav has proposed merging lp:~godricglow/postorius/tests_forms into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~godricglow/postorius/tests_forms/+merge/251740 Added tests for forms.py. Improving overall coverage -- Your team Mailman Coders is requested to review the proposed merge of lp:~godricglow/postorius/tests_forms into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 6988 bytes Desc: not available URL: From ankprashar at gmail.com Wed Mar 4 16:38:27 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Wed, 04 Mar 2015 15:38:27 -0000 Subject: [Merge] lp:~black-perl/postorius/fix-postorius into lp:postorius Message-ID: <20150304153824.11803.91718.launchpad@ackee.canonical.com> Ankush Sharma has proposed merging lp:~black-perl/postorius/fix-postorius into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1428169 in Postorius: "`client` not present in the scope of the interpreter invoked by doing `python manage.py mmclient`" https://bugs.launchpad.net/postorius/+bug/1428169 For more details, see: https://code.launchpad.net/~black-perl/postorius/fix-postorius/+merge/251761 Added the `client` to the globals() dictionary before invoking the python interpreter. This would fix up things for the systems on which ipython is not present and therefore default python interpreter is invoked. -- Your team Mailman Coders is requested to review the proposed merge of lp:~black-perl/postorius/fix-postorius into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 493 bytes Desc: not available URL: From 2013165 at iiitdmj.ac.in Thu Mar 5 06:02:30 2015 From: 2013165 at iiitdmj.ac.in (Rashi Karanpuria) Date: Thu, 05 Mar 2015 05:02:30 -0000 Subject: [Merge] lp:~rashi007/mailman/mailman into lp:mailman Message-ID: <20150305050224.31869.1137.launchpad@ackee.canonical.com> Rashi Karanpuria has proposed merging lp:~rashi007/mailman/mailman into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~rashi007/mailman/mailman/+merge/251870 Switchboard.py changed by solving bug #1165589 -- Your team Mailman Coders is requested to review the proposed merge of lp:~rashi007/mailman/mailman into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 592 bytes Desc: not available URL: From ankprashar at gmail.com Thu Mar 5 09:42:23 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Thu, 05 Mar 2015 08:42:23 -0000 Subject: [Merge] lp:~black-perl/postorius/fix-postorius-typo into lp:postorius Message-ID: <20150305084222.23344.66792.launchpad@ackee.canonical.com> Ankush Sharma has proposed merging lp:~black-perl/postorius/fix-postorius-typo into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1428543 in Postorius: "Typos in the postorius code which potentially can lead to unwanted code cascading problems." https://bugs.launchpad.net/postorius/+bug/1428543 For more details, see: https://code.launchpad.net/~black-perl/postorius/fix-postorius-typo/+merge/251879 Fixed the code for the spelling errors. -- Your team Mailman Coders is requested to review the proposed merge of lp:~black-perl/postorius/fix-postorius-typo into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1783 bytes Desc: not available URL: From ankprashar at gmail.com Thu Mar 5 09:46:53 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Thu, 05 Mar 2015 08:46:53 -0000 Subject: [Bug 1425359] Re: 500 error code shown by postorius instead of 409 error code References: <20150225025413.24385.93661.malonedeb@wampee.canonical.com> Message-ID: <20150305084654.6493.80086.launchpad@wampee.canonical.com> ** Tags added: postorius -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1425359 Title: 500 error code shown by postorius instead of 409 error code To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1425359/+subscriptions From bhavesh.goyal093 at gmail.com Thu Mar 5 10:32:24 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Thu, 05 Mar 2015 09:32:24 -0000 Subject: [Merge] lp:~bhavesh-goyal093/mailman/Fixed_Bug into lp:mailman Message-ID: <20150305093221.3164.833.launchpad@ackee.canonical.com> Bhavesh Goyal has proposed merging lp:~bhavesh-goyal093/mailman/Fixed_Bug into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~bhavesh-goyal093/mailman/Fixed_Bug/+merge/251886 Fixed Bug # #1425359 which caused postorius to show 500 error code instead of 409 when same but case sensitive email addresses are entered into subscription list. Earlier : 500 error code when email addresses such as xyz at gmail.com and xyz at Gmail.com are entered which are same Now: 409 error code in both cases since they are same -- Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/mailman/Fixed_Bug into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 798 bytes Desc: not available URL: From aanandshekhar007 at gmail.com Thu Mar 5 12:00:38 2015 From: aanandshekhar007 at gmail.com (aanand0071) Date: Thu, 05 Mar 2015 11:00:38 -0000 Subject: [Merge] lp:~aanand071/mailman/mailman into lp:mailman Message-ID: <20150305110036.26077.51348.launchpad@ackee.canonical.com> aanand0071 has proposed merging lp:~aanand071/mailman/mailman into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~aanand071/mailman/mailman/+merge/251897 Added patch for bug #967951 -- Your team Mailman Coders is requested to review the proposed merge of lp:~aanand071/mailman/mailman into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1153 bytes Desc: not available URL: From 2013001 at iiitdmj.ac.in Thu Mar 5 12:21:25 2015 From: 2013001 at iiitdmj.ac.in (Aanand) Date: Thu, 05 Mar 2015 11:21:25 -0000 Subject: [Merge] lp:~aanand0071/mailman/967951 into lp:mailman Message-ID: <20150305112123.31505.41369.launchpad@ackee.canonical.com> Aanand has proposed merging lp:~aanand0071/mailman/967951 into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~aanand0071/mailman/967951/+merge/251906 Added patch for bug #967591 -- Your team Mailman Coders is requested to review the proposed merge of lp:~aanand0071/mailman/967951 into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1286 bytes Desc: not available URL: From 2013001 at iiitdmj.ac.in Thu Mar 5 12:21:28 2015 From: 2013001 at iiitdmj.ac.in (Aanand) Date: Thu, 05 Mar 2015 11:21:28 -0000 Subject: [Merge] lp:~aanand0071/postorius/postorius into lp:postorius Message-ID: <20150305112127.31505.44896.launchpad@ackee.canonical.com> Aanand has proposed merging lp:~aanand0071/postorius/postorius into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~aanand0071/postorius/postorius/+merge/251907 Added test_list_delete.py -- Your team Mailman Coders is requested to review the proposed merge of lp:~aanand0071/postorius/postorius into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 3218 bytes Desc: not available URL: From coolyashish at gmail.com Thu Mar 5 13:46:34 2015 From: coolyashish at gmail.com (Ashish) Date: Thu, 05 Mar 2015 12:46:34 -0000 Subject: [Bug 1104498] Re: Member contact requests References: <20130124220904.6802.86776.malonedeb@soybean.canonical.com> Message-ID: <20150305124634.12297.9353.malone@gac.canonical.com> >From the description, I think we need to provide a request form to any mailman user to request any profile (whose email address is hidden) . Through the request, We will send an email to recepient. In request form , What fields should be present. I am able to come up with two fileds message and subject of email. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1104498 Title: Member contact requests To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1104498/+subscriptions From bhavesh.goyal093 at gmail.com Thu Mar 5 14:28:34 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Thu, 05 Mar 2015 13:28:34 -0000 Subject: [Merge] lp:~bhavesh-goyal093/postorius/postorius-ui-fix into lp:postorius Message-ID: <20150305132833.32135.37016.launchpad@ackee.canonical.com> Bhavesh Goyal has proposed merging lp:~bhavesh-goyal093/postorius/postorius-ui-fix into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~bhavesh-goyal093/postorius/postorius-ui-fix/+merge/251932 Subscription Based Preferences page in postorius had badly aligned radio buttons which mislead the user to selecting incorrect choices and affected UI of postorius too. Now the radio buttons are correctly aligned vertically (displayed in a listed view)rather than in an unordered fashion. -- Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/postorius-ui-fix into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1174 bytes Desc: not available URL: From bhavesh.goyal093 at gmail.com Thu Mar 5 15:00:24 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Thu, 05 Mar 2015 14:00:24 -0000 Subject: [Merge] lp:~bhavesh-goyal093/postorius/postorius-ui-fix into lp:postorius In-Reply-To: <20150305132833.32135.37016.launchpad@ackee.canonical.com> Message-ID: <20150305140023.14929.39642.launchpad@ackee.canonical.com> The proposal to merge lp:~bhavesh-goyal093/postorius/postorius-ui-fix into lp:postorius has been updated. Description changed to: Subscription Based Preferences page in postorius had badly aligned radio buttons which mislead the user to selecting incorrect choices and affected UI of postorius too. Now the radio buttons are correctly aligned vertically (displayed in a listed view)rather than in an unordered fashion. Also, the mailing list settings forms are now cleaner in the sense that earlier the width was uneven which affected the overall look of postorius, now all forms are of same width and ui looks better in overall For more details, see: https://code.launchpad.net/~bhavesh-goyal093/postorius/postorius-ui-fix/+merge/251932 -- Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/postorius-ui-fix into lp:postorius. From raj.abhilash1 at gmail.com Thu Mar 5 15:28:23 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Thu, 05 Mar 2015 14:28:23 -0000 Subject: [Merge] lp:~raj-abhilash1/postorius/postorius_standalone into lp:postorius Message-ID: <20150305142823.16006.62468.launchpad@ackee.canonical.com> Abhilash Raj has proposed merging lp:~raj-abhilash1/postorius/postorius_standalone into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~raj-abhilash1/postorius/postorius_standalone/+merge/251949 Replace django-social-auth with django-browserid for python3 compatibility. -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/postorius/postorius_standalone into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 9153 bytes Desc: not available URL: From raj.abhilash1 at gmail.com Thu Mar 5 15:28:27 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Thu, 05 Mar 2015 14:28:27 -0000 Subject: [Merge] lp:~raj-abhilash1/postorius/browserid into lp:postorius Message-ID: <20150305142826.16006.12802.launchpad@ackee.canonical.com> Abhilash Raj has proposed merging lp:~raj-abhilash1/postorius/browserid into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~raj-abhilash1/postorius/browserid/+merge/251950 Replace django-social-auth with django-browserid for python3 compatibility. -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/postorius/browserid into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 4847 bytes Desc: not available URL: From raj.abhilash1 at gmail.com Thu Mar 5 15:30:40 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Thu, 05 Mar 2015 14:30:40 -0000 Subject: [Merge] lp:~raj-abhilash1/postorius/postorius_standalone into lp:~mailman-coders/postorius/postorius_standalone Message-ID: <20150305143040.18095.57645.launchpad@ackee.canonical.com> Abhilash Raj has proposed merging lp:~raj-abhilash1/postorius/postorius_standalone into lp:~mailman-coders/postorius/postorius_standalone. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~raj-abhilash1/postorius/postorius_standalone/+merge/251951 Replace django-social-auth with django-browserid for python3 compatibility. -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/postorius/postorius_standalone into lp:~mailman-coders/postorius/postorius_standalone. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 2745 bytes Desc: not available URL: From ankprashar at gmail.com Thu Mar 5 10:47:18 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Thu, 05 Mar 2015 09:47:18 -0000 Subject: [Merge] lp:~bhavesh-goyal093/mailman/Fixed_Bug into lp:mailman In-Reply-To: <20150305093221.3164.833.launchpad@ackee.canonical.com> Message-ID: <20150305094718.10930.86178.codereview@soybean.canonical.com> Already fixed this up a few hours ago https://code.launchpad.net/~black-perl/mailman/fix-mailman . -- https://code.launchpad.net/~bhavesh-goyal093/mailman/Fixed_Bug/+merge/251886 Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/mailman/Fixed_Bug into lp:mailman. From prakash.gbpec at gmail.com Thu Mar 5 17:03:25 2015 From: prakash.gbpec at gmail.com (Prakash Kumar) Date: Thu, 05 Mar 2015 16:03:25 -0000 Subject: [Merge] lp:~prakash09/mailman/3.0 into lp:mailman Message-ID: <20150305160322.9444.39695.launchpad@ackee.canonical.com> Prakash Kumar has proposed merging lp:~prakash09/mailman/3.0 into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~prakash09/mailman/3.0/+merge/251968 Path for starting the mailman in src/mailman/docs/START.rst(line no.-196,197,198) was not correct. Earlier it was "bin/mailman start" which was causing the confusing as both "src/mailman/" and folder created by virtualenv has a folder named bin. I changed the path "bin/mailman start" to "/tmp/mm3/bin/mailman start" which do not cause the confusion. -- Your team Mailman Coders is requested to review the proposed merge of lp:~prakash09/mailman/3.0 into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 816 bytes Desc: not available URL: From bhavesh.goyal093 at gmail.com Fri Mar 6 07:04:20 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Fri, 06 Mar 2015 06:04:20 -0000 Subject: [Bug 1166911] Re: domain option for `bin/mailman lists` doesn't work as expected References: <20130409171303.27875.70181.malonedeb@soybean.canonical.com> Message-ID: <20150306060420.10930.24806.malone@soybean.canonical.com> The Bug was a small typo in cli_lists file. The correct attribute name was 'domain'(corrected in proposed branch) instead of 'domains'(as in original version) This correction in typo solves the bug and the bug may be marked as closed. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1166911 Title: domain option for `bin/mailman lists` doesn't work as expected To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1166911/+subscriptions From bhavesh.goyal093 at gmail.com Fri Mar 6 08:23:24 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Fri, 06 Mar 2015 07:23:24 -0000 Subject: [Merge] lp:~bhavesh-goyal093/postorius/postorius-list_nav-fix into lp:postorius Message-ID: <20150306072323.21099.51397.launchpad@ackee.canonical.com> Bhavesh Goyal has proposed merging lp:~bhavesh-goyal093/postorius/postorius-list_nav-fix into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~bhavesh-goyal093/postorius/postorius-list_nav-fix/+merge/252064 Fixed Postorius Bug #1428966 which caused member options page to show up unwanted piece of info in list_nav. The fix has been made by adding an empty space to the nav address instead of a null string which caused the bug to arise. Now the postorius UI is updated and looks better overall. -- Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/postorius-list_nav-fix into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1996 bytes Desc: not available URL: From coolyashish at gmail.com Fri Mar 6 12:40:42 2015 From: coolyashish at gmail.com (Ashish) Date: Fri, 06 Mar 2015 11:40:42 -0000 Subject: [Merge] lp:~coolyashish/postorius/postorius into lp:postorius Message-ID: <20150306114042.22934.24928.launchpad@ackee.canonical.com> Ashish has proposed merging lp:~coolyashish/postorius/postorius into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~coolyashish/postorius/postorius/+merge/252088 -- Your team Mailman Coders is requested to review the proposed merge of lp:~coolyashish/postorius/postorius into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 3063 bytes Desc: not available URL: From 558234 at bugs.launchpad.net Fri Mar 6 14:53:32 2015 From: 558234 at bugs.launchpad.net (jaromil) Date: Fri, 06 Mar 2015 13:53:32 -0000 Subject: [Bug 558234] Re: Addition of canonical list name References: <20100408090819.1687.70867.launchpad@loganberry.canonical.com> Message-ID: <20150306135333.10626.23632.malone@soybean.canonical.com> Premise: I haven't tried your suggestion of using , I have tried the patch above and it works. If the issue is about confusion as you mention, then if should be documented. This bug prevents people to link to mailinglist archives of mailman, to run their own fora. I think this is important enough to move forward towards any proposed solution that works, rather than a stalled debate lasting more than one year. I don't see any documentation for this, but reading the code of mailman at least this variable becomes self explanatory. In case really works the same, then please submit a patch adding a comment to the file, so that it is intelligible. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/558234 Title: Addition of canonical list name To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/558234/+subscriptions From yashmehrotra95 at gmail.com Fri Mar 6 15:24:44 2015 From: yashmehrotra95 at gmail.com (Yash) Date: Fri, 06 Mar 2015 14:24:44 -0000 Subject: [Bug 967951] Re: The LMTP runner should reject messages with duplicate Message-IDs References: <20120329030405.10615.26178.malonedeb@soybean.canonical.com> Message-ID: <20150306142444.29656.42585.malone@chaenomeles.canonical.com> hi, I am new here and would like to work on this bug. Can you please help me get started -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/967951 Title: The LMTP runner should reject messages with duplicate Message-IDs To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/967951/+subscriptions From 2013165 at iiitdmj.ac.in Fri Mar 6 16:19:47 2015 From: 2013165 at iiitdmj.ac.in (Rashi Karanpuria) Date: Fri, 06 Mar 2015 15:19:47 -0000 Subject: [Bug 1427979] Re: Documentation mistake References: <20150304042101.17031.44512.malonedeb@gac.canonical.com> Message-ID: <20150306151947.6095.48507.launchpad@wampee.canonical.com> ** Branch linked: lp:~rashi007/mailman/mailman ** Changed in: mailman Assignee: (unassigned) => Rashi Karanpuria (rashi007) ** Changed in: mailman Status: New => In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1427979 Title: Documentation mistake To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1427979/+subscriptions From 2013001 at iiitdmj.ac.in Fri Mar 6 16:20:08 2015 From: 2013001 at iiitdmj.ac.in (Aanand) Date: Fri, 06 Mar 2015 15:20:08 -0000 Subject: [Bug 1414352] Re: Improve code coverage by adding tests References: <20150124193353.29200.98953.malonedeb@gac.canonical.com> Message-ID: <20150306152008.29156.49268.launchpad@chaenomeles.canonical.com> ** Branch linked: lp:~aanand0071/postorius/postorius -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1414352 Title: Improve code coverage by adding tests To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1414352/+subscriptions From 2013165 at iiitdmj.ac.in Fri Mar 6 16:17:25 2015 From: 2013165 at iiitdmj.ac.in (Rashi Karanpuria) Date: Fri, 06 Mar 2015 15:17:25 -0000 Subject: [Bug 1165589] Re: Switchboard fails to log the error message with some exceptions. References: <20130407001403.10398.36355.malonedeb@gac.canonical.com> Message-ID: <20150306151727.11777.18825.launchpad@gac.canonical.com> ** Changed in: mailman/3.0 Assignee: (unassigned) => Rashi Karanpuria (rashi007) ** Branch linked: lp:~rashi007/mailman/mailman ** Changed in: mailman/3.0 Status: Triaged => Fix Committed ** Changed in: mailman/3.0 Status: Fix Committed => In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions From 2013001 at iiitdmj.ac.in Fri Mar 6 16:12:19 2015 From: 2013001 at iiitdmj.ac.in (Aanand) Date: Fri, 06 Mar 2015 15:12:19 -0000 Subject: [Bug 967951] Re: The LMTP runner should reject messages with duplicate Message-IDs References: <20120329030405.10615.26178.malonedeb@soybean.canonical.com> Message-ID: <20150306151220.10998.63625.launchpad@soybean.canonical.com> ** Changed in: mailman Assignee: (unassigned) => Aanand (aanand0071) ** Changed in: mailman Status: Confirmed => In Progress ** Branch linked: lp:~aanand0071/mailman/967951 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/967951 Title: The LMTP runner should reject messages with duplicate Message-IDs To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/967951/+subscriptions From bhavesh.goyal093 at gmail.com Fri Mar 6 07:01:51 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Fri, 06 Mar 2015 06:01:51 -0000 Subject: [Merge] lp:~mgill25/mailman/mailman into lp:mailman In-Reply-To: <20130409171820.29351.89295.launchpad@ackee.canonical.com> Message-ID: <20150306060150.29559.94026.codereview@chaenomeles.canonical.com> The Bug was a small typo in cli_lists file. The correct attribute name was 'domain'(corrected in proposed branch) instead of 'domains'(as in original version) This correction in typo solves the bug and the bug may be marked as closed. -- https://code.launchpad.net/~mgill25/mailman/mailman/+merge/157920 Your team Mailman Coders is requested to review the proposed merge of lp:~mgill25/mailman/mailman into lp:mailman. From mark at msapiro.net Fri Mar 6 17:30:12 2015 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 06 Mar 2015 16:30:12 -0000 Subject: [Bug 558234] Re: Addition of canonical list name References: <20100408090819.1687.70867.launchpad@loganberry.canonical.com> Message-ID: <20150306163013.8422.29129.malone@chaenomeles.canonical.com> No patch is required to use . That's the point. The patch attached to this report adds the tag to be usable in html templates to be replaced by the list's real_name converted to lower case. But, the tag is already recognized and is replaced by the list's internal name which is the same thing. It happens to be called 'mm-email-user' because it is the username portion of the list's posting email address. If you were to just use the tag in a template instead of installing the patch and using , the result is the same. If you want me to add a comment to a file, please tell me exactly what you want added to what file. ** Changed in: mailman Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/558234 Title: Addition of canonical list name To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/558234/+subscriptions From ankprashar at gmail.com Sat Mar 7 11:10:37 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Sat, 07 Mar 2015 10:10:37 -0000 Subject: [Bug 1429366] [NEW] Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Public bug reported: The hash(#) is a valid character as far as the local part of the email addresses is concerned. So, as the mailing list addresses are email addresses too, we can use # in the list names too. And, in context with mailman it works well. We can create a list with list_id sam#hashed.host.org for the address sam#hashed at host.org . This works fine. But it makes the list_id to contain the hash character and therefore the REST endpoint for retrieving list wise info becomes invalid, i.e : /lists/sam#hashed.host.org Because in an URL the stuff after # is treated as document starting point i.e an id identifier or something of a dom element. This is not a valid PATH for the server. Therefore the falcon wsgi request object does not contain information of that and the req.path simply returns sam as the list_id ( http://bazaar.launchpad.net/~mailman-coders/mailman/3.0/view/head:/src/mailman/rest/wsgiapp.py#L65 ) giving a 404 because there is no any list with list id sam. The mailman client works fine, it sends a GET to lists/sam#hashed.host.org. This causes the REST end points which needs list_id to return 404 or in worse we can have a list_id clash between ids sam#XXXXX and sam. Further more if the list_id starts with a # character then the server finds list_id to be empty string and therefore we get a KEY ERROR because fqdn_listname is not set too. The bug highly effects postorius too. The lists index template at /postorius/lists/ cannot be rendered as it uses the former REST endpoint and again a 404 is given. And, until we delete this list from the database, we cann't do anything except of getting a 404 and KEY ERROR each time. As far as security is concerned, if an another user created a public list using a hash character, then public list indexing would also fail. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 postorius -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From ankprashar at gmail.com Sat Mar 7 11:26:44 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Sat, 07 Mar 2015 10:26:44 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150307102645.21000.84518.launchpad@gac.canonical.com> ** Description changed: - The hash(#) is a valid character as far as the local part of the email addresses is concerned. So, as the mailing list addresses are email addresses too, we can use # in the list names too. And, in context with mailman it works well. We can create a list with list_id sam#hashed.host.org for the address sam#hashed at host.org . This works fine. But it makes the list_id to contain the hash character and therefore the REST endpoint for retrieving list wise info becomes invalid, i.e : - + The hash(#) is a valid character as far as the local part of the email + addresses is concerned. So, as the mailing list addresses are email + addresses too, we can use # in the list names too. And, in context with + mailman it works well. We can create a list with list_id + sam#hashed.host.org for the address sam#hashed at host.org . This works + fine. But it makes the list_id to contain the hash character and + therefore the REST endpoint for retrieving list wise info becomes + invalid, i.e : + /lists/sam#hashed.host.org Because in an URL the stuff after # is treated as document starting point i.e an id identifier or something of a dom element. This is not a valid PATH for the server. Therefore the falcon wsgi request object does not contain information of that and the req.path simply returns sam as the list_id ( http://bazaar.launchpad.net/~mailman-coders/mailman/3.0/view/head:/src/mailman/rest/wsgiapp.py#L65 ) giving a 404 because there is no any list with list id sam. - The mailman client works fine, it sends a GET to lists/sam#hashed.host.org. + The mailman client works fine, it sends a GET to lists/sam#hashed.host.org. - This causes the REST end points which needs list_id to return 404 or in worse we can have a list_id clash between ids sam#XXXXX and sam. Further more if the list_id starts with a # character then the server finds list_id to be empty string and therefore we get a KEY ERROR because fqdn_listname is not set too. The bug highly effects postorius too. The lists index template at /postorius/lists/ cannot be rendered as it uses the former REST endpoint and again a 404 is given. And, until we delete this list from the database, we cann't do anything except of getting a 404 and KEY ERROR each time. + This causes the REST end points which needs list_id to return 404 or in worse we can have a list_id clash between ids sam#XXXXX and sam. Further more if the list_id starts with a # character then the server finds list_id to be empty string and therefore we get a KEY ERROR because fqdn_listname is not set too. The bug highly effects postorius too. The lists index template at /postorius/lists/ cannot be rendered as it uses the former REST endpoint and again a 404 is given. And, until we delete this list from the database, we can't do anything except of getting a 404 and KEY ERROR each time. As far as security is concerned, if an another user created a public list using a hash character, then public list indexing would also fail. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From ankprashar at gmail.com Sat Mar 7 11:40:06 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Sat, 07 Mar 2015 10:40:06 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150307104006.21031.33191.launchpad@gac.canonical.com> ** Also affects: postorius Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From bhavesh.goyal093 at gmail.com Sat Mar 7 12:54:24 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Sat, 07 Mar 2015 11:54:24 -0000 Subject: [Merge] lp:~bhavesh-goyal093/postorius/postorius-fix-ui into lp:postorius Message-ID: <20150307115421.7968.34759.launchpad@ackee.canonical.com> Bhavesh Goyal has proposed merging lp:~bhavesh-goyal093/postorius/postorius-fix-ui into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~bhavesh-goyal093/postorius/postorius-fix-ui/+merge/252202 Subscription Based Preferences page in postorius had wrongly aligned radio buttons which mislead the user to selecting incorrect choices and affected UI of postorius too. Now the radio buttons are correctly aligned vertically rather than in an unordered fashion. Also, the mailing list settings forms are now cleaner in the sense that earlier the width of class element 'well' was uneven which affected the overall look of postorius, now all forms are of same width and ui looks better in overall -- Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/postorius-fix-ui into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 2760 bytes Desc: not available URL: From mark at msapiro.net Sun Mar 8 02:14:04 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 08 Mar 2015 01:14:04 -0000 Subject: [Bug 266809] Re: Feature Request: Admin change subscriber's e-mail References: <20080905194252.1806.16257.launchpad@forster.canonical.com> Message-ID: <20150308011404.21031.87777.malone@gac.canonical.com> This has recently come up on the mailman-users list, and I realize the obvious way to do it is just add a 'change member address' category under Membership Management.... Or possibly add a 'new address' text box to the Membership List pages. I'll consider this for the next release. ** Changed in: mailman Status: New => Triaged ** Changed in: mailman Milestone: None => 2.1.20 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/266809 Title: Feature Request: Admin change subscriber's e-mail To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/266809/+subscriptions From prakash.gbpec at gmail.com Sun Mar 8 08:25:52 2015 From: prakash.gbpec at gmail.com (Prakash Kumar) Date: Sun, 08 Mar 2015 07:25:52 -0000 Subject: [Merge] lp:~prakash09/mailman/3.0 into lp:mailman In-Reply-To: <20150305160322.9444.39695.launchpad@ackee.canonical.com> Message-ID: <20150308072551.2580.61818.launchpad@ackee.canonical.com> The proposal to merge lp:~prakash09/mailman/3.0 into lp:mailman has been updated. Description changed to: Path for starting the mailman in src/mailman/docs/START.rst(line no.-196,197,198) was not correct. Earlier it was "bin/mailman start" which was causing the confusing as both "src/mailman/" and folder created by virtualenv has a folder named bin. I changed the path "bin/mailman start" to "/tmp/mm3/bin/mailman start" which do not cause the confusion. Added test for registration of odd email addresses. Bug(https://bugs.launchpad.net/mailman/+bug/266288) For more details, see: https://code.launchpad.net/~prakash09/mailman/3.0/+merge/251968 -- Your team Mailman Coders is requested to review the proposed merge of lp:~prakash09/mailman/3.0 into lp:mailman. From coolyashish at gmail.com Sun Mar 8 11:25:31 2015 From: coolyashish at gmail.com (Ashish) Date: Sun, 08 Mar 2015 10:25:31 -0000 Subject: [Merge] lp:~coolyashish/mailman.client/mailman.client into lp:mailman.client Message-ID: <20150308102530.28687.69731.launchpad@ackee.canonical.com> Ashish has proposed merging lp:~coolyashish/mailman.client/mailman.client into lp:mailman.client. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~coolyashish/mailman.client/mailman.client/+merge/252213 -- Your team Mailman Coders is requested to review the proposed merge of lp:~coolyashish/mailman.client/mailman.client into lp:mailman.client. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 460 bytes Desc: not available URL: From ankprashar at gmail.com Sun Mar 8 12:05:23 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Sun, 08 Mar 2015 11:05:23 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150308110523.21031.65830.malone@gac.canonical.com> Anyone got into trouble after replication of this bug can refer here : https://gist.github.com/black-perl/b5a36089ed9c1939391f -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From ankprashar at gmail.com Sun Mar 8 13:13:42 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Sun, 08 Mar 2015 12:13:42 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150308121343.8734.6054.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: New => Confirmed ** Changed in: postorius Status: New => Confirmed ** Changed in: mailman Assignee: (unassigned) => Ankush Sharma (black-perl) ** Changed in: postorius Assignee: (unassigned) => Ankush Sharma (black-perl) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From ankprashar at gmail.com Sun Mar 8 13:15:05 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Sun, 08 Mar 2015 12:15:05 -0000 Subject: [Bug 1425359] Re: 500 error code shown by postorius instead of 409 error code References: <20150225025413.24385.93661.malonedeb@wampee.canonical.com> Message-ID: <20150308121506.10428.34764.launchpad@soybean.canonical.com> ** Changed in: mailman Status: New => Confirmed ** Changed in: mailman Assignee: (unassigned) => Ankush Sharma (black-perl) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1425359 Title: 500 error code shown by postorius instead of 409 error code To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1425359/+subscriptions From bhavesh.goyal093 at gmail.com Sun Mar 8 18:22:12 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Sun, 08 Mar 2015 17:22:12 -0000 Subject: [Bug 1425359] Re: 500 error code shown by postorius instead of 409 error code References: <20150225025413.24385.93661.malonedeb@wampee.canonical.com> Message-ID: <20150308172212.10554.10643.malone@soybean.canonical.com> This Bug was result of treating case sensitive and case insensitive addresses differently which in both cases mailman treats as identical. So always comparing the strings by making the cases identical (lower case here) , will solve the bug. The solution thus provided to make the cases similar seems apt. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1425359 Title: 500 error code shown by postorius instead of 409 error code To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1425359/+subscriptions From ankprashar at gmail.com Sun Mar 8 19:31:30 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Sun, 08 Mar 2015 18:31:30 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150308183130.4665.91527.launchpad@wampee.canonical.com> ** Description changed: The hash(#) is a valid character as far as the local part of the email addresses is concerned. So, as the mailing list addresses are email addresses too, we can use # in the list names too. And, in context with mailman it works well. We can create a list with list_id sam#hashed.host.org for the address sam#hashed at host.org . This works fine. But it makes the list_id to contain the hash character and therefore the REST endpoint for retrieving list wise info becomes invalid, i.e : /lists/sam#hashed.host.org Because in an URL the stuff after # is treated as document starting point i.e an id identifier or something of a dom element. This is not a valid PATH for the server. Therefore the falcon wsgi request object does not contain information of that and the req.path simply returns sam as the list_id ( http://bazaar.launchpad.net/~mailman-coders/mailman/3.0/view/head:/src/mailman/rest/wsgiapp.py#L65 ) giving a 404 because there is no any list with list id sam. The mailman client works fine, it sends a GET to lists/sam#hashed.host.org. - This causes the REST end points which needs list_id to return 404 or in worse we can have a list_id clash between ids sam#XXXXX and sam. Further more if the list_id starts with a # character then the server finds list_id to be empty string and therefore we get a KEY ERROR because fqdn_listname is not set too. The bug highly effects postorius too. The lists index template at /postorius/lists/ cannot be rendered as it uses the former REST endpoint and again a 404 is given. And, until we delete this list from the database, we can't do anything except of getting a 404 and KEY ERROR each time. - As far as security is concerned, if an another user created a public list using a hash character, then public list indexing would also fail. + This causes the REST end points which needs list_id to return 404 or in + worse we can have a list_id clash between ids sam#XXXXX and sam. Further + more if the list_id starts with a # character then the server finds + list_id to be empty string and therefore we get a KEY ERROR because + fqdn_listname is not set too. The bug highly effects postorius too. The + lists index template at /postorius/lists/ cannot be rendered as it uses + the former REST endpoint and again a 404 is given. And, until we delete + this list from the database, we can't do anything except of getting a + 404 and KEY ERROR each time. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From ankprashar at gmail.com Sun Mar 8 19:57:41 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Sun, 08 Mar 2015 18:57:41 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150308185741.8110.7525.launchpad@chaenomeles.canonical.com> ** Description changed: The hash(#) is a valid character as far as the local part of the email addresses is concerned. So, as the mailing list addresses are email addresses too, we can use # in the list names too. And, in context with mailman it works well. We can create a list with list_id sam#hashed.host.org for the address sam#hashed at host.org . This works fine. But it makes the list_id to contain the hash character and therefore the REST endpoint for retrieving list wise info becomes invalid, i.e : /lists/sam#hashed.host.org Because in an URL the stuff after # is treated as document starting point i.e an id identifier or something of a dom element. This is not a valid PATH for the server. Therefore the falcon wsgi request object does not contain information of that and the req.path simply returns sam as the list_id ( http://bazaar.launchpad.net/~mailman-coders/mailman/3.0/view/head:/src/mailman/rest/wsgiapp.py#L65 ) giving a 404 because there is no any list with list id sam. The mailman client works fine, it sends a GET to lists/sam#hashed.host.org. This causes the REST end points which needs list_id to return 404 or in worse we can have a list_id clash between ids sam#XXXXX and sam. Further more if the list_id starts with a # character then the server finds list_id to be empty string and therefore we get a KEY ERROR because fqdn_listname is not set too. The bug highly effects postorius too. The lists index template at /postorius/lists/ cannot be rendered as it uses the former REST endpoint and again a 404 is given. And, until we delete this list from the database, we can't do anything except of getting a 404 and KEY ERROR each time. + + Bug discussed in detail here: http://www.mail-archive.com/mailman- + developers%40python.org/msg15317.html -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From saprativejana at gmail.com Sun Mar 8 22:54:22 2015 From: saprativejana at gmail.com (Saprative) Date: Sun, 08 Mar 2015 21:54:22 -0000 Subject: [Bug 965520] Re: Improve installation documentation References: <20120326173237.4753.40985.malonedeb@chaenomeles.canonical.com> Message-ID: <20150308215422.9968.65760.malone@soybean.canonical.com> I have documented the mailman installation process . In my documematation virtualenv installation guide is also provided -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/965520 Title: Improve installation documentation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/965520/+subscriptions From saprativejana at gmail.com Sun Mar 8 22:55:57 2015 From: saprativejana at gmail.com (Saprative) Date: Sun, 08 Mar 2015 21:55:57 -0000 Subject: [Bug 965520] Re: Improve installation documentation References: <20120326173237.4753.40985.malonedeb@chaenomeles.canonical.com> Message-ID: <20150308215557.10071.41675.malone@soybean.canonical.com> my new branch is lp:~saprativejana/mailman/install_doc please review it and merge it. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/965520 Title: Improve installation documentation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/965520/+subscriptions From saprativejana at gmail.com Mon Mar 9 00:00:02 2015 From: saprativejana at gmail.com (Saprative) Date: Sun, 08 Mar 2015 23:00:02 -0000 Subject: [Bug 965520] Re: Improve installation documentation References: <20120326173237.4753.40985.malonedeb@chaenomeles.canonical.com> Message-ID: <20150308230003.8864.74093.malone@chaenomeles.canonical.com> sorry for actually i did not do bzr add so the modification ions where not made in my branch. So please ignore my precvious message. ** Patch added: "Installation Guide" https://bugs.launchpad.net/mailman/+bug/965520/+attachment/4338328/+files/install_doc.patch -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/965520 Title: Improve installation documentation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/965520/+subscriptions From bhavesh.goyal093 at gmail.com Mon Mar 9 13:26:22 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Mon, 09 Mar 2015 12:26:22 -0000 Subject: [Merge] lp:~bhavesh-goyal093/postorius/feature-added-search-postorius-lists into lp:postorius Message-ID: <20150309122621.17889.494.launchpad@ackee.canonical.com> Bhavesh Goyal has proposed merging lp:~bhavesh-goyal093/postorius/feature-added-search-postorius-lists into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~bhavesh-goyal093/postorius/feature-added-search-postorius-lists/+merge/252274 Search is regarded as an important function for any list. The postorius lists earlier had no such function in members list page. Thus for large lists, it was difficult for list maintainer to search for a particular member in such lists. Even with Find In Page Browser function, it doesn't allow to search among whole lists across different pages and just highlights the results merely reducing the effort of going through the whole list. Now The Members list can be filtered based on email address and certain functions such as getting all addresses starting with certain keywords and getting addresses containing some specific keywords can also be performed using the search box implemented in members list page. -- Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/feature-added-search-postorius-lists into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 7033 bytes Desc: not available URL: From saprativejana at gmail.com Mon Mar 9 16:48:32 2015 From: saprativejana at gmail.com (Saprative) Date: Mon, 09 Mar 2015 15:48:32 -0000 Subject: [Bug 965520] Re: Improve installation documentation References: <20120326173237.4753.40985.malonedeb@chaenomeles.canonical.com> Message-ID: <20150309154832.8734.93560.launchpad@chaenomeles.canonical.com> ** Branch linked: lp:~saprativejana/mailman/installation_guide -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/965520 Title: Improve installation documentation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/965520/+subscriptions From yashmehrotra95 at gmail.com Mon Mar 9 19:03:52 2015 From: yashmehrotra95 at gmail.com (Yash) Date: Mon, 09 Mar 2015 18:03:52 -0000 Subject: [Bug 1414352] Re: Improve code coverage by adding tests References: <20150124193353.29200.98953.malonedeb@gac.canonical.com> Message-ID: <20150309180353.10554.61493.launchpad@soybean.canonical.com> ** Changed in: mailman Assignee: (unassigned) => Yash (yashmehrotra95) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1414352 Title: Improve code coverage by adding tests To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1414352/+subscriptions From saprativejana at gmail.com Mon Mar 9 19:09:20 2015 From: saprativejana at gmail.com (Saprative) Date: Mon, 09 Mar 2015 18:09:20 -0000 Subject: [Bug 965520] Re: Improve installation documentation References: <20120326173237.4753.40985.malonedeb@chaenomeles.canonical.com> Message-ID: <20150309180920.10554.70796.launchpad@soybean.canonical.com> ** Branch linked: lp:~saprativejana/mailman/starting_guide -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/965520 Title: Improve installation documentation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/965520/+subscriptions From ankprashar at gmail.com Mon Mar 9 19:35:10 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Mon, 09 Mar 2015 18:35:10 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150309183510.8203.42714.launchpad@chaenomeles.canonical.com> ** Description changed: - The hash(#) is a valid character as far as the local part of the email - addresses is concerned. So, as the mailing list addresses are email - addresses too, we can use # in the list names too. And, in context with - mailman it works well. We can create a list with list_id - sam#hashed.host.org for the address sam#hashed at host.org . This works - fine. But it makes the list_id to contain the hash character and - therefore the REST endpoint for retrieving list wise info becomes - invalid, i.e : + The hash(#) and question mark(?) is a valid character as far as the local part of the email addresses is concerned. + Reference: http://stackoverflow.com/questions/2049502/what-characters-are-allowed-in-email-address + + So, as the mailing list addresses are email addresses too, we can use # + in the list names too. And, in context with mailman it works well. We + can create a list with list_id sam#hashed.host.org for the address + sam#hashed at host.org . This works fine. But it makes the list_id to + contain the hash character and therefore the REST endpoint for + retrieving list wise info becomes invalid, i.e : /lists/sam#hashed.host.org Because in an URL the stuff after # is treated as document starting point i.e an id identifier or something of a dom element. This is not a valid PATH for the server. Therefore the falcon wsgi request object does not contain information of that and the req.path simply returns sam as the list_id ( http://bazaar.launchpad.net/~mailman-coders/mailman/3.0/view/head:/src/mailman/rest/wsgiapp.py#L65 ) giving a 404 because there is no any list with list id sam. The mailman client works fine, it sends a GET to lists/sam#hashed.host.org. This causes the REST end points which needs list_id to return 404 or in worse we can have a list_id clash between ids sam#XXXXX and sam. Further more if the list_id starts with a # character then the server finds list_id to be empty string and therefore we get a KEY ERROR because fqdn_listname is not set too. The bug highly effects postorius too. The lists index template at /postorius/lists/ cannot be rendered as it uses the former REST endpoint and again a 404 is given. And, until we delete this list from the database, we can't do anything except of getting a 404 and KEY ERROR each time. Bug discussed in detail here: http://www.mail-archive.com/mailman- developers%40python.org/msg15317.html -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From yashmehrotra95 at gmail.com Mon Mar 9 20:21:18 2015 From: yashmehrotra95 at gmail.com (Yash) Date: Mon, 09 Mar 2015 19:21:18 -0000 Subject: [Bug 1094696] Re: Event notifications on postings References: <20121230162347.15671.27720.malonedeb@wampee.canonical.com> Message-ID: <20150309192119.9724.69714.launchpad@soybean.canonical.com> ** Changed in: mailman Assignee: (unassigned) => Yash (yashmehrotra95) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1094696 Title: Event notifications on postings To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1094696/+subscriptions From 266809 at bugs.launchpad.net Mon Mar 9 21:39:41 2015 From: 266809 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Mon, 09 Mar 2015 20:39:41 -0000 Subject: [Bug 266809] Re: Feature Request: Admin change subscriber's e-mail References: <20080905194252.1806.16257.launchpad@forster.canonical.com> Message-ID: <20150309203943.15088.48681.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/266809 Title: Feature Request: Admin change subscriber's e-mail To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/266809/+subscriptions From mark at msapiro.net Mon Mar 9 21:40:17 2015 From: mark at msapiro.net (Mark Sapiro) Date: Mon, 09 Mar 2015 20:40:17 -0000 Subject: [Bug 266809] Re: Feature Request: Admin change subscriber's e-mail References: <20080905194252.1806.16257.launchpad@forster.canonical.com> Message-ID: <20150309204019.8422.86935.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/266809 Title: Feature Request: Admin change subscriber's e-mail To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/266809/+subscriptions From yashmehrotra95 at gmail.com Mon Mar 9 22:18:58 2015 From: yashmehrotra95 at gmail.com (Yash) Date: Mon, 09 Mar 2015 21:18:58 -0000 Subject: [Bug 1414352] Re: Improve code coverage by adding tests References: <20150124193353.29200.98953.malonedeb@gac.canonical.com> Message-ID: <20150309211858.8203.29431.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: New => In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1414352 Title: Improve code coverage by adding tests To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1414352/+subscriptions From yashmehrotra95 at gmail.com Mon Mar 9 22:18:41 2015 From: yashmehrotra95 at gmail.com (Yash) Date: Mon, 09 Mar 2015 21:18:41 -0000 Subject: [Bug 1094696] Re: Event notifications on postings References: <20121230162347.15671.27720.malonedeb@wampee.canonical.com> Message-ID: <20150309211842.20736.65089.launchpad@gac.canonical.com> ** Changed in: mailman Status: New => In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1094696 Title: Event notifications on postings To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1094696/+subscriptions From raj.abhilash1 at gmail.com Tue Mar 10 00:34:24 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Mon, 09 Mar 2015 23:34:24 -0000 Subject: [Merge] lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman Message-ID: <20150309233421.4004.14239.launchpad@ackee.canonical.com> Abhilash Raj has proposed merging lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~raj-abhilash1/mailman/mailman_fix/+merge/252385 Fix the error causing read error on MAILMAN_EXTRA_TESTING_CFG (for testing against postgres) -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 583 bytes Desc: not available URL: From barry at canonical.com Tue Mar 10 00:43:57 2015 From: barry at canonical.com (Barry Warsaw) Date: Mon, 09 Mar 2015 23:43:57 -0000 Subject: [Merge] lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman In-Reply-To: <20150309233421.4004.14239.launchpad@ackee.canonical.com> Message-ID: <20150309234355.15128.31266.launchpad@ackee.canonical.com> The proposal to merge lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~raj-abhilash1/mailman/mailman_fix/+merge/252385 -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman. From noreply at launchpad.net Tue Mar 10 00:52:03 2015 From: noreply at launchpad.net (noreply at launchpad.net) Date: Mon, 09 Mar 2015 23:52:03 -0000 Subject: [Merge] lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman In-Reply-To: <20150309233421.4004.14239.launchpad@ackee.canonical.com> Message-ID: <20150309235202.15127.70931.launchpad@ackee.canonical.com> The proposal to merge lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~raj-abhilash1/mailman/mailman_fix/+merge/252385 -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman. From noreply at launchpad.net Tue Mar 10 09:24:49 2015 From: noreply at launchpad.net (noreply at launchpad.net) Date: Tue, 10 Mar 2015 08:24:49 -0000 Subject: [Merge] lp:~raj-abhilash1/postorius/postorius_standalone into lp:~mailman-coders/postorius/postorius_standalone In-Reply-To: <20150305143040.18095.57645.launchpad@ackee.canonical.com> Message-ID: <20150310082448.32431.93782.launchpad@ackee.canonical.com> The proposal to merge lp:~raj-abhilash1/postorius/postorius_standalone into lp:~mailman-coders/postorius/postorius_standalone has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raj-abhilash1/postorius/postorius_standalone/+merge/251951 -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/postorius/postorius_standalone into lp:~mailman-coders/postorius/postorius_standalone. From noreply at launchpad.net Tue Mar 10 09:25:05 2015 From: noreply at launchpad.net (noreply at launchpad.net) Date: Tue, 10 Mar 2015 08:25:05 -0000 Subject: [Merge] lp:~raj-abhilash1/postorius/browserid into lp:postorius In-Reply-To: <20150305142826.16006.12802.launchpad@ackee.canonical.com> Message-ID: <20150310082504.32430.8065.launchpad@ackee.canonical.com> The proposal to merge lp:~raj-abhilash1/postorius/browserid into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raj-abhilash1/postorius/browserid/+merge/251950 -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/postorius/browserid into lp:postorius. From noreply at launchpad.net Tue Mar 10 11:26:55 2015 From: noreply at launchpad.net (noreply at launchpad.net) Date: Tue, 10 Mar 2015 10:26:55 -0000 Subject: [Merge] lp:~black-perl/postorius/fix-postorius into lp:postorius In-Reply-To: <20150304153824.11803.91718.launchpad@ackee.canonical.com> Message-ID: <20150310102655.32431.11490.launchpad@ackee.canonical.com> The proposal to merge lp:~black-perl/postorius/fix-postorius into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~black-perl/postorius/fix-postorius/+merge/251761 -- Your team Mailman Coders is subscribed to branch lp:postorius. From prakhar126 at gmail.com Tue Mar 10 13:01:22 2015 From: prakhar126 at gmail.com (pjoshi) Date: Tue, 10 Mar 2015 12:01:22 -0000 Subject: [Merge] lp:~prakhar126/postorius/postorius into lp:postorius Message-ID: <20150310120122.8785.34270.launchpad@ackee.canonical.com> pjoshi has proposed merging lp:~prakhar126/postorius/postorius into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~prakhar126/postorius/postorius/+merge/252422 Adding test cases for creating new list. -- Your team Mailman Coders is requested to review the proposed merge of lp:~prakhar126/postorius/postorius into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1617 bytes Desc: not available URL: From f at florianfuchs.com Tue Mar 10 10:13:08 2015 From: f at florianfuchs.com (Florian Fuchs) Date: Tue, 10 Mar 2015 09:13:08 -0000 Subject: [Merge] lp:~godricglow/postorius/tests_forms into lp:postorius In-Reply-To: <20150304135722.17489.78748.launchpad@ackee.canonical.com> Message-ID: <20150310091308.18420.3011.codereview@gac.canonical.com> Hi Pranjal, thanks for this merge proposal. It looks pretty good so far, I only have some minor comments (see below). Florian Diff comments: > === modified file 'src/postorius/forms.py' > --- src/postorius/forms.py 2015-02-09 14:35:44 +0000 > +++ src/postorius/forms.py 2015-03-04 13:56:28 +0000 > @@ -17,7 +17,7 @@ > # Postorius. If not, see . > > from django import forms > -from django.core.validators import validate_email, URLValidator > +from django.core.validators import validate_email, URLValidator, validate_slug > from django.utils.translation import gettext_lazy as _ > from fieldset_forms import FieldsetForm > from django.forms.models import modelformset_factory > @@ -102,6 +102,7 @@ > Form fields to add a new list. Languages are hard coded which should > be replaced by a REST lookup of available languages. > """ > + > listname = forms.CharField( > label=_('List Name'), > required=True, > @@ -126,6 +127,7 @@ > label=_('Description'), > required=True) > > + > def __init__(self, domain_choices, *args, **kwargs): > super(ListNew, self).__init__(*args, **kwargs) > self.fields["mail_host"] = forms.ChoiceField( > @@ -138,17 +140,20 @@ > if len(domain_choices) < 2: > self.fields["mail_host"].help_text = _( > "Site admin has not created any domains") > - # if len(choices) < 2: > + #if len(choices) < 2: > # help_text=_("No domains available: " + > # "The site admin must create new domains " + > # "before you will be able to create a list") > > def clean_listname(self): > + > + cleaned_data = super(ListNew, self).clean() > + listname = cleaned_data.get('listname') For a single field's clean method, we don't need to call the parent's clean method. We can just access `self.cleaned_data.get('listname')` directly. > try: > - validate_email(self.cleaned_data['listname'] + '@example.net') > + validate_slug(listname) I think `validate_slug` is too restrictive here, because the local part of an email address has more valid characters than validate_slug allows. > except: > raise forms.ValidationError(_("Please enter a valid listname")) > - return self.cleaned_data['listname'] > + return listname > > class Meta: > > @@ -827,14 +832,19 @@ > widget=forms.PasswordInput(render_value=False)) > > def clean(self): > - cleaned_data = self.cleaned_data > - password = cleaned_data.get("password") > - password_repeat = cleaned_data.get("password_repeat") > + password = self.cleaned_data.get('password') > + password_repeat = self.cleaned_data.get('password_repeat') > if password != password_repeat: > raise forms.ValidationError("Passwords must be identical.") > - > - return cleaned_data > - > + return password_repeat The `clean` method needs to either return the whole `cleaned_data` dictionary or None (Django >= 1.7), but not just a single field. > + > + def clean_email(self): > + email = self.cleaned_data['email'] > + try: > + validate_email(email) > + except: > + raise forms.ValidationError(_("Please enter a valid email ID")) > + return email > > class UserSettings(FieldsetForm): > > > === modified file 'src/postorius/tests/__init__.py' > --- src/postorius/tests/__init__.py 2015-02-10 13:56:47 +0000 > +++ src/postorius/tests/__init__.py 2015-03-04 13:56:28 +0000 > @@ -20,7 +20,6 @@ > > from django.conf import settings > > - > TEST_ROOT = os.path.abspath(os.path.dirname(__file__)) > > FIXTURES_DIR = getattr( > > === modified file 'src/postorius/tests/test_forms.py' > --- src/postorius/tests/test_forms.py 2015-02-09 14:35:44 +0000 > +++ src/postorius/tests/test_forms.py 2015-03-04 13:56:28 +0000 > @@ -15,9 +15,7 @@ > # You should have received a copy of the GNU General Public License along with > # Postorius. If not, see . > from django.utils import unittest > - > -from postorius.forms import UserPreferences, DomainNew > - > +from postorius.forms import UserPreferences, DomainNew, ListNew, UserNew > > class UserPreferencesTest(unittest.TestCase): > > @@ -32,20 +30,78 @@ > > class DomainNewTest(unittest.TestCase): > > + def setUp(self): > + self.form_data = { > + 'mail_host': 'mailman.most-desirable.org', > + 'web_host': 'http://mailman.most-desirable.org', > + 'description': 'The Most Desirable organization', > + 'contact_address': 'contact at mailman.most-desirable.org', > + } > + > def test_form_fields_webhost(self): > - form = DomainNew({ > - 'mail_host': 'mailman.most-desirable.org', > - 'web_host': 'http://mailman.most-desirable.org', > - 'description': 'The Most Desirable organization', > - 'contact_address': 'contact at mailman.most-desirable.org', > - }) > + form = DomainNew(self.form_data) > self.assertTrue(form.is_valid()) > > def test_form_fields_webhost_invalid(self): > - form = DomainNew({ > + self.form_data['web_host'] = 'mailman.most-desirable.org' > + form = DomainNew(self.form_data) > + self.assertFalse(form.is_valid()) > + > + def test_form_fields_mailhost(self): > + form = DomainNew(self.form_data) > + self.assertTrue(form.is_valid()) > + > + def test_form_fields_mailhost_invalid(self): > + self.form_data['mail_host'] = 'mailman.most-desirable..org' > + form = DomainNew(self.form_data) > + self.assertFalse(form.is_valid()) > + > +class ListNewTest(unittest.TestCase): > + > + def setUp(self): > + self.choosable_domains = [('mailman.most-desirable.org', 'mailman.most-desirable.org')] > + > + self.form_data = { > + 'listname' : 'test_list1', > 'mail_host': 'mailman.most-desirable.org', > - 'web_host': 'mailman.most-desirable.org', > + 'list_owner': 'james at example.com', > + 'advertised': 'True', > 'description': 'The Most Desirable organization', > - 'contact_address': 'contact at mailman.most-desirable.org', > - }) > - self.assertFalse(form.is_valid()) > + } > + > + def test_form_fields_listname(self): > + form = ListNew(self.choosable_domains,self.form_data) > + self.assertTrue(form.is_valid()) > + > + def test_form_fields_listname_invalid(self): > + self.form_data['listname'] = 'test$list1' > + form = ListNew(self.choosable_domains,self.form_data) > + self.assertFalse(form.is_valid()) > + > +class UserNewTest(unittest.TestCase): > + > + def setUp(self): > + self.form_data = { > + 'display_name' : 'Pranjal Yadav', > + 'email' : 'pranjal at example.com', > + 'password' : 'password123', > + 'password_repeat' : 'password123', > + } > + > + def test_form_fields_password(self): > + form = UserNew(self.form_data) > + self.assertTrue(form.is_valid()) > + > + def test_form_fields_password_invalid(self): > + self.form_data['password_repeat'] = 'random' > + form = UserNew(self.form_data) > + self.assertFalse(form.is_valid()) > + > + def test_form_fields_email(self): > + form = UserNew(self.form_data) > + self.assertTrue(form.is_valid()) > + > + def test_form_fields_email_invalid(self): > + self.form_data['email'] = 'pranjal at example..com' > + form = UserNew(self.form_data) > + self.assertFalse(form.is_valid()) > \ No newline at end of file > -- https://code.launchpad.net/~godricglow/postorius/tests_forms/+merge/251740 Your team Mailman Coders is requested to review the proposed merge of lp:~godricglow/postorius/tests_forms into lp:postorius. From f at florianfuchs.com Tue Mar 10 11:27:33 2015 From: f at florianfuchs.com (Florian Fuchs) Date: Tue, 10 Mar 2015 10:27:33 -0000 Subject: [Merge] lp:~black-perl/postorius/fix-postorius into lp:postorius In-Reply-To: <20150304153824.11803.91718.launchpad@ackee.canonical.com> Message-ID: <20150310102732.19053.9019.codereview@gac.canonical.com> Review: Approve Hi Ankush, thanks for this fix. Tested, approved, merged. ;-) Florian -- https://code.launchpad.net/~black-perl/postorius/fix-postorius/+merge/251761 Your team Mailman Coders is subscribed to branch lp:postorius. From ankprashar at gmail.com Tue Mar 10 15:53:50 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Tue, 10 Mar 2015 14:53:50 -0000 Subject: [Merge] lp:~black-perl/postorius/fix-postorius into lp:postorius In-Reply-To: <20150304153824.11803.91718.launchpad@ackee.canonical.com> Message-ID: <20150310145350.25442.89532.codereview@soybean.canonical.com> Hello Florian, Thanks for giving time to it. It would be good if I can have your view on these https://bugs.launchpad.net/postorius/+bug/1428543 and https://bugs.launchpad.net/postorius/+bug/1429366 sometime later. I am working on to fix the latter one. Ankush -- https://code.launchpad.net/~black-perl/postorius/fix-postorius/+merge/251761 Your team Mailman Coders is subscribed to branch lp:postorius. From godricglow at gmail.com Tue Mar 10 19:36:26 2015 From: godricglow at gmail.com (Pranjal Yadav) Date: Tue, 10 Mar 2015 18:36:26 -0000 Subject: [Merge] lp:~godricglow/postorius/tests_forms into lp:postorius In-Reply-To: <20150310091308.18420.3011.codereview@gac.canonical.com> Message-ID: Hi Florian Thanks for you reply, I checked all you comments carefully and have replied below. On Tue, Mar 10, 2015 at 2:43 PM, Florian Fuchs wrote: > Hi Pranjal, > > thanks for this merge proposal. It looks pretty good so far, I only have > some minor comments (see below). > > Florian > > Diff comments: > > > === modified file 'src/postorius/forms.py' > > --- src/postorius/forms.py 2015-02-09 14:35:44 +0000 > > +++ src/postorius/forms.py 2015-03-04 13:56:28 +0000 > > @@ -17,7 +17,7 @@ > > # Postorius. If not, see . > > > > from django import forms > > -from django.core.validators import validate_email, URLValidator > > +from django.core.validators import validate_email, URLValidator, > validate_slug > > from django.utils.translation import gettext_lazy as _ > > from fieldset_forms import FieldsetForm > > from django.forms.models import modelformset_factory > > @@ -102,6 +102,7 @@ > > Form fields to add a new list. Languages are hard coded which should > > be replaced by a REST lookup of available languages. > > """ > > + > > listname = forms.CharField( > > label=_('List Name'), > > required=True, > > @@ -126,6 +127,7 @@ > > label=_('Description'), > > required=True) > > > > + > > def __init__(self, domain_choices, *args, **kwargs): > > super(ListNew, self).__init__(*args, **kwargs) > > self.fields["mail_host"] = forms.ChoiceField( > > @@ -138,17 +140,20 @@ > > if len(domain_choices) < 2: > > self.fields["mail_host"].help_text = _( > > "Site admin has not created any domains") > > - # if len(choices) < 2: > > + #if len(choices) < 2: > > # help_text=_("No domains available: " + > > # "The site admin must create new domains " + > > # "before you will be able to create a list") > > > > def clean_listname(self): > > + > > + cleaned_data = super(ListNew, self).clean() > > + listname = cleaned_data.get('listname') > > For a single field's clean method, we don't need to call the parent's > clean method. We can just access `self.cleaned_data.get('listname')` > directly. > Good point but I already tried doing that, it seems __init__ method creates some problem otherwise when I don't call the parent's clean method. I talked to abhilash and he too said that cleaning through parent seems to work. I need your advice on this part. > > > try: > > - validate_email(self.cleaned_data['listname'] + '@ > example.net') > > + validate_slug(listname) > > I think `validate_slug` is too restrictive here, because the local part of > an email address has more valid characters than validate_slug allows. > > I guess there is some confusion here, I'm validating the email with > 'validate_email' only. I'm using validate_slug for listname only and I > think listname need to have that restriction which again is not my decision > but my choice as per sample data from various tests, Please tell me If I > need to do otherwise. > > except: > > raise forms.ValidationError(_("Please enter a valid > listname")) > > - return self.cleaned_data['listname'] > > + return listname > > > > class Meta: > > > > @@ -827,14 +832,19 @@ > > widget=forms.PasswordInput(render_value=False)) > > > > def clean(self): > > - cleaned_data = self.cleaned_data > > - password = cleaned_data.get("password") > > - password_repeat = cleaned_data.get("password_repeat") > > + password = self.cleaned_data.get('password') > > + password_repeat = self.cleaned_data.get('password_repeat') > > if password != password_repeat: > > raise forms.ValidationError("Passwords must be identical.") > > - > > - return cleaned_data > > - > > + return password_repeat > > The `clean` method needs to either return the whole `cleaned_data` > dictionary or None (Django >= 1.7), but not just a single field. > I will correct this one right away, It was meant to return the whole > 'cleaned_data', I may have mis-typed, sorry :) > > + > > + def clean_email(self): > > + email = self.cleaned_data['email'] > > + try: > > + validate_email(email) > > + except: > > + raise forms.ValidationError(_("Please enter a valid email > ID")) > > + return email > > > > class UserSettings(FieldsetForm): > > > > > > === modified file 'src/postorius/tests/__init__.py' > > --- src/postorius/tests/__init__.py 2015-02-10 13:56:47 +0000 > > +++ src/postorius/tests/__init__.py 2015-03-04 13:56:28 +0000 > > @@ -20,7 +20,6 @@ > > > > from django.conf import settings > > > > - > > TEST_ROOT = os.path.abspath(os.path.dirname(__file__)) > > > > FIXTURES_DIR = getattr( > > > > === modified file 'src/postorius/tests/test_forms.py' > > --- src/postorius/tests/test_forms.py 2015-02-09 14:35:44 +0000 > > +++ src/postorius/tests/test_forms.py 2015-03-04 13:56:28 +0000 > > @@ -15,9 +15,7 @@ > > # You should have received a copy of the GNU General Public License > along with > > # Postorius. If not, see . > > from django.utils import unittest > > - > > -from postorius.forms import UserPreferences, DomainNew > > - > > +from postorius.forms import UserPreferences, DomainNew, ListNew, UserNew > > > > class UserPreferencesTest(unittest.TestCase): > > > > @@ -32,20 +30,78 @@ > > > > class DomainNewTest(unittest.TestCase): > > > > + def setUp(self): > > + self.form_data = { > > + 'mail_host': 'mailman.most-desirable.org', > > + 'web_host': 'http://mailman.most-desirable.org', > > + 'description': 'The Most Desirable organization', > > + 'contact_address': 'contact at mailman.most-desirable.org', > > + } > > + > > def test_form_fields_webhost(self): > > - form = DomainNew({ > > - 'mail_host': 'mailman.most-desirable.org', > > - 'web_host': 'http://mailman.most-desirable.org', > > - 'description': 'The Most Desirable organization', > > - 'contact_address': 'contact at mailman.most-desirable.org', > > - }) > > + form = DomainNew(self.form_data) > > self.assertTrue(form.is_valid()) > > > > def test_form_fields_webhost_invalid(self): > > - form = DomainNew({ > > + self.form_data['web_host'] = 'mailman.most-desirable.org' > > + form = DomainNew(self.form_data) > > + self.assertFalse(form.is_valid()) > > + > > + def test_form_fields_mailhost(self): > > + form = DomainNew(self.form_data) > > + self.assertTrue(form.is_valid()) > > + > > + def test_form_fields_mailhost_invalid(self): > > + self.form_data['mail_host'] = 'mailman.most-desirable..org' > > + form = DomainNew(self.form_data) > > + self.assertFalse(form.is_valid()) > > + > > +class ListNewTest(unittest.TestCase): > > + > > + def setUp(self): > > + self.choosable_domains = [('mailman.most-desirable.org', ' > mailman.most-desirable.org')] > > + > > + self.form_data = { > > + 'listname' : 'test_list1', > > 'mail_host': 'mailman.most-desirable.org', > > - 'web_host': 'mailman.most-desirable.org', > > + 'list_owner': 'james at example.com', > > + 'advertised': 'True', > > 'description': 'The Most Desirable organization', > > - 'contact_address': 'contact at mailman.most-desirable.org', > > - }) > > - self.assertFalse(form.is_valid()) > > + } > > + > > + def test_form_fields_listname(self): > > + form = ListNew(self.choosable_domains,self.form_data) > > + self.assertTrue(form.is_valid()) > > + > > + def test_form_fields_listname_invalid(self): > > + self.form_data['listname'] = 'test$list1' > > + form = ListNew(self.choosable_domains,self.form_data) > > + self.assertFalse(form.is_valid()) > > + > > +class UserNewTest(unittest.TestCase): > > + > > + def setUp(self): > > + self.form_data = { > > + 'display_name' : 'Pranjal Yadav', > > + 'email' : 'pranjal at example.com', > > + 'password' : 'password123', > > + 'password_repeat' : 'password123', > > + } > > + > > + def test_form_fields_password(self): > > + form = UserNew(self.form_data) > > + self.assertTrue(form.is_valid()) > > + > > + def test_form_fields_password_invalid(self): > > + self.form_data['password_repeat'] = 'random' > > + form = UserNew(self.form_data) > > + self.assertFalse(form.is_valid()) > > + > > + def test_form_fields_email(self): > > + form = UserNew(self.form_data) > > + self.assertTrue(form.is_valid()) > > + > > + def test_form_fields_email_invalid(self): > > + self.form_data['email'] = 'pranjal at example..com' > > + form = UserNew(self.form_data) > > + self.assertFalse(form.is_valid()) > > \ No newline at end of file > > > > > -- > https://code.launchpad.net/~godricglow/postorius/tests_forms/+merge/251740 > You are the owner of lp:~godricglow/postorius/tests_forms. > -- *Pranjal Yadav* *IIT Kharagpur* https://code.launchpad.net/~godricglow/postorius/tests_forms/+merge/251740 Your team Mailman Coders is subscribed to branch lp:postorius. From bhavesh.goyal093 at gmail.com Tue Mar 10 23:24:25 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Tue, 10 Mar 2015 22:24:25 -0000 Subject: [Bug 1430559] [NEW] Identical Addresses treated differently causes redundancy in address list References: <20150310222425.14535.39416.malonedeb@wampee.canonical.com> Message-ID: <20150310222425.14535.39416.malonedeb@wampee.canonical.com> Public bug reported: In accordance with RFC standards, certain special characters such as 'plus' (+) symbol are allowed to be used in 'local part' of email addresses. Thus the addresses abc+xyc at domain.com and a+r at domain.com are considered to be valid. Also, certain mail service providers such as gmail accepts as using the '+' symbol in an address and appending any number of characters after the 'plus' giving an option to filter the emails utilising the '+' for filtering and all those set of email addresses with different sets of characters after '+' yet address to a single account. On the other hand, Mailman doesn't processes 'plus' in any special way than a normal character and as a result two or more email addresses can be subscribed pointing to the same account for the same mailing list...This can cause redundancy of addresses in subscriber database and also multiple emails might go to the same user and thus even the important mails may be treated as spams. ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1430559 Title: Identical Addresses treated differently causes redundancy in address list To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1430559/+subscriptions From mark at msapiro.net Wed Mar 11 01:34:27 2015 From: mark at msapiro.net (Mark Sapiro) Date: Wed, 11 Mar 2015 00:34:27 -0000 Subject: [Bug 1430559] Re: Identical Addresses treated differently causes redundancy in address list References: <20150310222425.14535.39416.malonedeb@wampee.canonical.com> Message-ID: <20150311003428.24854.57963.malone@chaenomeles.canonical.com> Both RFC 2821 and RFC 5321 contain the following statement: The standard mailbox naming convention is defined to be "local- part at domain"; contemporary usage permits a much broader set of applications than simple "user names". Consequently, and due to a long history of problems when intermediate hosts have attempted to optimize transport by modifying them, the local-part MUST be interpreted and assigned semantics only by the host specified in the domain part of the address. Thus, Mailman not being the host specified in the domain part of the address MUST assume that different local-parts are different addresses regardless of the widespread use of + as a delimiter indicating the mailbox name ends here. ** Changed in: mailman Status: New => Invalid -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1430559 Title: Identical Addresses treated differently causes redundancy in address list To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1430559/+subscriptions From prakhar126 at gmail.com Wed Mar 11 08:11:03 2015 From: prakhar126 at gmail.com (pjoshi) Date: Wed, 11 Mar 2015 07:11:03 -0000 Subject: [Bug 1062963] Re: Admin notification not received References: <20121006182248.14546.68625.malonedeb@gac.canonical.com> Message-ID: <20150311071103.18916.58586.malone@gac.canonical.com> hi, I think admin should be notify when an user changes subscription settings. Right now admin is not notified about the chages user does in the list subscription. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1062963 Title: Admin notification not received To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1062963/+subscriptions From prakash.gbpec at gmail.com Wed Mar 11 12:35:43 2015 From: prakash.gbpec at gmail.com (Prakash Kumar) Date: Wed, 11 Mar 2015 11:35:43 -0000 Subject: [Merge] lp:~prakash09/mailman/3.0 into lp:mailman In-Reply-To: <20150305160322.9444.39695.launchpad@ackee.canonical.com> Message-ID: <20150311113540.2610.4183.launchpad@ackee.canonical.com> The proposal to merge lp:~prakash09/mailman/3.0 into lp:mailman has been updated. Description changed to: Command for starting mailman was "bin/mailman start" which was giving the error. Now it is changed to "mailman start" Added test for registration of odd email addresses. Bug(https://bugs.launchpad.net/mailman/+bug/266288) For more details, see: https://code.launchpad.net/~prakash09/mailman/3.0/+merge/251968 -- Your team Mailman Coders is requested to review the proposed merge of lp:~prakash09/mailman/3.0 into lp:mailman. From bhavesh.goyal093 at gmail.com Wed Mar 11 16:03:54 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Wed, 11 Mar 2015 15:03:54 -0000 Subject: [Merge] lp:~bhavesh-goyal093/postorius/feature-added-mass-removal into lp:postorius Message-ID: <20150311150353.2610.51462.launchpad@ackee.canonical.com> The proposal to merge lp:~bhavesh-goyal093/postorius/feature-added-mass-removal into lp:postorius has been updated. Description changed to: Implemented the feature : Mass Unsubscription of list members from a list. Earlier there was no such option to unsubscribe all / set of members from the list and the list maintainer had to manually unsubscribe each member going through their email addresses searching for each one of them manually in the entire list. Now Mass Removal feature to remove a set of email addresses is present as an option in the list nav bar to selectively unsubscribe a set of email addresses. The user can simply input the emails in each lines similar to mass subscribe and unsubscribe those members. Also, a feature to unsubscribe all members has also been added as a button in members list page itself to empty the list at once, unsubscribing all members from the list keeping list settings / configs the same. This feature was also missing earlier and is now supported with a confirmation too to prevent the user from accidentally pressing the button and emptying the list. For more details, see: https://code.launchpad.net/~bhavesh-goyal093/postorius/feature-added-mass-removal/+merge/252595 -- Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/feature-added-mass-removal into lp:postorius. From mark at msapiro.net Wed Mar 11 16:45:14 2015 From: mark at msapiro.net (Mark Sapiro) Date: Wed, 11 Mar 2015 15:45:14 -0000 Subject: [Bug 1062963] Re: Admin notification not received References: <20121006182248.14546.68625.malonedeb@gac.canonical.com> Message-ID: <20150311154515.18667.60508.malone@gac.canonical.com> @pjoshi If you are talking about MM 2.1, version 2.1.19 (and up) will notify the admin if a user changes her address. If you want other changes such as changing from regular to digest or changing from plain to MIME digest or changing her preferred language, those are not reported and I don't think they need to be. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1062963 Title: Admin notification not received To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1062963/+subscriptions From bhavesh.goyal093 at gmail.com Wed Mar 11 16:04:29 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Wed, 11 Mar 2015 15:04:29 -0000 Subject: [Merge] lp:~bhavesh-goyal093/postorius/feature-added-mass-removal into lp:postorius In-Reply-To: <20150311150353.2610.51462.launchpad@ackee.canonical.com> Message-ID: <20150311150425.12940.85054.launchpad@ackee.canonical.com> Bhavesh Goyal has proposed merging lp:~bhavesh-goyal093/postorius/feature-added-mass-removal into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1430837 in Postorius: "Feature Missing : Selective Removal of List Members [Mass Removal]" https://bugs.launchpad.net/postorius/+bug/1430837 For more details, see: https://code.launchpad.net/~bhavesh-goyal093/postorius/feature-added-mass-removal/+merge/252595 Implemented the feature : Mass Unsubscription of list members from a list. Earlier there was no such option to unsubscribe all / set of members from the list and the list maintainer had to manually unsubscribe each member going through their email addresses searching for each one of them manually in the entire list. Now Mass Removal feature to remove a set of email addresses is present as an option in the list nav bar to selectively unsubscribe a set of email addresses. The user can simply input the emails in each lines similar to mass subscribe and unsubscribe those members. Also, a feature to unsubscribe all members has also been added as a button in members list page itself to empty the list at once, unsubscribing all members from the list keeping list settings / configs the same. This feature was also missing earlier and is now supported with a confirmation too to prevent the user from accidentally pressing the button and emptying the list. -- Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/feature-added-mass-removal into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 285381 bytes Desc: not available URL: From f at florianfuchs.com Wed Mar 11 16:37:16 2015 From: f at florianfuchs.com (Florian Fuchs) Date: Wed, 11 Mar 2015 15:37:16 -0000 Subject: [Merge] lp:~bhavesh-goyal093/postorius/feature-added-mass-removal into lp:postorius In-Reply-To: <20150311150353.2610.51462.launchpad@ackee.canonical.com> Message-ID: <20150311153716.18766.14780.codereview@gac.canonical.com> Review: Needs Fixing Hi Bhavesh, thanks for your merge proposal! These are useful additions. My major concern is the JS-based confirmation: If someone doesn't have JS activated, the removal will happen immediately. Given that the members are a list's most valued assets that's just a little too risky IMO. How about using a separate confirmation page for that? The text area values could be stored in another form on that page, along with a hidden "confirm" field, so the corresponding view function knows that the user really intends to remove the given members (or all of them). Thanks! Florian -- https://code.launchpad.net/~bhavesh-goyal093/postorius/feature-added-mass-removal/+merge/252595 Your team Mailman Coders is subscribed to branch lp:postorius. From coolyashish at gmail.com Thu Mar 12 00:11:16 2015 From: coolyashish at gmail.com (Ashish) Date: Wed, 11 Mar 2015 23:11:16 -0000 Subject: [Bug 1414352] Re: Improve code coverage by adding tests References: <20150124193353.29200.98953.malonedeb@gac.canonical.com> Message-ID: <20150311231117.14806.69837.launchpad@wampee.canonical.com> ** Branch linked: lp:~coolyashish/postorius/tests -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1414352 Title: Improve code coverage by adding tests To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1414352/+subscriptions From prakhar126 at gmail.com Thu Mar 12 11:05:12 2015 From: prakhar126 at gmail.com (pjoshi) Date: Thu, 12 Mar 2015 10:05:12 -0000 Subject: [Bug 1062963] Re: Admin notification not received References: <20121006182248.14546.68625.malonedeb@gac.canonical.com> Message-ID: <20150312100513.25303.57487.malone@chaenomeles.canonical.com> @mark haven't test that yet (the email confirmation on add email address by subscribed user) as there is a bug https://bugs.launchpad.net/postorius/+bug/1430682 and it needs to be fixed first. So let it be done will check that later. :) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1062963 Title: Admin notification not received To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1062963/+subscriptions From prakhar126 at gmail.com Thu Mar 12 12:44:22 2015 From: prakhar126 at gmail.com (pjoshi) Date: Thu, 12 Mar 2015 11:44:22 -0000 Subject: [Bug 1157875] Re: Pipeline list setting should probably be a dropdown rather than text field References: <20130320175818.11194.38065.malonedeb@wampee.canonical.com> Message-ID: <20150312114423.24665.70563.launchpad@chaenomeles.canonical.com> ** Changed in: postorius Assignee: (unassigned) => pjoshi (prakhar126) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1157875 Title: Pipeline list setting should probably be a dropdown rather than text field To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1157875/+subscriptions From prakhar126 at gmail.com Thu Mar 12 13:00:19 2015 From: prakhar126 at gmail.com (pjoshi) Date: Thu, 12 Mar 2015 12:00:19 -0000 Subject: [Bug 1157875] Re: Pipeline list setting should probably be a dropdown rather than text field References: <20130320175818.11194.38065.malonedeb@wampee.canonical.com> Message-ID: <20150312120019.25572.43736.launchpad@soybean.canonical.com> ** Branch linked: lp:~prakhar126/postorius/adding_dropdown_option -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1157875 Title: Pipeline list setting should probably be a dropdown rather than text field To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1157875/+subscriptions From prakhar126 at gmail.com Thu Mar 12 13:23:16 2015 From: prakhar126 at gmail.com (pjoshi) Date: Thu, 12 Mar 2015 12:23:16 -0000 Subject: [Bug 1157875] Re: Pipeline list setting should probably be a dropdown rather than text field References: <20130320175818.11194.38065.malonedeb@wampee.canonical.com> Message-ID: <20150312122317.18700.31398.launchpad@gac.canonical.com> ** Changed in: postorius Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1157875 Title: Pipeline list setting should probably be a dropdown rather than text field To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1157875/+subscriptions From raj.abhilash1 at gmail.com Thu Mar 12 17:36:22 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Thu, 12 Mar 2015 16:36:22 -0000 Subject: [Merge] lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman Message-ID: <20150312163621.8223.10165.launchpad@ackee.canonical.com> Abhilash Raj has proposed merging lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~raj-abhilash1/mailman/mailman_fix/+merge/252774 Change bin/mailman with mailman everwhere in documentation and docstrings. -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 18423 bytes Desc: not available URL: From ankprashar at gmail.com Fri Mar 13 04:25:15 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Fri, 13 Mar 2015 03:25:15 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150313032516.24890.18051.launchpad@chaenomeles.canonical.com> ** Tags added: mailman.client ** Branch linked: lp:~black-perl/mailman.client/handling-special-chars- in-email -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From ankprashar at gmail.com Fri Mar 13 04:39:22 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Fri, 13 Mar 2015 03:39:22 -0000 Subject: [Merge] lp:~black-perl/mailman.client/handling-special-chars-in-email into lp:mailman.client Message-ID: <20150313033921.24298.58071.launchpad@ackee.canonical.com> Ankush Sharma has proposed merging lp:~black-perl/mailman.client/handling-special-chars-in-email into lp:mailman.client. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1429366 in GNU Mailman: "Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always" https://bugs.launchpad.net/mailman/+bug/1429366 For more details, see: https://code.launchpad.net/~black-perl/mailman.client/handling-special-chars-in-email/+merge/252854 As discussed in the bug report, use of emails with special character set is valid as per email RFCs but postorius crashes on using them giving 404 or KeyError always. As discussed on the mailing list a possible solution would be to percent encode these special characters when they appear in the list_id or fqdn_listname before sending a request to the REST server and decoding on the other end. Added utils.py which has to functions `encode` and `encode_url` to faciliate encoding of list_id's in URLs when required. The use of special characters in list_ids is working properly http://oi58.tinypic.com/33u689i.jpg. -- Your team Mailman Coders is requested to review the proposed merge of lp:~black-perl/mailman.client/handling-special-chars-in-email into lp:mailman.client. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 5879 bytes Desc: not available URL: From ankprashar at gmail.com Fri Mar 13 09:37:31 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Fri, 13 Mar 2015 08:37:31 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150313083731.14909.3141.launchpad@wampee.canonical.com> ** Also affects: mailman.client Importance: Undecided Status: New ** Changed in: mailman.client Status: New => Confirmed ** Changed in: mailman.client Assignee: (unassigned) => Ankush Sharma (black-perl) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From ankprashar at gmail.com Fri Mar 13 10:05:16 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Fri, 13 Mar 2015 09:05:16 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150313090517.25510.97150.launchpad@soybean.canonical.com> ** Branch linked: lp:~black-perl/mailman/handling-special-chars-in-email -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From ankprashar at gmail.com Fri Mar 13 10:13:26 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Fri, 13 Mar 2015 09:13:26 -0000 Subject: [Merge] lp:~black-perl/mailman/handling-special-chars-in-email into lp:mailman Message-ID: <20150313091323.14488.96912.launchpad@ackee.canonical.com> Ankush Sharma has proposed merging lp:~black-perl/mailman/handling-special-chars-in-email into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1429366 in GNU Mailman: "Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always" https://bugs.launchpad.net/mailman/+bug/1429366 For more details, see: https://code.launchpad.net/~black-perl/mailman/handling-special-chars-in-email/+merge/252865 In case the mailman-client percent encodes any appeared special characters in the list_identifier or fqdn_listname the mailman's REST server should be able to decode it back. Added support for this decoding operation.As discussed here : http://www.mail-archive.com/mailman-developers%40python.org/msg15317.html -- Your team Mailman Coders is requested to review the proposed merge of lp:~black-perl/mailman/handling-special-chars-in-email into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 728 bytes Desc: not available URL: From ankprashar at gmail.com Fri Mar 13 10:29:23 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Fri, 13 Mar 2015 09:29:23 -0000 Subject: [Merge] lp:~black-perl/mailman/handling-special-chars-in-email into lp:mailman Message-ID: <20150313092922.17061.28427.launchpad@ackee.canonical.com> Ankush Sharma has proposed merging lp:~black-perl/mailman/handling-special-chars-in-email into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~black-perl/mailman/handling-special-chars-in-email/+merge/252867 In case the mailman-client percent encodes any special character appeared in the list_id's or fqdn_listname's, the REST server should be able to decode it back. Added decoding support for it. As discussed here: http://www.mail-archive.com/mailman-developers%40python.org/msg15317.html Now mailman can also use emails with special characters [1] which earlier caused postorius to crash as discussed in the linked bug report. [1] : http://oi58.tinypic.com/33u689i.jpg -- Your team Mailman Coders is requested to review the proposed merge of lp:~black-perl/mailman/handling-special-chars-in-email into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 732 bytes Desc: not available URL: From ankprashar at gmail.com Fri Mar 13 10:19:18 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Fri, 13 Mar 2015 09:19:18 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150313091918.18916.50061.launchpad@gac.canonical.com> ** Branch unlinked: lp:~black-perl/mailman/handling-special-chars-in- email ** Branch linked: lp:~black-perl/mailman/handling-special-chars-in-email ** Branch unlinked: lp:~black-perl/mailman/handling-special-chars-in- email -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From ankprashar at gmail.com Fri Mar 13 10:31:51 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Fri, 13 Mar 2015 09:31:51 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150313093151.25106.10283.launchpad@soybean.canonical.com> ** Branch linked: lp:~black-perl/mailman/handling-special-chars-in-email -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From prakhar126 at gmail.com Fri Mar 13 11:44:23 2015 From: prakhar126 at gmail.com (pjoshi) Date: Fri, 13 Mar 2015 10:44:23 -0000 Subject: [Merge] lp:~prakhar126/postorius/adding_dropdown_option into lp:postorius Message-ID: <20150313104423.5187.87677.launchpad@ackee.canonical.com> pjoshi has proposed merging lp:~prakhar126/postorius/adding_dropdown_option into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1157875 in Postorius: "Pipeline list setting should probably be a dropdown rather than text field" https://bugs.launchpad.net/postorius/+bug/1157875 For more details, see: https://code.launchpad.net/~prakhar126/postorius/adding_dropdown_option/+merge/252878 -- Your team Mailman Coders is requested to review the proposed merge of lp:~prakhar126/postorius/adding_dropdown_option into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1996 bytes Desc: not available URL: From ankprashar at gmail.com Fri Mar 13 15:17:27 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Fri, 13 Mar 2015 14:17:27 -0000 Subject: [Merge] lp:~black-perl/mailman.client/handling-special-chars-in-email into lp:mailman.client Message-ID: <20150313141725.29225.37491.launchpad@ackee.canonical.com> Ankush Sharma has proposed merging lp:~black-perl/mailman.client/handling-special-chars-in-email into lp:mailman.client. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1429366 in GNU Mailman REST Client: "Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always" https://bugs.launchpad.net/mailman.client/+bug/1429366 For more details, see: https://code.launchpad.net/~black-perl/mailman.client/handling-special-chars-in-email/+merge/252899 As discussed in the bug report, use of emails with special character set is valid as per email RFCs but postorius crashes on using them giving 404 or KeyError always. As discussed on the mailing list a possible solution would be to percent encode these special characters when they appear in the list_id or fqdn_listname before sending a request to the REST server and decoding on the other end. Added utils.py which has to functions `encode` and `encode_url` to faciliate encoding of list_id's in URLs when required. The use of special characters in list_ids is working properly http://oi58.tinypic.com/33u689i.jpg. -- Your team Mailman Coders is requested to review the proposed merge of lp:~black-perl/mailman.client/handling-special-chars-in-email into lp:mailman.client. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 5473 bytes Desc: not available URL: From ankprashar at gmail.com Fri Mar 13 15:15:54 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Fri, 13 Mar 2015 14:15:54 -0000 Subject: [Bug 1429366] Re: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always References: <20150307101037.4399.95243.malonedeb@wampee.canonical.com> Message-ID: <20150313141554.18852.43038.launchpad@gac.canonical.com> ** Branch linked: lp:~black-perl/mailman.client/handling-special-chars- in-email ** Changed in: mailman Status: Confirmed => In Progress ** Changed in: mailman.client Status: Confirmed => In Progress ** Changed in: postorius Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1429366 Title: Anatomy of list ids does not keep with that of urls causes some REST end points to return 404 always To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1429366/+subscriptions From godricglow at gmail.com Fri Mar 13 16:44:24 2015 From: godricglow at gmail.com (Pranjal Yadav) Date: Fri, 13 Mar 2015 15:44:24 -0000 Subject: [Merge] lp:~godricglow/postorius/views_test into lp:postorius Message-ID: <20150313154422.19008.12687.launchpad@ackee.canonical.com> Pranjal Yadav has proposed merging lp:~godricglow/postorius/views_test into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~godricglow/postorius/views_test/+merge/252917 removing validate_slug and other changes completed as discussed -- Your team Mailman Coders is requested to review the proposed merge of lp:~godricglow/postorius/views_test into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 8414 bytes Desc: not available URL: From willey at washington.edu Fri Mar 13 17:50:48 2015 From: willey at washington.edu (Stephen Mats Mats) Date: Fri, 13 Mar 2015 16:50:48 -0000 Subject: [Bug 1431969] [NEW] Disable Precedence: bulk filtering on a per-list basis References: <20150313165048.14437.97085.malonedeb@wampee.canonical.com> Message-ID: <20150313165048.14437.97085.malonedeb@wampee.canonical.com> Public bug reported: User wants to be able to disable Precedence: bulk filtering on a per- list basis. Maybe the handling of precedence list and spam stay the same. We've never had any issues with them, just 'bulk'. There seems to be an increasing gulf in agreement about the Precedence header and some tools like TRAC and Jira will use them with precedence 'bulk' by default. Jira is configurable in this regard but TRAC is not. thanks, steve ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1431969 Title: Disable Precedence: bulk filtering on a per-list basis To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1431969/+subscriptions From coolyashish at gmail.com Fri Mar 13 19:26:24 2015 From: coolyashish at gmail.com (Ashish) Date: Fri, 13 Mar 2015 18:26:24 -0000 Subject: [Merge] lp:~coolyashish/postorius/add_email_address_in_settings into lp:postorius Message-ID: <20150313182623.29879.87665.launchpad@ackee.canonical.com> Ashish has proposed merging lp:~coolyashish/postorius/add_email_address_in_settings into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~coolyashish/postorius/add_email_address_in_settings/+merge/252939 Previously we are getting error on add email address page in user's settings as there is not email_confirmation_from set in the send_confirmation_link function in AddressConfirmationProfile model. This change adds the required email in the function. -- Your team Mailman Coders is requested to review the proposed merge of lp:~coolyashish/postorius/add_email_address_in_settings into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 537 bytes Desc: not available URL: From coolyashish at gmail.com Fri Mar 13 20:23:22 2015 From: coolyashish at gmail.com (Ashish) Date: Fri, 13 Mar 2015 19:23:22 -0000 Subject: [Merge] lp:~coolyashish/postorius/mass_unsubscribe into lp:postorius Message-ID: <20150313192321.11065.79449.launchpad@ackee.canonical.com> Ashish has proposed merging lp:~coolyashish/postorius/mass_unsubscribe into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~coolyashish/postorius/mass_unsubscribe/+merge/252943 This change adds feature of mass removal for admin/moderator in postorius interface like mass subscription. -- Your team Mailman Coders is requested to review the proposed merge of lp:~coolyashish/postorius/mass_unsubscribe into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 4593 bytes Desc: not available URL: From willey at washington.edu Fri Mar 13 21:39:08 2015 From: willey at washington.edu (Stephen Mats Mats) Date: Fri, 13 Mar 2015 20:39:08 -0000 Subject: [Bug 1431969] Re: Disable Precedence: bulk filtering on a per-list basis References: <20150313165048.14437.97085.malonedeb@wampee.canonical.com> Message-ID: <20150313203908.18296.71388.malone@gac.canonical.com> whoops. BulkDetection is a local to UW modification. Sorry for the nosie, steve -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1431969 Title: Disable Precedence: bulk filtering on a per-list basis To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1431969/+subscriptions From 1425359 at bugs.launchpad.net Fri Mar 13 22:34:23 2015 From: 1425359 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 13 Mar 2015 21:34:23 -0000 Subject: [Bug 1425359] Re: 500 error code shown by postorius instead of 409 error code References: <20150225025413.24385.93661.malonedeb@wampee.canonical.com> Message-ID: <20150313213425.25778.64685.launchpad@soybean.canonical.com> ** Changed in: mailman Importance: Undecided => High ** Changed in: mailman Milestone: None => 3.0.0b6 ** Changed in: mailman Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1425359 Title: 500 error code shown by postorius instead of 409 error code To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1425359/+subscriptions From noreply at launchpad.net Sat Mar 14 01:57:17 2015 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sat, 14 Mar 2015 00:57:17 -0000 Subject: [Merge] lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman In-Reply-To: <20150312163621.8223.10165.launchpad@ackee.canonical.com> Message-ID: <20150314005714.18610.26038.launchpad@ackee.canonical.com> The proposal to merge lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raj-abhilash1/mailman/mailman_fix/+merge/252774 -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/mailman/mailman_fix into lp:mailman. From 1166911 at bugs.launchpad.net Sat Mar 14 02:17:28 2015 From: 1166911 at bugs.launchpad.net (Barry Warsaw) Date: Sat, 14 Mar 2015 01:17:28 -0000 Subject: [Bug 1166911] Re: domain option for `bin/mailman lists` doesn't work as expected References: <20130409171303.27875.70181.malonedeb@soybean.canonical.com> Message-ID: <20150314011729.14472.82668.launchpad@wampee.canonical.com> ** Changed in: mailman Status: New => Fix Committed ** Changed in: mailman Importance: Undecided => High ** Changed in: mailman Milestone: None => 3.0.0b6 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1166911 Title: domain option for `bin/mailman lists` doesn't work as expected To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1166911/+subscriptions From ankprashar at gmail.com Sat Mar 14 12:19:32 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Sat, 14 Mar 2015 11:19:32 -0000 Subject: [Bug 1418276] Re: Deleting a user via the REST API does not delete their user preferences References: <20150205012953.6713.71408.malonedeb@soybean.canonical.com> Message-ID: <20150314111933.25106.17705.launchpad@soybean.canonical.com> ** Changed in: mailman Assignee: (unassigned) => Ankush Sharma (black-perl) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1418276 Title: Deleting a user via the REST API does not delete their user preferences To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1418276/+subscriptions From pskoli93 at gmail.com Sat Mar 14 14:17:13 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Sat, 14 Mar 2015 13:17:13 -0000 Subject: [Bug 975668] Re: mailman.client conflicts with mailman installation References: <20120407020956.18787.96843.malonedeb@wampee.canonical.com> Message-ID: <20150314131713.14737.76884.malone@wampee.canonical.com> I tried to reproduce this bug on mailman3, I created the virtualenvironment using pyvenv-3.4 venv-3.4 --without-pip and then manually installing pip and setuptools inside venv-3.4 cd venv-3.4 source bin/activate cd .. bzr branch lp:mailman.client cd mailman.client/ python setup.py develop easy_install sphinx cd .. bzr branch lp:mailman cd mailman python setup.py build_sphinx As bootstrap.py is no longer present I omitted that step also I omitted the bin/buildout step Resulted in: running build_sphinx creating /home/pkoli/Desktop/BUG/mailman/build creating /home/pkoli/Desktop/BUG/mailman/build/sphinx creating /home/pkoli/Desktop/BUG/mailman/build/sphinx/doctrees creating /home/pkoli/Desktop/BUG/mailman/build/sphinx/html Running Sphinx v1.3 loading pickled environment... not yet created WARNING: 'default' html theme has been renamed to 'classic'. Please change your html_theme setting either to the new 'alabaster' default theme, or to 'classic' to keep using the old default. building [mo]: targets for 0 po files that are out of date building [html]: targets for 122 source files that are out of date updating environment: 122 added, 0 changed, 0 removed reading sources... [100%] src/mailman/styles/docs/styles looking for now-outdated files... none found pickling environment... done checking consistency... done preparing documents... done WARNING: dot command 'dot' cannot be run (needed for graphviz output), check the graphviz_dot setting writing output... [100%] src/mailman/styles/docs/styles generating indices... genindex writing additional pages... search copying static files... done copying extra files... done dumping search index in English (code: en) ... done dumping object inventory... done build succeeded, 2 warnings. index.html -> README.html I am interested in fixing this bug, can someone assign it to me, I'll start by first testing different cases that can be used to reproduce it and then find a possible solution. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/975668 Title: mailman.client conflicts with mailman installation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/975668/+subscriptions From pskoli93 at gmail.com Sat Mar 14 14:29:19 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Sat, 14 Mar 2015 13:29:19 -0000 Subject: [Bug 975668] Re: mailman.client conflicts with mailman installation References: <20120407020956.18787.96843.malonedeb@wampee.canonical.com> Message-ID: <20150314132919.25270.3568.launchpad@soybean.canonical.com> ** Description changed: If mailman.client is loaded as a separate module (as instructed), then mailman cannot exist in the same environment because there are two "mailman" modules to search. I found this when I tried to generate sphinx documentation for mailman - after I had installed protorious. + after I had installed postorius. To reproduce: mkvirtualenv BUG bzr branch lp:mailman.client cd mailman.client/ python setup.py develop easy_install sphinx cd .. bzr branch lp:mailman cd mailman python bootstrap.py bin/buildout python setup.py build_sphinx - Results in: Running Sphinx v1.1.3 Traceback (most recent call last): - File "setup.py", line 112, in - 'zope.testing<4', - File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py", line 152, in setup - dist.run_commands() - File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 953, in run_commands - self.run_command(cmd) - File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 972, in run_command - cmd_obj.run() - File "/Volumes/UserSpace/rkw/.virtualenvs/BUG/lib/python2.7/site-packages/Sphinx-1.1.3-py2.7.egg/sphinx/setup_command.py", line 140, in run - freshenv=self.fresh_env) - File "/Volumes/UserSpace/rkw/.virtualenvs/BUG/lib/python2.7/site-packages/Sphinx-1.1.3-py2.7.egg/sphinx/application.py", line 102, in __init__ - confoverrides or {}, self.tags) - File "/Volumes/UserSpace/rkw/.virtualenvs/BUG/lib/python2.7/site-packages/Sphinx-1.1.3-py2.7.egg/sphinx/config.py", line 216, in __init__ - exec code in config - File "/Volumes/UserSpace/rkw/.virtualenvs/BUG/mailman/conf.py", line 54, in - from mailman.version import VERSION + ??File "setup.py", line 112, in + ????'zope.testing<4', + ??File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py", line 152, in setup + ????dist.run_commands() + ??File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 953, in run_commands + ????self.run_command(cmd) + ??File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 972, in run_command + ????cmd_obj.run() + ??File "/Volumes/UserSpace/rkw/.virtualenvs/BUG/lib/python2.7/site-packages/Sphinx-1.1.3-py2.7.egg/sphinx/setup_command.py", line 140, in run + ????freshenv=self.fresh_env) + ??File "/Volumes/UserSpace/rkw/.virtualenvs/BUG/lib/python2.7/site-packages/Sphinx-1.1.3-py2.7.egg/sphinx/application.py", line 102, in __init__ + ????confoverrides or {}, self.tags) + ??File "/Volumes/UserSpace/rkw/.virtualenvs/BUG/lib/python2.7/site-packages/Sphinx-1.1.3-py2.7.egg/sphinx/config.py", line 216, in __init__ + ????exec code in config + ??File "/Volumes/UserSpace/rkw/.virtualenvs/BUG/mailman/conf.py", line 54, in + ????from mailman.version import VERSION ImportError: No module named version ** Changed in: mailman Assignee: (unassigned) => Pavan Koli (pskoli93) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/975668 Title: mailman.client conflicts with mailman installation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/975668/+subscriptions From 975668 at bugs.launchpad.net Sat Mar 14 16:09:03 2015 From: 975668 at bugs.launchpad.net (Barry Warsaw) Date: Sat, 14 Mar 2015 15:09:03 -0000 Subject: [Bug 975668] Re: mailman.client conflicts with mailman installation References: <20120407020956.18787.96843.malonedeb@wampee.canonical.com> <20150314132919.25270.3568.launchpad@soybean.canonical.com> Message-ID: <20150314110903.72876664@limelight.wooz.org> On Mar 14, 2015, at 01:29 PM, Pavan Koli wrote: >If mailman.client is loaded as a separate module (as instructed), then >mailman cannot exist in the same environment because there are two >"mailman" modules to search. Use mailman.client with Python 3 and install them both using namespace packages. I haven't actually tried this, but it's (perhaps) how it should work. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/975668 Title: mailman.client conflicts with mailman installation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/975668/+subscriptions From andrew.stuart at supercoders.com.au Sat Mar 14 21:46:30 2015 From: andrew.stuart at supercoders.com.au (Andrew Stuart) Date: Sat, 14 Mar 2015 20:46:30 -0000 Subject: [Bug 1432239] [NEW] Lists cannot be deleted if the have acceptable alias records References: <20150314204630.25473.53454.malonedeb@soybean.canonical.com> Message-ID: <20150314204630.25473.53454.malonedeb@soybean.canonical.com> Public bug reported: Hi Andrew, Actually you have suspected right. Before removing the mailing_list record, we need to remove all records from `acceptablealias` table. We can either use a `MailingListDeleteEvent` event or a new `__delete__` method in `MailingList` model. The error is caused because deleting domains deletes all the mailing list associated with it, and since acceptablealias.mailing_list_id is set to `nullable=False` the deletion of a list is not possible. @barry: this looks like a bug to me, what do you say? Abhilash On 5 Mar 2015, at 11:16 am, Andrew Stuart wrote: Hi Abhilash Requesting your help - do you have some time to help me with this one please? You seem to know a fair bit about the database and sqlalchemy. Do you have any guesses as to what is going on here? It?s becoming quite a problem for me because the database in its stuck state won?t complete my test suite. thanks Andrew On 2 Mar 2015, at 7:41 am, Andrew Stuart wrote: After I run my tests, the Mailman database seems to get into a state in which it is not possible to delete my test mailing list and test domain. I figure it is something to do with the database state but I can?t see what at this stage. ######################################################################################################### ###################################Attempting to delete a domain gives sqlalchemy error ######################################################################################################### curl -X DELETE --verbose --header "authorization: Basic cmVzdGFkbWluOnJlc3RwYXNz" http://localhost:8001/3.0/domains/mail.example.org Traceback (most recent call last): File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 951, in _execute_context context) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/default.py", line 436, in do_execute cursor.execute(statement, parameters) sqlite3.IntegrityError: NOT NULL constraint failed: acceptablealias.mailing_list_id The above exception was the direct cause of the following exception: Traceback (most recent call last): File "/usr/lib/python3.4/wsgiref/handlers.py", line 137, in run self.result = application(self.environ, self.start_response) File "/home/ubuntu/mailman/src/mailman/database/transaction.py", line 57, in wrapper config.db.commit() File "/home/ubuntu/mailman/src/mailman/database/base.py", line 56, in commit self.store.commit() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 776, in commit self.transaction.commit() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 377, in commit self._prepare_impl() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 357, in _prepare_impl self.session.flush() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 1919, in flush self._flush(objects) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 2037, in _flush transaction.rollback(_capture_exception=True) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/langhelpers.py", line 60, in __exit__ compat.reraise(exc_type, exc_value, exc_tb) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 182, in reraise raise value File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 2001, in _flush flush_context.execute() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/unitofwork.py", line 372, in execute rec.execute(self) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/unitofwork.py", line 526, in execute uow File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/persistence.py", line 60, in save_obj mapper, table, update) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/persistence.py", line 518, in _emit_update_statements execute(statement, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 729, in execute return meth(self, multiparams, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/sql/elements.py", line 322, in _execute_on_connection return connection._execute_clauseelement(self, multiparams, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 826, in _execute_clauseelement compiled_sql, distilled_params File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 958, in _execute_context context) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 1159, in _handle_dbapi_exception exc_info File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 188, in raise_from_cause reraise(type(exception), exception, tb=exc_tb, cause=exc_value) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 181, in reraise raise value.with_traceback(tb) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 951, in _execute_context context) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/default.py", line 436, in do_execute cursor.execute(statement, parameters) sqlalchemy.exc.IntegrityError: (IntegrityError) NOT NULL constraint failed: acceptablealias.mailing_list_id 'UPDATE acceptablealias SET mailing_list_id=? WHERE acceptablealias.id = ?' (None, 1) ######################################################################################################### ###################################Attempting to delete a mailing list gives sqlalchemy error ######################################################################################################### curl -X DELETE --verbose --header "authorization: Basic cmVzdGFkbWluOnJlc3RwYXNz" http://localhost:8001/3.0/lists/testlist1.mail.example.org Traceback (most recent call last): File "/usr/lib/python3.4/wsgiref/handlers.py", line 137, in run self.result = application(self.environ, self.start_response) File "/home/ubuntu/mailman/src/mailman/database/transaction.py", line 56, in wrapper rtn = function(*args, **kws) File "/home/ubuntu/mailman/src/mailman/rest/wsgiapp.py", line 62, in __call__ environ, start_response) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/falcon/api.py", line 175, in __call__ responder(req, resp, **params) File "/home/ubuntu/mailman/src/mailman/rest/lists.py", line 145, in on_delete remove_list(self._mlist) File "/home/ubuntu/mailman/src/mailman/app/lifecycle.py", line 101, in remove_list call_name(config.mta.incoming).delete(mlist) File "/home/ubuntu/mailman/src/mailman/mta/postfix.py", line 69, in create self.regenerate() File "/home/ubuntu/mailman/src/mailman/mta/postfix.py", line 83, in regenerate self._generate_lmtp_file(fp) File "/home/ubuntu/mailman/src/mailman/mta/postfix.py", line 116, in _generate_lmtp_file for list_name, mail_host in list_manager.name_components: File "/home/ubuntu/mailman/src/mailman/model/listmanager.py", line 119, in name_components MailingList.list_name): File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/query.py", line 1011, in values return iter(q) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/query.py", line 2437, in __iter__ self.session._autoflush() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 1208, in _autoflush util.raise_from_cause(e) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 188, in raise_from_cause reraise(type(exception), exception, tb=exc_tb, cause=exc_value) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 182, in reraise raise value File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 1198, in _autoflush self.flush() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 1919, in flush self._flush(objects) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 2037, in _flush transaction.rollback(_capture_exception=True) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/langhelpers.py", line 60, in __exit__ compat.reraise(exc_type, exc_value, exc_tb) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 182, in reraise raise value File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/session.py", line 2001, in _flush flush_context.execute() File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/unitofwork.py", line 372, in execute rec.execute(self) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/unitofwork.py", line 526, in execute uow File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/persistence.py", line 60, in save_obj mapper, table, update) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/orm/persistence.py", line 518, in _emit_update_statements execute(statement, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 729, in execute return meth(self, multiparams, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/sql/elements.py", line 322, in _execute_on_connection return connection._execute_clauseelement(self, multiparams, params) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 826, in _execute_clauseelement compiled_sql, distilled_params File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 958, in _execute_context context) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 1159, in _handle_dbapi_exception exc_info File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 188, in raise_from_cause reraise(type(exception), exception, tb=exc_tb, cause=exc_value) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/util/compat.py", line 181, in reraise raise value.with_traceback(tb) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/base.py", line 951, in _execute_context context) File "/home/ubuntu/venv3.4/lib/python3.4/site-packages/SQLAlchemy-0.9.8-py3.4.egg/sqlalchemy/engine/default.py", line 436, in do_execute cursor.execute(statement, parameters) sqlalchemy.exc.IntegrityError: (raised as a result of Query-invoked autoflush; consider using a session.no_autoflush block if this flush is occurring prematurely) (IntegrityError) NOT NULL constraint failed: acceptablealias.mailing_list_id 'UPDATE acceptablealias SET mailing_list_id=? WHERE acceptablealias.id = ?' (None, 1) ######################################################################################################### This is the database at the time of the errors - note I have had to remove an accumulation of UID and preferences INSERTS. ######################################################################################################### PRAGMA foreign_keys=OFF; BEGIN TRANSACTION; CREATE TABLE pended ( id INTEGER NOT NULL, token VARCHAR, expiration_date DATETIME, PRIMARY KEY (id) ); CREATE TABLE preferences ( id INTEGER NOT NULL, acknowledge_posts BOOLEAN, hide_address BOOLEAN, preferred_language VARCHAR, receive_list_copy BOOLEAN, receive_own_postings BOOLEAN, delivery_mode INTEGER, delivery_status INTEGER, PRIMARY KEY (id), CHECK (acknowledge_posts IN (0, 1)), CHECK (hide_address IN (0, 1)), CHECK (receive_list_copy IN (0, 1)), CHECK (receive_own_postings IN (0, 1)) ); CREATE TABLE domain ( id INTEGER NOT NULL, mail_host VARCHAR, base_url VARCHAR, description VARCHAR, contact_address VARCHAR, PRIMARY KEY (id) ); INSERT INTO "domain" VALUES(1,'mail.example.org','http://mail.example.org',NULL,'postmaster at mail.example.org'); CREATE TABLE message ( id INTEGER NOT NULL, message_id VARCHAR, message_id_hash VARCHAR, path VARCHAR, PRIMARY KEY (id) ); CREATE TABLE mailinglist ( id INTEGER NOT NULL, list_name VARCHAR, mail_host VARCHAR, list_id VARCHAR, allow_list_posts BOOLEAN, include_rfc2369_headers BOOLEAN, advertised BOOLEAN, anonymous_list BOOLEAN, created_at DATETIME, next_request_id INTEGER, next_digest_number INTEGER, digest_last_sent_at DATETIME, volume INTEGER, last_post_at DATETIME, accept_these_nonmembers BLOB, admin_immed_notify BOOLEAN, admin_notify_mchanges BOOLEAN, administrivia BOOLEAN, archive_policy INTEGER, autoresponse_grace_period DATETIME, autorespond_owner INTEGER, autoresponse_owner_text VARCHAR, autorespond_postings INTEGER, autoresponse_postings_text VARCHAR, autorespond_requests INTEGER, autoresponse_request_text VARCHAR, filter_action INTEGER, filter_content BOOLEAN, collapse_alternatives BOOLEAN, convert_html_to_plaintext BOOLEAN, bounce_info_stale_after DATETIME, bounce_matching_headers VARCHAR, bounce_notify_owner_on_disable BOOLEAN, bounce_notify_owner_on_removal BOOLEAN, bounce_score_threshold INTEGER, bounce_you_are_disabled_warnings INTEGER, bounce_you_are_disabled_warnings_interval DATETIME, forward_unrecognized_bounces_to INTEGER, process_bounces BOOLEAN, default_member_action INTEGER, default_nonmember_action INTEGER, description VARCHAR, digest_footer_uri VARCHAR, digest_header_uri VARCHAR, digest_is_default BOOLEAN, digest_send_periodic BOOLEAN, digest_size_threshold FLOAT, digest_volume_frequency INTEGER, digestable BOOLEAN, discard_these_nonmembers BLOB, emergency BOOLEAN, encode_ascii_prefixes BOOLEAN, first_strip_reply_to BOOLEAN, footer_uri VARCHAR, forward_auto_discards BOOLEAN, gateway_to_mail BOOLEAN, gateway_to_news BOOLEAN, goodbye_message_uri VARCHAR, header_matches BLOB, header_uri VARCHAR, hold_these_nonmembers BLOB, info VARCHAR, linked_newsgroup VARCHAR, max_days_to_hold INTEGER, max_message_size INTEGER, max_num_recipients INTEGER, member_moderation_notice VARCHAR, mime_is_default_digest BOOLEAN, moderator_password BLOB, newsgroup_moderation INTEGER, nntp_prefix_subject_too BOOLEAN, nondigestable BOOLEAN, nonmember_rejection_notice VARCHAR, obscure_addresses BOOLEAN, owner_chain VARCHAR, owner_pipeline VARCHAR, personalize INTEGER, post_id INTEGER, posting_chain VARCHAR, posting_pipeline VARCHAR, preferred_language VARCHAR, display_name VARCHAR, reject_these_nonmembers BLOB, reply_goes_to_list INTEGER, reply_to_address VARCHAR, require_explicit_destination BOOLEAN, respond_to_post_requests BOOLEAN, scrub_nondigest BOOLEAN, send_goodbye_message BOOLEAN, send_welcome_message BOOLEAN, subject_prefix VARCHAR, topics BLOB, topics_bodylines_limit INTEGER, topics_enabled BOOLEAN, welcome_message_uri VARCHAR, PRIMARY KEY (id), CHECK (allow_list_posts IN (0, 1)), CHECK (include_rfc2369_headers IN (0, 1)), CHECK (advertised IN (0, 1)), CHECK (anonymous_list IN (0, 1)), CHECK (admin_immed_notify IN (0, 1)), CHECK (admin_notify_mchanges IN (0, 1)), CHECK (administrivia IN (0, 1)), CHECK (filter_content IN (0, 1)), CHECK (collapse_alternatives IN (0, 1)), CHECK (convert_html_to_plaintext IN (0, 1)), CHECK (bounce_notify_owner_on_disable IN (0, 1)), CHECK (bounce_notify_owner_on_removal IN (0, 1)), CHECK (process_bounces IN (0, 1)), CHECK (digest_is_default IN (0, 1)), CHECK (digest_send_periodic IN (0, 1)), CHECK (digestable IN (0, 1)), CHECK (emergency IN (0, 1)), CHECK (encode_ascii_prefixes IN (0, 1)), CHECK (first_strip_reply_to IN (0, 1)), CHECK (forward_auto_discards IN (0, 1)), CHECK (gateway_to_mail IN (0, 1)), CHECK (gateway_to_news IN (0, 1)), CHECK (mime_is_default_digest IN (0, 1)), CHECK (nntp_prefix_subject_too IN (0, 1)), CHECK (nondigestable IN (0, 1)), CHECK (obscure_addresses IN (0, 1)), CHECK (require_explicit_destination IN (0, 1)), CHECK (respond_to_post_requests IN (0, 1)), CHECK (scrub_nondigest IN (0, 1)), CHECK (send_goodbye_message IN (0, 1)), CHECK (send_welcome_message IN (0, 1)), CHECK (topics_enabled IN (0, 1)) ); INSERT INTO "mailinglist" VALUES(1,'testlist1','mail.example.org','testlist1.mail.example.org',0,0,0,1,'2015-03-01 20:04:21.186669',1,1,NULL,1,NULL,X'80049503000000000000005D942E',0,1,0,0,'1970-02-15 00:00:00.000000',1,'the owner',2,'the mailing list',1,'the robot',2,1,0,1,'1970-01-08 00:00:00.000000',' # Lines that *start* with a ''#'' are comments. to: friend at public.com message-id: relay.comanche.denmark.eu from: list at listme.com from: .*@uplinkpro.com ',1,1,5,3,'1970-01-08 00:00:00.000000',1,1,0,2,'This is my mailing list','mailman:///$listname/$language/footer-generic.txt',NULL,0,1,10.5,1,1,X'80049503000000000000005D942E',0,0,1,'mailman:///$listname/$language/footer-generic.txt',1,0,0,'',X'80049503000000000000005D942E',NULL,X'80049503000000000000005D942E','','',0,40,10,'',0,NULL,0,1,1,'',1,'default-owner-chain','default-owner-pipeline',0,1,'default-posting-chain','virgin','en','Fnords',X'80049503000000000000005D942E',1,'bee at example.com',1,1,0,1,0,'[ant]',X'80049503000000000000005D942E',5,0,'mailman:///welcome.txt'); CREATE TABLE bounceevent ( id INTEGER NOT NULL, list_id VARCHAR, email VARCHAR, timestamp DATETIME, message_id VARCHAR, context INTEGER, processed BOOLEAN, PRIMARY KEY (id), CHECK (processed IN (0, 1)) ); INSERT INTO "bounceevent" VALUES(1,'testlist1.mail.example.org','testuser1 at mail.example.org','2015-03-01 20:01:54.950333','<20150301200153.A950280974 at ip-10-223-10-27.us-west-1.compute.internal>',1,0); INSERT INTO "bounceevent" VALUES(2,'testlist1.mail.example.org','testuser1 at mail.example.org','2015-03-01 20:01:56.083932','<20150301200155.C229880974 at ip-10-223-10-27.us-west-1.compute.internal>',1,0); INSERT INTO "bounceevent" VALUES(3,'testlist1.mail.example.org','testuser1 at mail.example.org','2015-03-01 20:02:20.319257','<20150301200219.244BE80974 at ip-10-223-10-27.us-west-1.compute.internal>',1,0); INSERT INTO "bounceevent" VALUES(4,'testlist1.mail.example.org','testuser1 at mail.example.org','2015-03-01 20:03:14.618731','<20150301200313.BD8E180974 at ip-10-223-10-27.us-west-1.compute.internal>',1,0); CREATE TABLE uid ( id INTEGER NOT NULL, uid CHAR(32), PRIMARY KEY (id) ); CREATE TABLE ban ( id INTEGER NOT NULL, email VARCHAR, list_id VARCHAR, PRIMARY KEY (id) ); CREATE TABLE user ( id INTEGER NOT NULL, display_name VARCHAR, password VARCHAR, _user_id CHAR(32), _created_on DATETIME, _preferred_address_id INTEGER, preferences_id INTEGER, PRIMARY KEY (id), FOREIGN KEY(preferences_id) REFERENCES preferences (id) ); INSERT INTO "user" VALUES(1,'Server Owner','$6$rounds=101751$cOyechNgTQqeyfTJ$2lHEhtTCYTUuQ37CkZ/ncyptVRW3I9T61WxW8BV6sbzMa2KDJBoU6uRpiWyowbtVej.QTZnL9Ww0YXXM3lPdb/','4e0a784aeaa84b37b0e731aef00683aa','2015-03-01 20:00:41.531120',NULL,2); INSERT INTO "user" VALUES(2,'test user 1','$6$rounds=90188$eLE.L0U2hfbpa9QG$SKzS7PNvGiEvPjKSTDjG5PgDtIvsjARyt6HOtia24zT3eT3w99TCuXlL2ZrL.t7B3xLxX4PuWTolrjd1lZ6Qg.','23856abb3f414114b9cfde92d9557ecb','2015-03-01 20:00:58.143566',NULL,34); INSERT INTO "user" VALUES(4,'','$6$rounds=94146$ydwCyzFScrDi8mJt$Ia4w6zMnEdePdWvm3vuBrn8d0MpWstdmN0mLtImqJ3k/aLaEkZShgw.0aZU4Q7eh1sTuxUAtY7SLkSOWYj0RN.','c5e5dfd8a11e439a868cba6bdedc966e','2015-03-01 20:01:20.944564',NULL,92); CREATE TABLE listarchiver ( id INTEGER NOT NULL, mailing_list_id INTEGER NOT NULL, name VARCHAR NOT NULL, _is_enabled BOOLEAN, PRIMARY KEY (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id), CHECK (_is_enabled IN (0, 1)) ); INSERT INTO "listarchiver" VALUES(1,1,'prototype',1); INSERT INTO "listarchiver" VALUES(2,1,'mail-archive',1); INSERT INTO "listarchiver" VALUES(3,1,'mhonarc',1); CREATE TABLE acceptablealias ( id INTEGER NOT NULL, mailing_list_id INTEGER NOT NULL, alias VARCHAR NOT NULL, PRIMARY KEY (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id) ); INSERT INTO "acceptablealias" VALUES(1,1,'one at example.com'); INSERT INTO "acceptablealias" VALUES(2,1,'two at example.com'); CREATE TABLE pendedkeyvalue ( id INTEGER NOT NULL, "key" VARCHAR, value VARCHAR, pended_id INTEGER, PRIMARY KEY (id), FOREIGN KEY(pended_id) REFERENCES pended (id) ); CREATE TABLE contentfilter ( id INTEGER NOT NULL, mailing_list_id INTEGER, filter_type INTEGER, filter_pattern VARCHAR, PRIMARY KEY (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id) ); CREATE TABLE _request ( id INTEGER NOT NULL, "key" VARCHAR, request_type INTEGER, data_hash VARCHAR, mailing_list_id INTEGER, PRIMARY KEY (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id) ); CREATE TABLE address ( id INTEGER NOT NULL, email VARCHAR, _original VARCHAR, display_name VARCHAR, verified_on DATETIME, registered_on DATETIME, user_id INTEGER, preferences_id INTEGER, PRIMARY KEY (id), FOREIGN KEY(user_id) REFERENCES user (id), FOREIGN KEY(preferences_id) REFERENCES preferences (id) ); INSERT INTO "address" VALUES(1,'theboss at mail.example.org',NULL,'Server Owner',NULL,'2015-03-01 20:00:41.530793',1,1); CREATE TABLE autoresponserecord ( id INTEGER NOT NULL, address_id INTEGER, mailing_list_id INTEGER, response_type INTEGER, date_sent DATE, PRIMARY KEY (id), FOREIGN KEY(address_id) REFERENCES address (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id) ); CREATE TABLE onelastdigest ( id INTEGER NOT NULL, mailing_list_id INTEGER, address_id INTEGER, delivery_mode INTEGER, PRIMARY KEY (id), FOREIGN KEY(mailing_list_id) REFERENCES mailinglist (id), FOREIGN KEY(address_id) REFERENCES address (id) ); CREATE TABLE member ( id INTEGER NOT NULL, _member_id CHAR(32), role INTEGER, list_id VARCHAR, moderation_action INTEGER, address_id INTEGER, preferences_id INTEGER, user_id INTEGER, PRIMARY KEY (id), FOREIGN KEY(address_id) REFERENCES address (id), FOREIGN KEY(preferences_id) REFERENCES preferences (id), FOREIGN KEY(user_id) REFERENCES user (id) ); CREATE TABLE alembic_version ( version_num VARCHAR(32) NOT NULL ); INSERT INTO "alembic_version" VALUES('33e1f5f6fa8'); CREATE INDEX ix_uid_uid ON uid (uid); CREATE INDEX ix_user_preferences_id ON user (preferences_id); CREATE INDEX ix_user__user_id ON user (_user_id); CREATE INDEX ix_listarchiver_mailing_list_id ON listarchiver (mailing_list_id); CREATE INDEX ix_acceptablealias_mailing_list_id ON acceptablealias (mailing_list_id); CREATE INDEX ix_acceptablealias_alias ON acceptablealias (alias); CREATE INDEX ix_pendedkeyvalue_pended_id ON pendedkeyvalue (pended_id); CREATE INDEX ix_contentfilter_mailing_list_id ON contentfilter (mailing_list_id); CREATE INDEX ix__request_mailing_list_id ON _request (mailing_list_id); CREATE INDEX ix_address_user_id ON address (user_id); CREATE INDEX ix_address_preferences_id ON address (preferences_id); CREATE INDEX ix_autoresponserecord_address_id ON autoresponserecord (address_id); CREATE INDEX ix_autoresponserecord_mailing_list_id ON autoresponserecord (mailing_list_id); COMMIT; ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 ** Tags added: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1432239 Title: Lists cannot be deleted if the have acceptable alias records To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1432239/+subscriptions From abhi170893 at gmail.com Sun Mar 15 15:16:16 2015 From: abhi170893 at gmail.com (Abhishek) Date: Sun, 15 Mar 2015 14:16:16 -0000 Subject: [Bug 1418276] Re: Deleting a user via the REST API does not delete their user preferences References: <20150205012953.6713.71408.malonedeb@soybean.canonical.com> Message-ID: <20150315141617.25042.94210.launchpad@soybean.canonical.com> ** Changed in: mailman Assignee: Ankush Sharma (black-perl) => Abhishek (abhi170893) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1418276 Title: Deleting a user via the REST API does not delete their user preferences To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1418276/+subscriptions From 1432239 at bugs.launchpad.net Sun Mar 15 20:44:37 2015 From: 1432239 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 15 Mar 2015 19:44:37 -0000 Subject: [Bug 1432239] Re: Lists cannot be deleted if the have acceptable alias records References: <20150314204630.25473.53454.malonedeb@soybean.canonical.com> Message-ID: <20150315194437.18766.94564.malone@gac.canonical.com> I think this is a real bug. I think you're right that a new ListDeletingEvent should be added to clear out any aliases for the mailing list. I actually tried to write a test for this in src/mailman/model/tests/test_mailinglist.py but the AceptableAliasSet.add() method doesn't seem to add the record to the acceptablealias table. class TestAcceptableAliases(unittest.TestCase): layer = ConfigLayer def setUp(self): self._mlist = create_list('ant at example.com') def test_delete_list_with_acceptable_aliases(self): # LP: #1432239 - deleting a mailing list with acceptable aliases # causes a SQLAlchemy error. The aliases must be deleted first. alias_set = IAcceptableAliasSet(self._mlist) alias_set.add('bee at example.com') self.assertEqual(['bee at example.com'], [alias.alias for alias in alias_set.aliases]) getUtility(IListManager).delete(self._mlist) self.assertEqual(len(alias.alias for alias in alias_set.aliases), 0) $ .tox/py34/bin/python -m nose2 -P test_delete_list_with_acceptable_aliases F ====================================================================== FAIL: test_delete_list_with_acceptable_aliases (mailman.model.tests.test_mailinglist.TestAcceptableAliases) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/barry/projects/mailman/lp1432239/src/mailman/model/tests/test_mailinglist.py", line 162, in test_delete_list_with_acceptable_aliases [alias.alias for alias in alias_set.aliases]) AssertionError: Lists differ: ['bee at example.com'] != [] First list contains 1 additional elements. First extra element 0: bee at example.com - ['bee at example.com'] + [] ---------------------------------------------------------------------- Ran 1 test in 0.173s FAILED (failures=1) I'd rather not add an explicit commit here because IIUC, it isn't necessary in other model layer tests. I think if the test can be made to fail, the fix should be easy. ** Changed in: mailman Status: New => Triaged ** Changed in: mailman Milestone: None => 3.0.0b6 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1432239 Title: Lists cannot be deleted if the have acceptable alias records To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1432239/+subscriptions From 1432239 at bugs.launchpad.net Sun Mar 15 20:49:43 2015 From: 1432239 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 15 Mar 2015 19:49:43 -0000 Subject: [Bug 1432239] Re: Lists cannot be deleted if the have acceptable alias records References: <20150314204630.25473.53454.malonedeb@soybean.canonical.com> Message-ID: <20150315194943.15146.40196.malone@wampee.canonical.com> Just to follow up: this does need to be fixed in the model. The REST failure is just a byproduct. And remember that the REST tests must commit changes to the database because the test and the REST server run in different processes. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1432239 Title: Lists cannot be deleted if the have acceptable alias records To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1432239/+subscriptions From 1423756 at bugs.launchpad.net Sun Mar 15 20:52:08 2015 From: 1423756 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 15 Mar 2015 19:52:08 -0000 Subject: [Bug 1423756] Re: Ability to define user as domainowner or serverowner References: <20150220001108.20399.87602.malonedeb@gac.canonical.com> Message-ID: <20150315195209.18358.64730.launchpad@gac.canonical.com> ** Changed in: mailman Status: New => Triaged ** Changed in: mailman Importance: Undecided => High ** Changed in: mailman Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: mailman Milestone: None => 3.0.0b6 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1423756 Title: Ability to define user as domainowner or serverowner To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1423756/+subscriptions From 1423756 at bugs.launchpad.net Sun Mar 15 21:02:05 2015 From: 1423756 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 15 Mar 2015 20:02:05 -0000 Subject: [Bug 1423756] Re: Ability to define user as domainowner or serverowner References: <20150220001108.20399.87602.malonedeb@gac.canonical.com> Message-ID: <20150315200205.18916.54767.malone@gac.canonical.com> This needs to be tackled at several layers. Within the model, I think we add a flag to the user object to indicate whether they are a server_owner or not. It defaults to False. Also at the model layer, Domains currently have a `contact_address` field. I think this should go away in favor of a set of user references. This will probably need to go in a separate table. The field would be called `owners` and it would iterate over user objects for users who own the domain. I wish we could use a roster but rosters require mailing lists. There will need to be a database migration for these changes. Tests and docs too. After that, both features need to be plumbed through the REST API. For the server_owner flag, it's easy; just add the boolean to the user record. For domains, we probably need a subresource which is a collection of owners, i.e. users. That might make the _DomainBase a little trickier but I think it can be done. Then that subresource probably needs the usual GET, POST, PUT, PATCH, DELETE methods to add and remove domain owners. Docs and tests for these too. Am I missing anything? Would anyone like to take a crack at this? ** Changed in: mailman Assignee: Barry Warsaw (barry) => (unassigned) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1423756 Title: Ability to define user as domainowner or serverowner To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1423756/+subscriptions From andrew.stuart at supercoders.com.au Sun Mar 15 21:24:33 2015 From: andrew.stuart at supercoders.com.au (Andrew Stuart) Date: Sun, 15 Mar 2015 20:24:33 -0000 Subject: [Bug 1423756] Re: Ability to define user as domainowner or serverowner References: <20150220001108.20399.87602.malonedeb@gac.canonical.com> Message-ID: <20150315202433.14837.48877.malone@wampee.canonical.com> If there is a GSOC student with the skills to take this on then that would be ideal as I?m struggling to find enough time to get my own code finalised. Would it make sense to post to mailman-developers and ask if there are any GSOC?s up for it? as -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1423756 Title: Ability to define user as domainowner or serverowner To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1423756/+subscriptions From andrew.stuart at supercoders.com.au Sun Mar 15 21:45:40 2015 From: andrew.stuart at supercoders.com.au (Andrew Stuart) Date: Sun, 15 Mar 2015 20:45:40 -0000 Subject: [Bug 1423756] Re: Ability to define user as domainowner or serverowner References: <20150220001108.20399.87602.malonedeb@gac.canonical.com> Message-ID: <20150315204540.18799.37346.malone@gac.canonical.com> Actually re-thinking this after my post of 20 minutes ago. If Barry is willing to look at it that might be the best way to move ahead. Possibly too challenging for a GSOC student? -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1423756 Title: Ability to define user as domainowner or serverowner To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1423756/+subscriptions From f at florianfuchs.com Sun Mar 15 22:06:21 2015 From: f at florianfuchs.com (Florian Fuchs) Date: Sun, 15 Mar 2015 21:06:21 -0000 Subject: [Merge] lp:~flo-fuchs/mailman.client/archival_options into lp:mailman.client Message-ID: <20150315210620.17168.91381.launchpad@ackee.canonical.com> Florian Fuchs has proposed merging lp:~flo-fuchs/mailman.client/archival_options into lp:mailman.client. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1432398 in GNU Mailman REST Client: "Add archival options" https://bugs.launchpad.net/mailman.client/+bug/1432398 For more details, see: https://code.launchpad.net/~flo-fuchs/mailman.client/archival_options/+merge/253005 This change introduces archival options to mailman.client: - _List objects now have an `archivers` property which holds a dictionary with ": " pairs. - _List objects now have a `set_archiver` method which accepts an archiver name and a Boolean for the `enabled` status. -- Your team Mailman Coders is requested to review the proposed merge of lp:~flo-fuchs/mailman.client/archival_options into lp:mailman.client. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 302000 bytes Desc: not available URL: From aurelien at bompard.org Mon Mar 16 11:23:57 2015 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Mon, 16 Mar 2015 10:23:57 -0000 Subject: [Merge] lp:~abompard/mailman/fix-import-from-mm2 into lp:mailman In-Reply-To: <20150221185321.27029.71233.launchpad@ackee.canonical.com> Message-ID: <20150316102356.25396.45265.codereview@chaenomeles.canonical.com> I merged the changes in HEAD, please check out those fixes. -- https://code.launchpad.net/~abompard/mailman/fix-import-from-mm2/+merge/250535 Your team Mailman Coders is requested to review the proposed merge of lp:~abompard/mailman/fix-import-from-mm2 into lp:mailman. From 2013165 at iiitdmj.ac.in Mon Mar 16 17:30:21 2015 From: 2013165 at iiitdmj.ac.in (Rashi Karanpuria) Date: Mon, 16 Mar 2015 16:30:21 -0000 Subject: [Bug 1427979] Re: Documentation mistake References: <20150304042101.17031.44512.malonedeb@gac.canonical.com> Message-ID: <20150316163021.25095.92342.launchpad@chaenomeles.canonical.com> ** Branch linked: lp:~rashi007/mailman/docsfix -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1427979 Title: Documentation mistake To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1427979/+subscriptions From 2013165 at iiitdmj.ac.in Mon Mar 16 17:27:34 2015 From: 2013165 at iiitdmj.ac.in (Rashi Karanpuria) Date: Mon, 16 Mar 2015 16:27:34 -0000 Subject: [Bug 1165589] Re: Switchboard fails to log the error message with some exceptions. References: <20130407001403.10398.36355.malonedeb@gac.canonical.com> Message-ID: <20150316162734.18238.63654.launchpad@gac.canonical.com> ** Branch linked: lp:~rashi007/mailman/rashi -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1165589 Title: Switchboard fails to log the error message with some exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1165589/+subscriptions From 2013165 at iiitdmj.ac.in Mon Mar 16 17:36:00 2015 From: 2013165 at iiitdmj.ac.in (Rashi Karanpuria) Date: Mon, 16 Mar 2015 16:36:00 -0000 Subject: [Merge] lp:~rashi007/mailman/rashi into lp:mailman Message-ID: <20150316163557.350.47304.launchpad@ackee.canonical.com> Rashi Karanpuria has proposed merging lp:~rashi007/mailman/rashi into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1165589 in GNU Mailman: "Switchboard fails to log the error message with some exceptions." https://bugs.launchpad.net/mailman/+bug/1165589 For more details, see: https://code.launchpad.net/~rashi007/mailman/rashi/+merge/253080 Bug fix for 1165589 -- Your team Mailman Coders is requested to review the proposed merge of lp:~rashi007/mailman/rashi into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 725 bytes Desc: not available URL: From 2013165 at iiitdmj.ac.in Mon Mar 16 17:36:09 2015 From: 2013165 at iiitdmj.ac.in (Rashi Karanpuria) Date: Mon, 16 Mar 2015 16:36:09 -0000 Subject: [Merge] lp:~rashi007/mailman/docsfix into lp:mailman Message-ID: <20150316163606.350.32261.launchpad@ackee.canonical.com> Rashi Karanpuria has proposed merging lp:~rashi007/mailman/docsfix into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1427979 in GNU Mailman: "Documentation mistake" https://bugs.launchpad.net/mailman/+bug/1427979 For more details, see: https://code.launchpad.net/~rashi007/mailman/docsfix/+merge/253081 Docs fix -- Your team Mailman Coders is requested to review the proposed merge of lp:~rashi007/mailman/docsfix into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 807 bytes Desc: not available URL: From raj.abhilash1 at gmail.com Mon Mar 16 19:28:25 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Mon, 16 Mar 2015 18:28:25 -0000 Subject: [Bug 1432239] Re: Lists cannot be deleted if the have acceptable alias records References: <20150314204630.25473.53454.malonedeb@soybean.canonical.com> Message-ID: <20150316182826.25473.44564.launchpad@soybean.canonical.com> ** Tags added: mailman3-suite-blocker -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1432239 Title: Lists cannot be deleted if the have acceptable alias records To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1432239/+subscriptions From raj.abhilash1 at gmail.com Mon Mar 16 19:32:33 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Mon, 16 Mar 2015 18:32:33 -0000 Subject: [Bug 1423756] Re: Ability to define user as domainowner or serverowner References: <20150220001108.20399.87602.malonedeb@gac.canonical.com> Message-ID: <20150316183234.18389.98214.launchpad@gac.canonical.com> ** Changed in: mailman Assignee: (unassigned) => Abhilash Raj (raj-abhilash1) ** Tags added: mailman3-suite-blocker -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1423756 Title: Ability to define user as domainowner or serverowner To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1423756/+subscriptions From prakash.gbpec at gmail.com Tue Mar 17 05:47:25 2015 From: prakash.gbpec at gmail.com (Prakash Kumar) Date: Tue, 17 Mar 2015 04:47:25 -0000 Subject: [Merge] lp:~prakash09/mailman/test into lp:mailman Message-ID: <20150317044723.30371.40937.launchpad@ackee.canonical.com> Prakash Kumar has proposed merging lp:~prakash09/mailman/test into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #266288 in GNU Mailman: "Valid E-mails Rejected as Invalid" https://bugs.launchpad.net/mailman/+bug/266288 For more details, see: https://code.launchpad.net/~prakash09/mailman/test/+merge/253150 Test added for registration of odd email id. It is the test for the bug https://bugs.launchpad.net/mailman/+bug/266288. Test is added in the 'src/mailman/app/tests/test_registration.py' file. -- Your team Mailman Coders is requested to review the proposed merge of lp:~prakash09/mailman/test into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 812 bytes Desc: not available URL: From prakash.gbpec at gmail.com Tue Mar 17 05:49:22 2015 From: prakash.gbpec at gmail.com (Prakash Kumar) Date: Tue, 17 Mar 2015 04:49:22 -0000 Subject: [Merge] lp:~prakash09/mailman/3.0 into lp:mailman Message-ID: <20150317044921.30553.24398.launchpad@ackee.canonical.com> Prakash Kumar has proposed merging lp:~prakash09/mailman/3.0 into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~prakash09/mailman/3.0/+merge/253151 For starting mailman 'bin/mailman start' was written in the documentation earlier which is now corrected to 'mailman start'. Earlier it was giving error. -- Your team Mailman Coders is requested to review the proposed merge of lp:~prakash09/mailman/3.0 into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 47 bytes Desc: not available URL: From prakash.gbpec at gmail.com Tue Mar 17 05:44:45 2015 From: prakash.gbpec at gmail.com (Prakash Kumar) Date: Tue, 17 Mar 2015 04:44:45 -0000 Subject: [Bug 266288] Re: Valid E-mails Rejected as Invalid References: <20080905193037.27052.8355.launchpad@forster.canonical.com> Message-ID: <20150317044445.25713.98450.launchpad@soybean.canonical.com> ** Branch linked: lp:~prakash09/mailman/test -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/266288 Title: Valid E-mails Rejected as Invalid To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/266288/+subscriptions From mark at msapiro.net Tue Mar 17 16:16:39 2015 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 17 Mar 2015 15:16:39 -0000 Subject: [Bug 266288] Re: Valid E-mails Rejected as Invalid References: <20080905193037.27052.8355.launchpad@forster.canonical.com> Message-ID: <20150317151639.18799.24162.malone@gac.canonical.com> This was fixed in Mailman 2.1.18, but updating this bug was overlooked at the time. ** Changed in: mailman Status: New => Fix Released ** Changed in: mailman Milestone: 2.1-stable => 2.1.18 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/266288 Title: Valid E-mails Rejected as Invalid To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/266288/+subscriptions From abhi170893 at gmail.com Thu Mar 19 06:43:16 2015 From: abhi170893 at gmail.com (Abhishek) Date: Thu, 19 Mar 2015 05:43:16 -0000 Subject: [Bug 1418276] Re: Deleting a user via the REST API does not delete their user preferences References: <20150205012953.6713.71408.malonedeb@soybean.canonical.com> Message-ID: <20150319054316.13345.42566.malone@wampee.canonical.com> Deleted the preferences of the user being deleted before deleting him. ** Patch added: "delete_preferences_on_user_deletion" https://bugs.launchpad.net/mailman/+bug/1418276/+attachment/4349590/+files/delete_preferences_on_user_deletion.patch ** Changed in: mailman Status: New => In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1418276 Title: Deleting a user via the REST API does not delete their user preferences To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1418276/+subscriptions From abhi170893 at gmail.com Fri Mar 20 15:36:14 2015 From: abhi170893 at gmail.com (Abhishek) Date: Fri, 20 Mar 2015 14:36:14 -0000 Subject: [Bug 1418276] Re: Deleting a user via the REST API does not delete their user preferences References: <20150205012953.6713.71408.malonedeb@soybean.canonical.com> Message-ID: <20150320143615.14267.88960.malone@wampee.canonical.com> Deleted the preferences of the user being deleted before deleting him and added test for it. ** Attachment added: "contains solution and test for it." https://bugs.launchpad.net/mailman/+bug/1418276/+attachment/4350705/+files/preferences_delete_and_test -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1418276 Title: Deleting a user via the REST API does not delete their user preferences To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1418276/+subscriptions From 1418276 at bugs.launchpad.net Fri Mar 20 17:43:48 2015 From: 1418276 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 20 Mar 2015 16:43:48 -0000 Subject: [Bug 1418276] Re: Deleting a user via the REST API does not delete their user preferences References: <20150205012953.6713.71408.malonedeb@soybean.canonical.com> Message-ID: <20150320164348.16954.74746.malone@gac.canonical.com> Thanks for the patch and the test, it's a great contribution. I am going to apply it with some modifications. Here is some feedback for the future: Please read PEP 8 and the Mailman style guide for our coding standards. Because the fix is in the model, there should be a test in the model. It's okay to also have a test in the REST layer because that's where the problem was observed. I adapted your REST test and added one to the model. Be sure to run the full test suite with `tox` both before and after applying your fix. It's a good idea to add the test, run tox to validate that the test fails, then add your fix to validate that it succeeds. Also, running the full suite before submitting a patch ensures that there are no regressions elsewhere in Mailman. When attributing fixes by community members, I use the name given in your Launchpad id. If you want your full name to appear in the NEWS file, please contact me directly. See r7307 for the full, applied patch. ** Changed in: mailman Milestone: None => 3.0.0b6 ** Changed in: mailman Importance: Undecided => High ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1418276 Title: Deleting a user via the REST API does not delete their user preferences To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1418276/+subscriptions From abhi170893 at gmail.com Fri Mar 20 18:41:24 2015 From: abhi170893 at gmail.com (Abhishek) Date: Fri, 20 Mar 2015 17:41:24 -0000 Subject: [Bug 1418276] Re: Deleting a user via the REST API does not delete their user preferences References: <20150205012953.6713.71408.malonedeb@soybean.canonical.com> Message-ID: <20150320174124.16544.41190.malone@gac.canonical.com> Thanks Barry for the suggestions. I will see the PEP 8 and the Mailman guide. And i tried pushing the branch for the merge proposal, but from inside the college i cant do ssh outside and was getting error. So i submitted the patch. I looked at the r7307 and wanted to ask something: In rest/tests/test_users.py you have used config.db.store.query(Preferences) inside with. But there is another usage of it in line 221 and also in the file model/tests/test_user.py which are not inside with block. Any specific reason for the difference..? 230 with transaction(): 231 preferences = config.db.store.query(Preferences).filter_by( 232 id=anne.preferences.id) 233 self.assertEqual(preferences.count(), 0) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1418276 Title: Deleting a user via the REST API does not delete their user preferences To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1418276/+subscriptions From barry at python.org Fri Mar 20 20:38:42 2015 From: barry at python.org (Barry Warsaw) Date: Fri, 20 Mar 2015 15:38:42 -0400 Subject: [Bug 1418276] Re: Deleting a user via the REST API does not delete their user preferences In-Reply-To: <20150320174124.16544.41190.malone@gac.canonical.com> References: <20150205012953.6713.71408.malonedeb@soybean.canonical.com> <20150320174124.16544.41190.malone@gac.canonical.com> Message-ID: <20150320153842.1b12ee8c@limelight.wooz.org> On Mar 20, 2015, at 05:41 PM, Abhishek wrote: >In rest/tests/test_users.py you have used >config.db.store.query(Preferences) inside with. But there is another >usage of it in line 221 and also in the file model/tests/test_user.py >which are not inside with block. Any specific reason for the >difference..? > >230 with transaction(): >231 preferences = config.db.store.query(Preferences).filter_by( >232 id=anne.preferences.id) >233 self.assertEqual(preferences.count(), 0) Yes. The ids don't get assigned until after the commit, so they have to be within the with-statement in order for the subsequent query to work. But after that, the delete does not require a commit for the query to succeed. I don't think this was the case with Storm, but it appears to be so with SQLAlchemy. From 1418276 at bugs.launchpad.net Fri Mar 20 20:38:42 2015 From: 1418276 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 20 Mar 2015 19:38:42 -0000 Subject: [Bug 1418276] Re: Deleting a user via the REST API does not delete their user preferences References: <20150205012953.6713.71408.malonedeb@soybean.canonical.com> <20150320174124.16544.41190.malone@gac.canonical.com> Message-ID: <20150320153842.1b12ee8c@limelight.wooz.org> On Mar 20, 2015, at 05:41 PM, Abhishek wrote: >In rest/tests/test_users.py you have used >config.db.store.query(Preferences) inside with. But there is another >usage of it in line 221 and also in the file model/tests/test_user.py >which are not inside with block. Any specific reason for the >difference..? > >230 with transaction(): >231 preferences = config.db.store.query(Preferences).filter_by( >232 id=anne.preferences.id) >233 self.assertEqual(preferences.count(), 0) Yes. The ids don't get assigned until after the commit, so they have to be within the with-statement in order for the subsequent query to work. But after that, the delete does not require a commit for the query to succeed. I don't think this was the case with Storm, but it appears to be so with SQLAlchemy. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1418276 Title: Deleting a user via the REST API does not delete their user preferences To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1418276/+subscriptions From datht0404 at gmail.com Sat Mar 21 10:43:28 2015 From: datht0404 at gmail.com (dat) Date: Sat, 21 Mar 2015 09:43:28 -0000 Subject: [Bug 1434788] [NEW] How to fix Mailman Bug when Admin Login? References: <20150321094328.14870.6730.malonedeb@wampee.canonical.com> Message-ID: <20150321094328.14870.6730.malonedeb@wampee.canonical.com> Public bug reported: Im tried Login to a list administrator but my system throwed bug: Bug in Mailman version 2.1.9 We're sorry, we hit a bug! Please inform the webmaster for this site of this problem. Printing of traceback and other system information has been explicitly inhibited, but the webmaster can find this information in the Mailman error logs. [----- Mailman Version: 2.1.9 -----] [----- Traceback ------] Traceback (most recent call last): File "/usr/lib/mailman/scripts/driver", line 101, in run_main main() File "/usr/lib/mailman/Mailman/Cgi/admin.py", line 197, in main show_results(mlist, doc, category, subcat, cgidata) File "/usr/lib/mailman/Mailman/Cgi/admin.py", line 521, in show_results form.AddItem(show_variables(mlist, category, subcat, cgidata, doc)) File "/usr/lib/mailman/Mailman/Cgi/admin.py", line 570, in show_variables add_options_table_item(mlist, category, subcat, table, item) File "/usr/lib/mailman/Mailman/Cgi/admin.py", line 585, in add_options_table_item val = get_item_gui_value(mlist, category, kind, varname, params, extra) File "/usr/lib/mailman/Mailman/Cgi/admin.py", line 624, in get_item_gui_value value = getattr(mlist, varname) File "/usr/lib/mailman/Mailman/MailList.py", line 146, in __getattr__ AttributeError: from_is_list ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1434788 Title: How to fix Mailman Bug when Admin Login? To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1434788/+subscriptions From mark at msapiro.net Sat Mar 21 18:59:50 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 21 Mar 2015 17:59:50 -0000 Subject: [Bug 1434788] Re: How to fix Mailman Bug when Admin Login? References: <20150321094328.14870.6730.malonedeb@wampee.canonical.com> Message-ID: <20150321175950.23123.63802.malone@chaenomeles.canonical.com> Someone has done an incomplete job of backporting the from_is_list feature from Mailman 2.1.16+ into your 2.1.9 Mailman installation. The /usr/lib/mailman/Mailman/Gui/General.py file at least has been modified to include the option, but either the changes to /usr/lib/mailman/Mailman/versions.py to add the attribute to existing lists and/or changes to /usr/lib/mailman/Mailman/MailList.py to add the attribute to new lists have not been made or the DATA_FILE_VERSION setting in /usr/lib/mailman/Mailman/Version.py has not been incremented. ** Changed in: mailman Status: New => Invalid -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1434788 Title: How to fix Mailman Bug when Admin Login? To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1434788/+subscriptions From bhavesh.goyal093 at gmail.com Sun Mar 22 16:08:25 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Sun, 22 Mar 2015 15:08:25 -0000 Subject: [Merge] lp:~bhavesh-goyal093/postorius/fixed-nav-role-identification into lp:postorius Message-ID: <20150322150823.15547.30433.launchpad@ackee.canonical.com> Bhavesh Goyal has proposed merging lp:~bhavesh-goyal093/postorius/fixed-nav-role-identification into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1431474 in Postorius: "User roles not correctly identified in postorius nav bar" https://bugs.launchpad.net/postorius/+bug/1431474 For more details, see: https://code.launchpad.net/~bhavesh-goyal093/postorius/fixed-nav-role-identification/+merge/253771 Fixed Bug #1431474 Mailman offers different views for different roles in list nav bar. Earlier if the user had some access privileges for instance (a moderator), the the nav bar options which he got were the same as that of a normal subscriber. Manually opening the page from URL though allowed the user to access the privileged controls. Now, a correct view is given for each of the member roles by changing the if condition of list_summary template which was earlier set to display nav options only for super users. Also, Certain List Pages such as Held_messages were not accessible to moderators even though they have the right to access them and were given only to owners. Now The Permissions of the page are also corrected and set to moderators which hold actual control for those pages. -- Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/fixed-nav-role-identification into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 2152 bytes Desc: not available URL: From bhavesh.goyal093 at gmail.com Sun Mar 22 23:01:21 2015 From: bhavesh.goyal093 at gmail.com (Bhavesh Goyal) Date: Sun, 22 Mar 2015 22:01:21 -0000 Subject: [Merge] lp:~bhavesh-goyal093/postorius/feature-implemented-mass-removal into lp:postorius Message-ID: <20150322220120.27475.47119.launchpad@ackee.canonical.com> Bhavesh Goyal has proposed merging lp:~bhavesh-goyal093/postorius/feature-implemented-mass-removal into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~bhavesh-goyal093/postorius/feature-implemented-mass-removal/+merge/253775 Implemented the feature : Mass Unsubscription of list members from a list. Earlier there was no such option to unsubscribe all / set of members from the list and the list maintainer had to manually unsubscribe each member going through their email addresses searching for each one of them manually in the entire list. Now Mass Removal feature to remove a set of email addresses is present as an option in the list nav bar to selectively unsubscribe a set of email addresses. The user can simply input the emails in each lines similar to mass subscribe and unsubscribe those members. Also, a feature to unsubscribe all members has also been added as a button under the same tab itself to empty the list at once, unsubscribing all members from the list keeping list settings / configs the same. This feature was also missing earlier and is now supported with a confirmation page too to prevent the user from accidentally pressing the button and emptying the list. -- Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/feature-implemented-mass-removal into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 9714 bytes Desc: not available URL: From anabee.emacs at gmail.com Tue Mar 24 02:09:25 2015 From: anabee.emacs at gmail.com (Ana Badescu) Date: Tue, 24 Mar 2015 01:09:25 -0000 Subject: [Merge] lp:~anabee-emacs/postorius/admin-settings into lp:postorius Message-ID: <20150324010924.10755.68690.launchpad@ackee.canonical.com> Ana Badescu has proposed merging lp:~anabee-emacs/postorius/admin-settings into lp:postorius. Requested reviews: Florian Fuchs (flo-fuchs) For more details, see: https://code.launchpad.net/~anabee-emacs/postorius/admin-settings/+merge/253903 I investigated how Django forms can be customised but I found this solution far more cleaner. Attributes (such as classes, ids), can be indeed added to forms from within Django while composing the form. However, by default, input elements, such radio buttons are stacked vertically, not horizontally. So I inspected the style elements on some of the radio buttons, found that it boiled down to some styling properties that we could do without. -- Your team Mailman Coders is subscribed to branch lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 735 bytes Desc: not available URL: From pskoli93 at gmail.com Tue Mar 24 12:17:30 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Tue, 24 Mar 2015 11:17:30 -0000 Subject: [Bug 543618] Re: test breaks if existing mailman.cfg is found References: <20100321181821.13322.75963.malonedeb@potassium.ubuntu.com> Message-ID: <20150324111730.25843.9015.launchpad@gac.canonical.com> ** Branch unlinked: lp:mailman -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/543618 Title: test breaks if existing mailman.cfg is found To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/543618/+subscriptions From raj.abhilash1 at gmail.com Tue Mar 24 16:50:17 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Tue, 24 Mar 2015 15:50:17 -0000 Subject: [Bug 1435941] [NEW] Postgresql support is broken References: <20150324155017.7787.99641.malonedeb@chaenomeles.canonical.com> Message-ID: <20150324155017.7787.99641.malonedeb@chaenomeles.canonical.com> Public bug reported: The support for postgresql database backend is broken (I guess after the python3 port). The details of the failures can be found here with the continuous integration on gitlab https://ci.gitlab.com/projects/828 ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 mailman3-suite-blocker -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1435941 Title: Postgresql support is broken To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1435941/+subscriptions From pskoli93 at gmail.com Tue Mar 24 20:31:16 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Tue, 24 Mar 2015 19:31:16 -0000 Subject: [Bug 975668] Re: mailman.client conflicts with mailman installation References: <20120407020956.18787.96843.malonedeb@wampee.canonical.com> Message-ID: <20150324193116.7976.83235.malone@soybean.canonical.com> I followed the steps as mentioned to reproduce the error. mkvirtualenv BUGS bzr branch lp:mailman.client cd mailman.client/ python setup.py develop easy_install sphinx cd .. bzr branch lp:mailman cd mailman python setup.py develop python setup.py build_sphinx The build succeeds with no warnings. I ran through this documentation PEP420 (https://www.python.org/dev/peps/pep-0420/) to check about namespace packages, as I thought the error may be associated with it. Checking the output error which Richard has got- >File "/Volumes/UserSpace/rkw/.virtualenvs/BUG/mailman/conf.py", line 54, in No conf.py file present now, instead I looked in options.py >from mailman.version import VERSION The above line no longer exists, now the line given below exists. from mailman.version import MAILMAN_VERSION(http://bazaar.launchpad.net/~mailman-coders/mailman/3.0/view/head:/src/mailman/options.py#L34) >ImportError: No module named version I think it was caused due to some namespace package and modules issues which were present and were resolved using PEP 420. As this bug was reported on 2012-04-07 and the PEP 420 was created on 2012-04-19, maybe the BUG has been resolved by applying changes as recommended in PEP 420. Further trying to confirm whether the issue has been resolved, I checked the file __init__.py(http://bazaar.launchpad.net/~mailman- coders/mailman/3.0/view/head:/src/mailman/__init__.py) According to this post(http://stackoverflow.com/questions/1675734/how- do-i-create-a-namespace-package-in-python/27586272#27586272) the code given in __init__.py , is sufficient to handle the different modules and namespace packages issues. So ideally we should be able to run import mailman.version without any errors, and the successful build which I got at the end confirms that the BUG has been resolved. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/975668 Title: mailman.client conflicts with mailman installation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/975668/+subscriptions From pskoli93 at gmail.com Tue Mar 24 20:36:43 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Tue, 24 Mar 2015 19:36:43 -0000 Subject: [Bug 975668] Re: mailman.client conflicts with mailman installation References: <20120407020956.18787.96843.malonedeb@wampee.canonical.com> Message-ID: <20150324193644.26164.67206.launchpad@gac.canonical.com> ** Changed in: mailman Status: Triaged => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/975668 Title: mailman.client conflicts with mailman installation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/975668/+subscriptions From pskoli93 at gmail.com Tue Mar 24 21:06:39 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Tue, 24 Mar 2015 20:06:39 -0000 Subject: [Bug 975668] Re: mailman.client conflicts with mailman installation References: <20120407020956.18787.96843.malonedeb@wampee.canonical.com> Message-ID: <20150324200639.7513.23930.malone@soybean.canonical.com> Some observations- >Checking the output error which Richard has got- >>File "/Volumes/UserSpace/rkw/.virtualenvs/BUG/mailman/conf.py", line 54, in >No conf.py file present now, instead I looked in options.py >>from mailman.version import VERSION >The above line no longer exists, now the line given below exists. >from mailman.version import MAILMAN_VERSION(http://bazaar.launchpad.net/~mailman->coders/mailman/3.0/view/head:/src/mailman/options.py#L34) The file conf.py is present in mailman folder, I was looking for it in src/mailman folder. >>from mailman.version import VERSION >The above line no longer exists, now the line given below exists. >from mailman.version import MAILMAN_VERSION(http://bazaar.launchpad.net/~mailman->coders/mailman/3.0/view/head:/src/mailman/options.py#L34) The line exists at (http://bazaar.launchpad.net/~mailman- coders/mailman/3.0/view/head:/conf.py#L54) Submitting a minor patch for print statement. ** Patch added: "Minor change to print statement" https://bugs.launchpad.net/mailman/+bug/975668/+attachment/4354856/+files/conf.patch -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/975668 Title: mailman.client conflicts with mailman installation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/975668/+subscriptions From 1432239 at bugs.launchpad.net Wed Mar 25 03:34:38 2015 From: 1432239 at bugs.launchpad.net (Barry Warsaw) Date: Wed, 25 Mar 2015 02:34:38 -0000 Subject: [Bug 1432239] Re: Lists cannot be deleted if the have acceptable alias records References: <20150314204630.25473.53454.malonedeb@soybean.canonical.com> Message-ID: <20150325023440.7482.29920.launchpad@soybean.canonical.com> ** Changed in: mailman Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: mailman Importance: Undecided => High ** Changed in: mailman Status: Triaged => In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1432239 Title: Lists cannot be deleted if the have acceptable alias records To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1432239/+subscriptions From 1432239 at bugs.launchpad.net Wed Mar 25 03:43:56 2015 From: 1432239 at bugs.launchpad.net (Barry Warsaw) Date: Wed, 25 Mar 2015 02:43:56 -0000 Subject: [Bug 1432239] Re: Lists cannot be deleted if the have acceptable alias records References: <20150314204630.25473.53454.malonedeb@soybean.canonical.com> Message-ID: <20150325024357.7457.26293.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1432239 Title: Lists cannot be deleted if the have acceptable alias records To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1432239/+subscriptions From 1423756 at bugs.launchpad.net Wed Mar 25 03:46:06 2015 From: 1423756 at bugs.launchpad.net (Barry Warsaw) Date: Wed, 25 Mar 2015 02:46:06 -0000 Subject: [Bug 1423756] Re: Ability to define user as domainowner or serverowner References: <20150220001108.20399.87602.malonedeb@gac.canonical.com> Message-ID: <20150325024607.7552.3364.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Assignee: Abhilash Raj (raj-abhilash1) => Barry Warsaw (barry) ** Changed in: mailman Status: Triaged => In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1423756 Title: Ability to define user as domainowner or serverowner To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1423756/+subscriptions From raj.abhilash1 at gmail.com Wed Mar 25 04:02:57 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Wed, 25 Mar 2015 03:02:57 -0000 Subject: [Bug 1423756] Re: Ability to define user as domainowner or serverowner References: <20150220001108.20399.87602.malonedeb@gac.canonical.com> <20150325024607.7552.3364.launchpad@chaenomeles.canonical.com> Message-ID: I am already working on this, if you want to continue with my branch it is here: lp:~raj-abhilash1/mailman/bug_1423756 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1423756 Title: Ability to define user as domainowner or serverowner To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1423756/+subscriptions From andrew.stuart at supercoders.com.au Wed Mar 25 04:19:55 2015 From: andrew.stuart at supercoders.com.au (Andrew Stuart) Date: Wed, 25 Mar 2015 03:19:55 -0000 Subject: [Bug 1423756] Re: Ability to define user as domainowner or serverowner References: <20150220001108.20399.87602.malonedeb@gac.canonical.com> <20150325024607.7552.3364.launchpad@chaenomeles.canonical.com> Message-ID: <95FCCA7A-1A4E-41C4-ACDE-880197A2CA53@supercoders.com.au> I?m not working on it although Barry might be. On 25 Mar 2015, at 2:02 pm, Abhilash Raj wrote: I am already working on this, if you want to continue with my branch it is here: lp:~raj-abhilash1/mailman/bug_1423756 -- You received this bug notification because you are subscribed to the bug report. https://bugs.launchpad.net/bugs/1423756 Title: Ability to define user as domainowner or serverowner Status in GNU Mailman: In Progress Bug description: I had an idea about rounding out the Mailman permissions model, interested in hearing thoughts on it. Obviously there has been considerable discussion on this topic before. Mailman already carries much of the information needed for determining user permissions to Mailman resources. Only two things are missing: 1: the ability to define a user as being a ?serverowner? 2: the ability to define a user as being a ?domainowner? (You?ll need to look at this email in plain text to see the table properly). The Mailman permissions model currently looks like this: resource_type roles resource_id user_identifier where to find permission --------------------------------------------------------------------------------------------------------- user userowner n/a UUID (defined in user record) list listowner list_id subscriber (defined in list member record) list listmember list_id subscriber (defined in list member record) list listmoderator list_id subscriber (defined in list member record) list listnonmember list_id subscriber (defined in list member record) I am suggesting adding two further permissions to the existing permissions model, which would look like this: resource_type roles resource_id user_id where to find permission --------------------------------------------------------------------------------------------------------- server serverowner n/a UUID (not currently defined in Mailman) domain domainowner mail_host UUID (not currently defined in Mailman) To implement, it would need to be possible to define as user as being a ?serverowner?, and also to be able to define a user as being a ?domainowner? for any given domain. It should be possible to define multiple user with the serverowner role and it should be possible to define multiple users with the domain owner role. If it were possible to do so within the Mailman core then there would be a completely usable permissions model entirely within Mailman, and no need to store any additional permissions data outside Mailman. The permissions model would allow definition of user access to any Mailman resource including domains and servers. The interpretation of the permissions would still be up to the application that consumes the REST API, as is currently the case. There would need to be methods available via the REST API to: set domainowner role for a user set serverowner role for a user delete domainowner role from a user delete serverowner role from a user find if a specific user holds domainowner find if a specific user holds serverowner role find all domainowners for a domain find all serverowners To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1423756/+subscriptions -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1423756 Title: Ability to define user as domainowner or serverowner To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1423756/+subscriptions From 1423756 at bugs.launchpad.net Wed Mar 25 05:01:39 2015 From: 1423756 at bugs.launchpad.net (Barry Warsaw) Date: Wed, 25 Mar 2015 04:01:39 -0000 Subject: [Bug 1423756] Re: Ability to define user as domainowner or serverowner References: <20150220001108.20399.87602.malonedeb@gac.canonical.com> Message-ID: <20150325040140.7680.43457.launchpad@soybean.canonical.com> ** Changed in: mailman Assignee: Barry Warsaw (barry) => (unassigned) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1423756 Title: Ability to define user as domainowner or serverowner To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1423756/+subscriptions From raj.abhilash1 at gmail.com Wed Mar 25 05:01:54 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Wed, 25 Mar 2015 04:01:54 -0000 Subject: [Bug 1423756] Re: Ability to define user as domainowner or serverowner References: <20150220001108.20399.87602.malonedeb@gac.canonical.com> Message-ID: <20150325040155.7280.72802.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Assignee: (unassigned) => Abhilash Raj (raj-abhilash1) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1423756 Title: Ability to define user as domainowner or serverowner To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1423756/+subscriptions From pskoli93 at gmail.com Wed Mar 25 13:42:20 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Wed, 25 Mar 2015 12:42:20 -0000 Subject: [Merge] lp:~pskoli93/postorius/postorius into lp:postorius Message-ID: <20150325124220.2663.53451.launchpad@ackee.canonical.com> Pavan Koli has proposed merging lp:~pskoli93/postorius/postorius into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~pskoli93/postorius/postorius/+merge/254075 Fixed typos present in http://bazaar.launchpad.net/~mailman-coders/postorius/trunk/view/head:/src/postorius/models.py As reported by this BUG report https://bugs.launchpad.net/postorius/+bug/1436309 -- Your team Mailman Coders is requested to review the proposed merge of lp:~pskoli93/postorius/postorius into lp:postorius. From pskoli93 at gmail.com Wed Mar 25 13:44:29 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Wed, 25 Mar 2015 12:44:29 -0000 Subject: [Merge] lp:~pskoli93/postorius/postorius into lp:postorius In-Reply-To: <20150325124220.2663.53451.launchpad@ackee.canonical.com> Message-ID: <20150325124429.26308.52115.launchpad@ackee.canonical.com> The proposal to merge lp:~pskoli93/postorius/postorius into lp:postorius has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~pskoli93/postorius/postorius/+merge/254075 -- Your team Mailman Coders is requested to review the proposed merge of lp:~pskoli93/postorius/postorius into lp:postorius. From pskoli93 at gmail.com Wed Mar 25 14:05:29 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Wed, 25 Mar 2015 13:05:29 -0000 Subject: [Merge] lp:~pskoli93/postorius/postorius into lp:postorius Message-ID: <20150325130529.8957.98699.launchpad@ackee.canonical.com> Pavan Koli has proposed merging lp:~pskoli93/postorius/postorius into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~pskoli93/postorius/postorius/+merge/254078 Made necessary changes as suggested in this BUG report(https://bugs.launchpad.net/postorius/+bug/1436309) Now the typos have been fixed. -- Your team Mailman Coders is requested to review the proposed merge of lp:~pskoli93/postorius/postorius into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 670 bytes Desc: not available URL: From y1dothie at gmail.com Thu Mar 26 12:58:24 2015 From: y1dothie at gmail.com (akshay) Date: Thu, 26 Mar 2015 11:58:24 -0000 Subject: [Merge] lp:~akshayshah/postorius/postorius into lp:postorius Message-ID: <20150326115823.17717.49553.launchpad@ackee.canonical.com> akshay has proposed merging lp:~akshayshah/postorius/postorius into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~akshayshah/postorius/postorius/+merge/254232 added editable profile page -- Your team Mailman Coders is requested to review the proposed merge of lp:~akshayshah/postorius/postorius into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1950 bytes Desc: not available URL: From aurelien at bompard.org Thu Mar 26 17:02:28 2015 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Thu, 26 Mar 2015 16:02:28 -0000 Subject: [Merge] lp:~abompard/mailman/import21-instances-test into lp:mailman Message-ID: <20150326160225.20755.28225.launchpad@ackee.canonical.com> Aur?lien Bompard has proposed merging lp:~abompard/mailman/import21-instances-test into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~abompard/mailman/import21-instances-test/+merge/254277 New test for the _BounceInfo mock class added in commit 7310. -- Your team Mailman Coders is requested to review the proposed merge of lp:~abompard/mailman/import21-instances-test into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 2585 bytes Desc: not available URL: From mark at msapiro.net Fri Mar 27 05:19:57 2015 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 27 Mar 2015 04:19:57 -0000 Subject: [Bug 1437145] [NEW] Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. References: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> Message-ID: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> *** This bug is a security vulnerability *** Private security bug reported: The recommended Mailman Transport for Exim invokes the Mailman mail wrapper with an unedited listname derived from the $local_part of the email address less any known suffix. The problem with this configuration is that $local_part is not guaranteed to be safe for use as a filesystem directory name. This allows a local attacker to create a directory with a config.pck file in a location that the mailman user can access, send an email to an address with the directory traversal in it (../../../../../tmp/fakelist at domain.com), and then wait for the queue runner to execute arbitrary code as the mailman user either via the pickle file itself or through an extend.py file in the fake list directory. Neither exim nor mailman has code that protects against this attack. The recommended Exim configiration does check that the lists/${lc::$local_part}/config.pck file does exist, put this check is also vulnerable to the path traversal attack. ** Affects: mailman Importance: Medium Assignee: Mark Sapiro (msapiro) Status: In Progress ** Patch added: "Patch to fix this bug" https://bugs.launchpad.net/bugs/1437145/+attachment/4357559/+files/p -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1437145 Title: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1437145/+subscriptions From mark at msapiro.net Fri Mar 27 07:49:16 2015 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 27 Mar 2015 06:49:16 -0000 Subject: [Bug 1437145] Re: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. References: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> Message-ID: <20150327064917.7181.11009.launchpad@chaenomeles.canonical.com> ** Description changed: The recommended Mailman Transport for Exim invokes the Mailman mail wrapper with an unedited listname derived from the $local_part of the email address less any known suffix. The problem with this configuration is that $local_part is not guaranteed to be safe for use as a filesystem directory name. This allows a local attacker to create a directory with a config.pck file in a location that the mailman user can access, send an email to an address with the directory traversal in it (../../../../../tmp/fakelist at domain.com), and then wait for the queue runner to execute arbitrary code as the mailman user either via the pickle file itself or through an extend.py file in the fake list directory. Neither exim nor mailman has code that protects against this attack. The recommended Exim configiration does check that the - lists/${lc::$local_part}/config.pck file does exist, put this check is + lists/${lc::$local_part}/config.pck file does exist, but this check is also vulnerable to the path traversal attack. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1437145 Title: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1437145/+subscriptions From mark at msapiro.net Fri Mar 27 07:58:13 2015 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 27 Mar 2015 06:58:13 -0000 Subject: [Bug 1437145] Re: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. References: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> Message-ID: <20150327065813.7249.82221.malone@chaenomeles.canonical.com> -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1437145 Title: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1437145/+subscriptions From mark at msapiro.net Fri Mar 27 07:56:32 2015 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 27 Mar 2015 06:56:32 -0000 Subject: [Bug 1437145] Re: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. References: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> Message-ID: <20150327065632.23718.75904.malone@wampee.canonical.com> ** Patch removed: "Patch to fix this bug" https://bugs.launchpad.net/mailman/+bug/1437145/+attachment/4357559/+files/p -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1437145 Title: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1437145/+subscriptions From mark at msapiro.net Fri Mar 27 08:00:42 2015 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 27 Mar 2015 07:00:42 -0000 Subject: [Bug 1437145] Re: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. References: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> Message-ID: <20150327070043.23430.12862.malone@wampee.canonical.com> ** Attachment added: "Patch to fix this bug" https://bugs.launchpad.net/mailman/+bug/1437145/+attachment/4357589/+files/p -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1437145 Title: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1437145/+subscriptions From mark at msapiro.net Fri Mar 27 19:28:16 2015 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 27 Mar 2015 18:28:16 -0000 Subject: [Bug 1437145] Re: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. References: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> Message-ID: <20150327182816.26164.35831.malone@gac.canonical.com> It appears that the postfix_to_mailman.py transport for Postfix and probably other MTA transports that deliver programmatically without using aliases are ulso vulnerable. ** Attachment added: "Patch to fix this bug" https://bugs.launchpad.net/mailman/+bug/1437145/+attachment/4358114/+files/p ** Attachment removed: "Patch to fix this bug" https://bugs.launchpad.net/mailman/+bug/1437145/+attachment/4357589/+files/p -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1437145 Title: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1437145/+subscriptions From mark at msapiro.net Fri Mar 27 22:54:03 2015 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 27 Mar 2015 21:54:03 -0000 Subject: [Bug 1437145] Re: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. References: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> Message-ID: <20150327215404.7680.34501.malone@soybean.canonical.com> This vulnerability has been assigned CVE-2015-2775. ** CVE added: http://www.cve.mitre.org/cgi- bin/cvename.cgi?name=2015-2775 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1437145 Title: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1437145/+subscriptions From raj.abhilash1 at gmail.com Sat Mar 28 14:56:20 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Sat, 28 Mar 2015 13:56:20 -0000 Subject: [Merge] lp:~raj-abhilash1/mailman/bug_1423756 into lp:mailman Message-ID: <20150328135619.6964.80121.launchpad@ackee.canonical.com> The proposal to merge lp:~raj-abhilash1/mailman/bug_1423756 into lp:mailman has been updated. Description changed to: Ability to define a server owner and domain owner. @barry: I couldn't find where are variables filled in the confirm.txt template for verification of addresses so two tests related to the same are failing. For more details, see: https://code.launchpad.net/~raj-abhilash1/mailman/bug_1423756/+merge/254479 -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/mailman/bug_1423756 into lp:mailman. From raj.abhilash1 at gmail.com Sat Mar 28 14:56:28 2015 From: raj.abhilash1 at gmail.com (Abhilash Raj) Date: Sat, 28 Mar 2015 13:56:28 -0000 Subject: [Merge] lp:~raj-abhilash1/mailman/bug_1423756 into lp:mailman In-Reply-To: <20150328135619.6964.80121.launchpad@ackee.canonical.com> Message-ID: <20150328135622.32665.77550.launchpad@ackee.canonical.com> Abhilash Raj has proposed merging lp:~raj-abhilash1/mailman/bug_1423756 into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~raj-abhilash1/mailman/bug_1423756/+merge/254479 Ability to define a server owner and domain owner. @barry: I couldn't find where are variables filled in the confirm.txt template for verification of addresses so two tests related to the same are failing. -- Your team Mailman Coders is requested to review the proposed merge of lp:~raj-abhilash1/mailman/bug_1423756 into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 31700 bytes Desc: not available URL: From mark at msapiro.net Sun Mar 29 01:45:06 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 29 Mar 2015 00:45:06 -0000 Subject: [Bug 1437145] Re: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. References: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> Message-ID: <20150329004506.7711.4820.malone@soybean.canonical.com> The patch to Mailman/Utils.py at can be applied with at most a line number offset to any Mailman 2.1.x version, but the referenced mm_cfg.ACCEPTABLE_LISTNAME_CHARACTERS setting didn't exist before Mailman 2.1.11 so if you are patching an older version, you need to add ACCEPTABLE_LISTNAME_CHARACTERS = '[-+_.=a-z0-9]' to mm_cfg.py and/or Defaults.py. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1437145 Title: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1437145/+subscriptions From pskoli93 at gmail.com Sun Mar 29 16:40:50 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Sun, 29 Mar 2015 14:40:50 -0000 Subject: [Bug 265809] Re: "#" in mail address confuses mailman References: <20080905192605.27052.56674.launchpad@forster.canonical.com> Message-ID: <20150329144051.26046.73514.malone@gac.canonical.com> Tried to replicate the bug on Mailman 3, was able to subscribe an e-mail id with abcd#efg at gmail.com. The webpages related to the user were found to be accessible. ** Changed in: mailman Status: New => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/265809 Title: "#" in mail address confuses mailman To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/265809/+subscriptions From mark at msapiro.net Sun Mar 29 17:30:23 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 29 Mar 2015 15:30:23 -0000 Subject: [Bug 265809] Re: "#" in mail address confuses mailman References: <20080905192605.27052.56674.launchpad@forster.canonical.com> Message-ID: <20150329153024.7119.43401.malone@chaenomeles.canonical.com> This is a Mailman 2.1 bug, not a Mailman 3 or Postorius bug. While it is the case coincidently that this bug was fixed in Mailman 2.1.10, that fix did not specifically target this bug and its status was not updated. It happens that 'Fix Released' is the correct status for this bug, but that is just a coincidence. ** Changed in: mailman Milestone: None => mailman-2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/265809 Title: "#" in mail address confuses mailman To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/265809/+subscriptions From ankprashar at gmail.com Sun Mar 29 21:33:51 2015 From: ankprashar at gmail.com (Ankush Sharma) Date: Sun, 29 Mar 2015 19:33:51 -0000 Subject: [Bug 265809] Re: "#" in mail address confuses mailman References: <20080905192605.27052.56674.launchpad@forster.canonical.com> Message-ID: <20150329193351.7418.23983.malone@soybean.canonical.com> I have done a good amount of work regarding this, the work summary is here : https://bugs.launchpad.net/mailman.client/+bug/1429366 . -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/265809 Title: "#" in mail address confuses mailman To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/265809/+subscriptions From pskoli93 at gmail.com Mon Mar 30 20:51:22 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Mon, 30 Mar 2015 18:51:22 -0000 Subject: [Merge] lp:~pskoli93/postorius/Changes into lp:postorius Message-ID: <20150330185121.30713.42825.launchpad@ackee.canonical.com> Pavan Koli has proposed merging lp:~pskoli93/postorius/Changes into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1437866 in Postorius: "AttributeError while adding another email address to your account" https://bugs.launchpad.net/postorius/+bug/1437866 For more details, see: https://code.launchpad.net/~pskoli93/postorius/Changes/+merge/254628 Made changes in models.py file. Made changes in part where, error was encountered on trying to setup an additional e-mail for the list manager on a localhost. -- Your team Mailman Coders is requested to review the proposed merge of lp:~pskoli93/postorius/Changes into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 743 bytes Desc: not available URL: From pskoli93 at gmail.com Mon Mar 30 21:03:23 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Mon, 30 Mar 2015 19:03:23 -0000 Subject: [Merge] lp:~pskoli93/postorius/Change into lp:postorius Message-ID: <20150330190322.2451.6438.launchpad@ackee.canonical.com> Pavan Koli has proposed merging lp:~pskoli93/postorius/Change into lp:postorius. Commit message: "Changes in models.py" Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1437866 in Postorius: "AttributeError while adding another email address to your account" https://bugs.launchpad.net/postorius/+bug/1437866 For more details, see: https://code.launchpad.net/~pskoli93/postorius/Change/+merge/254635 Made changes in models.py now a person will be able to add alternate e-mail ids to his account. -- Your team Mailman Coders is requested to review the proposed merge of lp:~pskoli93/postorius/Change into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1048 bytes Desc: not available URL: From pskoli93 at gmail.com Tue Mar 31 14:20:20 2015 From: pskoli93 at gmail.com (Pavan Koli) Date: Tue, 31 Mar 2015 12:20:20 -0000 Subject: [Merge] lp:~pskoli93/postorius/Change into lp:postorius In-Reply-To: <20150330190322.2451.6438.launchpad@ackee.canonical.com> Message-ID: <20150331122019.14641.67939.launchpad@ackee.canonical.com> The proposal to merge lp:~pskoli93/postorius/Change into lp:postorius has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~pskoli93/postorius/Change/+merge/254635 -- Your team Mailman Coders is requested to review the proposed merge of lp:~pskoli93/postorius/Change into lp:postorius. From mark at msapiro.net Tue Mar 31 16:26:33 2015 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 31 Mar 2015 14:26:33 -0000 Subject: [Bug 1437145] Re: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. References: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> Message-ID: <20150331142633.23603.39709.launchpad@wampee.canonical.com> ** Information type changed from Private Security to Public Security -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1437145 Title: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1437145/+subscriptions From 1437145 at bugs.launchpad.net Tue Mar 31 18:43:25 2015 From: 1437145 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Tue, 31 Mar 2015 16:43:25 -0000 Subject: [Bug 1437145] Re: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. References: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> Message-ID: <20150331164326.14586.56967.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1437145 Title: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1437145/+subscriptions From mark at msapiro.net Tue Mar 31 19:54:56 2015 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 31 Mar 2015 17:54:56 -0000 Subject: [Bug 1437145] Re: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. References: <20150327041957.7249.96666.malonedeb@chaenomeles.canonical.com> Message-ID: <20150331175457.26259.77346.launchpad@gac.canonical.com> ** Changed in: mailman Status: In Progress => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1437145 Title: Path traversal vulnerability exists in Mailman and can be exploited if Mailman's MTA is Exim. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1437145/+subscriptions From mark at msapiro.net Tue Mar 31 19:55:29 2015 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 31 Mar 2015 17:55:29 -0000 Subject: [Bug 1427389] Re: SpamDetect throws LookupError if a message has an RFC 2047 encoded header with an unknown encoding. References: <20150302212246.19837.33553.malonedeb@wampee.canonical.com> Message-ID: <20150331175530.7513.82163.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1427389 Title: SpamDetect throws LookupError if a message has an RFC 2047 encoded header with an unknown encoding. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1427389/+subscriptions From mark at msapiro.net Tue Mar 31 19:55:40 2015 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 31 Mar 2015 17:55:40 -0000 Subject: [Bug 1426825] Re: CommandRunner throws KeyError References: <20150301065605.20840.58517.malonedeb@soybean.canonical.com> Message-ID: <20150331175541.7552.90916.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1426825 Title: CommandRunner throws KeyError To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1426825/+subscriptions From mark at msapiro.net Tue Mar 31 19:55:16 2015 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 31 Mar 2015 17:55:16 -0000 Subject: [Bug 266809] Re: Feature Request: Admin change subscriber's e-mail References: <20080905194252.1806.16257.launchpad@forster.canonical.com> Message-ID: <20150331175517.7943.70168.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/266809 Title: Feature Request: Admin change subscriber's e-mail To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/266809/+subscriptions From mark at msapiro.net Tue Mar 31 19:55:54 2015 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 31 Mar 2015 17:55:54 -0000 Subject: [Bug 1426829] Re: CommandRunner can look too far for command words and 'Subject: Re: Command is case sensitive. References: <20150301081622.20216.35182.malonedeb@wampee.canonical.com> Message-ID: <20150331175555.26164.99029.launchpad@gac.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1426829 Title: CommandRunner can look too far for command words and 'Subject: Re: Command is case sensitive. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1426829/+subscriptions