From mark at msapiro.net Sun Aug 9 03:36:29 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 09 Aug 2015 01:36:29 -0000 Subject: [Bug 1482940] [NEW] A bounced probe can throw AttributeError Message-ID: <20150809013629.25012.97996.malonedeb@chaenomeles.canonical.com> Public bug reported: If the site has set 'VERP_PROBES = Yes', when a user's bounce score reaches threshold, that user's score is reset and a probe message with a confirmation token is sent to the user. If the probe bounces, the user's delivery is disabled by bounce. The issue is if the probe bounces, but for some reason, the bounce is not returned within bounce_info_stale_after days, the user's bounce_info can be deleted before the probe bounce is returned. Then the probe processing gets the user's bounce_info which is None and attempts to disable the member's delivery with bounce_info = None, and disableBouncingMember attempts to get the cookie attribute from None resulting in AttributeError: 'NoneType' object has no attribute 'cookie' ** Affects: mailman Importance: Medium Assignee: Mark Sapiro (msapiro) Status: In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1482940 Title: A bounced probe can throw AttributeError To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1482940/+subscriptions From 1482940 at bugs.launchpad.net Sun Aug 9 05:54:00 2015 From: 1482940 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Sun, 09 Aug 2015 03:54:00 -0000 Subject: [Bug 1482940] Re: A bounced probe can throw AttributeError References: <20150809013629.25012.97996.malonedeb@chaenomeles.canonical.com> Message-ID: <20150809035401.15134.16496.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1482940 Title: A bounced probe can throw AttributeError To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1482940/+subscriptions From mark at msapiro.net Sun Aug 9 05:55:27 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 09 Aug 2015 03:55:27 -0000 Subject: [Bug 1482940] Re: A bounced probe can throw AttributeError References: <20150809013629.25012.97996.malonedeb@chaenomeles.canonical.com> Message-ID: <20150809035528.25529.94160.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1482940 Title: A bounced probe can throw AttributeError To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1482940/+subscriptions From mark at msapiro.net Tue Aug 18 23:38:56 2015 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 18 Aug 2015 21:38:56 -0000 Subject: [Bug 1486263] [NEW] cron/gate_news doesn't catch EOFError on opening the newsgroup. Message-ID: <20150818213856.19045.79167.malonedeb@wampee.canonical.com> Public bug reported: The Summary says it all. ** Affects: mailman Importance: Low Assignee: Mark Sapiro (msapiro) Status: In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1486263 Title: cron/gate_news doesn't catch EOFError on opening the newsgroup. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1486263/+subscriptions From 1486263 at bugs.launchpad.net Wed Aug 19 00:09:01 2015 From: 1486263 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Tue, 18 Aug 2015 22:09:01 -0000 Subject: [Bug 1486263] Re: cron/gate_news doesn't catch EOFError on opening the newsgroup. References: <20150818213856.19045.79167.malonedeb@wampee.canonical.com> Message-ID: <20150818220902.10714.91048.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1486263 Title: cron/gate_news doesn't catch EOFError on opening the newsgroup. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1486263/+subscriptions From mark at msapiro.net Wed Aug 19 00:09:07 2015 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 18 Aug 2015 22:09:07 -0000 Subject: [Bug 1486263] Re: cron/gate_news doesn't catch EOFError on opening the newsgroup. References: <20150818213856.19045.79167.malonedeb@wampee.canonical.com> Message-ID: <20150818220908.18555.24389.launchpad@wampee.canonical.com> ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1486263 Title: cron/gate_news doesn't catch EOFError on opening the newsgroup. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1486263/+subscriptions From simon+launchpad at le-huit.fr Tue Aug 25 22:51:39 2015 From: simon+launchpad at le-huit.fr (Simon) Date: Tue, 25 Aug 2015 20:51:39 -0000 Subject: [Bug 1488656] [NEW] REMOVE_DKIM_HEADERS = 2, describe but not implemented Message-ID: <20150825205139.19412.55659.malonedeb@wampee.canonical.com> Public bug reported: In the debian package (Wheezy) and the tarball mailman-2.1.20: Default.py describes than REMOVE_DKIM_HEADERS = 2 should overwrite the from_is_list == 1. But this is not implemented in Handlers/CleanseDKIM.py . ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1488656 Title: REMOVE_DKIM_HEADERS = 2, describe but not implemented To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1488656/+subscriptions From mark at msapiro.net Sun Aug 30 00:40:08 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 29 Aug 2015 22:40:08 -0000 Subject: [Bug 1488656] Re: REMOVE_DKIM_HEADERS = 2, describe but not implemented References: <20150825205139.19412.55659.malonedeb@wampee.canonical.com> Message-ID: <20150829224009.26871.31016.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: New => Incomplete -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1488656 Title: REMOVE_DKIM_HEADERS = 2, describe but not implemented To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1488656/+subscriptions From mark at msapiro.net Sun Aug 30 00:48:31 2015 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 29 Aug 2015 22:48:31 -0000 Subject: [Bug 1488656] Re: REMOVE_DKIM_HEADERS = 2, describe but not implemented References: <20150825205139.19412.55659.malonedeb@wampee.canonical.com> Message-ID: <20150829224831.18721.99709.malone@wampee.canonical.com> I believe the code is correct and does what is documented in Defaults.py. If you disagree, please give specific examples of settings, what result they should produce and what they actually produce. In particular, if REMOVE_DKIM_HEADERS =2, the if not (mm_cfg.REMOVE_DKIM_HEADERS or mlist.anonymous_list): is false and doesn't return, and the second if (mm_cfg.REMOVE_DKIM_HEADERS == 1 and not ... is also false and does not return and the del statements are executed. I don't know what you mean by "REMOVE_DKIM_HEADERS = 2 should overwrite the from_is_list == 1." What the documentation says is if REMOVE_DKIM_HEADERS = 2, the headers are removed regardless of the from_is_list setting, and that's what's done. ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1488656 Title: REMOVE_DKIM_HEADERS = 2, describe but not implemented To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1488656/+subscriptions