From 24.sneha at gmail.com Thu Oct 3 00:20:33 2013 From: 24.sneha at gmail.com (Sneha Priscilla) Date: Wed, 02 Oct 2013 22:20:33 -0000 Subject: [Merge] lp:~stylistica/mailman.client/user_preferences into lp:mailman.client Message-ID: <20131002222032.20985.70203.launchpad@ackee.canonical.com> Sneha Priscilla has proposed merging lp:~stylistica/mailman.client/user_preferences into lp:mailman.client. Requested reviews: Florian Fuchs (flo-fuchs) For more details, see: https://code.launchpad.net/~stylistica/mailman.client/user_preferences/+merge/188950 Made changes to the Mailman client file with respect to my user preferences GSoC project. Brief Summary: Added a read only attributes list for preferences , added preferences for Address object which was missing -- https://code.launchpad.net/~stylistica/mailman.client/user_preferences/+merge/188950 Your team Mailman Coders is subscribed to branch lp:mailman.client. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 4259 bytes Desc: not available URL: From 24.sneha at gmail.com Thu Oct 3 00:24:29 2013 From: 24.sneha at gmail.com (Sneha Priscilla) Date: Wed, 02 Oct 2013 22:24:29 -0000 Subject: [Merge] lp:~stylistica/postorius/preferences into lp:postorius Message-ID: <20131002222427.21326.44980.launchpad@ackee.canonical.com> Sneha Priscilla has proposed merging lp:~stylistica/postorius/preferences into lp:postorius. Requested reviews: Florian Fuchs (flo-fuchs) For more details, see: https://code.launchpad.net/~stylistica/postorius/preferences/+merge/188953 Proposing a merge for my GSoC Project - User Interface Design for Mailman users to manage their preferences. This branch contains 2 new html files - for address and subscription based preferences. It includes: 1. A new form called UserPreferences in forms.py 2. Three new views in views/user.py for the 3 type of preferences 3. Change to the get_memberships function in views/generic.py 4. Modifications to urls.py and other html files to accommodate the above 5. Autopep8ed files/corrected syntax in few other files -- https://code.launchpad.net/~stylistica/postorius/preferences/+merge/188953 Your team Mailman Coders is subscribed to branch lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 69639 bytes Desc: not available URL: From 1234567 at bugs.launchpad.net Thu Oct 3 10:27:33 2013 From: 1234567 at bugs.launchpad.net (Jan Kratochvil) Date: Thu, 03 Oct 2013 08:27:33 -0000 Subject: [Bug 1234567] [NEW] Czech catalog bug References: <20131003082733.4346.50379.malonedeb@gac.canonical.com> Message-ID: <20131003082733.4346.50379.malonedeb@gac.canonical.com> Public bug reported: obvious ** Affects: mailman Importance: Undecided Status: New ** Patch added: "fix" https://bugs.launchpad.net/bugs/1234567/+attachment/3856819/+files/mailman-cs.patch -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1234567 Title: Czech catalog bug To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1234567/+subscriptions From 1234567 at bugs.launchpad.net Thu Oct 3 16:38:41 2013 From: 1234567 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Thu, 03 Oct 2013 14:38:41 -0000 Subject: [Bug 1234567] Re: Czech catalog bug References: <20131003082733.4346.50379.malonedeb@gac.canonical.com> Message-ID: <20131003143844.10054.14086.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1234567 Title: Czech catalog bug To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1234567/+subscriptions From mark at msapiro.net Thu Oct 3 16:39:59 2013 From: mark at msapiro.net (Mark Sapiro) Date: Thu, 03 Oct 2013 14:39:59 -0000 Subject: [Bug 1234567] Re: Czech catalog bug References: <20131003082733.4346.50379.malonedeb@gac.canonical.com> Message-ID: <20131003144000.24955.8437.malone@soybean.canonical.com> Thanks for the report. ** Changed in: mailman Importance: Undecided => Low ** Changed in: mailman Status: New => Fix Committed ** Changed in: mailman Milestone: None => 2.1.16 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1234567 Title: Czech catalog bug To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1234567/+subscriptions From davidw at axis.com Fri Oct 4 09:03:10 2013 From: davidw at axis.com (David Westlund) Date: Fri, 04 Oct 2013 07:03:10 -0000 Subject: [Bug 1235101] [NEW] Mailman 2.1.15 and later crashes on more email References: <20131004070310.3962.1242.malonedeb@gac.canonical.com> Message-ID: <20131004070310.3962.1242.malonedeb@gac.canonical.com> Public bug reported: After upgrading from Mailman 2.1.14 to 2.1.15 we noticed a steep increase in the number of shunted email. The error message is the following: File "/var/lib/mailman/Mailman/Queue/Runner.py", line 119, in _oneloop self._onefile(msg, msgdata) File "/var/lib/mailman/Mailman/Queue/Runner.py", line 190, in _onefile keepqueued = self._dispose(mlist, msg, msgdata) File "/var/lib/mailman/Mailman/Queue/IncomingRunner.py", line 130, in _dispose more = self._dopipeline(mlist, msg, msgdata, pipeline) File "/var/lib/mailman/Mailman/Queue/IncomingRunner.py", line 153, in _dopipeline sys.modules[modname].process(mlist, msg, msgdata) File "/var/lib/mailman/Mailman/Handlers/SpamDetect.py", line 99, in process headers += getDecodedHeaders(p, lcset) File "/var/lib/mailman/Mailman/Handlers/SpamDetect.py", line 71, in getDecodedHeaders v = decode_header(re.sub('\n\s', ' ', v)) File "/usr/lib/python2.7/email/header.py", line 108, in decode_header raise HeaderParseError HeaderParseError The older version of SpamDetect.py did not crash nearly as often. The reason seems to be that now python's email module is used and it crashes much more often than the earlier solution where the HeaderGenerator class in SpamDetect.py was used. ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1235101 Title: Mailman 2.1.15 and later crashes on more email To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1235101/+subscriptions From mark at msapiro.net Fri Oct 4 16:58:29 2013 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 04 Oct 2013 14:58:29 -0000 Subject: [Bug 1235101] Re: Mailman 2.1.15 and later crashes on more email References: <20131004070310.3962.1242.malonedeb@gac.canonical.com> Message-ID: <20131004145830.27592.46861.malone@wampee.canonical.com> I'm not convinced that the post 2.1.14 changes are responsible. There could be a bug in email.Header.decode_header(), but the main difference is the 2.1.14 method didn't decode RFC 2047 encoded headers. It could be that the messages that throw the exception are all malformed spam anyway. In any case, please provide one or more of the messages that cause the exception to be thrown. Also, it will be easy to catch the exception and prevent the shunting, but what should be done with the message? At this point in the processing, we don't know what rule if any this header might match. I am inclined to do one of two things: 1) just leave the header undecoded. 2) replace the header along the lines of "Header-Name: unparseable RFC 2047 encoding" becomes "X-Undecodable-Header: Header-Name: unparseable RFC 2047 encoding". Any thoughts? ** Changed in: mailman Importance: Undecided => Medium ** Changed in: mailman Status: New => Incomplete ** Changed in: mailman Milestone: None => 2.1.16 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1235101 Title: Mailman 2.1.15 and later crashes on more email To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1235101/+subscriptions From duffy at fedoraproject.org Sat Oct 5 18:40:36 2013 From: duffy at fedoraproject.org (mairin) Date: Sat, 05 Oct 2013 16:40:36 -0000 Subject: [Merge] lp:~mairin/postorius/mairin-1 into lp:postorius Message-ID: <20131005164034.11392.21215.launchpad@ackee.canonical.com> mairin has proposed merging lp:~mairin/postorius/mairin-1 into lp:postorius. Commit message: Minor HTML fix for new users form This change fixes a minor issue in the new users form where most of the form fields are outside of the "field" div. From reading fieldset_forms.py it looks like all of the form fields are meant to be inside of this div. I'm trying to pretty up the form stylistically and need this change on this form to do so. Requested reviews: Terri (terriko) For more details, see: https://code.launchpad.net/~mairin/postorius/mairin-1/+merge/189476 This change fixes a minor issue in the new users form where most of the form fields are outside of the "field" div. From reading fieldset_forms.py it looks like all of the form fields are meant to be inside of this div. I'm trying to pretty up the form stylistically and need this change on this form to do so. Specifically, this fixes the new users form. If I find this issue on other forms I'll fix those too in separate merge requests. -- https://code.launchpad.net/~mairin/postorius/mairin-1/+merge/189476 Your team Mailman Coders is subscribed to branch lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 548 bytes Desc: not available URL: From terri at zone12.com Sat Oct 5 18:40:47 2013 From: terri at zone12.com (Terri) Date: Sat, 05 Oct 2013 16:40:47 -0000 Subject: [Merge] lp:~mairin/postorius/mairin-1 into lp:postorius In-Reply-To: <20131005164034.11392.21215.launchpad@ackee.canonical.com> Message-ID: <20131005164046.4204.2466.codereview@gac.canonical.com> Review: Approve looks good! -- https://code.launchpad.net/~mairin/postorius/mairin-1/+merge/189476 Your team Mailman Coders is subscribed to branch lp:postorius. From noreply at launchpad.net Sat Oct 5 18:42:55 2013 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sat, 05 Oct 2013 16:42:55 -0000 Subject: [Merge] lp:~mairin/postorius/mairin-1 into lp:postorius In-Reply-To: <20131005164034.11392.21215.launchpad@ackee.canonical.com> Message-ID: <20131005164253.6704.85390.launchpad@ackee.canonical.com> The proposal to merge lp:~mairin/postorius/mairin-1 into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~mairin/postorius/mairin-1/+merge/189476 -- https://code.launchpad.net/~mairin/postorius/mairin-1/+merge/189476 Your team Mailman Coders is subscribed to branch lp:postorius. From noreply at launchpad.net Sat Oct 5 18:57:25 2013 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sat, 05 Oct 2013 16:57:25 -0000 Subject: [Merge] lp:~stylistica/postorius/user_preferences into lp:postorius In-Reply-To: <20130808205048.30865.18539.launchpad@ackee.canonical.com> Message-ID: <20131005165724.6704.4931.launchpad@ackee.canonical.com> The proposal to merge lp:~stylistica/postorius/user_preferences into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~stylistica/postorius/user_preferences/+merge/179274 -- https://code.launchpad.net/~stylistica/postorius/user_preferences/+merge/179274 Your team Mailman Coders is subscribed to branch lp:postorius. From noreply at launchpad.net Sat Oct 5 19:42:03 2013 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sat, 05 Oct 2013 17:42:03 -0000 Subject: [Merge] lp:~stylistica/mailman.client/user_preferences into lp:mailman.client In-Reply-To: <20131002222032.20985.70203.launchpad@ackee.canonical.com> Message-ID: <20131005174203.6707.66479.launchpad@ackee.canonical.com> The proposal to merge lp:~stylistica/mailman.client/user_preferences into lp:mailman.client has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~stylistica/mailman.client/user_preferences/+merge/188950 -- https://code.launchpad.net/~stylistica/mailman.client/user_preferences/+merge/188950 Your team Mailman Coders is subscribed to branch lp:mailman.client. From noreply at launchpad.net Sat Oct 5 19:42:22 2013 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sat, 05 Oct 2013 17:42:22 -0000 Subject: [Branch ~mailman-coders/mailman.client/trunk] Rev 47: Merging Stylistica's mailman.client changes so that the GHC Open Source Day Message-ID: <20131005174222.24160.77977.launchpad@ackee.canonical.com> Merge authors: Sneha Priscilla (stylistica) Related merge proposals: https://code.launchpad.net/~stylistica/mailman.client/user_preferences/+merge/188950 proposed by: Sneha Priscilla (stylistica) ------------------------------------------------------------ revno: 47 [merge] committer: Terri Oda branch nick: mailman.client timestamp: Sat 2013-10-05 09:46:23 -0700 message: Merging Stylistica's mailman.client changes so that the GHC Open Source Day participants from Systers will be able to play with her code more easily. modified: src/mailmanclient/_client.py -- lp:mailman.client https://code.launchpad.net/~mailman-coders/mailman.client/trunk Your team Mailman Coders is subscribed to branch lp:mailman.client. To unsubscribe from this branch go to https://code.launchpad.net/~mailman-coders/mailman.client/trunk/+edit-subscription -------------- next part -------------- A non-text attachment was scrubbed... Name: revision-diff.txt Type: text/x-diff Size: 4259 bytes Desc: not available URL: From noreply at launchpad.net Sat Oct 5 19:49:13 2013 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sat, 05 Oct 2013 17:49:13 -0000 Subject: [Merge] lp:~stylistica/postorius/preferences into lp:postorius In-Reply-To: <20131002222427.21326.44980.launchpad@ackee.canonical.com> Message-ID: <20131005174912.6707.23429.launchpad@ackee.canonical.com> The proposal to merge lp:~stylistica/postorius/preferences into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~stylistica/postorius/preferences/+merge/188953 -- https://code.launchpad.net/~stylistica/postorius/preferences/+merge/188953 Your team Mailman Coders is subscribed to branch lp:postorius. From duffy at fedoraproject.org Sat Oct 5 19:50:34 2013 From: duffy at fedoraproject.org (mairin) Date: Sat, 05 Oct 2013 17:50:34 -0000 Subject: [Merge] lp:~mairin/postorius/mairin-2 into lp:postorius Message-ID: <20131005175033.25738.33420.launchpad@ackee.canonical.com> mairin has proposed merging lp:~mairin/postorius/mairin-2 into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~mairin/postorius/mairin-2/+merge/189477 revamp new user form removed default django automatic {{ form.as_p }} and replaced with cleaner, bootstrappy form with nice alignment, etc. -- https://code.launchpad.net/~mairin/postorius/mairin-2/+merge/189477 Your team Mailman Coders is requested to review the proposed merge of lp:~mairin/postorius/mairin-2 into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1948 bytes Desc: not available URL: From duffy at fedoraproject.org Sat Oct 5 20:59:25 2013 From: duffy at fedoraproject.org (mairin) Date: Sat, 05 Oct 2013 18:59:25 -0000 Subject: [Merge] lp:~mairin/postorius/mairin-3 into lp:postorius Message-ID: <20131005185924.9426.12751.launchpad@ackee.canonical.com> mairin has proposed merging lp:~mairin/postorius/mairin-3 into lp:postorius. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~mairin/postorius/mairin-3/+merge/189480 Revamp of new domain creation form removed default django automatic {{ form.as_p }} and replaced with cleaner, bootstrappy form with nice alignment, etc. -- https://code.launchpad.net/~mairin/postorius/mairin-3/+merge/189480 Your team Mailman Coders is requested to review the proposed merge of lp:~mairin/postorius/mairin-3 into lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 4163 bytes Desc: not available URL: From rthiels1 at swarthmore.edu Sat Oct 5 21:34:26 2013 From: rthiels1 at swarthmore.edu (RThielstrom) Date: Sat, 05 Oct 2013 19:34:26 -0000 Subject: [Merge] lp:~rthiels1/postorius/help_text into lp:postorius Message-ID: <20131005193424.15769.593.launchpad@ackee.canonical.com> RThielstrom has proposed merging lp:~rthiels1/postorius/help_text into lp:postorius. Requested reviews: Terri (terriko) For more details, see: https://code.launchpad.net/~rthiels1/postorius/help_text/+merge/189481 Fixes long help_text lines -- https://code.launchpad.net/~rthiels1/postorius/help_text/+merge/189481 Your team Mailman Coders is subscribed to branch lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 24466 bytes Desc: not available URL: From noreply at launchpad.net Sat Oct 5 21:37:35 2013 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sat, 05 Oct 2013 19:37:35 -0000 Subject: [Merge] lp:~rthiels1/postorius/help_text into lp:postorius In-Reply-To: <20131005193424.15769.593.launchpad@ackee.canonical.com> Message-ID: <20131005193733.6705.52056.launchpad@ackee.canonical.com> The proposal to merge lp:~rthiels1/postorius/help_text into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~rthiels1/postorius/help_text/+merge/189481 -- https://code.launchpad.net/~rthiels1/postorius/help_text/+merge/189481 Your team Mailman Coders is subscribed to branch lp:postorius. From noreply at launchpad.net Sat Oct 5 22:09:13 2013 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sat, 05 Oct 2013 20:09:13 -0000 Subject: [Merge] lp:~mairin/postorius/mairin-2 into lp:postorius In-Reply-To: <20131005175033.25738.33420.launchpad@ackee.canonical.com> Message-ID: <20131005200912.6707.71239.launchpad@ackee.canonical.com> The proposal to merge lp:~mairin/postorius/mairin-2 into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~mairin/postorius/mairin-2/+merge/189477 -- https://code.launchpad.net/~mairin/postorius/mairin-2/+merge/189477 Your team Mailman Coders is requested to review the proposed merge of lp:~mairin/postorius/mairin-2 into lp:postorius. From terri at zone12.com Sat Oct 5 22:20:32 2013 From: terri at zone12.com (Terri) Date: Sat, 05 Oct 2013 20:20:32 -0000 Subject: [Merge] lp:~mairin/postorius/mairin-2 into lp:postorius In-Reply-To: <20131005175033.25738.33420.launchpad@ackee.canonical.com> Message-ID: <20131005202031.4551.66147.codereview@gac.canonical.com> Review: Approve -- https://code.launchpad.net/~mairin/postorius/mairin-2/+merge/189477 Your team Mailman Coders is subscribed to branch lp:postorius. From terri at zone12.com Sat Oct 5 22:22:52 2013 From: terri at zone12.com (Terri) Date: Sat, 05 Oct 2013 20:22:52 -0000 Subject: [Merge] lp:~mairin/postorius/mairin-3 into lp:postorius In-Reply-To: <20131005185924.9426.12751.launchpad@ackee.canonical.com> Message-ID: <20131005202251.25021.90793.codereview@soybean.canonical.com> Review: Approve -- https://code.launchpad.net/~mairin/postorius/mairin-3/+merge/189480 Your team Mailman Coders is subscribed to branch lp:postorius. From noreply at launchpad.net Sat Oct 5 22:23:50 2013 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sat, 05 Oct 2013 20:23:50 -0000 Subject: [Merge] lp:~mairin/postorius/mairin-3 into lp:postorius In-Reply-To: <20131005185924.9426.12751.launchpad@ackee.canonical.com> Message-ID: <20131005202349.6707.51629.launchpad@ackee.canonical.com> The proposal to merge lp:~mairin/postorius/mairin-3 into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~mairin/postorius/mairin-3/+merge/189480 -- https://code.launchpad.net/~mairin/postorius/mairin-3/+merge/189480 Your team Mailman Coders is subscribed to branch lp:postorius. From rthiels1 at swarthmore.edu Sat Oct 5 23:51:26 2013 From: rthiels1 at swarthmore.edu (RThielstrom) Date: Sat, 05 Oct 2013 21:51:26 -0000 Subject: [Merge] lp:~rthiels1/postorius/pep8edits into lp:postorius Message-ID: <20131005215122.17678.14111.launchpad@ackee.canonical.com> RThielstrom has proposed merging lp:~rthiels1/postorius/pep8edits into lp:postorius. Requested reviews: Terri (terriko) For more details, see: https://code.launchpad.net/~rthiels1/postorius/pep8edits/+merge/189485 Postorius python files edited to comply with Pep8 standards. -- https://code.launchpad.net/~rthiels1/postorius/pep8edits/+merge/189485 Your team Mailman Coders is subscribed to branch lp:postorius. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 36684 bytes Desc: not available URL: From noreply at launchpad.net Sat Oct 5 23:55:37 2013 From: noreply at launchpad.net (noreply at launchpad.net) Date: Sat, 05 Oct 2013 21:55:37 -0000 Subject: [Merge] lp:~rthiels1/postorius/pep8edits into lp:postorius In-Reply-To: <20131005215122.17678.14111.launchpad@ackee.canonical.com> Message-ID: <20131005215536.6707.49590.launchpad@ackee.canonical.com> The proposal to merge lp:~rthiels1/postorius/pep8edits into lp:postorius has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~rthiels1/postorius/pep8edits/+merge/189485 -- https://code.launchpad.net/~rthiels1/postorius/pep8edits/+merge/189485 Your team Mailman Coders is subscribed to branch lp:postorius. From terri at zone12.com Sat Oct 5 18:28:38 2013 From: terri at zone12.com (Terri) Date: Sat, 05 Oct 2013 16:28:38 -0000 Subject: [Merge] lp:~stylistica/mailman.client/user_preferences into lp:mailman.client In-Reply-To: <20131002222032.20985.70203.launchpad@ackee.canonical.com> Message-ID: <20131005162837.27278.53949.codereview@wampee.canonical.com> Asked stylistica, and apparently the extra lines were added by the pep8 tool, so I'm going to assume they're awesome and long-overdue fixes ;) -- https://code.launchpad.net/~stylistica/mailman.client/user_preferences/+merge/188950 Your team Mailman Coders is subscribed to branch lp:mailman.client. From terri at zone12.com Sat Oct 5 18:55:53 2013 From: terri at zone12.com (Terri) Date: Sat, 05 Oct 2013 16:55:53 -0000 Subject: [Merge] lp:~stylistica/postorius/user_preferences into lp:postorius In-Reply-To: <20130808205048.30865.18539.launchpad@ackee.canonical.com> Message-ID: <20131005165552.24827.9987.codereview@soybean.canonical.com> Review: Approve We're looking for some "easy" bugs to fix at the GHC Open Source Day, so I'm actually going to merge this as-is and then let our new contributors find the style problems as simple first commits. (I know, I know, this isn't how it's supposed to be done, but it'll be fun!) -- https://code.launchpad.net/~stylistica/postorius/user_preferences/+merge/179274 Your team Mailman Coders is subscribed to branch lp:postorius. From terri at zone12.com Sat Oct 5 23:55:14 2013 From: terri at zone12.com (Terri) Date: Sat, 05 Oct 2013 21:55:14 -0000 Subject: [Merge] lp:~rthiels1/postorius/pep8edits into lp:postorius In-Reply-To: <20131005215122.17678.14111.launchpad@ackee.canonical.com> Message-ID: <20131005215514.4455.77322.codereview@gac.canonical.com> Review: Approve -- https://code.launchpad.net/~rthiels1/postorius/pep8edits/+merge/189485 Your team Mailman Coders is subscribed to branch lp:postorius. From aurelien at bompard.org Mon Oct 7 12:55:36 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Mon, 07 Oct 2013 10:55:36 -0000 Subject: [Bug 1117174] Re: mailman remove list fails due to constraint error on contentfilter References: <20130206100600.1671.21029.malonedeb@chaenomeles.canonical.com> Message-ID: <20131007105536.8464.5889.malone@chaenomeles.canonical.com> Since SQLite does not do cascade deletes IIRC, here's a patch to remove the content filters first (it's a very simple patch, and contains the test suite). ** Patch added: "mailman-delete-content-filters.patch" https://bugs.launchpad.net/mailman/+bug/1117174/+attachment/3863999/+files/mailman-delete-content-filters.patch -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1117174 Title: mailman remove list fails due to constraint error on contentfilter To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1117174/+subscriptions From aurelien at bompard.org Mon Oct 7 13:00:28 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Mon, 07 Oct 2013 11:00:28 -0000 Subject: [Bug 1236297] [NEW] Unicode errors with PostgreSQL and RawStr fields References: <20131007110028.27245.18411.malonedeb@wampee.canonical.com> Message-ID: <20131007110028.27245.18411.malonedeb@wampee.canonical.com> Public bug reported: When using PostgreSQL as a database, it's impossible to set the moderator_password field of a mailing list, which is of type RawStr. To be precise, it's possible to set it, but getting it back from the database after a commit will cause a TypeError with the message: "Expected str, found " as if PostgreSQL always returned unicode on TEXT fields and Storm did not convert them to bytestrings. I get no errors on an SQLite database. I don't know if the problem comes from Mailman or Storm. I have written a python script to reproduce it, see the attached file. There are comments, it should be easily readable. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 ** Attachment added: "test-mm-storm-unicode.py" https://bugs.launchpad.net/bugs/1236297/+attachment/3864008/+files/test-mm-storm-unicode.py -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1236297 Title: Unicode errors with PostgreSQL and RawStr fields To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1236297/+subscriptions From aurelien at bompard.org Mon Oct 7 14:44:18 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Mon, 07 Oct 2013 12:44:18 -0000 Subject: [Bug 1236297] Re: Unicode errors with PostgreSQL and RawStr fields References: <20131007110028.27245.18411.malonedeb@wampee.canonical.com> Message-ID: <20131007124418.8505.80605.malone@chaenomeles.canonical.com> I found why! In "mailman/src/mailman/database/schema/postgres.sql", the moderator_password field is of type "TEXT" instead of being "BYTEA". As a result, the psycopg2 driver converts it to an unicode string. This is coherent with the Storm manual which states that RawStr types should be set as BYTEA types in PostgreSQL: https://storm.canonical.com/Manual#Table_of_properties_vs._python_vs._database_types I believe a schema migration script will be needed. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1236297 Title: Unicode errors with PostgreSQL and RawStr fields To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1236297/+subscriptions From aurelien at bompard.org Mon Oct 7 15:11:17 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Mon, 07 Oct 2013 13:11:17 -0000 Subject: [Bug 1236297] Re: Unicode errors with PostgreSQL and RawStr fields References: <20131007110028.27245.18411.malonedeb@wampee.canonical.com> Message-ID: <20131007131117.7855.90699.malone@chaenomeles.canonical.com> Here's the schema migration script, it's pretty simple. I'm converting existing data to ASCII and not UTF-8 because we don't expect non-ascii chars to be in the moderator_password column (it should contain the result of the config.password_context.encrypt() function, which is ASCII-only. ** Attachment added: "mm_20131007000000.py" https://bugs.launchpad.net/mailman/+bug/1236297/+attachment/3864274/+files/mm_20131007000000.py -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1236297 Title: Unicode errors with PostgreSQL and RawStr fields To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1236297/+subscriptions From 1235101 at bugs.launchpad.net Tue Oct 8 06:59:58 2013 From: 1235101 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Tue, 08 Oct 2013 04:59:58 -0000 Subject: [Bug 1235101] Re: Mailman 2.1.15 and later crashes on more email References: <20131004070310.3962.1242.malonedeb@gac.canonical.com> Message-ID: <20131008050002.28105.45494.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1235101 Title: Mailman 2.1.15 and later crashes on more email To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1235101/+subscriptions From mark at msapiro.net Tue Oct 8 07:12:14 2013 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 08 Oct 2013 05:12:14 -0000 Subject: [Bug 1235101] Re: Mailman 2.1.15 and later crashes on more email References: <20131004070310.3962.1242.malonedeb@gac.canonical.com> Message-ID: <20131008051214.26952.80064.malone@chaenomeles.canonical.com> I have tentatively fixed this for 2.1.16 by just adding the undecoded header to the header text. This means that the text that will be searched by header_filter_rules will include just the raw header for any unparseable RFC 2047 encoded header. This was the case in 2.1.14 and prior for all RFC 2047 encoded headers. ** Changed in: mailman Status: Incomplete => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1235101 Title: Mailman 2.1.15 and later crashes on more email To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1235101/+subscriptions From tgc at statsbiblioteket.dk Wed Oct 16 15:05:35 2013 From: tgc at statsbiblioteket.dk (Tom Christensen) Date: Wed, 16 Oct 2013 13:05:35 -0000 Subject: [Merge] lp:~tgc/mailman/2.1-da into lp:mailman/2.1 Message-ID: <20131016130534.3749.4379.launchpad@ackee.canonical.com> Tom Christensen has proposed merging lp:~tgc/mailman/2.1-da into lp:mailman/2.1. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~tgc/mailman/2.1-da/+merge/191396 A long overdue update of the danish translation which I hope can make it into the 2.1.16 release! I've translated all the missing bits in mailman.po and resolved the fuzzy translations aswell. There's also a few updates to the templates, I looked at the history for the english templates and not much has happened, so I think they're okay with these small updates. I am one of the original translators for the current danish translation in mailman 2.1. I still have not signed any FSF papers. -- https://code.launchpad.net/~tgc/mailman/2.1-da/+merge/191396 Your team Mailman Coders is requested to review the proposed merge of lp:~tgc/mailman/2.1-da into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 17710 bytes Desc: not available URL: From noreply at launchpad.net Wed Oct 16 15:58:38 2013 From: noreply at launchpad.net (noreply at launchpad.net) Date: Wed, 16 Oct 2013 13:58:38 -0000 Subject: [Merge] lp:~tgc/mailman/2.1-da into lp:mailman/2.1 In-Reply-To: <20131016130534.3749.4379.launchpad@ackee.canonical.com> Message-ID: <20131016135837.19866.11004.launchpad@ackee.canonical.com> The proposal to merge lp:~tgc/mailman/2.1-da into lp:mailman/2.1 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~tgc/mailman/2.1-da/+merge/191396 -- https://code.launchpad.net/~tgc/mailman/2.1-da/+merge/191396 Your team Mailman Coders is requested to review the proposed merge of lp:~tgc/mailman/2.1-da into lp:mailman/2.1. From mark at msapiro.net Wed Oct 16 16:56:35 2013 From: mark at msapiro.net (Mark Sapiro) Date: Wed, 16 Oct 2013 14:56:35 -0000 Subject: [Bug 1235101] Re: Mailman 2.1.15 and later crashes on more email References: <20131004070310.3962.1242.malonedeb@gac.canonical.com> Message-ID: <20131016145636.15643.9721.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1235101 Title: Mailman 2.1.15 and later crashes on more email To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1235101/+subscriptions From mark at msapiro.net Wed Oct 16 16:57:03 2013 From: mark at msapiro.net (Mark Sapiro) Date: Wed, 16 Oct 2013 14:57:03 -0000 Subject: [Bug 1234567] Re: Czech catalog bug References: <20131003082733.4346.50379.malonedeb@gac.canonical.com> Message-ID: <20131016145704.11560.54693.launchpad@gac.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1234567 Title: Czech catalog bug To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1234567/+subscriptions From 1241770 at bugs.launchpad.net Fri Oct 18 20:40:44 2013 From: 1241770 at bugs.launchpad.net (Matthias Andree) Date: Fri, 18 Oct 2013 18:40:44 -0000 Subject: [Bug 1241770] [NEW] PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files References: <20131018184044.24461.16040.malonedeb@wampee.canonical.com> Message-ID: <20131018184044.24461.16040.malonedeb@wampee.canonical.com> Public bug reported: Packaging mailman 2.1.16 for FreeBSD's new STAGEDIR (think DESTDIR) support, the FreeBSD Q/A scripts complained that the .pyc files contain the DESTDIR prefix, and thus might misrepresent their own path in tracebacks. I debugged this and figured that Makefile.in is the culprit, $(PYTHON) -c 'from compileall import *; compile_dir("$(DESTDIR)$(prefix)/Mailman")' Read this in context with the Python reference, http://docs.python.org/2/library/compileall.html#module-compileall (about the ddir argument), and http://docs.python.org/2/library/py_compile.html#module-py_compile. I am offering a patch to remedy this problem, and ask that it be included in all future releases (2.1.17, for instance). Assume it is under the 2-clause BSD license. ** Affects: mailman Importance: Undecided Status: New ** Patch added: "PATCH to fix recorded filename paths in .pyc files" https://bugs.launchpad.net/bugs/1241770/+attachment/3882637/+files/patch-Makefile.in -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1241770 Title: PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1241770/+subscriptions From mark at msapiro.net Fri Oct 18 23:47:07 2013 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 18 Oct 2013 21:47:07 -0000 Subject: [Bug 1241770] Re: PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files References: <20131018184044.24461.16040.malonedeb@wampee.canonical.com> Message-ID: <20131018214708.28514.15485.malone@gac.canonical.com> Is there some reason why your patch does (cd "$(DESTDIR)$(prefix)" \ && $(PYTHON) -c 'from compileall import *; compile_dir("Mailman", ddir="$(prefix)/Mailman")') instead of just $(PYTHON) -c 'from compileall import *; compile_dir("$(DESTDIR)$(prefix)/Mailman", ddir="$(prefix)/Mailman")' ** Changed in: mailman Importance: Undecided => Low ** Changed in: mailman Status: New => Confirmed ** Changed in: mailman Milestone: None => 2.1.17 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1241770 Title: PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1241770/+subscriptions From 1227658 at bugs.launchpad.net Sat Oct 19 00:06:30 2013 From: 1227658 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 18 Oct 2013 22:06:30 -0000 Subject: [Bug 1227658] Re: Mailman's import21 does not import the archive policy References: <20130919133118.19954.25795.malonedeb@wampee.canonical.com> Message-ID: <20131018220631.28720.60598.launchpad@gac.canonical.com> ** Changed in: mailman Milestone: None => 3.0.0b4 ** Changed in: mailman Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: mailman Importance: Undecided => High ** Changed in: mailman Status: New => Confirmed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1227658 Title: Mailman's import21 does not import the archive policy To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1227658/+subscriptions From 1227658 at bugs.launchpad.net Sat Oct 19 00:18:56 2013 From: 1227658 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 18 Oct 2013 22:18:56 -0000 Subject: [Bug 1227658] Re: Mailman's import21 does not import the archive policy References: <20130919133118.19954.25795.malonedeb@wampee.canonical.com> Message-ID: <20131018221857.28375.17631.launchpad@gac.canonical.com> ** Changed in: mailman Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1227658 Title: Mailman's import21 does not import the archive policy To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1227658/+subscriptions From 1241770 at bugs.launchpad.net Sat Oct 19 00:22:14 2013 From: 1241770 at bugs.launchpad.net (Matthias Andree) Date: Fri, 18 Oct 2013 22:22:14 -0000 Subject: [Bug 1241770] Re: PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files References: <20131018184044.24461.16040.malonedeb@wampee.canonical.com> <20131018214708.28514.15485.malone@gac.canonical.com> Message-ID: <5261B496.3020807@gmx.de> Mark, Thanks for the prompt response. No, there is no special reason, I simply have not explored alternative solutions once I had one that worked. Your proposed solution works for me, too (tested with Python 2.7.5 on FreeBSD 9.2-amd64). Best regards Matthias Andree -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1241770 Title: PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1241770/+subscriptions From 1241770 at bugs.launchpad.net Sat Oct 19 00:49:15 2013 From: 1241770 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Fri, 18 Oct 2013 22:49:15 -0000 Subject: [Bug 1241770] Re: PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files References: <20131018184044.24461.16040.malonedeb@wampee.canonical.com> Message-ID: <20131018224918.27435.54479.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1241770 Title: PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1241770/+subscriptions From mark at msapiro.net Sat Oct 19 00:54:54 2013 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 18 Oct 2013 22:54:54 -0000 Subject: [Bug 1241770] Re: PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files References: <20131018184044.24461.16040.malonedeb@wampee.canonical.com> Message-ID: <20131018225455.12031.53479.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1241770 Title: PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1241770/+subscriptions From 1241770 at bugs.launchpad.net Sat Oct 19 01:10:51 2013 From: 1241770 at bugs.launchpad.net (Matthias Andree) Date: Fri, 18 Oct 2013 23:10:51 -0000 Subject: [Bug 1241770] Re: PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files References: <20131018184044.24461.16040.malonedeb@wampee.canonical.com> Message-ID: <20131018231051.24461.20924.malone@wampee.canonical.com> Excellent, thank you. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1241770 Title: PATCH: Installation with DESTDIR leaves DESTDIR/ prefixes in .pyc files To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1241770/+subscriptions From RytoEX at gmail.com Sun Oct 20 00:34:41 2013 From: RytoEX at gmail.com (Ryan Foster) Date: Sat, 19 Oct 2013 22:34:41 -0000 Subject: [Bug 265179] Re: Security hole: passwords mailed in clear References: <20080905191826.27052.96947.launchpad@forster.canonical.com> Message-ID: <20131019223441.28442.14926.malone@gac.canonical.com> When a new list is created, the list owner is emailed the password in plain text, and I did not see a preference or option to disable this notification. This was on Mailman 2.1.14, but I did not see anything in the changelogs to indicate that this behavior would be different in 2.1.16. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/265179 Title: Security hole: passwords mailed in clear To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/265179/+subscriptions From mark at msapiro.net Sun Oct 20 00:57:12 2013 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 19 Oct 2013 22:57:12 -0000 Subject: [Bug 265179] Re: Security hole: passwords mailed in clear References: <20080905191826.27052.96947.launchpad@forster.canonical.com> Message-ID: <20131019225712.24790.56550.malone@wampee.canonical.com> Ryan Foster (rytoex) wrote: > When a new list is created, the list owner is emailed the password in plain text ... If you create the list with bin/newlist, use the -q/--quiet option to supress the list owner notice. If you use the web interface, set 'Send "list created" email to list owner?' to No. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/265179 Title: Security hole: passwords mailed in clear To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/265179/+subscriptions From mark at msapiro.net Sun Oct 20 02:39:59 2013 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 20 Oct 2013 00:39:59 -0000 Subject: [Bug 265179] Re: Security hole: passwords mailed in clear References: <20080905191826.27052.96947.launchpad@forster.canonical.com> Message-ID: <20131020003959.1976.38326.malone@chaenomeles.canonical.com> One caveat on the above. If you set 'Auto-generate initial list password?' to Yes and 'Send "list created" email to list owner?' to No in the web list create process, there's no way to find out the list password. You'd have to use bin/change_pw or equivalent to set a password you know. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/265179 Title: Security hole: passwords mailed in clear To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/265179/+subscriptions From aurelien at bompard.org Tue Oct 22 15:43:54 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Tue, 22 Oct 2013 13:43:54 -0000 Subject: [Merge] lp:~abompard/mailman/import21 into lp:mailman Message-ID: <20131022134353.14984.14592.codereview@soybean.canonical.com> Oh by the way, I'm not very at ease with Bazaar yet, so I may have made a mistake with the merging, please make sure I did not do something funny there... Sorry. -- https://code.launchpad.net/~abompard/mailman/import21/+merge/192146 Your team Mailman Coders is requested to review the proposed merge of lp:~abompard/mailman/import21 into lp:mailman. From aurelien at bompard.org Tue Oct 22 15:46:48 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Tue, 22 Oct 2013 13:46:48 -0000 Subject: [Merge] lp:~abompard/mailman/import21 into lp:mailman In-Reply-To: <20131022134353.14984.14592.codereview@soybean.canonical.com> Message-ID: <20131022134647.32614.36534.codereview@chaenomeles.canonical.com> Another thing, it contains a fix on mailman.app.templates (and the associated test case) to expect templates to be UTF-8 encoded, as discussed on the mailing-list. -- https://code.launchpad.net/~abompard/mailman/import21/+merge/192146 Your team Mailman Coders is requested to review the proposed merge of lp:~abompard/mailman/import21 into lp:mailman. From aurelien at bompard.org Tue Oct 22 15:49:29 2013 From: aurelien at bompard.org (=?utf-8?q?Aur=C3=A9lien_Bompard?=) Date: Tue, 22 Oct 2013 13:49:29 -0000 Subject: [Merge] lp:~abompard/mailman/import21 into lp:mailman In-Reply-To: <20131022134353.14984.14592.codereview@soybean.canonical.com> Message-ID: <20131022134925.30177.95042.launchpad@ackee.canonical.com> Aur?lien Bompard has proposed merging lp:~abompard/mailman/import21 into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~abompard/mailman/import21/+merge/192146 This branch contains my work on the import21 command. Most list properties are imported, as well as their rosters. There are a few exceptions that I don't know how to handle, such as umbrella_list & umbrella_member_suffix, or the fact that header_filter_rules can't be directly converted to header_matches because the former used to match the whole header while the latter only matches the header value, not the header name itself, so I would need to "split" the regexp, which seems very brittle. There are currently 67 unit tests (which are great for conversions), and it's been tested on about 300 mailing-lists (the Fedora project's lists). -- https://code.launchpad.net/~abompard/mailman/import21/+merge/192146 Your team Mailman Coders is requested to review the proposed merge of lp:~abompard/mailman/import21 into lp:mailman. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 55462 bytes Desc: not available URL: From mark at msapiro.net Tue Oct 22 20:11:14 2013 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 22 Oct 2013 18:11:14 -0000 Subject: [Bug 1243343] [NEW] bin/sync_members throws UnicodeDecodeError with non-ascii names. References: <20131022181114.12859.68285.malonedeb@gac.canonical.com> Message-ID: <20131022181114.12859.68285.malonedeb@gac.canonical.com> Public bug reported: If bin/sync_members is adding a member whose display name includes non- ascii, it can throw a UnicodeDecodeError as in Traceback (most recent call last): File "/usr/local/mailman/bin/sync_members", line 288, in main() File "/usr/local/mailman/bin/sync_members", line 259, in main s = email.Utils.formataddr((name, addr)).encode(enc, 'replace') UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 3: ordinal not in range(128) A similar issue may occur with removal. ** Affects: mailman Importance: Undecided Assignee: Mark Sapiro (msapiro) Status: Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1243343 Title: bin/sync_members throws UnicodeDecodeError with non-ascii names. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1243343/+subscriptions From 1243343 at bugs.launchpad.net Tue Oct 22 20:18:36 2013 From: 1243343 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Tue, 22 Oct 2013 18:18:36 -0000 Subject: [Bug 1243343] Re: bin/sync_members throws UnicodeDecodeError with non-ascii names. References: <20131022181114.12859.68285.malonedeb@gac.canonical.com> Message-ID: <20131022181838.5217.12566.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1243343 Title: bin/sync_members throws UnicodeDecodeError with non-ascii names. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1243343/+subscriptions From mark at msapiro.net Tue Oct 22 20:18:39 2013 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 22 Oct 2013 18:18:39 -0000 Subject: [Bug 1243343] Re: bin/sync_members throws UnicodeDecodeError with non-ascii names. References: <20131022181114.12859.68285.malonedeb@gac.canonical.com> Message-ID: <20131022181840.12921.68234.launchpad@gac.canonical.com> ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1243343 Title: bin/sync_members throws UnicodeDecodeError with non-ascii names. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1243343/+subscriptions From dbadrak at gmail.com Wed Oct 23 20:40:11 2013 From: dbadrak at gmail.com (Don Badrak) Date: Wed, 23 Oct 2013 18:40:11 -0000 Subject: [Bug 1243870] [NEW] SpamDetect.py unable to process headers for ICS file References: <20131023184011.12766.72000.malonedeb@gac.canonical.com> Message-ID: <20131023184011.12766.72000.malonedeb@gac.canonical.com> Public bug reported: I am running 2.1.16rc3. Since updating to this from 2.1.14, we are no longer able to send meeting invitations from Lotus Notes to Mailman lists. I get this stack trace in the errors file: Oct 23 10:11:04 2013 (5280) Uncaught runner exception: Oct 23 10:11:04 2013 (5280) Traceback (most recent call last): File "/apps/mailman/Mailman/Queue/Runner.py", line 119, in _oneloop self._onefile(msg, msgdata) File "/apps/mailman/Mailman/Queue/Runner.py", line 190, in _onefile keepqueued = self._dispose(mlist, msg, msgdata) File "/apps/mailman/Mailman/Queue/IncomingRunner.py", line 130, in _dispose more = self._dopipeline(mlist, msg, msgdata, pipeline) File "/apps/mailman/Mailman/Queue/IncomingRunner.py", line 153, in _dopipeline sys.modules[modname].process(mlist, msg, msgdata) File "/apps/mailman/Mailman/Handlers/SpamDetect.py", line 99, in process headers += getDecodedHeaders(p, lcset) File "/apps/mailman/Mailman/Handlers/SpamDetect.py", line 71, in getDecodedHeaders v = decode_header(re.sub('\n\s', ' ', v)) File "/usr/lib64/python2.6/email/header.py", line 101, in decode_header raise HeaderParseError HeaderParseError Oct 23 10:11:04 2013 (5280) SHUNTING: 1382537463.296186+6e41872d4cb789a2cb6b3439e6f6a4210cb32c3c I have traced it down to this particular header: X-Notes-Item: =?UTF-8?B?SW52aXRlIFJSW0xvY2FsXSBieSBIVFRQIFNlcnZlciBvbiBJVDAxMk1haWwo?= =?UTF-8?B?UmVsZWFzZSA4LjUuM0ZQM3xOb3ZlbWJlciAxNSwgMjAxMikgYXQgMTAvMjMv?= =?UTF-8?B?MjAxMyAwMjoyOTowNSBQTQ==?=, =?UTF-8?B?U2VuZFtMb2NhbF0gYnkgSFRUUCBTZXJ2ZXIgb24gSVQwMTJNYWlsKA==?= =?UTF-8?B?UmVsZWFzZSA4LjUuM0ZQM3xOb3ZlbWJlciAxNSwgMjAxMikgYXQgMTAvMjMv?= =?UTF-8?B?MjAxMyAwMjoyOTowNSBQTQ==?=, =?UTF-8?B?UHJlcGFyZVRvU2VuZFtMb2NhbF0gYnkgSFRUUCBTZXJ2ZXIgb24=?= =?UTF-8?B?IElUMDEyTWFpbChSZWxlYXNlIDguNS4zRlAzfE5vdmVtYmVyIDE1LCAyMDEy?= =?UTF-8?B?KSBhdCAxMC8yMy8yMDEzIDAyOjI5OjA1IFBN?=, =?UTF-8?B?Q1MgTm90aWNlIGNvbnZlcnRlZCB0byBpQ2FsZW5kYXIgZm9ybWF0W0xvY2Fs?= =?UTF-8?B?XSBieSBSb3V0ZXIgb24gTE5IUTA4TVRBKFJlbGVhc2UgOC41LjNGUDJ8?= =?UTF-8?B?SnVseSAwMiwgMjAxMikgYXQgMTAvMjMvMjAxMyAwMjoyOTowNyBQTQ==?=; type=501; name=$CSTrack Any suggestions for fixing this or working around it? Thanks in advance. Don Badrak ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1243870 Title: SpamDetect.py unable to process headers for ICS file To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1243870/+subscriptions From mark at msapiro.net Thu Oct 24 01:19:52 2013 From: mark at msapiro.net (Mark Sapiro) Date: Wed, 23 Oct 2013 23:19:52 -0000 Subject: [Bug 1243870] Re: SpamDetect.py unable to process headers for ICS file References: <20131023184011.12766.72000.malonedeb@gac.canonical.com> Message-ID: <20131023231953.12962.47978.launchpad@gac.canonical.com> *** This bug is a duplicate of bug 1235101 *** https://bugs.launchpad.net/bugs/1235101 ** This bug has been marked a duplicate of bug 1235101 Mailman 2.1.15 and later crashes on more email -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1243870 Title: SpamDetect.py unable to process headers for ICS file To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1243870/+subscriptions From pierre.slamich at gmail.com Tue Oct 29 16:56:39 2013 From: pierre.slamich at gmail.com (Pierre Slamich) Date: Tue, 29 Oct 2013 15:56:39 -0000 Subject: [Bug 1245935] [NEW] Adding schema.org Quick Actions support References: <20131029155639.10204.26776.malonedeb@wampee.canonical.com> Message-ID: <20131029155639.10204.26776.malonedeb@wampee.canonical.com> Public bug reported: There's a new standard proposal by Google floating around for taking quick actions on an email without leaving the inbox. https://developers.google.com/gmail/actions/actions/actions-overview https://developers.google.com/gmail/actions/reference/schema-org-proposals As a list admin, it would save me a lot of time if I could approve/deny requests and such without leaving the inbox (just by looking at the sender or title). ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1245935 Title: Adding schema.org Quick Actions support To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1245935/+subscriptions From mark at msapiro.net Tue Oct 29 21:22:02 2013 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 29 Oct 2013 20:22:02 -0000 Subject: [Bug 1246039] [NEW] Non-standard headers can leak sender information to anonymous lists. References: <20131029202203.10092.19283.malonedeb@wampee.canonical.com> Message-ID: <20131029202203.10092.19283.malonedeb@wampee.canonical.com> Public bug reported: Various MUAs, MTAs and MDAs can add non-standard X- headers to messages, e.g. X-Envelope-Sender, that might reveal sender information in posts to anonymous lists. Since it is not possible to know what all these headers might be, it is not possible to explicitly remove them. Thus, we will instead use a configurable list of headers to keep and remove the rest. ** Affects: mailman Importance: High Assignee: Mark Sapiro (msapiro) Status: Fix Committed ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1246039 Title: Non-standard headers can leak sender information to anonymous lists. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1246039/+subscriptions From 1246039 at bugs.launchpad.net Tue Oct 29 21:27:35 2013 From: 1246039 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Tue, 29 Oct 2013 20:27:35 -0000 Subject: [Bug 1246039] Re: Non-standard headers can leak sender information to anonymous lists. References: <20131029202203.10092.19283.malonedeb@wampee.canonical.com> Message-ID: <20131029202737.28765.23455.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1246039 Title: Non-standard headers can leak sender information to anonymous lists. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1246039/+subscriptions