From 837676 at bugs.launchpad.net Fri Sep 2 02:22:54 2011 From: 837676 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 02 Sep 2011 00:22:54 -0000 Subject: [Bug 837676] Re: Getting the roster or configuration of a nonexistent list returns a 500 from REST API. References: <20110830204256.24410.52796.malonedeb@gac.canonical.com> Message-ID: <20110902002254.1100.38645.malone@wampee.canonical.com> Nicely done, thanks. I moved the tests to unittests though. ** Changed in: mailman Status: New => Confirmed ** Changed in: mailman Importance: Undecided => Medium ** Changed in: mailman Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: mailman Milestone: None => 3.0.0a8 ** Changed in: mailman Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/837676 Title: Getting the roster or configuration of a nonexistent list returns a 500 from REST API. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/837676/+subscriptions From 833376 at bugs.launchpad.net Fri Sep 2 02:33:51 2011 From: 833376 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 02 Sep 2011 00:33:51 -0000 Subject: [Bug 833376] Re: Attempting to PATCH an invalid attribute on a member object in REST API results in 500, instead of 400. References: <20110824210922.12989.23778.malonedeb@gac.canonical.com> Message-ID: <20110902003352.1076.54302.launchpad@gac.canonical.com> ** Changed in: mailman Status: New => Confirmed ** Changed in: mailman Importance: Undecided => Medium ** Changed in: mailman Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: mailman Milestone: None => 3.0.0a8 ** Changed in: mailman Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/833376 Title: Attempting to PATCH an invalid attribute on a member object in REST API results in 500, instead of 400. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/833376/+subscriptions From noreply at launchpad.net Fri Sep 2 03:18:21 2011 From: noreply at launchpad.net (noreply at launchpad.net) Date: Fri, 02 Sep 2011 01:18:21 -0000 Subject: [Merge] lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman In-Reply-To: <20110825001440.27001.48065.launchpad@ackee.canonical.com> Message-ID: <20110902011817.30477.96510.launchpad@ackee.canonical.com> The proposal to merge lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~postfuturist/mailman/rest-api-delivery_mode/+merge/72813 -- https://code.launchpad.net/~postfuturist/mailman/rest-api-delivery_mode/+merge/72813 Your team Mailman Coders is requested to review the proposed merge of lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman. From 833132 at bugs.launchpad.net Fri Sep 2 03:14:50 2011 From: 833132 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 02 Sep 2011 01:14:50 -0000 Subject: [Bug 833132] Re: Unable to query or change member delivery_mode through REST API. References: <20110824161713.27770.61663.malonedeb@soybean.canonical.com> Message-ID: <20110902011451.1428.67970.launchpad@gac.canonical.com> ** Changed in: mailman Status: New => Confirmed ** Changed in: mailman Importance: Undecided => Wishlist ** Changed in: mailman Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: mailman Milestone: None => 3.0.0a8 ** Changed in: mailman Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/833132 Title: Unable to query or change member delivery_mode through REST API. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/833132/+subscriptions From barry at canonical.com Fri Sep 2 02:28:22 2011 From: barry at canonical.com (Barry Warsaw) Date: Fri, 02 Sep 2011 00:28:22 -0000 Subject: [Merge] lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman In-Reply-To: <20110825001440.27001.48065.launchpad@ackee.canonical.com> Message-ID: <20110902002746.721.61610.codereview@gac.canonical.com> Thanks for the branch! It's generally better to provide separate branches for each of the separate bugs though, otherwise it's more difficult to review and apply. In this case, no worries, I'll work it out. -- https://code.launchpad.net/~postfuturist/mailman/rest-api-delivery_mode/+merge/72813 Your team Mailman Coders is requested to review the proposed merge of lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman. From barry at canonical.com Fri Sep 2 03:11:23 2011 From: barry at canonical.com (Barry Warsaw) Date: Fri, 02 Sep 2011 01:11:23 -0000 Subject: [Merge] lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman In-Reply-To: <20110825001440.27001.48065.launchpad@ackee.canonical.com> Message-ID: <20110902011031.965.18425.codereview@gac.canonical.com> Oh, one thing I'm going to remove is the prohibition against PATCHing with no attributes. I think that should be fine (and the member won't change). -- https://code.launchpad.net/~postfuturist/mailman/rest-api-delivery_mode/+merge/72813 Your team Mailman Coders is requested to review the proposed merge of lp:~postfuturist/mailman/rest-api-delivery_mode into lp:mailman. From 837526 at bugs.launchpad.net Fri Sep 2 04:22:00 2011 From: 837526 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 02 Sep 2011 02:22:00 -0000 Subject: [Bug 837526] Re: Deleting a domain through REST API does not remove lists belonging to that domain. References: <20110830163528.7208.6332.malonedeb@soybean.canonical.com> Message-ID: <20110902022200.1533.89134.launchpad@gac.canonical.com> ** Changed in: mailman Status: New => Confirmed ** Changed in: mailman Importance: Undecided => Medium ** Changed in: mailman Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: mailman Milestone: None => 3.0.0a8 ** Summary changed: - Deleting a domain through REST API does not remove lists belonging to that domain. + Deleting a domain does not remove lists belonging to that domain. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/837526 Title: Deleting a domain does not remove lists belonging to that domain. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/837526/+subscriptions From 837526 at bugs.launchpad.net Fri Sep 2 20:49:16 2011 From: 837526 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 02 Sep 2011 18:49:16 -0000 Subject: [Bug 837526] Re: Deleting a domain does not remove lists belonging to that domain. References: <20110830163528.7208.6332.malonedeb@soybean.canonical.com> Message-ID: <20110902184917.31973.37875.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/837526 Title: Deleting a domain does not remove lists belonging to that domain. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/837526/+subscriptions From steveth45 at gmail.com Tue Sep 6 20:24:54 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Tue, 06 Sep 2011 18:24:54 -0000 Subject: [Bug 826861] Re: doctests failing on Centos 6 due to "unprintable" error objects References: <20110815171107.3935.64001.malonedeb@soybean.canonical.com> Message-ID: <20110906182454.23062.44600.malone@soybean.canonical.com> Since recent code changes another test is failing in this way on Centos 6: src/mailman/model/docs/registration.txt File "/home/sgoss/mailman_clone/src/mailman/model/docs/registration.txt", line 61, in registration.txt Failed example: registrar.register(mlist, '\xa0 at example.com') Differences (ndiff with -expected +actual): Traceback (most recent call last): - ... - InvalidEmailAddressError: \xa0 at example.com + File "/usr/lib64/python2.6/doctest.py", line 1248, in __run + compileflags, 1) in test.globs + File "", line 1, in + registrar.register(mlist, '\xa0 at example.com') + File "/home/sgoss/mailman_clone/src/mailman/app/registrar.py", line 60, in register + getUtility(IEmailValidator).validate(email) + File "/home/sgoss/mailman_clone/src/mailman/email/validate.py", line 69, in validate + raise InvalidEmailAddressError(email) + InvalidEmailAddressError: -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/826861 Title: doctests failing on Centos 6 due to "unprintable" error objects To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/826861/+subscriptions From 827547 at bugs.launchpad.net Wed Sep 7 04:09:41 2011 From: 827547 at bugs.launchpad.net (Barry Warsaw) Date: Wed, 07 Sep 2011 02:09:41 -0000 Subject: [Bug 827547] Re: KeyError in "virgin" runner. References: <20110816180701.9849.41629.malonedeb@wampee.canonical.com> Message-ID: <20110907020941.32234.78508.malone@gac.canonical.com> Yeah, I think this had to be caused by some unsupported external manipulation of the database. The base Runner class will refuse to process any message destined for a mailing list that does not exist, and every mailing list should be associated with an existing domain. I'm going to mark this one incomplete, but if you find a reproducible test case to show the error, please re-open it. ** Changed in: mailman Status: Triaged => Incomplete -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/827547 Title: KeyError in "virgin" runner. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/827547/+subscriptions From 833208 at bugs.launchpad.net Wed Sep 7 04:18:19 2011 From: 833208 at bugs.launchpad.net (Barry Warsaw) Date: Wed, 07 Sep 2011 02:18:19 -0000 Subject: [Bug 833208] Re: test_accepted_message_gets_posted failing on Centos 6 / Python 2.6 References: <20110824171134.30807.78230.malonedeb@chaenomeles.canonical.com> Message-ID: <20110907021819.2237.63430.malone@chaenomeles.canonical.com> Okay, I know what this is. It's the stupid email package rewrap-using- tabs bug. I'll fix the test. ** Changed in: mailman Status: New => Confirmed ** Changed in: mailman Importance: Undecided => Low ** Changed in: mailman Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: mailman Milestone: None => 3.0.0a8 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/833208 Title: test_accepted_message_gets_posted failing on Centos 6 / Python 2.6 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/833208/+subscriptions From 265819 at bugs.launchpad.net Wed Sep 7 04:33:05 2011 From: 265819 at bugs.launchpad.net (Bryce Harrington) Date: Wed, 07 Sep 2011 02:33:05 -0000 Subject: [Bug 265819] Re: Digest message count incorrect in 2.0.6 References: <20080905192613.27052.8226.launchpad@forster.canonical.com> Message-ID: <20110907023306.1715.55120.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: New => Invalid -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/265819 Title: Digest message count incorrect in 2.0.6 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/265819/+subscriptions From 833208 at bugs.launchpad.net Wed Sep 7 20:57:02 2011 From: 833208 at bugs.launchpad.net (Barry Warsaw) Date: Wed, 07 Sep 2011 18:57:02 -0000 Subject: [Bug 833208] Re: test_accepted_message_gets_posted failing on Centos 6 / Python 2.6 References: <20110824171134.30807.78230.malonedeb@chaenomeles.canonical.com> Message-ID: <20110907185702.2452.98910.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/833208 Title: test_accepted_message_gets_posted failing on Centos 6 / Python 2.6 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/833208/+subscriptions From 821438 at bugs.launchpad.net Thu Sep 8 01:55:09 2011 From: 821438 at bugs.launchpad.net (Barry Warsaw) Date: Wed, 07 Sep 2011 23:55:09 -0000 Subject: [Bug 821438] Re: REST and Client are missing membership_settings options References: <20110805121851.6965.2119.malonedeb@wampee.canonical.com> Message-ID: <20110907235509.2612.714.launchpad@gac.canonical.com> ** Changed in: mailman Status: New => Confirmed ** Changed in: mailman Importance: Undecided => Medium ** Changed in: mailman Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: mailman Milestone: None => 3.0.0a8 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/821438 Title: REST and Client are missing membership_settings options To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/821438/+subscriptions From 821438 at bugs.launchpad.net Thu Sep 8 03:16:09 2011 From: 821438 at bugs.launchpad.net (Barry Warsaw) Date: Thu, 08 Sep 2011 01:16:09 -0000 Subject: [Bug 821438] Re: REST and Client are missing membership_settings options References: <20110805121851.6965.2119.malonedeb@wampee.canonical.com> Message-ID: <20110908011609.6609.20911.malone@soybean.canonical.com> Actually, these are going to be interesting, because individual IMember preferences are stored in multiple places, and there's a _lookup() method that returns the first non-None value. This would probably be fine for read-only access, but if you want to write changes, where do you write them? I think that if you POST or PATCH any of the attributes, it changes them on the member directly (i.e. overriding any other value). -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/821438 Title: REST and Client are missing membership_settings options To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/821438/+subscriptions From steveth45 at gmail.com Mon Sep 12 19:51:39 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Mon, 12 Sep 2011 17:51:39 -0000 Subject: [Bug 848103] Re: The REST API returns a 500 when requesting subscriptions for a nonexistent address. References: <20110912173509.24636.17281.malonedeb@chaenomeles.canonical.com> Message-ID: <20110912175139.23418.73486.malone@chaenomeles.canonical.com> Here's a simple fix. ** Patch added: "test and fix patch" https://bugs.launchpad.net/mailman/+bug/848103/+attachment/2392495/+files/848103.patch -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/848103 Title: The REST API returns a 500 when requesting subscriptions for a nonexistent address. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/848103/+subscriptions From steveth45 at gmail.com Mon Sep 12 19:35:09 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Mon, 12 Sep 2011 17:35:09 -0000 Subject: [Bug 848103] [NEW] The REST API returns a 500 when requesting subscriptions for a nonexistent address. References: <20110912173509.24636.17281.malonedeb@chaenomeles.canonical.com> Message-ID: <20110912173509.24636.17281.malonedeb@chaenomeles.canonical.com> Public bug reported: Requests to /addresses/missing at example.com/memberships causes an exception in Mailman so it returns a 500 instead of a 404. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/848103 Title: The REST API returns a 500 when requesting subscriptions for a nonexistent address. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/848103/+subscriptions From 848103 at bugs.launchpad.net Mon Sep 12 20:04:54 2011 From: 848103 at bugs.launchpad.net (Neil Leathers) Date: Mon, 12 Sep 2011 18:04:54 -0000 Subject: [Bug 848103] Re: The REST API returns a 500 when requesting subscriptions for a nonexistent address. References: <20110912173509.24636.17281.malonedeb@chaenomeles.canonical.com> Message-ID: <20110912180454.23517.64213.malone@chaenomeles.canonical.com> This sounds like a http.bad_request() not http.not_found(). -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/848103 Title: The REST API returns a 500 when requesting subscriptions for a nonexistent address. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/848103/+subscriptions From steveth45 at gmail.com Mon Sep 12 21:33:54 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Mon, 12 Sep 2011 19:33:54 -0000 Subject: [Bug 848103] Re: The REST API returns a 500 when requesting subscriptions for a nonexistent address. References: <20110912173509.24636.17281.malonedeb@chaenomeles.canonical.com> Message-ID: <20110912193354.14492.97710.malone@wampee.canonical.com> Possibly, though the request would be valid if someone were to subscribe to a mailing list with that email address, which is why I lean towards 404. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/848103 Title: The REST API returns a 500 when requesting subscriptions for a nonexistent address. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/848103/+subscriptions From 848103 at bugs.launchpad.net Wed Sep 14 00:44:57 2011 From: 848103 at bugs.launchpad.net (Barry Warsaw) Date: Tue, 13 Sep 2011 22:44:57 -0000 Subject: [Bug 848103] Re: The REST API returns a 500 when requesting subscriptions for a nonexistent address. References: <20110912173509.24636.17281.malonedeb@chaenomeles.canonical.com> Message-ID: <20110913224457.5846.80625.malone@chaenomeles.canonical.com> Agreed that for consistency, a 404 is a better error code. Thanks for the patch! ** Changed in: mailman Status: New => In Progress ** Changed in: mailman Importance: Undecided => Medium ** Changed in: mailman Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: mailman Milestone: None => 3.0.0a8 ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/848103 Title: The REST API returns a 500 when requesting subscriptions for a nonexistent address. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/848103/+subscriptions From 802971 at bugs.launchpad.net Wed Sep 14 04:40:06 2011 From: 802971 at bugs.launchpad.net (Barry Warsaw) Date: Wed, 14 Sep 2011 02:40:06 -0000 Subject: [Bug 802971] Re: Mailman Client doesn't _DOMAIN doesn't offer a list of lists References: <20110628125543.26674.56509.malonedeb@chaenomeles.canonical.com> Message-ID: <20110914024006.5323.37882.malone@chaenomeles.canonical.com> This is in the engine now, e.g. http://localhost:9001/3.0/domains/example.com/lists ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/802971 Title: Mailman Client doesn't _DOMAIN doesn't offer a list of lists To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/802971/+subscriptions From 772135 at bugs.launchpad.net Wed Sep 14 04:41:58 2011 From: 772135 at bugs.launchpad.net (Barry Warsaw) Date: Wed, 14 Sep 2011 02:41:58 -0000 Subject: [Bug 772135] Re: The bounce qrunner needs to be enabled References: <20110428022216.18346.71587.malonedeb@soybean.canonical.com> Message-ID: <20110914024159.768.97596.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Confirmed => Fix Committed ** Changed in: mailman Milestone: None => 3.0.0a8 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/772135 Title: The bounce qrunner needs to be enabled To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/772135/+subscriptions From 821438 at bugs.launchpad.net Sun Sep 18 20:31:28 2011 From: 821438 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 18 Sep 2011 18:31:28 -0000 Subject: [Bug 821438] Re: REST access to preferences References: <20110805121851.6965.2119.malonedeb@wampee.canonical.com> Message-ID: <20110918183129.20633.71789.launchpad@wampee.canonical.com> ** Summary changed: - REST and Client are missing membership_settings options + REST access to preferences -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/821438 Title: REST access to preferences To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/821438/+subscriptions From steveth45 at gmail.com Thu Sep 22 02:17:25 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Thu, 22 Sep 2011 00:17:25 -0000 Subject: [Bug 856004] [NEW] "OperationalError: database is locked" encountered under very light load while using REST API References: <20110922001725.29048.8128.malonedeb@wampee.canonical.com> Message-ID: <20110922001725.29048.8128.malonedeb@wampee.canonical.com> Public bug reported: I've seen this error twice while running integration tests (of our own application) that access Mailman 3 using the API. The load on Mailman is very light, as all requests made to the API are serial, never in parallel. Of course the various processing queues in MM3 are separate processes and could be doing work concurrently. The platform is Centos 6. Traceback (most recent call last): File "/usr/lib64/python2.6/wsgiref/handlers.py", line 93, in run self.result = application(self.environ, self.start_response) File "/home/sgoss/mailman_clone/src/mailman/rest/wsgiapp.py", line 63, in __call__ config.db.commit() File "/home/sgoss/mailman_clone/src/mailman/database/stock.py", line 70, in commit self.store.commit() File "/home/sgoss/phoenix-deploy/lib/python2.6/site-packages/storm-0.18-py2.6-linux-x86_64.egg/storm/store.py", line 122, in commit self._connection.commit() File "/home/sgoss/phoenix-deploy/lib/python2.6/site-packages/storm-0.18-py2.6-linux-x86_64.egg/storm/databases/sqlite.py", line 126, in commit self.raw_execute("COMMIT", _end=True) File "/home/sgoss/phoenix-deploy/lib/python2.6/site-packages/storm-0.18-py2.6-linux-x86_64.egg/storm/databases/sqlite.py", line 154, in raw_execute return Connection.raw_execute(self, statement, params) File "/home/sgoss/phoenix-deploy/lib/python2.6/site-packages/storm-0.18-py2.6-linux-x86_64.egg/storm/database.py", line 321, in raw_execute self._check_disconnect(raw_cursor.execute, *args) File "/home/sgoss/phoenix-deploy/lib/python2.6/site-packages/storm-0.18-py2.6-linux-x86_64.egg/storm/database.py", line 366, in _check_disconnect return function(*args, **kwargs) OperationalError: database is locked The backend here is SQLite, which falls over very quickly under concurrent load. If the goal here is to create a stable mailing list server, maybe SQLite is a poor default. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/856004 Title: "OperationalError: database is locked" encountered under very light load while using REST API To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/856004/+subscriptions From 856004 at bugs.launchpad.net Thu Sep 22 03:27:13 2011 From: 856004 at bugs.launchpad.net (Barry Warsaw) Date: Thu, 22 Sep 2011 01:27:13 -0000 Subject: [Bug 856004] [NEW] "OperationalError: database is locked" encountered under very light load while using REST API References: <20110922001725.29048.8128.malonedeb@wampee.canonical.com> Message-ID: <20110921212713.6628890d@resist.wooz.org> On Sep 22, 2011, at 12:17 AM, Stephen A. Goss wrote: >I've seen this error twice while running integration tests (of our own >application) that access Mailman 3 using the API. The load on Mailman is >very light, as all requests made to the API are serial, never in >parallel. Of course the various processing queues in MM3 are separate >processes and could be doing work concurrently. This probably means that one of the other processes is holding onto the database lock longer than it should, e.g. by not committing or aborting the transaction. I believe Python's sqlite layer should retry the transaction for a few seconds when it finds the database is locked. We'll have to hunt down which other process is holding the database lock (and add some debugging instrumentation if necessary). Fortunately, we don't have threads to worry about! >The backend here is SQLite, which falls over very quickly under >concurrent load. If the goal here is to create a stable mailing list >server, maybe SQLite is a poor default. It could be that sqlite is only really useful for the test suite. However, Storm (our ORM layer) supports MySQL and PostgreSQL. Have you tried either of those databases? -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/856004 Title: "OperationalError: database is locked" encountered under very light load while using REST API To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/856004/+subscriptions From steveth45 at gmail.com Fri Sep 23 02:20:42 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Fri, 23 Sep 2011 00:20:42 -0000 Subject: [Bug 856004] Re: "OperationalError: database is locked" encountered under very light load while using REST API References: <20110922001725.29048.8128.malonedeb@wampee.canonical.com> Message-ID: <20110923002042.3203.7462.malone@wampee.canonical.com> I'm working on Postgres support. It certainly doesn't work yet, mostly because the database creation is very SQLite specific, both the schema definitions which are in raw SQLite-flavored SQL, and some supporting code. I'm currently creating a mailman_pg.sql file to be used if a postgres database URL is given. There's probably a better way to do it, and I'd hazard to guess that would have been using a different ORM. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/856004 Title: "OperationalError: database is locked" encountered under very light load while using REST API To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/856004/+subscriptions From 856004 at bugs.launchpad.net Fri Sep 23 03:41:21 2011 From: 856004 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 23 Sep 2011 01:41:21 -0000 Subject: [Bug 856004] Re: "OperationalError: database is locked" encountered under very light load while using REST API References: <20110922001725.29048.8128.malonedeb@wampee.canonical.com> <20110923002042.3203.7462.malone@wampee.canonical.com> Message-ID: <20110922214121.1d7952d3@limelight.wooz.org> On Sep 23, 2011, at 12:20 AM, Stephen A. Goss wrote: >I'm working on Postgres support. It certainly doesn't work yet, mostly >because the database creation is very SQLite specific, both the schema >definitions which are in raw SQLite-flavored SQL, and some supporting >code. I'm currently creating a mailman_pg.sql file to be used if a >postgres database URL is given. There's probably a better way to do it, >and I'd hazard to guess that would have been using a different ORM. I know these things are notoriously difficult to reproduce, but is there any chance you have a way to reproduce the problem? I'll definitely be very interested to see your branch. I think supporting pg out of the box would be a great benefit. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/856004 Title: "OperationalError: database is locked" encountered under very light load while using REST API To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/856004/+subscriptions From 821438 at bugs.launchpad.net Fri Sep 23 21:32:34 2011 From: 821438 at bugs.launchpad.net (Barry Warsaw) Date: Fri, 23 Sep 2011 19:32:34 -0000 Subject: [Bug 821438] Re: REST access to preferences References: <20110805121851.6965.2119.malonedeb@wampee.canonical.com> Message-ID: <20110923193235.27372.19135.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/821438 Title: REST access to preferences To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/821438/+subscriptions From steveth45 at gmail.com Fri Sep 23 21:40:47 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Fri, 23 Sep 2011 19:40:47 -0000 Subject: [Bug 856004] Re: "OperationalError: database is locked" encountered under very light load while using REST API References: <20110922001725.29048.8128.malonedeb@wampee.canonical.com> Message-ID: <20110923194047.10823.18187.malone@gac.canonical.com> I haven't found a way to reliably reproduce the error. It's only happened twice, and repeatedly running the tests that triggered it haven't reproduced it, yet. Unfortunately, those tests are integration tests with a proprietary system and I can't share the code (nor would it be very useful). It happens after many operations including creating mailing lists, sending messages through, moderating messages, etc. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/856004 Title: "OperationalError: database is locked" encountered under very light load while using REST API To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/856004/+subscriptions From steveth45 at gmail.com Fri Sep 23 22:06:11 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Fri, 23 Sep 2011 20:06:11 -0000 Subject: [Bug 856004] Re: "OperationalError: database is locked" encountered under very light load while using REST API References: <20110922001725.29048.8128.malonedeb@wampee.canonical.com> Message-ID: <20110923200611.3203.20045.malone@wampee.canonical.com> The way I run the tests that caused this error is that a temporary folder is created to hold the config and all the files for mailman, including log files, etc. There's a new folder each time I run the tests. If we added some logging to help catch the problem, those logs would be available the next time the problem occurred. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/856004 Title: "OperationalError: database is locked" encountered under very light load while using REST API To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/856004/+subscriptions From 802540 at bugs.launchpad.net Sat Sep 24 02:00:52 2011 From: 802540 at bugs.launchpad.net (Barry Warsaw) Date: Sat, 24 Sep 2011 00:00:52 -0000 Subject: [Bug 802540] Re: Add c.get_domain() by web_host and not only mail_host References: <20110627133124.21182.5123.malonedeb@chaenomeles.canonical.com> Message-ID: <20110924000053.27783.62915.launchpad@soybean.canonical.com> ** Changed in: mailman Milestone: 3.0.0a8 => None -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/802540 Title: Add c.get_domain() by web_host and not only mail_host To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/802540/+subscriptions From 832404 at bugs.launchpad.net Mon Sep 26 00:02:39 2011 From: 832404 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:02:39 -0000 Subject: [Bug 832404] Re: Test failing: test_accepted_message_gets_posted References: <20110823223243.20294.64368.malonedeb@gac.canonical.com> Message-ID: <20110925220240.26671.44715.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/832404 Title: Test failing: test_accepted_message_gets_posted To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/832404/+subscriptions From 848103 at bugs.launchpad.net Mon Sep 26 00:04:15 2011 From: 848103 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:04:15 -0000 Subject: [Bug 848103] Re: The REST API returns a 500 when requesting subscriptions for a nonexistent address. References: <20110912173509.24636.17281.malonedeb@chaenomeles.canonical.com> Message-ID: <20110925220416.14664.75278.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/848103 Title: The REST API returns a 500 when requesting subscriptions for a nonexistent address. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/848103/+subscriptions From 829765 at bugs.launchpad.net Mon Sep 26 00:04:46 2011 From: 829765 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:04:46 -0000 Subject: [Bug 829765] Re: Need REST endpoint to retrieve lists for a particular domain. References: <20110819204927.14287.20344.malonedeb@chaenomeles.canonical.com> Message-ID: <20110925220446.2592.67350.launchpad@wampee.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/829765 Title: Need REST endpoint to retrieve lists for a particular domain. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/829765/+subscriptions From 837676 at bugs.launchpad.net Mon Sep 26 00:04:04 2011 From: 837676 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:04:04 -0000 Subject: [Bug 837676] Re: Getting the roster or configuration of a nonexistent list returns a 500 from REST API. References: <20110830204256.24410.52796.malonedeb@gac.canonical.com> Message-ID: <20110925220405.14355.25091.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/837676 Title: Getting the roster or configuration of a nonexistent list returns a 500 from REST API. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/837676/+subscriptions From 837526 at bugs.launchpad.net Mon Sep 26 00:03:59 2011 From: 837526 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:03:59 -0000 Subject: [Bug 837526] Re: Deleting a domain does not remove lists belonging to that domain. References: <20110830163528.7208.6332.malonedeb@soybean.canonical.com> Message-ID: <20110925220359.10309.41369.launchpad@gac.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/837526 Title: Deleting a domain does not remove lists belonging to that domain. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/837526/+subscriptions From 834130 at bugs.launchpad.net Mon Sep 26 00:03:54 2011 From: 834130 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:03:54 -0000 Subject: [Bug 834130] Re: Unable to create list moderators or owners with REST API. References: <20110825210011.22215.79306.malonedeb@wampee.canonical.com> Message-ID: <20110925220354.10207.92325.launchpad@gac.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/834130 Title: Unable to create list moderators or owners with REST API. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/834130/+subscriptions From 833376 at bugs.launchpad.net Mon Sep 26 00:03:48 2011 From: 833376 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:03:48 -0000 Subject: [Bug 833376] Re: Attempting to PATCH an invalid attribute on a member object in REST API results in 500, instead of 400. References: <20110824210922.12989.23778.malonedeb@gac.canonical.com> Message-ID: <20110925220349.26770.60623.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/833376 Title: Attempting to PATCH an invalid attribute on a member object in REST API results in 500, instead of 400. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/833376/+subscriptions From 821020 at bugs.launchpad.net Mon Sep 26 00:03:13 2011 From: 821020 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:03:13 -0000 Subject: [Bug 821020] Re: Attempting to GET a nonexistent members object results in a 500 instead of a 404. References: <20110804165415.19219.20724.malonedeb@soybean.canonical.com> Message-ID: <20110925220314.26869.31607.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/821020 Title: Attempting to GET a nonexistent members object results in a 500 instead of a 404. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/821020/+subscriptions From 799612 at bugs.launchpad.net Mon Sep 26 00:03:00 2011 From: 799612 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:03:00 -0000 Subject: [Bug 799612] Re: Expose REST API call to look up member/user id given an email address References: <20110620064752.20698.13504.malonedeb@soybean.canonical.com> Message-ID: <20110925220300.10207.51249.launchpad@gac.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/799612 Title: Expose REST API call to look up member/user id given an email address To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/799612/+subscriptions From 833132 at bugs.launchpad.net Mon Sep 26 00:04:37 2011 From: 833132 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:04:37 -0000 Subject: [Bug 833132] Re: Unable to query or change member delivery_mode through REST API. References: <20110824161713.27770.61663.malonedeb@soybean.canonical.com> Message-ID: <20110925220437.15077.15082.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/833132 Title: Unable to query or change member delivery_mode through REST API. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/833132/+subscriptions From 787599 at bugs.launchpad.net Mon Sep 26 00:02:54 2011 From: 787599 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:02:54 -0000 Subject: [Bug 787599] Re: host_name ancient name for mail_host References: <20110524145425.22626.24657.malonedeb@wampee.canonical.com> Message-ID: <20110925220254.2388.82838.launchpad@wampee.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/787599 Title: host_name ancient name for mail_host To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/787599/+subscriptions From 820660 at bugs.launchpad.net Mon Sep 26 00:04:54 2011 From: 820660 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:04:54 -0000 Subject: [Bug 820660] Re: Attempting to DELETE a user through REST API returns '405 Method Not Allowed' References: <20110803230443.2421.68421.malonedeb@soybean.canonical.com> Message-ID: <20110925220454.15077.70424.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/820660 Title: Attempting to DELETE a user through REST API returns '405 Method Not Allowed' To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/820660/+subscriptions From 821438 at bugs.launchpad.net Mon Sep 26 00:03:19 2011 From: 821438 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:03:19 -0000 Subject: [Bug 821438] Re: REST access to preferences References: <20110805121851.6965.2119.malonedeb@wampee.canonical.com> Message-ID: <20110925220320.3309.19451.launchpad@wampee.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/821438 Title: REST access to preferences To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/821438/+subscriptions From 827060 at bugs.launchpad.net Mon Sep 26 00:03:36 2011 From: 827060 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:03:36 -0000 Subject: [Bug 827060] Re: AttributeError triggered by i18n.py calling os.path.join with Language object. References: <20110816012527.23925.88454.malonedeb@gac.canonical.com> Message-ID: <20110925220336.26968.23800.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/827060 Title: AttributeError triggered by i18n.py calling os.path.join with Language object. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/827060/+subscriptions From 825570 at bugs.launchpad.net Mon Sep 26 00:03:25 2011 From: 825570 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:03:25 -0000 Subject: [Bug 825570] Re: Broken REST API to get member from list given email address (and role). References: <20110812230955.13531.68076.malonedeb@soybean.canonical.com> Message-ID: <20110925220325.13631.28513.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/825570 Title: Broken REST API to get member from list given email address (and role). To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/825570/+subscriptions From 827697 at bugs.launchpad.net Mon Sep 26 00:02:28 2011 From: 827697 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:02:28 -0000 Subject: [Bug 827697] Re: Moderating a message with Action.accept does not cause held message to be sent or even removed from pending. References: <20110816231325.20572.27659.malonedeb@gac.canonical.com> Message-ID: <20110925220228.27477.79750.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/827697 Title: Moderating a message with Action.accept does not cause held message to be sent or even removed from pending. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/827697/+subscriptions From 770328 at bugs.launchpad.net Mon Sep 26 00:04:22 2011 From: 770328 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:04:22 -0000 Subject: [Bug 770328] Re: REST qrunner sometimes does not exit after tests exception References: <20110425153257.28204.36811.malonedeb@wampee.canonical.com> Message-ID: <20110925220422.15077.44573.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/770328 Title: REST qrunner sometimes does not exit after tests exception To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/770328/+subscriptions From 778687 at bugs.launchpad.net Mon Sep 26 00:04:28 2011 From: 778687 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:04:28 -0000 Subject: [Bug 778687] Re: Invalid roster upon initial list creation References: <20110506185152.19505.36492.malonedeb@wampee.canonical.com> Message-ID: <20110925220429.14664.21031.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/778687 Title: Invalid roster upon initial list creation To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/778687/+subscriptions From 772135 at bugs.launchpad.net Mon Sep 26 00:02:46 2011 From: 772135 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:02:46 -0000 Subject: [Bug 772135] Re: The bounce qrunner needs to be enabled References: <20110428022216.18346.71587.malonedeb@soybean.canonical.com> Message-ID: <20110925220247.14043.81195.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/772135 Title: The bounce qrunner needs to be enabled To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/772135/+subscriptions From 833208 at bugs.launchpad.net Mon Sep 26 00:05:56 2011 From: 833208 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:05:56 -0000 Subject: [Bug 833208] Re: test_accepted_message_gets_posted failing on Centos 6 / Python 2.6 References: <20110824171134.30807.78230.malonedeb@chaenomeles.canonical.com> Message-ID: <20110925220556.26968.7724.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/833208 Title: test_accepted_message_gets_posted failing on Centos 6 / Python 2.6 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/833208/+subscriptions From 790994 at bugs.launchpad.net Mon Sep 26 00:06:09 2011 From: 790994 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:06:09 -0000 Subject: [Bug 790994] Re: GPL License References: <20110601010614.2891.32732.malonedeb@wampee.canonical.com> Message-ID: <20110925220609.13839.13869.launchpad@chaenomeles.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/790994 Title: GPL License To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/790994/+subscriptions From 831660 at bugs.launchpad.net Mon Sep 26 00:06:02 2011 From: 831660 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:06:02 -0000 Subject: [Bug 831660] Re: IDomain.email_host should be renamed to IDomain.mail_host References: <20110822215232.10290.2941.malonedeb@chaenomeles.canonical.com> Message-ID: <20110925220602.27372.73645.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/831660 Title: IDomain.email_host should be renamed to IDomain.mail_host To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/831660/+subscriptions From 802971 at bugs.launchpad.net Mon Sep 26 00:03:06 2011 From: 802971 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:03:06 -0000 Subject: [Bug 802971] Re: Mailman Client doesn't _DOMAIN doesn't offer a list of lists References: <20110628125543.26674.56509.malonedeb@chaenomeles.canonical.com> Message-ID: <20110925220307.27681.15416.launchpad@soybean.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/802971 Title: Mailman Client doesn't _DOMAIN doesn't offer a list of lists To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/802971/+subscriptions From 827036 at bugs.launchpad.net Mon Sep 26 00:03:30 2011 From: 827036 at bugs.launchpad.net (Barry Warsaw) Date: Sun, 25 Sep 2011 22:03:30 -0000 Subject: [Bug 827036] Re: Pending message requests survive list deletion. References: <20110815234049.23483.97879.malonedeb@gac.canonical.com> Message-ID: <20110925220331.2999.46387.launchpad@wampee.canonical.com> ** Changed in: mailman Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/827036 Title: Pending message requests survive list deletion. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/827036/+subscriptions From steveth45 at gmail.com Mon Sep 26 22:03:33 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Mon, 26 Sep 2011 20:03:33 -0000 Subject: [Bug 856004] Re: "OperationalError: database is locked" encountered under very light load while using REST API References: <20110922001725.29048.8128.malonedeb@wampee.canonical.com> Message-ID: <20110926200333.9391.98221.malone@gac.canonical.com> Ah, this is likely my fault and not an issue on the main mailman branch. On our own branch we have code that will ping a callback HTML endpoint to query our system upon incoming mail to a mailing list so we can rely on our own code's rules for moderation, acceptance, rejection. This internal delay for the HTTP request is almost certainly the culprit here. This bug should probably be closed, though it is important to keep in mind that it is not impossible for database locks to be held for longer than normal under heavy load and that SQLite does not do well in these conditions. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/856004 Title: "OperationalError: database is locked" encountered under very light load while using REST API To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/856004/+subscriptions From 856004 at bugs.launchpad.net Mon Sep 26 22:16:07 2011 From: 856004 at bugs.launchpad.net (Barry Warsaw) Date: Mon, 26 Sep 2011 20:16:07 -0000 Subject: [Bug 856004] Re: "OperationalError: database is locked" encountered under very light load while using REST API References: <20110922001725.29048.8128.malonedeb@wampee.canonical.com> Message-ID: <20110926201607.14200.60461.malone@chaenomeles.canonical.com> Cool, thanks for the follow up. I'll mark it incomplete, but your absolutely right that we have to be careful about this. ** Changed in: mailman Status: New => Incomplete -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/856004 Title: "OperationalError: database is locked" encountered under very light load while using REST API To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/856004/+subscriptions From steveth45 at gmail.com Tue Sep 27 02:18:49 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Tue, 27 Sep 2011 00:18:49 -0000 Subject: [Bug 860159] [NEW] Mailman 3.0 support for Postgres References: <20110927001849.9391.31768.malonedeb@gac.canonical.com> Message-ID: <20110927001849.9391.31768.malonedeb@gac.canonical.com> Public bug reported: Currently, the MM3 source is SQLite specific, but only in the schema and database creation code, otherwise, it uses Storm which (mostly) supports Postgres. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/860159 Title: Mailman 3.0 support for Postgres To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/860159/+subscriptions From steveth45 at gmail.com Tue Sep 27 02:35:09 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Tue, 27 Sep 2011 00:35:09 -0000 Subject: [Bug 860159] Re: Mailman 3.0 support for Postgres References: <20110927001849.9391.31768.malonedeb@gac.canonical.com> Message-ID: <20110927003509.18894.35571.launchpad@wampee.canonical.com> ** Branch linked: lp:~postfuturist/mailman/postgres -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/860159 Title: Mailman 3.0 support for Postgres To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/860159/+subscriptions From steveth45 at gmail.com Tue Sep 27 02:44:18 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Tue, 27 Sep 2011 00:44:18 -0000 Subject: [Bug 860159] Re: Mailman 3.0 support for Postgres References: <20110927001849.9391.31768.malonedeb@gac.canonical.com> Message-ID: <20110927004418.10717.68620.malone@gac.canonical.com> I've attached a branch with the Postgres support code that I've cooked up. Some notes: 1. You must install Storm trunk (or v. 0.19 whenever that is released) as version 0.18 is broken w/regards to Postgres and UUID columns. 2. I haven't adapted the test suite to run against Postgres, yet, but my own external integration tests pass (which encompass quite a bit of functionality). 3. There is now an alternate mailman_pg.sql file which is used to create the tables. Currently, two foreign key constraints are commented out because those are violated in Mailman 3 (apparently this doesn't bother SQLite). Some column TYPES are different from mailman.sql. Classes are created in a slightly different order due to FK constraint creation requires the referenced table to actually exist. The primary key indexes defined after each class are probably redundant, as those are created automatically for SERIAL columns defined as PRIMARY KEY in Postgres. 4. Probably more FK constraint violations exist that my tests haven't uncovered. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/860159 Title: Mailman 3.0 support for Postgres To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/860159/+subscriptions From barry at python.org Tue Sep 27 03:03:38 2011 From: barry at python.org (Barry Warsaw) Date: Mon, 26 Sep 2011 21:03:38 -0400 Subject: [Bug 860159] Re: Mailman 3.0 support for Postgres In-Reply-To: <20110927004418.10717.68620.malone@gac.canonical.com> References: <20110927001849.9391.31768.malonedeb@gac.canonical.com> <20110927004418.10717.68620.malone@gac.canonical.com> Message-ID: <20110926210338.05782ba4@resist.wooz.org> On Sep 27, 2011, at 12:44 AM, Stephen A. Goss wrote: >I've attached a branch with the Postgres support code that I've cooked >up. Fantastic, thanks! Do be sure to add a merge proposal. >3. There is now an alternate mailman_pg.sql file which is used to create >the tables. Currently, two foreign key constraints are commented out >because those are violated in Mailman 3 (apparently this doesn't bother >SQLite). Some column TYPES are different from mailman.sql. Classes are >created in a slightly different order due to FK constraint creation >requires the referenced table to actually exist. The primary key indexes >defined after each class are probably redundant, as those are created >automatically for SERIAL columns defined as PRIMARY KEY in Postgres. Do you have any thoughts on whether the two .sql files can possibly be shared? My biggest concern is that it will be difficult-ish to keep them in sync as I add or modify the SQLite version. If it's not possible, so be it. I took a quick look at the Python changes, and I think I'm going to refactor the code to not hardcode so much in stock.py. For example, I'll probably rename StockDatabase to SQLiteDatabase and add a PostgresDatabase class, adding a common super class. That way, you'd only need to put this in your mailman.cfg file: [database] class: mailman.database.postgres.PostgresDatabase Don't worry about that too much, I can make that change when I merge your branch. >4. Probably more FK constraint violations exist that my tests haven't >uncovered. I'd definitely like to be able to run the test suite against Postgres, if even for now it's a manual select (e.g. because Postgres would obviously have to be installed and configured in order to work). From 860159 at bugs.launchpad.net Tue Sep 27 03:03:38 2011 From: 860159 at bugs.launchpad.net (Barry Warsaw) Date: Tue, 27 Sep 2011 01:03:38 -0000 Subject: [Bug 860159] Re: Mailman 3.0 support for Postgres References: <20110927001849.9391.31768.malonedeb@gac.canonical.com> <20110927004418.10717.68620.malone@gac.canonical.com> Message-ID: <20110926210338.05782ba4@resist.wooz.org> On Sep 27, 2011, at 12:44 AM, Stephen A. Goss wrote: >I've attached a branch with the Postgres support code that I've cooked >up. Fantastic, thanks! Do be sure to add a merge proposal. >3. There is now an alternate mailman_pg.sql file which is used to create >the tables. Currently, two foreign key constraints are commented out >because those are violated in Mailman 3 (apparently this doesn't bother >SQLite). Some column TYPES are different from mailman.sql. Classes are >created in a slightly different order due to FK constraint creation >requires the referenced table to actually exist. The primary key indexes >defined after each class are probably redundant, as those are created >automatically for SERIAL columns defined as PRIMARY KEY in Postgres. Do you have any thoughts on whether the two .sql files can possibly be shared? My biggest concern is that it will be difficult-ish to keep them in sync as I add or modify the SQLite version. If it's not possible, so be it. I took a quick look at the Python changes, and I think I'm going to refactor the code to not hardcode so much in stock.py. For example, I'll probably rename StockDatabase to SQLiteDatabase and add a PostgresDatabase class, adding a common super class. That way, you'd only need to put this in your mailman.cfg file: [database] class: mailman.database.postgres.PostgresDatabase Don't worry about that too much, I can make that change when I merge your branch. >4. Probably more FK constraint violations exist that my tests haven't >uncovered. I'd definitely like to be able to run the test suite against Postgres, if even for now it's a manual select (e.g. because Postgres would obviously have to be installed and configured in order to work). -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/860159 Title: Mailman 3.0 support for Postgres To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/860159/+subscriptions From steveth45 at gmail.com Tue Sep 27 18:17:35 2011 From: steveth45 at gmail.com (Stephen A. Goss) Date: Tue, 27 Sep 2011 16:17:35 -0000 Subject: [Bug 860159] Re: Mailman 3.0 support for Postgres References: <20110927001849.9391.31768.malonedeb@gac.canonical.com> Message-ID: <20110927161735.30952.14647.malone@gac.canonical.com> The two SQL files really can't be shared due to the differences in those database engines, and even less so if anyone wants to bother to add MySQL support (inevitable, I imagine). We could write the database schema in some simplified intermediate form and generate the appropriate SQL. If we were using Django's ORM or SQLAlchemy, we would generate that directly from the model class definitions in code. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/860159 Title: Mailman 3.0 support for Postgres To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/860159/+subscriptions From 860159 at bugs.launchpad.net Tue Sep 27 22:38:01 2011 From: 860159 at bugs.launchpad.net (Barry Warsaw) Date: Tue, 27 Sep 2011 20:38:01 -0000 Subject: [Bug 860159] Re: Mailman 3.0 support for Postgres References: <20110927001849.9391.31768.malonedeb@gac.canonical.com> Message-ID: <20110927203801.23096.6683.launchpad@wampee.canonical.com> ** Changed in: mailman Status: New => Confirmed ** Changed in: mailman Importance: Undecided => High ** Changed in: mailman Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: mailman Milestone: None => 3.0.0b1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/860159 Title: Mailman 3.0 support for Postgres To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/860159/+subscriptions From mark at msapiro.net Thu Sep 29 20:59:07 2011 From: mark at msapiro.net (Mark Sapiro) Date: Thu, 29 Sep 2011 18:59:07 -0000 Subject: [Bug 862675] [NEW] Changes to a list (subscribe, unsubscribe, etc.) can be lost. References: <20110929185908.15075.36468.malonedeb@chaenomeles.canonical.com> Message-ID: <20110929185908.15075.36468.malonedeb@chaenomeles.canonical.com> Public bug reported: Under certain circumstances such as when bin/add_members is run multiple times in a script, VirginRunner in the process of sending notifications can fail to detect that the list object was updated by another process and can save the list object without having first loaded the latest version, thus losing changes. ** Affects: mailman Importance: Medium Assignee: Mark Sapiro (msapiro) Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/862675 Title: Changes to a list (subscribe, unsubscribe, etc.) can be lost. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/862675/+subscriptions From mark at msapiro.net Thu Sep 29 21:07:50 2011 From: mark at msapiro.net (Mark Sapiro) Date: Thu, 29 Sep 2011 19:07:50 -0000 Subject: [Bug 862683] [NEW] List caching in the qrunners can cause the processes to grow unduly large. References: <20110929190750.7384.62672.malonedeb@soybean.canonical.com> Message-ID: <20110929190750.7384.62672.malonedeb@soybean.canonical.com> Public bug reported: The qrunners implement a cache of list objects to save reloading the list from the file system when not necessary. This cache is implemented via a weakref dictionary which is intended to free cached objects when they are no longer referenced. However, there is a self reference in the default MemberAdaptor (OldStyleMemberships) that prevents cached list objects from ever being freed. Thus, the qrunners grow until they have a cached copy of every list. This can be quite large in an installation with many lists and/or multiple large lists. ** Affects: mailman Importance: Low Assignee: Mark Sapiro (msapiro) Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/862683 Title: List caching in the qrunners can cause the processes to grow unduly large. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/862683/+subscriptions From mark at msapiro.net Fri Sep 30 02:44:13 2011 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 30 Sep 2011 00:44:13 -0000 Subject: [Bug 862683] Re: List caching in the qrunners can cause the processes to grow unduly large. References: <20110929190750.7384.62672.malonedeb@soybean.canonical.com> Message-ID: <20110930004414.12116.40204.malone@gac.canonical.com> This is fixed by eliminating the qrunner list cache. It is not clear that this cache offers much benefit with modern file systems. ** Changed in: mailman Status: New => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/862683 Title: List caching in the qrunners can cause the processes to grow unduly large. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/862683/+subscriptions From mark at msapiro.net Fri Sep 30 02:54:55 2011 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 30 Sep 2011 00:54:55 -0000 Subject: [Bug 862675] Re: Changes to a list (subscribe, unsubscribe, etc.) can be lost. References: <20110929185908.15075.36468.malonedeb@chaenomeles.canonical.com> Message-ID: <20110930005455.13492.66333.malone@chaenomeles.canonical.com> The committed fix will fix this bug for systems in which the mailman installation is all on a single server. For installations with multiple servers accessing Mailman via a shared file system, there can still be manifestations of this bug if there is time skew across the servers. A complete fix would add another Defaults.py/mm_cfg.py setting such as # Maximum time skew in seconds between servers in a shared file system environment. # Set to 0 if the Mailman file system is on a single server. SERVER_MAX_TIME_SKEW = 0 and changing line 611 of Mailman/MailList.py from if mtime < self.__timestamp: to if mtime + mm_cfg.SERVER_MAX_TIME_SKEW < self.__timestamp: ** Changed in: mailman Status: New => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/862675 Title: Changes to a list (subscribe, unsubscribe, etc.) can be lost. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/862675/+subscriptions