[ mailman-Patches-1032434 ] make KNOWN_SPAMMERS work for headers appearing mult. times

[SourceForge.net]

Patches item #1032434, was opened at 2004-09-22 08:39
Message generated for change (Comment added) made by tkikuchi
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1032434&group_id=103

Category: mail delivery
Group: Mailman 2.1
>Status: Closed
Resolution: None
Priority: 5
Submitted By: Alexander Bergolth (bergolth)
Assigned to: Tokio Kikuchi (tkikuchi)
Summary: make KNOWN_SPAMMERS work for headers appearing mult. times

Initial Comment:
Hi!

Currently the header check against the KNOWN_SPAMMERS
config option in SpamDetect.py uses msg[header], i.e.
__getitem__. This method only checks against the first
matching header:

        Note that if the header appeared multiple
times, exactly which
        occurrance gets returned is undefined.  Use
getall() to get all
        the values matching a header field name.

I've changed the code to use msg.get_all() instead.

--leo


----------------------------------------------------------------------

>Comment By: Tokio Kikuchi (tkikuchi)
Date: 2004-10-09 05:00

Message:
Logged In: YES 
user_id=67709

Merged in CVS; closing.
Checking in Handlers/SpamDetect.py;
new revision: 2.3.2.2; previous revision: 2.3.2.1


----------------------------------------------------------------------

Comment By: Alexander Bergolth (bergolth)
Date: 2004-09-24 08:11

Message:
Logged In: YES 
user_id=24695

I'm using spamassassin and amavisd to tag spam and viruses.
The header lines added by the virus-check look like the
following:

---------- snipp! ----------
X-Amavis-Alert: INFECTED, message contains virus:
Worm.SomeFool.Gen-1
X-Amavis-Alert: BANNED FILENAME, message contains part
named: .exe
---------- snipp! ----------

I.e. there are multiple "X-Amavis-Alert" headers to be
considered.

--leo


----------------------------------------------------------------------

Comment By: Tokio Kikuchi (tkikuchi)
Date: 2004-09-24 02:20

Message:
Logged In: YES 
user_id=67709

Looks like resonable to me. So, testing in my site.
Do you have example to catch spam with this patch enabled.
(received: ??)


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1032434&group_id=103