[ mailman-Bugs-825084 ] HyperArch.py allows empty subjects

[SourceForge.net]

Bugs item #825084, was opened at 2003-10-16 13:49
Message generated for change (Comment added) made by lanclos
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=825084&group_id=103

Category: Pipermail
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Kyle Lanclos (lanclos)
Assigned to: Nobody/Anonymous (nobody)
Summary: HyperArch.py allows empty subjects

Initial Comment:
Messages coming into HyperArch.py with a subject of
"Re: " (or similar) come out having no subject at all.
This is Bad(tm), because the HREF links in the HTML
archives are keyed to the subject, and if there's no
subject, there's no link.

Here's a simple fix, against the 2.1.3 source.


--- mailman-2.1.3/Mailman/Archiver/HyperArch.py     
Sun Sep 21 19:40:51 2003
+++ /opt/mailman/Mailman/Archiver/HyperArch.py Thu Oct
16 13:38:39 2003
@@ -262,6 +262,8 @@
             if result:
                 i = result.end(0)
                 self.subject = self.subject[i:]
+               if self.subject.strip() == EMPTYSTRING:
+                       self.subject = '(no subject)'
             else:
                 i = -1
         # Useful to keep around


----------------------------------------------------------------------

>Comment By: Kyle Lanclos (lanclos)
Date: 2003-12-01 08:06

Message:
Logged In: YES 
user_id=888067

I encountered this bug repeatedly when I was using 'arch' to
import an old, non-mailman mbox file which contained
messages with subjects of "Re:" or "Re: ". HyperArch.py
strips the Re: off the subject line, but when it does so, it
does not check for an empty string... it assumes that the
empty-string check happens earlier in the mail path, which
for normal mailman messages, it does.

The only time (that I can think of) you would encounter this
bug is when you are importing non-mailman correspondence in
via the 'arch' command. This situation is not uncommon when
converting old mailing lists to mailman.

If you still want sample messages that caused this bug at
our site, I can provide them, though it is trivial to set up
an mbox-formtted message matching this description by
manually editing the subject line.

----------------------------------------------------------------------

Comment By: Barry A. Warsaw (bwarsaw)
Date: 2003-12-01 07:06

Message:
Logged In: YES 
user_id=12800

I can't reproduce this.  Can you provide more information on
how your site and list is set up and possibly include a
sample message that triggers the bug?

Or, if you can find an example of the bug in one of the
python.org mailing lists, that would be great.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=825084&group_id=103