[IPython-dev] Cntr-s makes cell inactive

[Matthias Bussonnier]

in action.js. 


when clicking on save button we ned to ensure that focus get back on notebook, so we call focus, 
though when triggering the same action from keyboard, calling focus with to command mode. 

Not a trivial change 

We probably need a "ensure_focus" that focus the cell only if neither ell, not code mirror is focused. 
-- 
M



Le 11 mars 2015 à 15:14, Zoltán Vörös <zvoros at gmail.com> a écrit :

> I haven't yet found the culprit. I have checked the obvious places
> 
> services/contents.js
> notebook/js/notebook.js
> edit/js/editor.js
> 
> but those don't seem to contain the definition of the save function. Can
> you point me in the right direction?
> 
> Zoltán
> 
> 
> On 03/11/2015 11:06 PM, Matthias Bussonnier wrote:
>> Sure, this seem like a bug.
>> -- M Le 11 mars 2015 à 10:46, Zoltán Vörös <zvoros at gmail.com> a écrit :
>>>> Thanks for the reply! I will try to find a fix, then.
>>>> 
>>>> A somewhat related question: when the notebook is busy for a long time,
>>>> the html title reflects this state, but only till the first autosave.
>>>> I.e., the title switches from 'mynotebook (Busy)' to 'mynotebook', when
>>>> the autosave runs. I think this should happen only, when the kernel
>>>> becomes idle. Would you agree? I can try to get to the bottom of this, too.
>>>> 
>>>> Cheers,
>>>> Zoltán
>>>> 
>>>> On 03/11/2015 06:17 PM, MinRK wrote:
>>>>>> I think mode switching on save is a bug.
>>>>>> 
>>>>>> On Wed, Mar 11, 2015 at 9:52 AM, Zoltán Vörös <zvoros at gmail.com
>>>>>> <mailto:zvoros at gmail.com>> wrote:
>>>>>> 
>>>>>>   Hi all,
>>>>>> 
>>>>>>   I think the behaviour of some keyboard shortcuts has changed recently.
>>>>>>   In particular, Cntr-s for saving the notebook renders the cell
>>>>>>   inactive
>>>>>>   (i.e., the cursor is taken away, and the border of the cell becomes
>>>>>>   gray). Was this a conscious design decision, or this happened by
>>>>>>   accident? I would like to propose that in cases, where it is clear
>>>>>>   that
>>>>>>   one doesn't want to leave the cell when invoking a certain shortcut,
>>>>>>   e.g., saving the entire notebook, the cell should not become inactive.
>>>>>>   What now happens to me quite often is that I hit Cntr-s, and then b,
>>>>>>   which then creates a new cell above, while I actually wanted to
>>>>>>   type 'b'
>>>>>>   in the current cell. I think this was not like this before.
>>>>>> 
>>>>>>   If this was considered, and this is the decision that the developers
>>>>>>   arrived at, so be it. Otherwise, I would be happy to issue a PR,
>>>>>>   if the
>>>>>>   core team agrees.
>>>>>> 
>>>>>>   Cheers,
>>>>>>   Zoltán
>>>>>>   _______________________________________________
>>>>>>   IPython-dev mailing list
>>>>>>   IPython-dev at scipy.org  <mailto:IPython-dev at scipy.org>
>>>>>>   http://mail.scipy.org/mailman/listinfo/ipython-dev
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> _______________________________________________
>>>>>> IPython-dev mailing list
>>>>>> IPython-dev at scipy.org
>>>>>> http://mail.scipy.org/mailman/listinfo/ipython-dev
>>>> 
>>>> _______________________________________________
>>>> IPython-dev mailing list
>>>> IPython-dev at scipy.org
>>>> http://mail.scipy.org/mailman/listinfo/ipython-dev
>> _______________________________________________
>> IPython-dev mailing list
>> IPython-dev at scipy.org
>> http://mail.scipy.org/mailman/listinfo/ipython-dev
> _______________________________________________
> IPython-dev mailing list
> IPython-dev at scipy.org
> http://mail.scipy.org/mailman/listinfo/ipython-dev