[IPython-dev] pyside, pyqt import testing question

[MinRK]

On Thu, May 3, 2012 at 1:48 PM, Thomas Kluyver <takowl at gmail.com> wrote:

> On 3 May 2012 21:14, Julian Taylor <jtaylor.debian at googlemail.com> wrote:
> > external/qt.py only checks if import PySide succeeds and the fixes
> > itself to that, even if PySide turns out to be incomplete later and pyqt
> > would available as a fallback.
> >
> > Why is the check split up into two parts like that?
> > Would there be any issues in making a complete PySide import test before
> > settling on it?
>
> I think it makes sense to fix it in IPython so it checks for all the
> parts it needs, and I don't think that would cause any problems. I
> guess when it was written, we hadn't considered the possibility of
> PySide being partially installed.
>

Yes, it's as simple as this - I had no idea that you could get less than
all of PySide (a valueless source of complexity, but something we should
deal with, I suppose).  Our PySide import check should not only try to
import PySide, but import everything we need from PySide.


>
> Thomas
> _______________________________________________
> IPython-dev mailing list
> IPython-dev at scipy.org
> http://mail.scipy.org/mailman/listinfo/ipython-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/ipython-dev/attachments/20120503/cc4bda7c/attachment.html>