[IPython-dev] control is not returned to main program, when plotting

[Fernando Perez]

On Fri, Jan 14, 2011 at 2:05 AM, Paul Ivanov <pivanov314 at gmail.com> wrote:
> Hi Thomas,
>
> this was originally reported in issue 185, and I submitted a pull
> request on Dec 28th [**cough** last year! ;) ] to fix
> this, coming to the same conclusion as you, which Mark Voorhies
> graciously tested and verified that it resolves the issue.
>
> https://github.com/ipython/ipython/pull/237
>
> In the pull request message, I came to the same conclusion as
> you:
>
>  What isn't clear to me is the purpose of the function
>  check_gtk inside Shell.py, which was added in the problematic
>  commit. For some reason, it unconditionally returns mode
>  'tkthread' if gtk was safely imported and hasattr
>  'set_interactive', regardless of what mode was passed to it.
>
> Your patch is a subset of the lines to be removed by the pull
> request. I additionally got rid of the entire check_gtk function
> as it was no longer used anywhere.
>
> We just need someone with ipython privileges to put pull it into
> the 0.10.2 branch. Anyone lurking out there? :)

Just to note for the record that this did get merged in to 0.10.2
before release, so the problem is fixed in the released version.

Thanks to those who did the actual work!

Cheers,

f