[IPython-dev] Brian and Vishal, help with #400600?

Fernando Perez fperez.net at gmail.com
Mon Apr 26 02:00:46 EDT 2010


On Sun, Apr 25, 2010 at 8:56 PM, Brian Granger <ellisonbg at gmail.com> wrote:
> This patch can be applied.
>

Mmmh, are you sure? The patch reads:

=== modified file 'IPython/kernel/core/interpreter.py'
--- IPython/kernel/core/interpreter.py	2009-04-20 22:44:50 +0000
+++ IPython/kernel/core/interpreter.py	2009-07-17 09:46:18 +0000
@@ -375,7 +375,7 @@
             exec code in self.user_ns
             outflag = 0
         except SystemExit:
-            self.resetbuffer()
+            self.reset()
             self.traceback_trap.args = sys.exc_info()
         except:
             self.traceback_trap.args = sys.exc_info()

but the code at that location now reads:

        try:
            exec code in self.user_ns
            outflag = 0
        except SystemExit:
            self.traceback_trap.args = sys.exc_info()
        except:
            self.traceback_trap.args = sys.exc_info()

There is not even a self.resetbuffer() call anymore.  So the patch
does not apply anymore. The question is, should I put in the
self.reset() the patch had added, or should I lseave the code like it
is now?

Thanks for the help, it does look at least like this one is simple
enough that we'll be able to finish it off before the transition.

Cheers,

f



More information about the IPython-dev mailing list